From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Eric Botcazou <ebotcazou@adacore.com>,
James Greenhalgh <James.Greenhalgh@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Sudakshina Das <Sudi.Das@arm.com>, Jeff Law <law@redhat.com>,
nd <nd@arm.com>, Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][AARCH64] PR target/84521 Fix frame pointer corruption with -fomit-frame-pointer with __builtin_setjmp
Date: Wed, 27 Jun 2018 08:12:00 -0000 [thread overview]
Message-ID: <HE1PR08MB1035D51F733B3D8D767A492083480@HE1PR08MB1035.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <16280160.Nx4lr6RsWP@polaris>
Eric Botcazou wrote:
> > The AArch64 parts are OK. I've been holding off approving the patch while
> > I wait for Eric to reply on the x86_64 fails with your new testcase.
>
> The test is not portable in any case since it uses the "optimize" attribute so
> I'd just make it specific to Aarch64 and install the patch.
This test can easily be changed not to use optimize since it doesn't look like it
needs it. We really need to tests these builtins properly, otherwise they will
continue to fail on most targets.
Wilco
next prev parent reply other threads:[~2018-06-27 8:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 18:07 Sudakshina Das
2018-03-19 12:12 ` James Greenhalgh
2018-03-20 19:36 ` Sudakshina Das
2018-05-02 17:29 ` Jeff Law
2018-06-07 13:04 ` Sudakshina Das
2018-06-07 15:33 ` Eric Botcazou
2018-06-14 11:10 ` Sudakshina Das
2018-06-25 9:25 ` Sudakshina Das
2018-06-26 21:45 ` James Greenhalgh
2018-06-26 22:33 ` Eric Botcazou
2018-06-27 8:12 ` Wilco Dijkstra [this message]
2018-06-27 8:26 ` Eric Botcazou
2018-06-27 11:22 ` Wilco Dijkstra
2018-07-12 17:01 ` Sudakshina Das
2018-07-31 21:42 ` James Greenhalgh
2018-07-31 21:49 ` Andrew Pinski
2018-08-01 10:33 ` Sudakshina Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR08MB1035D51F733B3D8D767A492083480@HE1PR08MB1035.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Sudi.Das@arm.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).