From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7686 invoked by alias); 27 Jun 2018 08:12:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7639 invoked by uid 89); 27 Jun 2018 08:12:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:636, HTo:U*ebotcazou X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0078.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 08:12:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pZJzfCOHeyu0VeRFiGltjC4qf55+JoYhL/N/ZzYxVJM=; b=rYDY7UC18SNLiEfVGzFdEhwqo01LupelZWImmmqxdCZQ6LlUT/2N1WwwMCQHL5H37yioAYQjg5nOP81Om2sNTjNLl9KZha4TJJS4IRwfK4xtBsaEu6As1Q+h4zwilGoUMiMQD9VtPlqRu5edxDporVQ33A3y8eISt0Kv4YIcJwo= Received: from HE1PR08MB1035.eurprd08.prod.outlook.com (10.166.125.145) by HE1PR08MB1147.eurprd08.prod.outlook.com (10.166.96.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.24; Wed, 27 Jun 2018 08:12:10 +0000 Received: from HE1PR08MB1035.eurprd08.prod.outlook.com ([fe80::dc65:2c61:4e8e:dd8b]) by HE1PR08MB1035.eurprd08.prod.outlook.com ([fe80::dc65:2c61:4e8e:dd8b%6]) with mapi id 15.20.0884.024; Wed, 27 Jun 2018 08:12:10 +0000 From: Wilco Dijkstra To: Eric Botcazou , James Greenhalgh CC: "gcc-patches@gcc.gnu.org" , Sudakshina Das , Jeff Law , nd , Marcus Shawcroft , Richard Earnshaw Subject: Re: [PATCH][AARCH64] PR target/84521 Fix frame pointer corruption with -fomit-frame-pointer with __builtin_setjmp Date: Wed, 27 Jun 2018 08:12:00 -0000 Message-ID: References: <4ee92fe8-3070-0129-59ad-40cbe0207822@arm.com> <20180626214437.GA25303@arm.com>,<16280160.Nx4lr6RsWP@polaris> In-Reply-To: <16280160.Nx4lr6RsWP@polaris> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2018-06/txt/msg01660.txt.bz2 Eric Botcazou wrote: > > The AArch64 parts are OK. I've been holding off approving the patch whi= le > > I wait for Eric to reply on the x86_64 fails with your new testcase. > > The test is not portable in any case since it uses the "optimize" attribu= te so=20 > I'd just make it specific to Aarch64 and install the patch. This test can easily be changed not to use optimize since it doesn't look l= ike it needs it. We really need to tests these builtins properly, otherwise they w= ill continue to fail on most targets. Wilco =20=20=20=20