From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18655 invoked by alias); 12 Feb 2018 13:37:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18644 invoked by uid 89); 12 Feb 2018 13:37:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:15.20.0485.015, H*r:15.20.0485.015, H*RU:15.20.0485.015, Wales X-HELO: relmlie2.idc.renesas.com Received: from relmlor3.renesas.com (HELO relmlie2.idc.renesas.com) (210.160.252.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Feb 2018 13:36:59 +0000 Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie2.idc.renesas.com with ESMTP; 12 Feb 2018 22:36:56 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id DBF407E19D; Mon, 12 Feb 2018 22:36:56 +0900 (JST) Received: from mail-pu1apc01lp0016.outbound.protection.outlook.com (HELO APC01-PU1-obe.outbound.protection.outlook.com) ([65.55.88.16]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 12 Feb 2018 22:36:56 +0900 Received: from HK2PR0601MB1828.apcprd06.prod.outlook.com (10.170.148.22) by HK2PR0601MB1442.apcprd06.prod.outlook.com (10.165.182.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Mon, 12 Feb 2018 13:36:54 +0000 Received: from HK2PR0601MB1828.apcprd06.prod.outlook.com ([fe80::9be:7205:8daf:f9ef]) by HK2PR0601MB1828.apcprd06.prod.outlook.com ([fe80::9be:7205:8daf:f9ef%17]) with mapi id 15.20.0485.015; Mon, 12 Feb 2018 13:36:54 +0000 From: Sebastian Perta To: Jakub Jelinek CC: Nick Clifton , gcc-patches Subject: RE: PING [PATCH] RX movsicc degrade fix Date: Mon, 12 Feb 2018 13:37:00 -0000 Message-ID: References: <20180209182349.GL5867@tucnak> <000001d3a3f1$8cf26ce0$a6d746a0$@renesas.com> <20180212124430.GA5867@tucnak> <000101d3a405$3926eb40$ab74c1c0$@renesas.com> <20180212133011.GB5867@tucnak> In-Reply-To: <20180212133011.GB5867@tucnak> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Sebastian.Perta@renesas.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HK2PR0601MB1442;7:NUTpmsKqITISjcCRJX2yOnj/nhKVCVG0GShQZL/OLRQdI2YMhcb3AP0f4cPebfv7UPg36Tx46R1auimsKzHVoTZoNymHXSro6XgTvhN3u0M+jbfAUk0dn/9tQMNB0XjFwxeHGeX1q89hx3Zryeb6zaNReach2oOuX/Su5WCo7ca+SurjqECXJ7OrA5eAdpAPw5LRYSi2huDShVjlDiWWP0tVPFl2Ux+rKPfNK7oqDnlLjS4tsPLo6uRNgW1CeA1j;20:FB2m4+K3zj+jugxv/pxhSAzkhmMwSpC5kcs1QcQqv4EvXEwq3KaXQkfDWOZB4g7WsS6jKyxJCCPzPHOxUAaPRBNSYHA/+eSJA+6bw0hAzhBmcloGUapucOf8B4mAMZKNZhZr//cEGPF1+OtgzcZLtLsp6bYwA8hCG82SKDt9l38= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b3a77869-10bd-4838-8569-08d5721dae58 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:HK2PR0601MB1442; x-ms-traffictypediagnostic: HK2PR0601MB1442: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(22074186197030)(183786458502308)(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(2400082)(944501161)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011);SRVR:HK2PR0601MB1442;BCL:0;PCL:0;RULEID:;SRVR:HK2PR0601MB1442; x-forefront-prvs: 0581B5AB35 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(396003)(376002)(39860400002)(346002)(39380400002)(54534003)(13464003)(189003)(199004)(377424004)(25786009)(316002)(81166006)(93886005)(86362001)(8676002)(5660300001)(105586002)(106356001)(6246003)(9686003)(66066001)(81156014)(2950100002)(6916009)(8936002)(2906002)(54906003)(97736004)(229853002)(74316002)(59450400001)(14454004)(186003)(6116002)(26005)(76176011)(68736007)(3846002)(305945005)(3660700001)(6436002)(72206003)(2900100001)(53936002)(6506007)(3280700002)(102836004)(7696005)(478600001)(4326008)(99286004)(7736002)(33656002)(53546011)(55016002)(5250100002);DIR:OUT;SFP:1102;SCL:1;SRVR:HK2PR0601MB1442;H:HK2PR0601MB1828.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: eXOWMOqYJol4P5JvzqSLnRZ02pSLKnq0WBTzdI0zhReMJngNIcHLbHwIyqlM9qfd1U1QpcMXvVrgQHm+4yQDNA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3a77869-10bd-4838-8569-08d5721dae58 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2018 13:36:54.6510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1442 X-SW-Source: 2018-02/txt/msg00644.txt.bz2 Hi Jakub, >>Still missing . at the end of the above line. The sentence continues on the next line (so the "." is there): +* config/rx/constraints.md (CALL_OP_SYMBOL_REF): Added new constraint +to allow or block "symbol_ref" depending on the value of TARGET_JSR. I think this is OK, please confirm. Best Regards, Sebastian > -----Original Message----- > From: Jakub Jelinek [mailto:jakub@redhat.com] > Sent: 12 February 2018 13:30 > To: Sebastian Perta > Cc: Nick Clifton ; gcc-patches patches@gcc.gnu.org> > Subject: Re: PING [PATCH] RX movsicc degrade fix > > On Mon, Feb 12, 2018 at 01:27:24PM -0000, Sebastian Perta wrote: > > --- ChangeLog(revision 257583) > > +++ ChangeLog(working copy) > > @@ -129,8 +129,7 @@ > > > > 2018-02-09 Sebastian Perta > > > > -* config/rx.md: updated "movsicc" expand to be matched by GCC > > -* testsuite/gcc.target/rx/movsicc.c: new test case > > +* config/rx/rx.md (movsicc): Update expander to be matched by > GCC. > > > > 2018-02-09 Peter Bergner > > > > @@ -143,10 +142,10 @@ > > > > 2018-02-09 Sebastian Perta > > > > -* config/rx/constraints.md: added new constraint > CALL_OP_SYMBOL_REF > > -to allow or block "symbol_ref" depending on value of TARGET_JSR > > -* config/rx/rx.md: use CALL_OP_SYMBOL_REF in call_internal and > > -call_value_internal insns > > +* config/rx/constraints.md (CALL_OP_SYMBOL_REF): Added new > constraint > > Still missing . at the end of the above line. > > Otherwise LGTM. > > Jakub Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, B= uckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered= No. 04586709.