From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by sourceware.org (Postfix) with ESMTPS id 963143858D28 for ; Mon, 5 Jun 2023 02:49:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 963143858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685933382; x=1717469382; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=WuTVfNuYlQp2h1tZc6Qw9ZzxIzKHhFbL4YeNeyfdNcg=; b=GJbsJWuNPbtZA74DqJopJfiRmvnGh6iid55Mw6kBmK4xFMZ9HXJrxEAC A9DFsNaUtxRAMUbuGl4WNGXJG1ZZUDU5Qv3Im+pXC7tGP+TJ9/E90rN5S n/N2NAOTkKD/SA7Dshx+IrYVVcZJ94LtxwUhUHpaTvSgdBYOCL5dGvVGY qhECG+Ow3Biq7L/cL1UCSpLrGu+pRHTqYeEYrCak1KI0hrVumcrrPEvC+ /LkksfegsRkoNrzU023VPFrriA7n1x5P1hIBFj8n5of8ZJcpeZBdggmR8 mIT5inSfc4tuYHayFDCBWpwVrycSpr3A6pD2BUEvkbVcqwTDDn/1sf7lV A==; X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="359576098" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208,217";a="359576098" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2023 19:49:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="711639515" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208,217";a="711639515" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 04 Jun 2023 19:49:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 4 Jun 2023 19:49:40 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 4 Jun 2023 19:49:40 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 4 Jun 2023 19:49:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WY2QeYJqHqJIGe3VHwJkPZEasleDDMRHnxwC1OAmZC+QvkF/DFOyB5HCluSmwNpAvsJ0r4uTO9CplLijE1FFYhmOfuSLo0YfsTWLCGyaH/BwWAAUK4Voy8qyqTNiXn3b9TS7wsTzQM4hJdO9xbRIu+FAev5pBq9tPsdREfk3dkf/JhfV8SaDSVR5z3uLJpC1ytKszhlzdK6y1Hwt1i/flUs7gFkG0rKHErFJclmzkFqtBsKg8zxViWqkCITW0X/s5zgtC8qK5dYzVwGcYlFxkXAacB0OrSB2I308sSlJMUrp7o3+x72U0DZW0e4D52YUSN7hFFbehFWrGVdSvRTt2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9QooiK5zNT4WnK9hZesDTbZqTMWtSHA+czmh3yA5tZQ=; b=fbThdk8HIc9Dj2WoyUE+/gOt96DlWwjv6lElHS1W7yZojkLMOUfKvCRUPwzrYuupiA7FYojZqZbZjPBGIIeay8wrcR1KtlWSKBzqimCUwrCvrClHCLQFEMTzZKWcHBEMfuRjiBDBqQUnjfyAwdDNwtSLxtgHQMIOD2MYBGXiFBM7J4lPWlR8/3NVXLYg+m2NFxCxZ5Z0e8FaXroKCJUFkctfl4R7f/foA04AmvYtekLtdMBNajXVDY0fTs13yAYc0snLpPz7KNSxI9POgktFCjC5rdP76vnrBg5ALm6ct4rb+c+BrGGQik5iLC1DgMaFCFyteY9E/cszKJYA3ly0WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6466.namprd11.prod.outlook.com (2603:10b6:208:3a6::21) by SN7PR11MB7115.namprd11.prod.outlook.com (2603:10b6:806:29a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Mon, 5 Jun 2023 02:49:38 +0000 Received: from IA1PR11MB6466.namprd11.prod.outlook.com ([fe80::6400:4191:765b:1bb4]) by IA1PR11MB6466.namprd11.prod.outlook.com ([fe80::6400:4191:765b:1bb4%5]) with mapi id 15.20.6455.030; Mon, 5 Jun 2023 02:49:38 +0000 From: "Wang, Yanzhang" To: Jeff Law , "gcc-patches@gcc.gnu.org" CC: "juzhe.zhong@rivai.ai" , "kito.cheng@sifive.com" , "Li, Pan2" Subject: Re: [PATCH] RISCV: Add -m(no)-omit-leaf-frame-pointer support. Thread-Topic: [PATCH] RISCV: Add -m(no)-omit-leaf-frame-pointer support. Thread-Index: AQHZlSDwF/PZ/EZR3U64IcrZzA3VA694YAOAgAMXucA= Date: Mon, 5 Jun 2023 02:49:37 +0000 Message-ID: References: <20230602070726.3807539-1-yanzhang.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6466:EE_|SN7PR11MB7115:EE_ x-ms-office365-filtering-correlation-id: 9f6f644d-51fd-4257-b727-08db656f808b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xBqjn5+qzAGpf+SOAKbzorrxoKmJ2X7vxC47EOVFS+m6vrYZMTU1HpibUbSeyYWle2vXVs5juZ1hh+V/Oa19l5G1ZMUx6oQNMFv/EA8LrWVlYCNoTzjVHKE2Fj6LMl0a0B0D9/pAgbUKRLPgeYgKWBkSz0ftI9BnNcue1q6AGe7C8wu12DbQkZt7CsYvt6FL2XRmlbMoJThz8yKeORrYgv6TK2Yn0F0MmTdtclVCdY7sJPNzDT32QY6PYS7w2/T20iB6EKe2l+hpVHCs8hdvmbY6now1AG0UN0tOkq+vHPeWVpmN6AjhRxTlj+2sMdyd4l5og/QhRXDu+7B/vXw/Ram/qsQQkAnoMtunih7satOwhA873BlYAQXv97LnvQulXVKBqzudlUYANjbyHtTV1DxvUNFXDW20ovkQvKDIm5k6IiF849QHbFpozlcjRCkyfmBT7qhHGKUpFmP6fIHJXDo7dGlCuzkL4QIkHCtoxYNsGfA4Xd1gG/CFXrma8iIDdv47va0Tzmo9zF5kh1xw4L47HpQSKSYxjpo7gEK5eiK+dmrUYLX+ur12cqsiFqZLt1BIGq/+bQtWqM04u6n8MxCUNXjXDpQWZqAd3Fa3XRc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6466.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(39860400002)(346002)(396003)(136003)(451199021)(19627405001)(7696005)(38100700002)(84970400001)(53546011)(186003)(41300700001)(26005)(9686003)(6506007)(107886003)(478600001)(71200400001)(66446008)(110136005)(54906003)(91956017)(66476007)(4326008)(55016003)(316002)(82960400001)(64756008)(122000001)(52536014)(76116006)(66556008)(8676002)(8936002)(66946007)(2906002)(5660300002)(86362001)(33656002)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z6dG1rKK8RGNGvNnAKJCcPkJP7nFkrodG/V/GTxuPOjiDQ3oVxbqFAekeVRT?= =?us-ascii?Q?CSTp8OG7HiUaQvVJBc1bHV5lBUDBNPNRBWdE5w4uzBmVqWLF2nN6fmNDd0E4?= =?us-ascii?Q?18JPJMYKEwG+dklD0OZSRPkrm5mvjtrkWQE01JEiCDzJ3p5qnjTTLn7uzE/Y?= =?us-ascii?Q?BtrtISkg3ikd9lP9myREcpS0pEVqkffg6WitCa/MyDWGiuxGoPNQLX3vMfiz?= =?us-ascii?Q?IqBdkaamsh3Eqk5/VaMyVkw49Z2t2L8ySbgvdaw+DxJfxBmodDGy4qx5WC+T?= =?us-ascii?Q?uBa48pXuzf6zG361mgXzwpKYoFIXPJMIqkGeg0KT+nNqDZ79HeYNATPjyhUV?= =?us-ascii?Q?2ZzFEUqNaFE6q+6Ehbk9SsyVAV3ibqWvxiy+xpRKwb+I/eNy1snq40PjzaQ+?= =?us-ascii?Q?KnkKqncMLJwqdib6CHWPanFNbBFreOC/0IXofXxqJBZB26/2WJeSsQ4Ysx4X?= =?us-ascii?Q?1h8k5gFdLhDx1i6wms3AF8TGWihi0f3t+EvSEHlrRxD+Tw+v4LaH3q4uCUjQ?= =?us-ascii?Q?mntnx8DpYjI+gsF55uwUO/WffxquJxJW6HiJU+9kTktfBwTYjOgIiDYb8tp6?= =?us-ascii?Q?3MiRFML6SO5vPcJPPscTE0dQtiPN7AZVNjRIb6a1PpdZ+JtwHyOjrZuLS088?= =?us-ascii?Q?DUWqmRdTCbOeY1yjrNwzVe4qDrkaC4bjffzSzOUrSluWkdRWzh8Qdft1/ufJ?= =?us-ascii?Q?p9ibMWRJBzMCFHCg95Sb0SZsz4B6UMbdFMUAm4lMJml+isLUDYB0onTs/x+W?= =?us-ascii?Q?8NfF7OmeLAAQvBIXIdZw5qUHBYwZkg8LkCwOfkFbzHFILvSRpE26pUCH+lME?= =?us-ascii?Q?zs3EuwAY5X6j+hvJlPcuE+odoQjYtGhCpNUhI+gum+pQIOSWJo3i0TpOn1Kw?= =?us-ascii?Q?E8YHwSZlv0bnVzbFXoahCh1iGR5rtyIkiO/DZhVGlRQRQe2swdMbz4EHcj0w?= =?us-ascii?Q?b7K7XN/5d7+AhoPgGTrHU++rC2cBAixD6OdT8Ne+cpY4KSz0laN02KQQo2oV?= =?us-ascii?Q?c7zoBaYdkT5ui6nVhwuKvx4e/z1wr/vP681YvwDWehb54OgQo6OBShgAHEx2?= =?us-ascii?Q?GNO4lr/CeHqBIAFq1H67lr7nrtkV3qjzVRa90A+vqGMgGVRvDAjULTgHvh7a?= =?us-ascii?Q?0suuDMpfG5eZ6tmcn+GrY59xZVpRXeQAlTzVoSKfE3/rtbS+yQxM5ET8Xd2L?= =?us-ascii?Q?b1EHiB3vsMadHJGShmm3IpWys2G7wGIUP2VO0B//6qz3ELLCO2b41Ol/m1HL?= =?us-ascii?Q?A+lvMCtQdRF9y8YWHPfP81yMdZtVF0OYUIvAvIXpfL3/w3UdaDs3mj2bkxUX?= =?us-ascii?Q?DWppdHcBRvbPXKgcQ7azBvK3uYlz8PpgJs2ddUAqEIuQz9NOGInr0shyVdCq?= =?us-ascii?Q?smsVmy8Zgd65YuUjzsrNGye/MQxYD1ihn58FbC7AiiK19CSz6K09SY5b1G3J?= =?us-ascii?Q?yQ23hb7DcATYCBHnvG0585+I7yMo1R/mOuN7qZwri7JagtCuh6SqAk+JfRgz?= =?us-ascii?Q?tzM3LYjvrpAs2//78UFJViJm2LOvL9kz+Coe5dYihWl9LjJPlINSbKa28K2v?= =?us-ascii?Q?yp/5MMgGwDo5OhFafpcb3bqs7uuJ0xUirGeMkxC6?= Content-Type: multipart/alternative; boundary="_000_IA1PR11MB6466101CB30FBAF74AFFD4A7F24DAIA1PR11MB6466namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6466.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6f644d-51fd-4257-b727-08db656f808b X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2023 02:49:37.5366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3JkzheBIoWzrbSwPHutcZX4l+jCr7qbZZBsW6qWHuL3Bywf7Esh8fEif9blW+qihbzm8O3OojKHpX8elHkuOwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7115 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_IA1PR11MB6466101CB30FBAF74AFFD4A7F24DAIA1PR11MB6466namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jeff, Yes, there's a requirement to support backtrace based on the fp+ra. And the unwind/cfa is not acceptable because it will add additional sections to the binary. Currently, -fno-omit-frame-pointer can not save the ra for the leaf function. So we need to add another option like ARM/X86 to support consistent fp+ra stack layout for the leaf and non-leaf functions. Thanks, Yanzhang ________________________________ From: Jeff Law Sent: Saturday, June 3, 2023 10:43 AM To: Wang, Yanzhang ; gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai ; kito.cheng@sifive.com ; Li, Pan2 Subject: Re: [PATCH] RISCV: Add -m(no)-omit-leaf-frame-pointer support. On 6/2/23 01:07, yanzhang.wang--- via Gcc-patches wrote: > From: Yanzhang Wang > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_save_reg_p): Save ra for leaf > when enabling -mno-omit-leaf-frame-pointer > (riscv_option_override): Override omit-frame-pointer. > (riscv_frame_pointer_required): Save s0 for non-leaf function > (TARGET_FRAME_POINTER_REQUIRED): Override defination > * config/riscv/riscv.opt: Add option support. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/omit-frame-pointer-1.c: New test. > * gcc.target/riscv/omit-frame-pointer-2.c: New test. > * gcc.target/riscv/omit-frame-pointer-3.c: New test. > * gcc.target/riscv/omit-frame-pointer-4.c: New test. > * gcc.target/riscv/omit-frame-pointer-test.c: New test. Not ACKing or NAKing at this time. Why do you want this feature? jeff --_000_IA1PR11MB6466101CB30FBAF74AFFD4A7F24DAIA1PR11MB6466namp_--