From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-obe.outbound.protection.outlook.com (mail-eastus2azon11021017.outbound.protection.outlook.com [52.101.57.17]) by sourceware.org (Postfix) with ESMTPS id 896B63857831 for ; Sun, 12 Jun 2022 23:56:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 896B63857831 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yh0xJTGsVDb7HdnoObKnWXd0HuS7f1GVHLiO3Sif4bg1qaFVSWf6y3lsY6bP9SeYNDA/3zFeOXsmF2EFrMxDkmfmP65UzTQ2IZaR6mtB6SemDghkIEDNB0yOyn524xn+ADFE3+Hnh23VpVN3YsKdfCvGCBwl53/u6NIuXJ/v/esd8C10bVPS4lQ/S5PBGB+XS2/XReekmQe5JwSSfjUm1f/UD5fYuMW8h6Nel00yNP/eHjUlxrLbE0OJqLBBq8GzGPamPzi6yRDkPtDOLRWk8XNk9bFgEs+JICzsnzgKtM9SIVPYmG/mGYwakLDB/2Mpzj+q+6P9QsXaMfAbbGwQoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GrCXCfzwYfl/P1gA6zoEbacjoTB4aXbjQOe/XovU+T4=; b=GNQFf8m5TPQOhdbQnHUm9I2qEvJpUDGZgYTj53S5JFG68BPCIDeJKcaZcBmMjRL4ptP2KcmDZH8j+Uvf3BTBL1yy0mDjxIA0JazEgNDRB6LAMgBaMgm//u4qvxaZDU8ML+B7QGp9zl2ah5tHvsTP4VVb/LyMWbReY28hOOitiNEELq9Rkx+iVXljWUiBkUJAwhY2WoTiXo5odum2bJVJJFfAT0mk9tsW5vJTPyVtZUbfs/QitgwlSkuDjkMcMKSZOHqXXTWL1zoy4sFgR+08YEF1Scou6FU3TYtTBZO1fWNFYka+Wsgg3DCJ2Yjrrk1HL3QMgskNWKKEweV1jk1G2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from MW2PR2101MB1770.namprd21.prod.outlook.com (2603:10b6:302:8::14) by BL1PR21MB3235.namprd21.prod.outlook.com (2603:10b6:208:39b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.6; Sun, 12 Jun 2022 23:56:38 +0000 Received: from MW2PR2101MB1770.namprd21.prod.outlook.com ([fe80::a55d:e34d:c11e:fa4]) by MW2PR2101MB1770.namprd21.prod.outlook.com ([fe80::a55d:e34d:c11e:fa4%5]) with mapi id 15.20.5373.005; Sun, 12 Jun 2022 23:56:37 +0000 From: Eugene Rozenfeld To: Andi Kleen , Eugene Rozenfeld via Gcc-patches CC: Jan Hubicka Subject: RE: [EXTERNAL] Re: [PATCH] Add instruction level discriminator support. Thread-Topic: [EXTERNAL] Re: [PATCH] Add instruction level discriminator support. Thread-Index: Adh2I9GkEjnbUiXgThSaOgZZn4BDCQIk8jjeAAAIu8A= Date: Sun, 12 Jun 2022 23:56:37 +0000 Message-ID: References: <87pmjdfngv.fsf@linux.intel.com> In-Reply-To: <87pmjdfngv.fsf@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=aa82979d-93b0-4ab3-b932-2aa6e8cf631b; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-06-12T23:54:22Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 32329409-13c1-4469-19f3-08da4ccf3012 x-ms-traffictypediagnostic: BL1PR21MB3235:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tJW5Teb0B3kn/QJ/XApMVbjku44+XNkv5noUWwJd65nPAid0buoDosh1uVCHb6wRkKsxBqRarsGaUK2tg7IvDoMMMHpEOxMMD+BMH0fd8wS8YOsw0uMw58TwlcmW4ONC9kj7p38AjP7JXIQC0EvSPHvoHNeN8bLlRmVt66VWTTJXUJEBtI8csm4dh00CnA35REEAXHt9EvQj1oxjji2UVWw5GkZTERELgy+A74s1OwtnUVVb9isyT9cXD/7UCEIHuizqBgic2BL8NGKR1FP/4O1kadrRDn8keffTUHC17QSsQ5gZ3yh56ALWmHVBWDaDigSAaWPXE/hp2VqBPszEYXHU11ySIbAOUF/TTZp0n5fHXr0fOlMHAq00vJ7YGjgqIFbmS6y52gYJP91UETnSptjVA7ukFVgjnyQlFga/So62Y7q6otEn1GQkmrjyYAuSMdjvnrT41Ee6anBUC7a3N5pXlJ80cGuHwCPlpPOY8u+cbroVJZ6N3Wf1s/tTQK0utRj9Qmp9uic7Gnwx5LFaB968yIpkNIg4qZbcPEkf3LsGDtkWqLMthhNqgP0j44tz33QVMRcQIYUlvZR/KoYV2BhY8Mhy5J8e7NC7Kpkm5IriApWgfZwrEPC8tf48ig7lsKQyrxIdq3OrC4SoMTH2K7mkznXxCke71BUUWgOCfjc7VhixOTXWUPVLUpbLMRG9maDGx9uPYc2lIcG5+7VO6v/LN5tfr47/k0/45dtdasJkE/tA/I2R1+gyMjFYuptp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR2101MB1770.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(451199009)(508600001)(33656002)(55016003)(5660300002)(71200400001)(8936002)(52536014)(122000001)(8990500004)(82950400001)(82960400001)(83380400001)(9686003)(186003)(64756008)(2906002)(38070700005)(7696005)(53546011)(6506007)(86362001)(66946007)(66556008)(66476007)(66446008)(8676002)(4326008)(76116006)(38100700002)(10290500003)(316002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KxjLVZp46ysAwOsGqp0/Je0+RjUyDozAIvEyZGwEttDpLtZEhFAMH/gapR64?= =?us-ascii?Q?bICx+oKF5cdIjyaxhLvHJ1GCoXAcK2MbSWbiFYKQxYqwhi3x6do+ZeOaQ01p?= =?us-ascii?Q?wk2aE3qQSv24/Zb1YNvb14rlg0UCkbQQCJ2q02136V4PlgQUOrhI2Xq8jaSi?= =?us-ascii?Q?D0WJ5FPh3WQS8ga2Rcsd9enErSQeC9sTjq2obRlVZpuHAPCx2FIhBuvMbED4?= =?us-ascii?Q?5r7n1Utpo2+1avzI9YIKTZT5DvsJl4PEUm6Fu9GKQtDIPFtd4xyCZyB0tmcg?= =?us-ascii?Q?3C3UnySbM7Uh10eqWXeE66BXwxCNsriGQggLUMrdTBhW12xUz6ehoFc0y6f0?= =?us-ascii?Q?qJUmguCZmXCnc+vM1j13oz80KG7zqPX89RiJbnIgG07JTSxtxI6YZ8DIBy7V?= =?us-ascii?Q?fLh8UOHNp6pHilc6ok4Ql+mwTMiHr0GVlhX8ROvIFmCEevY0o6PNzX/7JakN?= =?us-ascii?Q?MbbaNkdezkn8P2gEBmZr4Hw5k/qgRivCSrrrO96TQbCgRTejyYL0aULT0yLL?= =?us-ascii?Q?Zf6EH1tbQiJhVV0mbfr/Con9vE8mNjOAixR9oJx6XWbzfGUE/smDsvMnOZgD?= =?us-ascii?Q?lQ6UH4JJGEfqIbTwzdzCJ7Xem0etftR/PstuKpQlaRMNNhBUBwhkgg3V+NVp?= =?us-ascii?Q?/xrdEFtfvBacAaRjoIBsxbNDV2p2vB5nGJ3smQ9EuW6WQfBgJaS18k/4ZM1d?= =?us-ascii?Q?Agc/utF/bj3R58XY/nZyDKJvBvO+kgNZUOxLj4gWczmEuxvdqpuezFyh1DjM?= =?us-ascii?Q?bhnMTSdTfdCL+IB0bb3VJR8fSw+W/fwCzrTYo2nWlX+cSWWLQEGpiP9pvJLy?= =?us-ascii?Q?lfNk0BHAKnUUB4migD+ZypGiu1M8KsCsOOHwrbiwURTZvPtLwopzJGvlb5gi?= =?us-ascii?Q?Psh3RzAqJ2VBU6pETwwk3iovuxgAIXS/PXtJrfgmdWbXmYzNCeTWSLTvkOUW?= =?us-ascii?Q?ER3eEq8XqNgM8JhDHYUiDXNN0uA7N6tumdo8rGbuge6jbICDNzeJeBlgvneK?= =?us-ascii?Q?HFPyDqRQL94MSktqMXtG4LJXj169I4ee614Z8tnoJIT/I2+A822xHWQT7KrQ?= =?us-ascii?Q?EUoGinzSuO0LVXzpqtzYlfGvyt49XaDz9iRBEGB1zkwl7Ko852uRcmtrPLpX?= =?us-ascii?Q?8f3ZvvxIcgvbPVtq05GYpsxmGeYm0tlWTT/nvGVjbTiZ8ZhC2c13uw9+4S3W?= =?us-ascii?Q?UM69JyvMP9o5A+0Eh3sULAbuBXJSRVhs2FoNhgJ7kTDvOD910Iy5ihprcAdb?= =?us-ascii?Q?/HUkG66q3WT3xsr0haYh5luIKJmmM1MZNch+aaVXktjY+TiswZzDlUkSzxiE?= =?us-ascii?Q?WBE8zEBCYEjLlo0v2RyfvSib9f+pN3ZOt/SEQU9gqVIdWkvKUjaQjFRWBwAQ?= =?us-ascii?Q?zM7497VBvt5jaFWZ/jK2WOjnw3x2AfvxJlecEF0MhPZRZKytE0rgZAVYlAKI?= =?us-ascii?Q?cCBH/cHyJYmwMLUDvxnPhHQ31wgjLahUSPgzRB28Ztl4BvjHgo4Ay6GLL2Hl?= =?us-ascii?Q?cLAfmlAwWgmtYKaobvIK/cgJ+wk5KtMOxJN6X1mtddPWUFj++FTDSqFDomBr?= =?us-ascii?Q?UJie4kpoKz0ifDiCkR80vG5EAMAlYh1poBSocty5XIutzWEMYOamBliFOiC7?= =?us-ascii?Q?qmuy1l0CIfZTOSkduPfClj3iH3FUFP3OrVGL3AD+yndFZg7mXGDj++MD+9p9?= =?us-ascii?Q?K8bSd+IePVOi+Jaz9bw3ZgFh4sDPojzjxo1UzoljfYOieTdPGDD3+jly8R3f?= =?us-ascii?Q?SMHp5jzhWfqlAsR7g2pQ45PJ9JQpPr7AYAjPIbMGjSOq3f51fqwt0HIAdVpd?= x-ms-exchange-antispam-messagedata-1: trGZ1Q19JV3FNg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR2101MB1770.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32329409-13c1-4469-19f3-08da4ccf3012 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2022 23:56:37.4467 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rwFywPa8TEHaAhETw9129GCX+kfPvcphUScziqhQkU8j5yN9jEPAsuXa9SA6MrhfgkdwRgTMey4Y6Zzdu+RSpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR21MB3235 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jun 2022 23:56:44 -0000 Thank you for the review Andi. Yes, the corresponding reader change is @@ -15671,8 +15673,9 @@ module_state::read_location (bytes_in &sec) const if (range.m_start =3D=3D UNKNOWN_LOCATION) range.m_start =3D locus; range.m_finish =3D read_location (sec); + unsigned discriminator =3D sec.u (); if (locus !=3D loc && range.m_start !=3D loc && range.m_finish !=3D loc) - locus =3D get_combined_adhoc_loc (line_table, locus, range, NULL); + locus =3D get_combined_adhoc_loc (line_table, locus, range, NULL, discr= iminator); } break; -----Original Message----- From: Andi Kleen =20 Sent: Sunday, June 12, 2022 4:53 PM To: Eugene Rozenfeld via Gcc-patches Cc: Jan Hubicka ; Eugene Rozenfeld Subject: [EXTERNAL] Re: [PATCH] Add instruction level discriminator support= . Eugene Rozenfeld via Gcc-patches writes: > { > diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc index=20 > d1dc73724d1..5ed6b7b0f94 100644 > --- a/gcc/cp/module.cc > +++ b/gcc/cp/module.cc > @@ -15587,6 +15587,8 @@ module_state::write_location (bytes_out &sec, loc= ation_t loc) > range.m_start =3D UNKNOWN_LOCATION; > write_location (sec, range.m_start); > write_location (sec, range.m_finish); > + unsigned discriminator =3D get_discriminator_from_adhoc_loc (line_= table, loc); > + sec.u (discriminator); I hope this has a corresponding reader change, wasn't fully clear. Should i= t use some common function? The patch looks good to me, but I cannot approve. -Andi