From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 9AFF53858D1E for ; Mon, 26 Jun 2023 09:36:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9AFF53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687772174; x=1719308174; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JJUbA//Lz0AtFwExBkrNks0bZVozkRPy2u7WFnK4MpE=; b=bNskYB03ZW3tz5CLvZvqVNWMPslVUFELFMYVv9r2N2L8xHrH6tI/IWLG BgWB3pyjbNyd2jWtQkmcZR8b6ggZCZS/W7iEtNsHctCzRnecTy4FwZDp9 YoDZYOendUYsFVOv7l0KYnKNEwkTQC1MbxDUk6eRSI0h/EL6hF0l2SejZ 8GPyUHzeaJ/R/V8MmvlwgpHz6MLXPpo7ZufYtgt/9ZmDyv7U/+euWLA6g QskfoQWwHgJqRKqJnvff+6HinxHhodSjTmf/ENR/wbYlJSPyorEYGQsgd exGEOaX4wUhsFFNyJb0+zbaj+exa52/+WY1d9bOzjxvg1JOmd3CEjvJT7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="427219183" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="427219183" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 02:36:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="693424712" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="693424712" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 26 Jun 2023 02:36:13 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 02:36:13 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 26 Jun 2023 02:36:13 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 26 Jun 2023 02:36:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KRJ4gwAUYxp/XSieive/M+5RC6k3vfIR2YIwdonO6JbwQ7W4XKCVfNLc6iZxZ5k1i4JEmHLBPaxhb3/4iZ4LrNUhLxmatHX3MZIS25T03gUfFCfPqUVUIyAyHFWANqosn/EQKH4kGvbdraRYfjECNvqjvF8QCQZOBfR/9FD4pzE4nLQ1JYk8KUFx7BRVaybaBAwZO2l24+bW+VcGQlN/Wxh6e0l7qkclE/S9b15vBIXQt61IdqKEwnRUY0vjwp4DQxK2Q7EKUFBHjYZGvMxU+AQExO0ki6IccACnftn/4u8isaTKKmooMPcH1TRCHfAGFeJ6gVDjBx1il1zqP1iKRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g5qwaBcR31BAG94Bn84BRie++sM74/frnKI3n0bBfOY=; b=RfxKB2/wEnc0pQM1aFaXXMUvavDjv0ymOsB4iXD+UP4WaJAyeYapUR8d2IqSDHIk77e06xlBbTcPEAKnebMTArWsqymnQWGMVj7vZYd1N3hbDapDefolXes/KWqUbaFA0d/Da1D5hD/EGZMwnGkY3u3vcOXdDOxjFHl42OT90NeFrrusyAb49tcga/LrVoxPRCAA7m1A2kz+8CkqtPnQFCpj9DTmhM+YlAnz2tQHJpTZi2lAbLanRhiuS6nJicFVfRvQdEcd6BOfjC3eWocGRjow1VjKAX1vtg3LdkzOqjZtrlnPameyVkD/PJPhwefjvc4BN9HzLw2q8DKmHNNYcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SA1PR11MB5921.namprd11.prod.outlook.com (2603:10b6:806:22a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Mon, 26 Jun 2023 09:36:04 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::127c:f4cc:e699:8f73]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::127c:f4cc:e699:8f73%6]) with mapi id 15.20.6521.023; Mon, 26 Jun 2023 09:36:04 +0000 From: "Li, Pan2" To: Richard Biener , Ju-Zhe Zhong CC: "gcc-patches@gcc.gnu.org" , "richard.sandiford@arm.com" Subject: RE: [PATCH] SCCVN: Fix repeating variable name "len" Thread-Topic: [PATCH] SCCVN: Fix repeating variable name "len" Thread-Index: AQHZp9aGX3Kjyi7WsEGN7rMpPb2W1K+cttSAgAAcrAA= Date: Mon, 26 Jun 2023 09:36:04 +0000 Message-ID: References: <20230626023204.1010610-1-juzhe.zhong@rivai.ai> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SA1PR11MB5921:EE_ x-ms-office365-filtering-correlation-id: c65804ec-d7e3-41cb-e455-08db7628c2cf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aJuDD6b8SoYdLd2Z4AzZGV+nCA7EB+tJaj9LfyAS4nUbs1EyQ+p68EJfvrEg1qQaBwESvWkMgQuMMF+HPFoE2SB0VX4fb52FNCUgUDATYWO1HwRwmIZutzS7RdcjEAK/SEF3zBx1E0vYUMIzLSpHBRtLtmOCrDcrLgitmiGDwk7vYqBmuILsVr555ESNm8lEneokpIBqxcVYVkoJWA9ySvMuazMzo1qWwgWsGUqdM7cWxu9zZfWY74FS/agu769bIFEeds6NQ5o93roL3C3KgqAzEUDTKm+fzyMrH3TfADVv2598M1rAKgDiKemjUwjvbZe+ptugxZ/YqGIAeaBIBeOPok87e3YUPmuvNq3ZQRfMW2WJB6LInLQ8P3wVydFCtqkiy6VTD63AR0z0SNFh8XP65AxzzzHWi/FlLvJFS8BiU/lZ08ALbfpRtjUZenu3o93vBYxtmnWEnHchIZZmWzpKmYEVxWgbc92bIkXpu1i0U689fmu+R7CkUTXJ2B2it8sRyvpF8zFVDEhxggF8cHSHcwGqnfsbjh3GQtUwy2oYaorCJjTv4YcJnuLu2nZh1gRO8K27+ILpB9WXmFUd/sw93GPn+Ir2BSz3NR+mJexQEhZdwSGzPAdprzLNaxGx x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199021)(478600001)(7696005)(71200400001)(110136005)(54906003)(83380400001)(26005)(9686003)(6506007)(53546011)(186003)(66446008)(2906002)(5660300002)(52536014)(33656002)(38100700002)(122000001)(76116006)(4326008)(66946007)(55016003)(82960400001)(316002)(86362001)(8936002)(8676002)(41300700001)(38070700005)(66476007)(66556008)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GuiguKHHTwLG4X/hnRBk8nhIDFqTCIVD0ppJBalzvceyHNhV/lmgwuctjSiU?= =?us-ascii?Q?RKjJ3xbt+I7KXUHsucVDBsM034yjc5eR+UM7hnqkvmZLHHOY84pkLDidp97i?= =?us-ascii?Q?2rfuZv1PcXav2CfEJeJZ5kjgETaHa0eTaaseoWZdts4lMR+RIlmcjXG8AJp7?= =?us-ascii?Q?zc9nf8gRLKClIYLTt1ebboozvdDwp+fgQPAvfQhUV7PzKk0w/lV4A56sN+HJ?= =?us-ascii?Q?/tgfnVZ3/OTZj2g0tCzTMOpbcBQNQGTwgZjkYCXLMdUPzMu6jOzlXhzuYc42?= =?us-ascii?Q?mTqS605+5TMl+s/+RJsnP3YM2UwIBYT2ttELTVVKSyv36gDjFnYaN0ZlTTx4?= =?us-ascii?Q?VkT4mA0e22TOKi1RbJaiZB9cPBpK434eNkH+YT0wPlNJtPji0lsdpF9yzsIu?= =?us-ascii?Q?UK/CQVHMGa/0pZ9RPGPDsaVwib8yqynRD4kovTtT3cIFrPjuiuZFzxwWeECw?= =?us-ascii?Q?0/TVenU1fR/koZygkmmv+L6h28Pc4p5yx2YYx6tzG3jXiOk7pQ3pgyELBVFd?= =?us-ascii?Q?2i1rvU2DrJA2khufzmDbbfbx4AfDHuh/j8NvTEVZpFPclRwzGCKv8Y7bBHTx?= =?us-ascii?Q?MmQGziI7gQuPZ1sxT32rV+llVQgt7JT+FxW6YHAT21QUgyT9YQnevJDCKZNG?= =?us-ascii?Q?iS2cfbvPChIdLvIJogmH1pDqKEOtcKwKYzm5cLH6GA1ooZxpuAL96eCwEcSy?= =?us-ascii?Q?XeCLQiFRttTYc0I1HHfgemeRBGTX7y8/66cM6Sio37p77KWDnXmRNrBFjA23?= =?us-ascii?Q?RHEY4waDf+fNXgfuG8C38U+Va74WpLlwOA2bNTFv3wA5k4IR4fnCe+6h5LIR?= =?us-ascii?Q?VTyzBlqsxwGmv44eloTotWWf7RY4lOe7yldCHKjLseNEtRw1EOhDRIwKu1em?= =?us-ascii?Q?6JLEKSWjSu2AUM9VAgps1Fm7atBYNv1m9+85v4PLbUboUf3uMGAWMSAOqq+t?= =?us-ascii?Q?v5woZTz4O3DHes917NG8nXnQ/ZM0I7lTJBPn4gRpKyCG60m8NiX8AbkFkl0r?= =?us-ascii?Q?SREpmbIR2drzszPmkf84LQHftOIiEcBeeylDedv98ZwZFfKQrxgdm1t+EKOp?= =?us-ascii?Q?wqPLi+Btlbtyy+Sz4y/ncTSntKzyy78yzqqu1dSyePyjhJKabpClAMwk0u/y?= =?us-ascii?Q?9CrY0aQInW7iiOxL25fV0lkSuFXZG1+zetAfkLUTUq5f/UZE46AHQtHLjeCn?= =?us-ascii?Q?7TSeWVm9CrOXbEI8cEvemAiQV7+DWYeOVatBc5EJbwRqs7/t4bQ84pk1J0mM?= =?us-ascii?Q?CSO+N8gnh/lECfZ+nNnYfKdfNvtiERSSmUSXckZFT8HjQ307eb3J0PwShlp3?= =?us-ascii?Q?OMIbRH4qfG28Pa6kQVox0wmHNYmlQ/ysCwYzCsSLbcnsu16ivYwiu2rc4sC8?= =?us-ascii?Q?BE2c56bkPRsak0+K1GA2La7RoDdbiYfpEZ3uvcCiJIKeV+6YUwJzQ4/CLo49?= =?us-ascii?Q?RHpaAGRcDVUPbMm9JMbAJM9zDaA+RRTZm6HrzCssUkSxk+re8eJN2q8uSy9K?= =?us-ascii?Q?g0ScNii4WOzka1wk3blySLJFNS+XNymDpJs/bHuo1/zzVqc5/1wu82pSsZaq?= =?us-ascii?Q?k52ONGfVuCGzpHMo05I=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c65804ec-d7e3-41cb-e455-08db7628c2cf X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2023 09:36:04.1781 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BhNb4/+qmfCWgcNyRKnwHydNrgWH8f/Sif4MuF0gi8zTISFoRRqScVqXMe5SZwuwMFbjkCiLoyabwjNDaxEsCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5921 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed, thanks Richard. Pan -----Original Message----- From: Gcc-patches On = Behalf Of Richard Biener via Gcc-patches Sent: Monday, June 26, 2023 3:53 PM To: Ju-Zhe Zhong Cc: gcc-patches@gcc.gnu.org; richard.sandiford@arm.com Subject: Re: [PATCH] SCCVN: Fix repeating variable name "len" On Mon, 26 Jun 2023, juzhe.zhong@rivai.ai wrote: > From: Ju-Zhe Zhong >=20 > Line 3292: has variable name "len": tree mask =3D NULL_TREE, len =3D NULL= _TREE, bias =3D NULL_TREE; > Line 3349: has variable name "len": HOST_WIDE_INT start =3D 0, len =3D 0; >=20 > Since they are never used simultaneously, such issue is not recognized fo= r now. > However, I want to add LEN_MASK_{LOAD,STORE} which will need these 2 vari= ables, so fix naming in this path. >=20 > Change HOST_WIDE_INT start =3D 0, len =3D 0; into HOST_WIDE_INT start =3D= 0, length =3D 0; OK. > gcc/ChangeLog: >=20 > * tree-ssa-sccvn.cc (vn_reference_lookup_3): Change name "len" in= to "length". >=20 > --- > gcc/tree-ssa-sccvn.cc | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc > index 27c84e78fcf..11061a374a2 100644 > --- a/gcc/tree-ssa-sccvn.cc > +++ b/gcc/tree-ssa-sccvn.cc > @@ -3346,17 +3346,17 @@ vn_reference_lookup_3 (ao_ref *ref, tree vuse, vo= id *data_, > =3D tree_to_uhwi (TYPE_SIZE (TREE_TYPE (vectype))); > if (mask) > { > - HOST_WIDE_INT start =3D 0, len =3D 0; > + HOST_WIDE_INT start =3D 0, length =3D 0; > unsigned mask_idx =3D 0; > do > { > if (integer_zerop (VECTOR_CST_ELT (mask, mask_idx))) > { > - if (len !=3D 0) > + if (length !=3D 0) > { > pd.rhs_off =3D start; > pd.offset =3D offset2i + start; > - pd.size =3D len; > + pd.size =3D length; > if (ranges_known_overlap_p > (offset, maxsize, pd.offset, pd.size)) > { > @@ -3367,18 +3367,18 @@ vn_reference_lookup_3 (ao_ref *ref, tree vuse, vo= id *data_, > } > } > start =3D (mask_idx + 1) * elsz; > - len =3D 0; > + length =3D 0; > } > else > - len +=3D elsz; > + length +=3D elsz; > mask_idx++; > } > while (known_lt (mask_idx, TYPE_VECTOR_SUBPARTS (vectype))); > - if (len !=3D 0) > + if (length !=3D 0) > { > pd.rhs_off =3D start; > pd.offset =3D offset2i + start; > - pd.size =3D len; > + pd.size =3D length; > if (ranges_known_overlap_p (offset, maxsize, > pd.offset, pd.size)) > return data->push_partial_def (pd, set, set, >=20 --=20 Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)