From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 1DFDB3857013 for ; Mon, 8 May 2023 06:42:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DFDB3857013 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683528134; x=1715064134; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VwdqXr+TRsPAKe5ij22Yayg4mErxpxK5yr+weijpNBA=; b=HdkuSe/Y1FCjQX4D5kk+N1qmjS/v8utLq+kF4TiTcKybqKooVWU35a+q claMSCnPMrKhYEXIZissdMgTh4vpfSBgV+YrKNV54ZNQVnJiJgeaGq0eS Qe63Vg8PvJ++i69aqisSBbLGKWt3LDHT1SgiAVuEjUaaZ3NVzeKzQGodZ v/FThlF7ERKa9zlwqFWYRwq9r20WvkCQYpKJGsXswowHozSY6Rzvcf7jZ ecrwIXQ5t++THU1IjDB7nS9oT07UYyOWHI8a2z6ebA4kgyanSWLFXn488 /C0N+yiSQi6dTtNsMG8p8Yuf/B1GJdiC+kFCbiib72vI8x+nVSf+YdFbc Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10703"; a="435888392" X-IronPort-AV: E=Sophos;i="5.99,258,1677571200"; d="scan'208";a="435888392" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2023 23:42:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10703"; a="731185643" X-IronPort-AV: E=Sophos;i="5.99,258,1677571200"; d="scan'208";a="731185643" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 07 May 2023 23:42:07 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 7 May 2023 23:42:06 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 7 May 2023 23:42:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 7 May 2023 23:42:06 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 7 May 2023 23:42:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cUXAOnI0mINLIlimw8WpgObxzVXVYAy74DqLC7PMub+l/20WNPOhp5K2yLBmfF/Nm7vKRz2s/kmV3KNiPZ6DYC5ZEvMCu6IX1c5vZ7wp6pLGWrSh7kf7GQ7Bp0LsplLmktdUOeuGNXixTXt3hvJiZwHltWkc550uMmseGkp+n1ura1QwBJe2aYZX/wJ/zhtcG2855a0IHxI8VE3UebQbIQPRsfHAJjZVU0TVLmv4N/f4+YW1OPk910pJzXcRfySU2p5Q6a2DCkw/c9fTLIhXzbMM4xIu5gUSK+dTT6HNSjND9BYxdwdGMS4x53wPKo+KobT3m69Q/KRNWlTsP+5dzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dftUxZqjfuPXTFputtRpKXdqqI4OBZ0Bwjg59hM0i0E=; b=iHD9qmiHYXnLa7Sc/qpKok2OUbz8SMFZ2LgZkTpI8fBae+ZhCXuVPcOZ1NgJjhFMVNoQ++Ke+5CcjuAkQQbv2qXhMRL9XldSpNEpuLYHxP66C8cv6H3oHhdQc8fw/30pFsLUpo987f6Hpx+4R/rPyNWK2k9Xe1ceItl8xq3X1kbYsTmEQ1EjtEhzvv0FKJsiFydaGdDRZSGzFffwEpU2wMsGEm3GO/s0QKlyC+V49lmEs0UMh2vlrJ4qxDvH74jBM15FoXN64Vjf6tqgYaJLr33TUK19xQFLdcffmh2uuAIc6IF4hO3ocOCcGd/igZdDBXZ2cZAXvjz0cEzq/m2spA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SJ0PR11MB5647.namprd11.prod.outlook.com (2603:10b6:a03:3af::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 06:41:59 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9%3]) with mapi id 15.20.6363.032; Mon, 8 May 2023 06:41:58 +0000 From: "Li, Pan2" To: Richard Biener , Jeff Law CC: Kito Cheng , "juzhe.zhong@rivai.ai" , richard.sandiford , gcc-patches , palmer , jakub Subject: RE: [PATCH] machine_mode type size: Extend enum size from 8-bit to 16-bit Thread-Topic: [PATCH] machine_mode type size: Extend enum size from 8-bit to 16-bit Thread-Index: AQHZgPgLEItqgvjuhkOVhtsYc5zgaq9P6wCAgAABRvA= Date: Mon, 8 May 2023 06:41:58 +0000 Message-ID: References: <20230410144808.324346-1-juzhe.zhong@rivai.ai> <2978624D57874251+2023041307225185723242@rivai.ai> <436847c8-0c15-24de-5925-f56d78caf540@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SJ0PR11MB5647:EE_ x-ms-office365-filtering-correlation-id: 842a7d2c-99b1-4663-7276-08db4f8f5293 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: leYBKLNzFi+8+lieL4x276yaXBk8CsALFFI7MxvkveFc8TfcYHkyzEsEUIZIFyvTHSVvLcm9Jla2mmBLvacRXG9qP71UpWDJMxHSU6fi2VhZYCyvecQu3fw/eHlJYGIWXARQ4j06e2F1ujI019IOsRHXJ9aVCAH8LbO+5y3jvKcTricI/oSNfnCFd4fnJhWtv7V8HZzCEGViUJAAwUMTkhucr2RHQh2/Dqg2oQiQxtcuqv3PDbX/RgGiLVZePzMPm86PKWyF9VHAaiKRbAMkuoSUlFLwN9ClnuB0Y6DnbrWHcsRAGD+U5ndc0kuOghoJ721/1hlI0uTFAWGIp0d1YHChBeddbJP14XIrSNkGsPHQII8NGjJC5c0l6+WBetyTVi6k4wj1P+pAcd0iFR/O+08Va/FE5muvqLm3YEcjVVglPWP4GDYtWaBcKyOA8z/Z+CuOXt2KFIWm5K/4iJM69mc9fVSH1ZusXJ58BAml4ibimW6SHmgKCA7FHf/uqZJMqVwsIM4Ldy6UgDSJw36ilAVWiTUK37mypBn+2RcszwU5HVFYS5M05FEO25LILLJn4iJ5KrHTtCE2XXCpCkf9wNiikUOphi3EbyRoEG0xgDvuIdSwgJGLpaenJ7h5D0oo x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199021)(33656002)(38100700002)(52536014)(2906002)(38070700005)(316002)(8676002)(8936002)(5660300002)(86362001)(55016003)(66476007)(66556008)(66946007)(76116006)(66446008)(4326008)(64756008)(41300700001)(122000001)(82960400001)(83380400001)(53546011)(186003)(9686003)(6506007)(26005)(7696005)(478600001)(54906003)(71200400001)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FWh/W2z4l7me45et+tATZTD+jPz7wriovwqkWn1JDTExx0s3pXTExBDUqMsc?= =?us-ascii?Q?7dPPzFAOav82AL/gH+01cgREp/ib+Vb+kfS5481+v9Wc7Hcixk4oauKMPk1N?= =?us-ascii?Q?FOhMV91mlRTqkIINtXOSg9yYkSdmlz4wjs4/dvL+9Bxf8OKT7ufsy5sMSc7X?= =?us-ascii?Q?DtZCWhFOVl8e7ia/TjV3bduVdt69N91Z7/DlkuyMZXjsnRJLBSUqAP2vVU9K?= =?us-ascii?Q?xJjON9zAB93EIhBVG6//XYlHNDztvqD3v+kHvaNK/SRr5ksk0PgZ3VJX868w?= =?us-ascii?Q?R7C8TzSyx3FAlvvvARMn7CiFMhmzoGOtbkJPG6dDkyu6mFhKrM3W8XnuKuBb?= =?us-ascii?Q?n1c2hcCCD878krEWCESyuM9rqlTWQkmvQrn4M4acMLVof1Xo6bmcAq9JQw3d?= =?us-ascii?Q?tvbdNb0pZlvbNrVN5t/jXstTg7uzjJjIxZWuy2tOfQLWySPEonn7VrwRV51i?= =?us-ascii?Q?6K2sdjiQE6jbV747XjuB20dHxLr6RRbylZ7by3O0BRYW9/xXbzVwXbnPGbA9?= =?us-ascii?Q?2EarUkFZpyUvwgwbSAjZzA9aJ+l6l+ejgOM8/3LO6i8xO1yGMWICZOJurxCy?= =?us-ascii?Q?nxkNHmkzmSc49SZWSGY6lY3iRhJ6HfazgTSqoqt6KDH/NejXTg1BdCz+YYgk?= =?us-ascii?Q?U0zgrO1GlvFJ9IGry0wowCcMst0sb5JAzs86aTjdWZElvefckDKJK5UUik2x?= =?us-ascii?Q?ky2qF0ZjspKh/hpGL1DidohuwDdtl5VmaR6pVCXByvDCHfHxTuItri44vimp?= =?us-ascii?Q?jRsEAOSkLIkfUVDwBI5KeT3hGl7C7ugGfDsSPpuMZ/FnYWE1tqT65vyknyqr?= =?us-ascii?Q?5WUUaxKzwqjO2gXNlG/36Yy+OwLnju+nJzy+zlBcRPKhJr1GBFhgVddiWvuc?= =?us-ascii?Q?ltsK+b9ZXZ1qNKxIIXGqN2nsZ6oBts6sqUDVNInkRGflfs0aXZSzrrn29qmk?= =?us-ascii?Q?V/j30JxrRhSrJEs5wzYmRXbuC9ruQuKyRdsgD1lHiES3LWCVkwvvGMo3XU3g?= =?us-ascii?Q?TWuNQYSZUl9SV+Uo8CTaBFm/xbGk6fJiRPBrMJ5RQex6RdirDRiBM3p7oqC/?= =?us-ascii?Q?7rxyMGzF7tJckyOiILLuLY7A/caUSeGMKLTR+qLexMdu5Vn19j5CO1zxgk1d?= =?us-ascii?Q?Ht9XMYKZxcFh13jLfZKiWjaMccpFCVv07ddRtEjAdBlupaU2RIVwSK0CWac6?= =?us-ascii?Q?nzGStZA9X9WkK/FPl0p5NZFuX2UFvn9tm8Vmfod7AyDKh34pF1vo5mDjsaws?= =?us-ascii?Q?bhRKYHc84kjCa5lOvhy9qTGxqKz2Oafu1o1gM0VltwtgyFpN0h7PoQrBDXBv?= =?us-ascii?Q?0uwIu0EmzWFKEOg1+yFvR6rVvvTL5AxOG+vselmHcrv0BxDIczsuUZc32u0r?= =?us-ascii?Q?W9lZNai+LRiHS2n2MHWFBwuLNJs74Ngb5Mvq+VTajJDNgCoz+Nfpv7lg7CpZ?= =?us-ascii?Q?L7/t6ekTXDW74km/XnO7OQELZ71BK/1z60Y2CkUnw77nKibCGViJu8SkY0RH?= =?us-ascii?Q?kzdP9yTs/iLxHV/TeR9ZMhp8SyIbH+llTzC1ldgxrtKZ2qi7iVM31DMweq26?= =?us-ascii?Q?wGFU1sJAtfjEhTaMGiI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 842a7d2c-99b1-4663-7276-08db4f8f5293 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2023 06:41:58.7172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bPI39749DysUpdCnuKW62Zxsw5zCAcKywMv+scC7DtmM9n28jliUmQCvBjfWG7+uDnhaVPWUtuvTnKlya+6VGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5647 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Oops. Actually I am patching a version as you mentioned like storage alloca= tion. Thank you Richard, will try your suggestion and keep you posted. Pan -----Original Message----- From: Richard Biener =20 Sent: Monday, May 8, 2023 2:30 PM To: Jeff Law Cc: Li, Pan2 ; Kito Cheng ; juzhe.= zhong@rivai.ai; richard.sandiford ; gcc-patches = ; palmer ; jakub Subject: Re: [PATCH] machine_mode type size: Extend enum size from 8-bit to= 16-bit On Sun, 7 May 2023, Jeff Law wrote: >=20 >=20 > On 5/6/23 19:55, Li, Pan2 wrote: > > It looks like we cannot simply swap the code and mode in rtx_def,=20 > > the code may have to be the same bits as the tree_code in tree_base.=20 > > Or we will meet ICE like below. > >=20 > > rtx_def code 16 =3D> 8 bits. > > rtx_def mode 8 =3D> 16 bits. > >=20 > > static inline decl_or_value > > dv_from_value (rtx value) > > { > > decl_or_value dv; > > dv =3D value; > > gcc_checking_assert (dv_is_value_p (dv)); <=3D ICE > > return dv; > Ugh. We really just need to fix this code. It assumes particular=20 > structure layouts and that's just wrong/dumb. Well, it's a neat trick ... we just need to adjust it to static inline bool dv_is_decl_p (decl_or_value dv) { return !dv || (int) GET_CODE ((rtx) dv) !=3D (int) VALUE; } =20 I think (and hope for the 'decl' case the bits inspected are never 'VALUE')= . Of course the above stinks from a TBAA perspective ... Any "real" fix would require allocating storage for a discriminator and thu= s hurt the resource constrained var-tracking a lot. Richard.