From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id CAF1D3858C2B for ; Thu, 20 Jul 2023 08:40:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAF1D3858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689842432; x=1721378432; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=Y3M4wk6grA+OQbdht3vZrvNbCngpfqe9RY0eHdLV4o0=; b=SlrIFZ5xaBdRSD2Q0CaVbT6EvRRsOvY2Cf1D7KfVRJ5lLk1A50Sq0HWg xDTHL9ysq8EGWASKlrCpAiBYsgyLdBPRcQtISgl2kkprLJs3IDpMxMzD8 hdKAhp7ko/Y2j8EDSkm3LG/G7Mfk/MVnCxB78tkgdSYv/HqiRO6EFw2LP AQf+oarOZap2jcJ0P6Emuv9zeRGGwZlO8ewS5h4jEV+dV8JRJtlnzS8Yw 7zky9MJ3XuY4nLSYNzUpEsyLE9rvAIjd83V1yHw3Y4XizrIg8yoMgo2IH GO/cxfsf42ga/yoxnNeo0+X5jOApbglbCgNvmu2zQ2oSF04rw63103DLJ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="453049322" X-IronPort-AV: E=Sophos;i="6.01,218,1684825200"; d="scan'208,217";a="453049322" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2023 01:40:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="753993212" X-IronPort-AV: E=Sophos;i="6.01,218,1684825200"; d="scan'208,217";a="753993212" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 20 Jul 2023 01:40:29 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 01:40:28 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 01:40:28 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 20 Jul 2023 01:40:28 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 20 Jul 2023 01:40:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdy0hzsCWgOIZLhkJgWayXBjCl7OywtG0lZ3mtzv+G7nYF0QSk4YnYHvLyBen4Sf6x+b+ETnwqa6qwkHgt66UV8xyDwtGjeTrklWd8BUpgqVG6dp/wXwMKrjtNzOoAS919vUnui51YvraJOgWCkYXQg1Wyj8kxd72KOgXlOPROUepJH4n5PtlDj9CM9v95f8c0wbY2k0uRP6RuF8x1D5nY1Qew1hikiHNL211r88FNaZBZO2bIe7gYVv7QrUbSGymwQYO8r/VSeXObMOpblVhSPBG6k0uwqBd1wZ0PSUh2hSJLY0UBaPVHQI0WS4RLPTS3L41xNJucrAw4RQ4iKx+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nv4JTzUYLK9fMaDJUnqcoGMpZ4fFKw3l53p8ytopZrE=; b=f2Kw/dvxQUxhqKVg8Wo9ZNAtexwMJqafTnsiG5wR9Wpvjiw6zA3QG/W/tOnaj490bXbxeY7mnIBvunwl81RQro9OQ/0cnklsSlO3mAzETg4hwyhgjll72IhisUJ0IRWIo3zIJnVk/q25G1765MN7yZ54ojyqmceBk1+YiSaqpeplL8YMNHhRqR7wngPVUwrGMolDIkgpLbHThUox1BTx+Z0u1yyGmQHe98pAN4FbDkigF7eGB3J8Nhs6D+MfMrGe7fDkORK90nyjk8JAELhlutiBCRBHZwZAYdk3eJkdxzqx0r+GA+415RpnxOZzXfSH3RQQEBKN7QOz4+SRAFEBpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SJ0PR11MB6720.namprd11.prod.outlook.com (2603:10b6:a03:479::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33; Thu, 20 Jul 2023 08:40:24 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::21a9:85fa:b8a8:8052]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::21a9:85fa:b8a8:8052%3]) with mapi id 15.20.6609.025; Thu, 20 Jul 2023 08:40:24 +0000 From: "Li, Pan2" To: "juzhe.zhong@rivai.ai" , gcc-patches CC: "Wang, Yanzhang" , kito.cheng Subject: RE: [PATCH v1] RISC-V: Fix one incorrect match operand for RVV reduction Thread-Topic: [PATCH v1] RISC-V: Fix one incorrect match operand for RVV reduction Thread-Index: AQHZuuUoxkc974fcEEqf8hSOvNorta/CVTHDgAAAZWA= Date: Thu, 20 Jul 2023 08:40:24 +0000 Message-ID: References: <20230720083530.3260344-1-pan2.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SJ0PR11MB6720:EE_ x-ms-office365-filtering-correlation-id: 5c4f807f-7159-40ee-6102-08db88fcf632 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bJIibQrIC6kCjALsO1FnKQyn/LXWvwDnQDewl1tGYY0Ze38sUh+GWzkNq1V14DmApMvXFY6w4Hy+SCWqM7O8MnwGvh0cHity9Vs7NcBn7PBEA+VA+ruhw5pyD4bTapSo+RgoETf1n/kX8lZyuo1K1+l2FHdQpp2fY5eOyM7muec7DvncnJAxyMucofV7WEIQM6BtCHB6W6FJ277NmPAlc0E5QH9GqUcu48yA8QrCpW16fsoBkKCwpAhGnQbKASExuenUOs/atVcS77WAHYEGOw7d5N7KOOse9kaIDPGq3Db1ZSYVW+XLenSTB10J7Gsz7eGXuxHBwTzoiUO6smUKOh2SddBXlMkt8Wsht87Hp3q3uliHfE81z0/Xz3LslTAjNrAbVnh7sx6Xa9PXzd3DT7XIsww+AIETuseZE1LBMSs8QvZbpzhwjWXEGg8cYUiJhfBvzzeWks/XgWgmxFChPVZb+Pbm2pIGJVex5EjQXCcmYTXKP9W6YgAOHSDzaMbLM/DG/Lv+FWStlkJgi3PiYvkYNlZdVKij+pXyFLf8cQShVRbfiDBLB4wLju5tzerKCfU61EQSolQwa36571vjSgS+VDk+bI/gl36B0vVDX78= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(346002)(396003)(39860400002)(376002)(451199021)(84970400001)(2906002)(54906003)(7696005)(64756008)(8676002)(33656002)(478600001)(41300700001)(110136005)(66446008)(316002)(66476007)(66556008)(76116006)(4326008)(66946007)(71200400001)(122000001)(9686003)(83380400001)(8936002)(82960400001)(38100700002)(55016003)(86362001)(5660300002)(6506007)(53546011)(38070700005)(186003)(52536014)(579004)(559001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XgJUOpo8YTMoOsqnMr0R68WNAHd1oQlCX7WlaVBT/jUbunyvr6lXuVIF1J9d?= =?us-ascii?Q?CY2Yoz5PQnNqxxYIF+WUI0OXccesKmuRrwJVEGznyzOGlaLgPg7NNc3DhZS8?= =?us-ascii?Q?MMshoCarP+HBnoQM15h02pBHLqIFXs8W9vTkL9hekCVLm5GQhlHgxdIPBrrn?= =?us-ascii?Q?XjT90fDFUpVdxYIIeB0G1es6xodHtpCmdO7nPQn2sezGOKxtjJTodq5H8xzK?= =?us-ascii?Q?g3YBHZScpuscTXQ4QqvNn5NMHy/gKgrYe6C5t/y5CSL19IxbtxXgbULR4KW5?= =?us-ascii?Q?wgj1qe2IFCQWDLec38Ds2Ym5tm6UEg1H/9dawaswr88LsTcIuZ4EOZDW6KCT?= =?us-ascii?Q?7cR2bN0hQjbxXJ6EYZUZlwQm6gA71AFR6JgVt03TDdnfDjvNfPZucX0pnQVP?= =?us-ascii?Q?XGmJXpocIN3poL7HOFoc+ieMvyX5TSRt9BBgGWAuJPoR+0VwaMjV8f2pMvsU?= =?us-ascii?Q?8bbjDTjgtVbVzkVtOaWwyK5onMGcsv37ONBbstidvf0H3L/Mfp7EUtqzy4mt?= =?us-ascii?Q?oJZVIJSLRyknFHfDygGximBsr5qiUKRNTEnNl6EncHDruKMtlWk8GDDVn98X?= =?us-ascii?Q?dC4WUbA59ol5PXhRCxqqh41htyqEfCLujs95+6L+0EOaGAzgPtdv/fmTw43S?= =?us-ascii?Q?iLtzUw9O38lJoMasTUwEaxYuG6dJrTKr2Ar5whoWMb0IQJ4oOELaWUT0y5y5?= =?us-ascii?Q?mVtRYeaXzvFPVdKg3NJCuTW2SnQwVJw96qs2lWVwtynW6fd9lZ9N2wv533di?= =?us-ascii?Q?6dvf4bxTjJP9coHSkHLGALeF7VukWeyDbOnw84QFGzgLNGz+sJDgTsGrtqoN?= =?us-ascii?Q?AcVL85QcjdZ2dtfDzUdmY36VsxQaHBXF6vXPpnaQhEDEGBLJlK/T6LUK+7E4?= =?us-ascii?Q?6LAS//uXnSt5mnphJKZnsiuYTgpTY7LwHmaplJyL5Bk/Okyfu/2TW+NdKusp?= =?us-ascii?Q?mLjoUeU5qmLR6bPdJj1BQdcZ0raw01iiy9Q1n3XiXZkpclghiUgUE6OarWpR?= =?us-ascii?Q?oG8CMnArh9gTqd+pyDl+Dp33wcM9Cowcf8TuOCwLJ9KUzyTtMZeN9cZOw1I4?= =?us-ascii?Q?o9RQHe0kg7VK7gXuv6fBjvt3M2l2SHSN2g5o8cTNlm+vpZaIQf/tUBO85JTs?= =?us-ascii?Q?H7FGxpoB/fi8GhPsBkyeTFnlaHgADtYbTraIwqcVZMI+1R/G6ZcYepZqrCch?= =?us-ascii?Q?rewR6pDrK2HYo4yCFx+Ravvtx6YJW/9OPDkufeqXwWB+KLfS5GNfIyrQ38UI?= =?us-ascii?Q?ERkf0fzNBWrjmVinOpOwaZwfFH+Ikv4wQcth5Yg71cTBRLyhwzKFMHzb0T81?= =?us-ascii?Q?0t4e+ZSlxyEGr9uZiPzS/204HPyvMoGIV9Y4hXnlUmjh9SVz7AT4EZmIhIyW?= =?us-ascii?Q?SuBHPjT4gnh6m5dbs2s0FHSa0T/TLpWlZiYF1OKYcPQrio6BEziym6y7RqmN?= =?us-ascii?Q?1vvbIRk9C8ZOrWIcSXjoPjLUECmsWe0owDneDhTO3jfJT5Q45oF7O9xvDm7g?= =?us-ascii?Q?2a3GSGJzbmd/5jNTIUwUfxd9bUZZZ/NPQlJua7RFdoNPH0Hw7HsY2L2rgw?= =?us-ascii?Q?=3D=3D?= Content-Type: multipart/alternative; boundary="_000_MW5PR11MB59083906E48AE13329FA0D90A93EAMW5PR11MB5908namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c4f807f-7159-40ee-6102-08db88fcf632 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2023 08:40:24.6376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 21FF2faVgDHIWsBqgnTB0nVsXoAblmVgZEWL+++iH5oTjsM3/boXAnpTbdzz0B716MJ6IiV1kjxIIUArhrukfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6720 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_MW5PR11MB59083906E48AE13329FA0D90A93EAMW5PR11MB5908namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Committed, thanks Juzhe. Pan From: juzhe.zhong@rivai.ai Sent: Thursday, July 20, 2023 4:37 PM To: Li, Pan2 ; gcc-patches Cc: Li, Pan2 ; Wang, Yanzhang ;= kito.cheng Subject: Re: [PATCH v1] RISC-V: Fix one incorrect match operand for RVV red= uction LGTM. You can commit it. ________________________________ juzhe.zhong@rivai.ai From: pan2.li Date: 2023-07-20 16:35 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v1] RISC-V: Fix one incorrect match operand for RVV reducti= on From: Pan Li > There are 2 of the RVV reduction pattern mask operand takes vector_merge_operand instead of vector_mask_operand by mistake. This patch would like to fix this. Signed-off-by: Pan Li > gcc/ChangeLog: * config/riscv/vector.md: Fix incorrect match_operand. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/pr110299-1.c: Adjust tests. * gcc.target/riscv/rvv/base/pr110299-2.c: Ditto. --- gcc/config/riscv/vector.md | 4 ++-- gcc/testsuite/gcc.target/riscv/rvv/base/pr110299-1.c | 4 ++-- gcc/testsuite/gcc.target/riscv/rvv/base/pr110299-2.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/config/riscv/vector.md b/gcc/config/riscv/vector.md index fcff3ee3a17..f745888127c 100644 --- a/gcc/config/riscv/vector.md +++ b/gcc/config/riscv/vector.md @@ -7915,7 +7915,7 @@ (define_insn "@pred_widen_reduc_plus= " (unspec:VSF_LMUL1 [(unspec:VSF_LMUL1 [(unspec: - [(match_operand: 1 "vector_merge_operand" "vmWc1,vmWc1") + [(match_operand: 1 "vector_mask_operand" "vmWc1,vmWc1") (match_operand 5 "vector_length_operand" " rK, rK") (match_operand 6 "const_int_operand" " i, i") (match_operand 7 "const_int_operand" " i, i") @@ -7937,7 +7937,7 @@ (define_insn "@pred_widen_reduc_plus= " (unspec:VDF_LMUL1 [(unspec:VDF_LMUL1 [(unspec: - [(match_operand: 1 "vector_merge_operand" "vmWc1,vmWc1") + [(match_operand: 1 "vector_mask_operand" "vmWc1,vmWc1") (match_operand 5 "vector_length_operand" " rK, rK") (match_operand 6 "const_int_operand" " i, i") (match_operand 7 "const_int_operand" " i, i") diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/pr110299-1.c b/gcc/tes= tsuite/gcc.target/riscv/rvv/base/pr110299-1.c index d83eea925a7..a903dde34d1 100644 --- a/gcc/testsuite/gcc.target/riscv/rvv/base/pr110299-1.c +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/pr110299-1.c @@ -3,5 +3,5 @@ #include "pr110299-1.h" -/* { dg-final { scan-assembler-times {vfwredosum\.vs\s+v[0-9]+,\s*v[0-9]+,= \s*v[0-9]+,\s*v0.t} 1 } } */ -/* { dg-final { scan-assembler-times {vfwredusum\.vs\s+v[0-9]+,\s*v[0-9]+,= \s*v[0-9]+,\s*v0.t} 1 } } */ +/* { dg-final { scan-assembler-times {vfwredosum\.vs\s+v[0-9]+,\s*v[0-9]+,= \s*v[0-9]+} 1 } } */ +/* { dg-final { scan-assembler-times {vfwredusum\.vs\s+v[0-9]+,\s*v[0-9]+,= \s*v[0-9]+} 1 } } */ diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/pr110299-2.c b/gcc/tes= tsuite/gcc.target/riscv/rvv/base/pr110299-2.c index cdcde1b89a4..1254ace58eb 100644 --- a/gcc/testsuite/gcc.target/riscv/rvv/base/pr110299-2.c +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/pr110299-2.c @@ -4,5 +4,5 @@ #include "pr110299-1.h" #include "pr110299-2.h" -/* { dg-final { scan-assembler-times {vfwredosum\.vs\s+v[0-9]+,\s*v[0-9]+,= \s*v[0-9]+,\s*v0.t} 3 } } */ -/* { dg-final { scan-assembler-times {vfwredusum\.vs\s+v[0-9]+,\s*v[0-9]+,= \s*v[0-9]+,\s*v0.t} 3 } } */ +/* { dg-final { scan-assembler-times {vfwredosum\.vs\s+v[0-9]+,\s*v[0-9]+,= \s*v[0-9]+} 3 } } */ +/* { dg-final { scan-assembler-times {vfwredusum\.vs\s+v[0-9]+,\s*v[0-9]+,= \s*v[0-9]+} 3 } } */ -- 2.34.1 --_000_MW5PR11MB59083906E48AE13329FA0D90A93EAMW5PR11MB5908namp_--