From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id 70D8A3858D33 for ; Thu, 9 Nov 2023 12:34:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70D8A3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70D8A3858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=192.55.52.120 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699533271; cv=pass; b=gCO0I252Tfx5eCUrfdNcpGdpGw31ClK31/URlLh7K7jWIqwNiemDHV/c4i9PCskHr66/otAaxjgMKWUk4TD9bvdT6GIqv57J20UE6HSwlmZjIBLzipWN1pcU1mzInrGAfVNr2L22uVYM+7bIn5Ta3Xmxl+dzPkQOp9kASGMdpSY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699533271; c=relaxed/simple; bh=YBMEgPWPUDTm0fYdORn63JJfnKWlX59PehJrOaV2oc0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JdRD9R6TIJBIr9cE42anyGNKultS76iH5IQLDY38w+h+DMJs3ltMzRCAMyRh2DyEXn7SajODd5PDEqSjeQ6kvGaixae+3Bo470wWY7MmVlVVjilQueAnHF7SIrJxqNT/shvNYZd8TSf+9D1z3XAdjsFFxiF3bXa+aoxpw/Torv8= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699533260; x=1731069260; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=YBMEgPWPUDTm0fYdORn63JJfnKWlX59PehJrOaV2oc0=; b=MEg+mona7Bg/NpxJMCqDfQwfXf9o0K8Npx5HlC39krnGSUGObHouc7yi +CUi5XgpBD9gRKcij4vw9T1ZKmqEjDkYoIrjPP/gWs0MMCYeQyffNWG+V 2J/DgZLSMNRjWut8AHTqe+6NTaAd5q255Kc/V55HnnjP9nKUmoUYQ6IfX 5g8QLttCpyiaPuArWbc4VH830Dz5MEn6QcCXC10dLWFzmn8evk2TVDfyG xKgR3NveRJd9yWcAhDykcwBzBCsHItakPYF4/L1ImSGGYb/8+Kpsp7CwM DIHPcRm+WubUbVEr9YgnD6C+KboiQikxJkLAh0Ha8CZTIYSpDbedXEGlp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="388830410" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208,217";a="388830410" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 04:34:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="739831686" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208,217";a="739831686" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2023 04:34:18 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 04:34:18 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 04:34:17 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 9 Nov 2023 04:34:17 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 9 Nov 2023 04:34:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLPcEOMcxlaMMw/g0bo4YB8UwRCsH2GRKWdH2bEOTAP4G9r0wS1LPmiiLnRioS/2MRG6tUG/8zVEa2w0BSFJcON3VDyAdphQeHFHLFJIDbbfZe1ohh/vZ2gmJffO5xP14mrfjkvYXlYR2k1+r4Gckw/CbdXraIjS2WjQtyKDfWYqXKFW8CtJB91Z5zsv3hCFs4436wnrTKSSr/llVnpwtuBnNksoDCSrIRmrQvaup0LuZsAvd4WXdEfb0w1fomalZu4Zrv6GSofF4giMNV18Z2aSsvRbP8utbWiFPl2Eyb4TsKI7TL9UQUpakU38xFBOaUvmtGLYpxVgSUC4oBi3QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UkrFVkTAVvY29oeheo+HnJy5tZrcCZzjcg5of9njwPU=; b=EBTNBeE6bOQRUFRAzqcE6NCrouRKJGdMYHpPluvFy7DdrnAOOkpM0C5Bwn6A112JsqHF6pHWFCnyqPKNI7/ADqdIfelrHu12FOLRxzQ2/pFD0U2hOcN7fMcuHSeU5+eVXbARS0fbUFNC5zEjwUdAjtUnbP/8lsyoqpqRv/d+j3KYwZbsxcMs1LUcca22FWfpCHt0vUBaMSZGsYHim16Eg4lt6A5UTSLaXDUMHpsnBsvpGDKXpnEsqUGrOBpc8IIqALIQwCusM2KwXsxIrFJAdEUZIO+o8VZ+h1bxkLnAGAcBuHvoYlGmIqDF1P3iAUU36JoYwenVm9qEnxRBXNRO6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by BL3PR11MB6532.namprd11.prod.outlook.com (2603:10b6:208:38f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Thu, 9 Nov 2023 12:34:07 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::4317:53a0:2638:358c]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::4317:53a0:2638:358c%5]) with mapi id 15.20.6954.029; Thu, 9 Nov 2023 12:34:07 +0000 From: "Li, Pan2" To: "juzhe.zhong@rivai.ai" , gcc-patches CC: "Wang, Yanzhang" , kito.cheng Subject: RE: [PATCH v1] RISC-V: Refine frm emit after bb end in succ edges Thread-Topic: [PATCH v1] RISC-V: Refine frm emit after bb end in succ edges Thread-Index: AQHaEtkhpQhksnbxMk629npCSvUl8bBxjWoBgAAWT+A= Date: Thu, 9 Nov 2023 12:34:07 +0000 Message-ID: References: <20231109065057.3179104-1-pan2.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|BL3PR11MB6532:EE_ x-ms-office365-filtering-correlation-id: dfd53a57-3292-4b53-14ac-08dbe1202a8f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6ppIm7gczIP1/m+6HdnNDB91TZIu4cbvbPfy5kazJH5GKHB0zHukCDIrX5kv6+b5/qmeEnlHnqD6ZctN1sY7nKbGpnMWopopeSw8uKNqvxrK4ra3BeGB2U7hkFMeEHumBDRvk9wpvhVkpI1ei0UjE5nbq0hZ/z9aX2TsO4e+BC5c1RLP9ro4/8JtfLRFZqiIFzT7b98PdNX4DBG5JPI7XxrMea4KEiO+1z1iLd1uFu5A0dxjcu1ZFw2/EezkwEMHmIL3xwl7inETlehEm0IdLDaeU+qkl0NLghGC3yUfU75YVyaJ1RW8CjEfUlyxp2XYYgMoT5xprjBLzSjl7Be8X96he0wGGav2X4ZOooOAcrJISlEoarmqGVq5xRaYa2qbM+vgQlZoLnw3fGtGSkmDDrdWrngOF31XIDDpouptGmGdlcrNrem+cTa4zzmE0e8n+4HjuRQJbRpc+cD/EppZvVBaqQuT0qljlRn7lZwHykeNmlU3kR4rIM+azD7H3g6kb5fKLtyCgAt0vYWxIaPs3DUFQRvAOfZyrjQYpD4SzFX519EzSIYljLUwvHYLnP6uB3l+GtQmb/VePGnCvnIYExQSlJfbYrP59BaPoJ7EoNYpswyz7LFTsL4GVQtkwB5U x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(346002)(366004)(376002)(39860400002)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(316002)(8676002)(8936002)(41300700001)(4326008)(38100700002)(55016003)(5660300002)(2906002)(53546011)(66556008)(9686003)(66446008)(33656002)(54906003)(64756008)(66476007)(52536014)(86362001)(66946007)(83380400001)(76116006)(122000001)(26005)(82960400001)(38070700009)(110136005)(71200400001)(7696005)(6506007)(478600001)(559001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?Y1lwSmtuejEremxlWnV5ekU2ZGg2c0VKSGE4TkxWek9NUi9tLytTekRi?= =?iso-2022-jp?B?cko2Z1RUUFdoSjd2WGpGMVRpdFY2K24yR3dRcjBVRzh1VlR3NVlrM2dN?= =?iso-2022-jp?B?NnhCZnRyTmdENVFHcmI1T3cvWC9DWmsyb3VGalg0VUJEUlZUMmQyMitN?= =?iso-2022-jp?B?SlVINWpSOTBpQ0hDMXpxaTN5ZWxBc2MrTkpkeFZjaU1ySUtMNGhFc0hh?= =?iso-2022-jp?B?bHphUVU1bzMrM3o2c2JYRGNVWkVKTUkvMjFyc1M4enhCU2JGYzNTWmNS?= =?iso-2022-jp?B?M2t6TVdtSDZMeWhRL0VBRmFVQ20wRm5uSEFrNWpteHpLeTF0UEpqQnhu?= =?iso-2022-jp?B?VG9CKzM1YzY0OFdnLytSL01zTmJGMWttOFU1N1NjeG1vSldiQUwzSk1L?= =?iso-2022-jp?B?YWo4RU5xeVpnU1dkbTE1U1cyclV6bUYrbHYzazQyQyt2WU5COTIydkhk?= =?iso-2022-jp?B?MlpSZXlyNE9nZjQrYzg1bjd6U1dyUGpzVllhVExYdEszVUIvL1RQWkVL?= =?iso-2022-jp?B?WUNqMWRpdXA3bEcxTTZJUmI4T1JqcXV4NHJ2RHpJbzg5Z0NhMWVXS0NY?= =?iso-2022-jp?B?WFFxa0VVWGhmbUpXOTZPZ00ybmRxUGlLbEFKRWV2WmZ2eTUwUHUxWmlr?= =?iso-2022-jp?B?b0dQcUhJTGwvbDMxcnVHazBud3BiZjA2MkxHQjd4dEcxZjVjWFB1cUF4?= =?iso-2022-jp?B?S3FUeVBDN0pOUjUwd0lnRzV6OTAvZFNYZzZUYVp3VFVqU0dXWkc4NG5E?= =?iso-2022-jp?B?NGh2enZNSjk1bGFYQko4MFpoSDk1VGlib3htd0c1RUx0Ui9XNGptZ3hY?= =?iso-2022-jp?B?UlUwSjFNS2MxdVZMcVQvVVRaeTNpNU4rWDFSbWorMEhqWjVOMkxXOHRP?= =?iso-2022-jp?B?UWNIaWZnRWNCUmJyYUJBamNGcTlXQkIza2JBRTh6R1ZZU1F2MXhkUnhC?= =?iso-2022-jp?B?cldsMFZjcTNNcVJFcllsRksxcmI2VXVFc21JclpFdXA4by9vVzcxL3Nm?= =?iso-2022-jp?B?U0luMDUySXExc1FEUHR5OE0rTTVCTHlzVGQza3JqTHIyT0FuNDZRUzJi?= =?iso-2022-jp?B?cFV5cWwrRTgwNTc5cVNmckFNcW1rY3lqd1hHWlh3eDFXZE12NndBN2dB?= =?iso-2022-jp?B?SjJKT2x5MWVmZHFISE94NzhjRDFGT3BCT1ZNRzBpSXNNSk1PNVhONlZL?= =?iso-2022-jp?B?Q1lmcU9YLzIxVHA1M0dON0M3MkxXd2g5Qk1iWUFJNEROa1lKeEpCSXRq?= =?iso-2022-jp?B?Q21kazhRN0RrRTMrZG5zU3dIZ1h0Sjk0YUZEc3JOcWZKWUNhalhLa0Ny?= =?iso-2022-jp?B?cnhnN09KWDh3NjV1Wm1QeS9EVlo2ZDNnU3Qya01sM0dJZnhsOVVVdXNm?= =?iso-2022-jp?B?Y2JJZlZjTHFHMzdPZS90UC8xUmppdHdMTHRsVFNVcHRTSDdpS2RIWVdo?= =?iso-2022-jp?B?QnRhYXVPVGJna1RrSFZsdFZNZWNrMkJLMHdRUkVUUmV5Zzh3WFlFR1Ay?= =?iso-2022-jp?B?WGtld280eEl6VnRYeGdPajZvS2d5djJCNUZKcnNXdVB2VW1yZ2ZCeG9V?= =?iso-2022-jp?B?eGFmLzZYbW1nU1ZXL1BwdlZrblB6eHhJYVJ3NUVmSlNCY0lwVUxnL3lJ?= =?iso-2022-jp?B?NGpNTk1BUForcGUxV21sQlZSRVJEZnh4KzRhUUVjY0VKYmM3TmFKZ0pp?= =?iso-2022-jp?B?UElaZzdIblAvUG1xR0hubTljVEVCVkU4UmhDZmw1ejdVcG5vaU04cjNj?= =?iso-2022-jp?B?VXhUMzh0M0EvWVQycEszRE4waHRYWmY4cG00U3lvN2dqT2RlWVQ3TDNJ?= =?iso-2022-jp?B?bS9FSHZVczQwdnNOSXlPYlZzRnBiNXNMWGtqOStiL1crOG5nRk9mNVNG?= =?iso-2022-jp?B?L3F0VUhkTkZYeExnajAxdVBYMTFKNmNvZDRPLzc2OFdPVHp3MkN2amVD?= =?iso-2022-jp?B?MTZKTVdhalpjcmVsMHViVU40K3J1S3Z3d0h3UGxSRWMyNHlDemlBaHRX?= =?iso-2022-jp?B?SFRPd3FRVWtWUWRIeHpJK0RFUm5mZU9XWUE0YTRiNHhVb2dsMVBLazNq?= =?iso-2022-jp?B?OHFDUktSQ2d6Rk8vanV5aU1oUFhhSTlUaUMzN3BocG9FTXdNOTFqaFAx?= =?iso-2022-jp?B?QVN1WjRLUm16bHp3YzByNStyZnV4bU1OOXVPT3Fva0xRbk04eG8zRjAv?= =?iso-2022-jp?B?WU9zQkdmOGkxODE3Y2g1UmRSejRUcTRCQ09FcEpITFo5NkZpMDRLNGNy?= =?iso-2022-jp?B?MUYvV1lieWwxU3Y5bTdJTXdDVUFLSGF4Yz0=?= Content-Type: multipart/alternative; boundary="_000_MW5PR11MB59083A384A30EA63968D7A41A9AFAMW5PR11MB5908namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfd53a57-3292-4b53-14ac-08dbe1202a8f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2023 12:34:07.1815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n3cUZ/Ips9xhNlwaF3R7rPu/EtOuZhZVaReJReVbsgvYpOwtPIsf9+fG83GZn3iQBc+Ip76B/8NOpgmMhMygBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6532 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_MW5PR11MB59083A384A30EA63968D7A41A9AFAMW5PR11MB5908namp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Committed, thanks Juzhe. Pan From: juzhe.zhong@rivai.ai Sent: Thursday, November 9, 2023 2:54 PM To: Li, Pan2 ; gcc-patches Cc: Li, Pan2 ; Wang, Yanzhang ;= kito.cheng Subject: Re: [PATCH v1] RISC-V: Refine frm emit after bb end in succ edges OK=1B$B!#=1B(B ________________________________ juzhe.zhong@rivai.ai From: pan2.li Date: 2023-11-09 14:50 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v1] RISC-V: Refine frm emit after bb end in succ edges From: Pan Li > This patch would like to fine the frm insn emit when we meet abnormal edge in the loop. Conceptually, we only need to emit once when abnormal instead of every iteration in the loop. This patch would like to fix this defect and only perform insert_insn_end_basic_block when at least one succ edge is abnormal. gcc/ChangeLog: * config/riscv/riscv.cc (riscv_frm_emit_after_bb_end): Only perform once emit when at least one succ edge is abnormal. Signed-off-by: Pan Li > --- gcc/config/riscv/riscv.cc | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 08ff05dcc3f..e25692b86fc 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -9348,20 +9348,33 @@ static void riscv_frm_emit_after_bb_end (rtx_insn *cur_insn) { edge eg; + bool abnormal_edge_p =3D false; edge_iterator eg_iterator; basic_block bb =3D BLOCK_FOR_INSN (cur_insn); FOR_EACH_EDGE (eg, eg_iterator, bb->succs) + { + if (eg->flags & EDGE_ABNORMAL) + abnormal_edge_p =3D true; + else + { + start_sequence (); + emit_insn (gen_frrmsi (DYNAMIC_FRM_RTL (cfun))); + rtx_insn *backup_insn =3D get_insns (); + end_sequence (); + + insert_insn_on_edge (backup_insn, eg); + } + } + + if (abnormal_edge_p) { start_sequence (); emit_insn (gen_frrmsi (DYNAMIC_FRM_RTL (cfun))); rtx_insn *backup_insn =3D get_insns (); end_sequence (); - if (eg->flags & EDGE_ABNORMAL) - insert_insn_end_basic_block (backup_insn, bb); - else - insert_insn_on_edge (backup_insn, eg); + insert_insn_end_basic_block (backup_insn, bb); } commit_edge_insertions (); -- 2.34.1 --_000_MW5PR11MB59083A384A30EA63968D7A41A9AFAMW5PR11MB5908namp_--