From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id AABF23858D20 for ; Tue, 18 Jul 2023 03:04:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AABF23858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689649482; x=1721185482; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=GZMwApVV0+I1MmDdN2ryGfikgytyPfrQCskhSPsRJ5I=; b=nT2d7xTfEIdRbDs8woyIx6I30yJ37mO10JxNHg7zLuKC6W3OEMDbAZK3 qjA7Vl4LhvMq5y5hxP+f9RiMdtIbNsRTuyDMIcQBYGOgvXCDriRi5IHLY 9jgcq/3spY5t4pFpxJpeOyxYG1QZjZnTHKmRRdT5HP1Cib1nWL8aE7veS A2JpVY+FR7d+ey3k5PKXDRosHNK0VsMiYCmlnUyr4Jh0uphnSdPqrQD3c AyiYWYjXktUy3wanEXgOiCqVjtoDvtQGe8PuIcBF4yTw87VBskEgt/iQP J0tLG3iQ+rSZv29u2EED8Sxg3RgdMIdNdmP1285zASB2DamgeDSeWm5L3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="350956062" X-IronPort-AV: E=Sophos;i="6.01,213,1684825200"; d="scan'208,217";a="350956062" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 20:04:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="1054119390" X-IronPort-AV: E=Sophos;i="6.01,213,1684825200"; d="scan'208,217";a="1054119390" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 17 Jul 2023 20:04:39 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 20:04:39 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 17 Jul 2023 20:04:39 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 17 Jul 2023 20:04:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FPgzNfOEaFlEQLa91PEdnaOuJFTEq744iRgAFHbt9FlzQWyBF7RFoaTBSQNVezNJg8LnKzXDAJcsjjgYpijFg4IXwD6alPhyNLJ2Sh9qYiDTufW4qSFxI50eakp08S9aDMMvO9BcqXtZ2ZcePgdrz6Ce/VXW2i1Pv+0eFKTxI1haomx2uVSihvkHcUC8ijtOK6HOofATELLnG38C6z96mH0r5JY4RndOzY+y7WITAsSiYcwmvBbS/lwLnqaTsDH45+19HqWUjfjZgFNj7jLsm5jrIwsVvJCa6alSnoIUzkgdrpjn1RGuGTu6zG0RZnm3RgZFzeDim5X2DNbTwHDcGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5CWsnRVVB8VKX3WhApPIUbCuuYk+wWTDGMYCX8w2j1g=; b=Xv3Dyhrv2MGmZhIbVxBqHN36iA5wB9vtJrERZ5OtoSe59cVruGFu03jbdh7y+KDNPz6PQGpk1/qLNy+qcw93X0+pkmJB/XCJwJQhGC1QU+iWn/XXecLLF0OOXRgfJg7R0RxLa4WueRuzjE6dS32nSzabfRxXuNz6BfvR5zKrCXdR9YR+8zS0ExULZj4bsSyq8YwvZmcHV7n3aRhWpkWZ3Tw+Xt95x1Syn5hvPiwPmjnUjWt7R0GaPS45zHfObAfV2rq2UJ+2Srnh40M7HphQua579VilNdm4UuCbeqdJRQ8gxFxsA1g03VVd6Tvwgcye3Yh/VeH/uw7+Hf7cp8IPfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SA0PR11MB4688.namprd11.prod.outlook.com (2603:10b6:806:72::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Tue, 18 Jul 2023 03:04:31 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::21a9:85fa:b8a8:8052]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::21a9:85fa:b8a8:8052%3]) with mapi id 15.20.6588.031; Tue, 18 Jul 2023 03:04:31 +0000 From: "Li, Pan2" To: "juzhe.zhong@rivai.ai" , gcc-patches CC: "Wang, Yanzhang" , kito.cheng Subject: RE: [PATCH v2] RISC-V: Fix RVV frm run test failure on RV32 Thread-Topic: [PATCH v2] RISC-V: Fix RVV frm run test failure on RV32 Thread-Index: AQHZuSKNOXWmVUHsjEuzxB96bPD6K6++1AftgAACycA= Date: Tue, 18 Jul 2023 03:04:31 +0000 Message-ID: References: <20230714132050.2728477-1-pan2.li@intel.com>, <20230718024953.1343484-1-pan2.li@intel.com> <1D785913DF32449D+2023071810532882861938@rivai.ai> In-Reply-To: <1D785913DF32449D+2023071810532882861938@rivai.ai> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SA0PR11MB4688:EE_ x-ms-office365-filtering-correlation-id: 846f61f2-d4f1-4f85-7767-08db873bb504 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5GCa819FF09udvR04kdJx6vbDaHQTxkfUDoDMbC+lf5yEGTfw7Vbkt41VaJi/ekWKhqcGkk0lYy/cokt5gvYCm83kGN/5NymhQsWRiU9QNDG6vhsULSVKZedW8bRB6PqLeYGJvn0UYT0BgsQL3T2lFDNnZRiQ4Vd1SybxLv0Vl2wq8ChkC8xkPYgxyrxX1h2Z6gYqFa7xBixHApDhsII8SyeyH/1y4cRBHRKSINiIeFQ04Y5yBcx7GhR6s9nViN031BNXGvqKHWbUIt5TxL80DRZ0ks9Lvw50YTPIyfRuBFLWABi1c1QOvI5NhPlfu2VgJYTTCpXgZIjVod6IybYHkIzj8HJ5O7qvApUtx3q/8FOUlHKZ5HV+J2yPtgQrwR7u9McHC7FNp6wuM3I38rIUaGW5NvXGpztWYFaHE6iPnVVRbeuYBezwx31ToF5eXiCqeM+C9wAScT653BEPovC3g98mwRc6DKHJASvcGZR7UE3nNIQcFTUMVkuuYqXs2lSX8n5ViF72EM5OsjM4sFaOZYBy8osypVtXT8EXJ/dHd338LCDg3Zoqs+f6ACF2n8p4INx1l/vDwc6ScvVSW0eDdeQOaz69HgcdjDDr/cE6/8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(366004)(346002)(39860400002)(136003)(451199021)(83380400001)(26005)(82960400001)(478600001)(6506007)(53546011)(7696005)(9686003)(55016003)(71200400001)(33656002)(52536014)(4326008)(66556008)(41300700001)(38070700005)(8936002)(66446008)(5660300002)(64756008)(66476007)(76116006)(316002)(38100700002)(66946007)(8676002)(84970400001)(86362001)(2906002)(122000001)(110136005)(186003)(54906003)(559001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9rb06Yf/V9/h3GZf9bRnOoRPD2C/PZ3iB5oUXIEebqzT3P/cLGlE1OOpu0qO?= =?us-ascii?Q?kDr33XibNwNpsHkWnsK2IRDZpO0SKdXXkuY4eTxILib1MZ6Zu2G+6/qupCEw?= =?us-ascii?Q?cnh6TCg5FQxDuMInZjNxPTfOL/0S3eM4h4xDTxCcVi9r7LUEp1CdWikgHpNE?= =?us-ascii?Q?LF9hROPLv1L1A7QLOdeJPfVSK5K5JsRLcA4rOrTNDS3V5C3EcjZVTdXW8VHo?= =?us-ascii?Q?0y52IsqLl9WOi/nnvh/wTzi43R6ZPlZ1PUmxclp8srfkRb6pUjHAVlW7N/tB?= =?us-ascii?Q?w4qPCUyk9ZvRGJhBRnladHRWUiboEZV9EpRSMu8Bc6W7thLe1lUFDv0A22mj?= =?us-ascii?Q?LoNblZFstP52PCdf7RDdhj4TbVO7dX5DAZlEpaXRJVRSQFNRfF9DDuKGWCqe?= =?us-ascii?Q?aYfkA8t3lV/7tTFqv46IS/EFoSVkv085qOWcXavh1q7KhfOIbJt+8krpnKvB?= =?us-ascii?Q?OfnO0TF1oekbYmxksp/NDySsvY0vO6I4ko7db+nx1Un1Bw/u3nzundNOL6M+?= =?us-ascii?Q?PTVteYVXFaQI+lKaD7aQScVG/gNR/b9oEUTjwnZ+sMM3LLmmbHN15qmeelAu?= =?us-ascii?Q?rf0ygLmdi4yu2lgqZYOxy5tFdIwbKrtKkyZyhmP+wc677shYv3ZvWL3oW6SP?= =?us-ascii?Q?2xt3ZxLeNh0uAZIXjHQhx3+L4mQz/pOCKpfoIc7PrONm3LxkCcsQlaoHErUF?= =?us-ascii?Q?DoihypCeKmEx5qAhUysC0Q5F6/NTuEWqumRy2YK6Rrf0CReMqssSQ+JZ5uFv?= =?us-ascii?Q?cdDdJgki+x7N5ntuydMRaCwwt+loDGhnyoy7vaV9iVImLtw2phA7eNFdecj3?= =?us-ascii?Q?cOzdd4rUu1WT6XGYOt7p+TLaumewUShl3hu9qLOsCIpSWX2FMezrGw052Wow?= =?us-ascii?Q?pwgAvApp2Rje4LTZgPGLToS73CL5BmBcG016k4zr7bB7egQN+MHMTCGHhDvS?= =?us-ascii?Q?hs2QDHppRECVQm2MsGjPHYcWM/tD80isEctA+MQl+i19Tm29xtZIuayes+2g?= =?us-ascii?Q?ton3S07Xsb/FenhgnjPz21dISx/o2WykHK08O6ZXLcQz4iSQzvOcTaGEdhJw?= =?us-ascii?Q?lykJey9nNrvBJwHt+cfSUZNqWuvM8/bZp0zIRkKj0tOXVBJvJ9844L7QHWlz?= =?us-ascii?Q?V1y4pDm3FkUXGkYaLuHp9s+G39HRcM6/0EhNI4fPKp+1rrh4VRV+8nqrj4vX?= =?us-ascii?Q?/vcR21Gi+yla3Xtjtr501R9aC5QOXOn1OvsV4ZHNHJLFyxsfUQc6BPoJqdGL?= =?us-ascii?Q?q+GhQt7e7LasFaBQzqbNF+Tf0SYwhu+3UDPgqbaecVAOHo/snpgbE6EXBvXZ?= =?us-ascii?Q?kb0GGDi67ezgNNhhGP0JwC8HwwMiOQoD/xBoaQPUy9vNu7XP67nRn7T7L+nY?= =?us-ascii?Q?SIAcsjY82UJovrJ5P3l/Cm3elkbH5nkNqYVy90GgYZJqDd6qE4ymPeo75jWq?= =?us-ascii?Q?v19wPHFhavueJoSpR0y6x8jSI0/7Vg9vqesIO4QzAEk4xdyS9dBP808Xoe4T?= =?us-ascii?Q?ea51onM4C7BNhNj2fCf2S7f8rmVyvwJoH9TxZ6/k5udm3HdnioGvczE8y7ZM?= =?us-ascii?Q?eccWzy60ltcmeKd4N3E=3D?= Content-Type: multipart/alternative; boundary="_000_MW5PR11MB59083E0160C669B098A30C59A938AMW5PR11MB5908namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 846f61f2-d4f1-4f85-7767-08db873bb504 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2023 03:04:31.2471 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HhQ6FGWqZzC8tpOPSGhJTFGHNVDSq2rLKQ50sgkchlXmpXh1xn7TjzDPKpN6wg6C+NMWeRTo8RTeEqUzATpTvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4688 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_MW5PR11MB59083E0160C669B098A30C59A938AMW5PR11MB5908namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Committed, thanks Juzhe. Pan From: juzhe.zhong@rivai.ai Sent: Tuesday, July 18, 2023 10:53 AM To: Li, Pan2 ; gcc-patches Cc: Li, Pan2 ; Wang, Yanzhang ;= kito.cheng Subject: Re: [PATCH v2] RISC-V: Fix RVV frm run test failure on RV32 LGTM. ________________________________ juzhe.zhong@rivai.ai From: pan2.li Date: 2023-07-18 10:49 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v2] RISC-V: Fix RVV frm run test failure on RV32 From: Pan Li > Refine the run test case to avoid interactive checking in RV32, by separating each checks in different functions. Signed-off-by: Pan Li > gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/float-point-frm-run-1.c: Fix run failure. --- .../riscv/rvv/base/float-point-frm-run-1.c | 59 +++++++++++-------- 1 file changed, 36 insertions(+), 23 deletions(-) diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-run-1.= c b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-run-1.c index 245ce7d1fc0..1b2789a924b 100644 --- a/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-run-1.c +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-run-1.c @@ -5,6 +5,24 @@ #include #include +#define DEFINE_TEST_FUNC(FRM) \ +vfloat32m1_t __attribute__ ((noinline)) \ +test_float_point_frm_run_##FRM (vfloat32m1_t op1, vfloat32m1_t op2, size_t= vl) \ +{ = \ + vfloat32m1_t result; = \ + = \ + set_frm (0); = \ + = \ + result =3D __riscv_vfadd_vv_f32m1_rm (op1, result, FRM, vl); = \ + = \ + assert_equal (FRM, get_frm (), "The value of frm should be " #FRM "."); = \ + = \ + return result; = \ +} + +#define RUN_TEST_FUNC(FRM, op1, op2, vl) \ + test_float_point_frm_run_##FRM (op1, op2, vl) + static int get_frm () { @@ -41,28 +59,11 @@ assert_equal (int a, int b, char *message) } } -vfloat32m1_t __attribute__ ((noinline)) -test_float_point_frm_run (vfloat32m1_t op1, vfloat32m1_t op2, size_t vl) -{ - vfloat32m1_t result; - - result =3D __riscv_vfadd_vv_f32m1_rm (op1, result, 1, vl); - assert_equal (1, get_frm (), "The value of frm register should be 1."); - - result =3D __riscv_vfadd_vv_f32m1_rm (op1, result, 2, vl); - assert_equal (2, get_frm (), "The value of frm register should be 2."); - - result =3D __riscv_vfadd_vv_f32m1_rm (op1, result, 3, vl); - assert_equal (3, get_frm (), "The value of frm register should be 3."); - - result =3D __riscv_vfadd_vv_f32m1_rm (op1, result, 4, vl); - assert_equal (4, get_frm (), "The value of frm register should be 4."); - - result =3D __riscv_vfadd_vv_f32m1_rm (op1, result, 0, vl); - assert_equal (0, get_frm (), "The value of frm register should be 0."); - - return result; -} +DEFINE_TEST_FUNC (0) +DEFINE_TEST_FUNC (1) +DEFINE_TEST_FUNC (2) +DEFINE_TEST_FUNC (3) +DEFINE_TEST_FUNC (4) int main () @@ -72,8 +73,20 @@ main () vfloat32m1_t op2; set_frm (4); - test_float_point_frm_run (op1, op2, vl); + RUN_TEST_FUNC (0, op1, op2, vl); + assert_equal (4, get_frm (), "The value of frm register should be 4."); + + RUN_TEST_FUNC (1, op1, op2, vl); + assert_equal (4, get_frm (), "The value of frm register should be 4."); + + RUN_TEST_FUNC (2, op1, op2, vl); + assert_equal (4, get_frm (), "The value of frm register should be 4."); + + RUN_TEST_FUNC (3, op1, op2, vl); + assert_equal (4, get_frm (), "The value of frm register should be 4."); + + RUN_TEST_FUNC (4, op1, op2, vl); assert_equal (4, get_frm (), "The value of frm register should be 4."); return 0; -- 2.34.1 --_000_MW5PR11MB59083E0160C669B098A30C59A938AMW5PR11MB5908namp_--