From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 25EF43858D37 for ; Thu, 25 May 2023 14:55:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25EF43858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685026554; x=1716562554; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=usFlKhBCyfZd+8s9qIN5J3Zi/yxj5l+Im9rNgJmEEh0=; b=YNDIEgrXw1J94vYiMnE05mS/OT9pxXRhc/9slS7IxWqJHWM0QtHRrgEU 9e786VfjkZDM0JYEX2qiAkzk6kq/eb17OP1bt6248+R36t8KUbnIph1h3 o/QIOooagh599xPm/Ps5UNdUu1bgI3+ZJ4o6KpwKcMH7/TqZTUJQlHgqm KVCkaHYMWUkr0pQ31h5OXEHqMSA1/IHs7mTffRv2S3dimzWJ3qTmzejk5 sluYQYejRtuljcSsccUxfjU9YLEe+7PekEaVOwkiSXv1yD5MCoyz+CvTK 1V9udH23vNHYb4/qtvH6PeNTi4C6MzUaIJifnGW3SIsbl0gvdXKRGHzgQ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="419648296" X-IronPort-AV: E=Sophos;i="6.00,191,1681196400"; d="scan'208";a="419648296" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2023 07:49:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="699005007" X-IronPort-AV: E=Sophos;i="6.00,191,1681196400"; d="scan'208";a="699005007" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 25 May 2023 07:49:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 07:49:50 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 07:49:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 25 May 2023 07:49:50 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 25 May 2023 07:49:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dDhqCm6CUrLn22pfxZjAUhFL+OzQWKM6HTvFBisXRdiONiM8JrQ0HVveSllGn+lKtRfgLwoEDw/WkkkT2xXXnb2GyLaIt/qsBkGx4OFyk1dGKThdgRxA0KlTCsubKSEZa/Pur5hcxV00Ri+J4sFE+gPwm3OdyzbQmwa9KjRDOH1qh3cfAYc0+nzvDZzKtcZyLnt9ygger89T9yGSRdXkB8npZdIASSifzPPUd41TMpFpDUDxUNGg1mHhzdLcIy0xNm8Y1yC17sae0FLYiyCopx0eRhakS3MFlPZAJ34tnaCGtlQlmBEjJagCA/noenG/EHImno2gGEgpFWw7d8cMYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=963nyUm7tHwDP1jaFIHUVV80vj8bLUhZyBbLqEcRy9U=; b=n37PSLfPUd8c/xjWNyz854mGGGLpk8z+3Qj4PxzqcppFyM9j6ivj4oC9RekVwDPsZU5YE1Iii8H3WAeozO/N0PQwaQbKAWNwEwdJAxYJHRd/6DER5VFUboKvvckLMFz/BVYEbiDLLzt0IzYhxBSd9Al/fIUoDoX3gUQBP6zobzBNNgwacelInsi/NEgUmJ54xHwb1NeZ9M3Qm/vhT9iPeu8gWQARp81FB18J4y2bA844fCB/ibOy2glxMAnLw/TkBAZgjwdyqmObLMzUF5f+wXToylpFao/JAAwYx/GzjnYJ3ojy0gBKYT1xig/Pfmo44rOLvrs0m7O0yovliXddMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by PH0PR11MB5578.namprd11.prod.outlook.com (2603:10b6:510:e7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16; Thu, 25 May 2023 14:49:48 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9%3]) with mapi id 15.20.6411.028; Thu, 25 May 2023 14:49:47 +0000 From: "Li, Pan2" To: Richard Biener , Richard Sandiford CC: "juzhe.zhong@rivai.ai" , "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH V16] VECT: Add decrement IV iteration loop control by variable amount support Thread-Topic: [PATCH V16] VECT: Add decrement IV iteration loop control by variable amount support Thread-Index: AQHZjwFkEdgKrEccBkWMtd/3jQCYfa9q7VlkgAAIDYCAABzR0A== Date: Thu, 25 May 2023 14:49:47 +0000 Message-ID: References: <20230525120550.6275-1-juzhe.zhong@rivai.ai> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|PH0PR11MB5578:EE_ x-ms-office365-filtering-correlation-id: dfa61f92-7a72-4a56-5adc-08db5d2f496c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xAantSJMsR+qne/KhUV/7oGBWI6BKjCBXyTJynsgIUpBk9ueD91cJjPuibP6PDtacy02cJRb3TH1Y4Aj5cP3Sps84ktEZSoIgb7r38QmcWLdsVeFQTGQLGOIAenxPL55LDTBoGafUuKUZBk+bRyh0iN11LUhALmjWWteeMAgBVI+5qzyxv/u9ruw0rVE4zyubMHkyJiXqqgItDZm3RQ8XWzJ9HrYj8Sj+HcIklXUFLNETmtQsPO545XStFqybEBqIgKxA+roFL761MGSRmDJxKzy5qtiDVYeR556cxdfOLLlkZwqti8Shai7JTgXoV9c9IIh4yO7Ytq/sRI4kaYK6ofeBhdvWumsxXtEQMO1wu0fwqBifWUbrMiTqlS1NcL21f7coW5jco4ps6Fr24WWjXRCHob30HHYY3KwOGx9bFEB2LnFymTOBcGhAIs5+LpaBjxESNW5rd8ezdnl7BSSinuZGSkSiRRxye8WDvFDAqQDSTPi6LpHq/2HprjM+eiBaDYsKOtHVCruHtjDA5LiTOGyLy5KsyJeUsoBgXyULXuZQ/Ak/0zPgo0/YWiUCo7JiPq0P+sPIOCG7pm1kTpVUN4F1epL8jd/bvajPzCZxvhxjXNvE5mrez8QPaDuapoO x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(136003)(396003)(39860400002)(376002)(451199021)(71200400001)(7696005)(41300700001)(53546011)(26005)(6506007)(8936002)(8676002)(38100700002)(52536014)(9686003)(5660300002)(83380400001)(2906002)(38070700005)(186003)(33656002)(86362001)(55016003)(122000001)(82960400001)(66476007)(66446008)(4326008)(64756008)(76116006)(66946007)(66556008)(54906003)(478600001)(110136005)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uOVveHDvjkZN2sI4y0ya6tzGTbwNVXtGBTRYpjLbQldR0wng4IrikIbCDRQM?= =?us-ascii?Q?2kJ82/mZNx/3PdWsH4uGoLZkGVeA43EQ8SzuOs9sev9tlqHucfCiBymDyhZV?= =?us-ascii?Q?W53oTSYGAL80AEzl+O2WPRqxkbbN4u2N06zeIwxznQGSLGfGyd/9X19z1i6m?= =?us-ascii?Q?MJ4Mj1cgzqMwPG8gSvuXgoPQlQpC4bEIuvFuU6JryYz6YjifDj9eLI2wK+vi?= =?us-ascii?Q?KoJsYibrySuvW2Fw/2PHhCkWULlUJ2ITgArGHqD03CMdNSeoZJkecv4dcGX3?= =?us-ascii?Q?IfiMcrUxowBT37rgVMjylyAzaTlue79LkdBQNdTZJwqW46ezGRUZwto0XitK?= =?us-ascii?Q?werWjTJ+ClSVW/3XNcbghP+gZO/Qz2fvBcBBG+xZE7J5nB2p7/4q7rlmCrvS?= =?us-ascii?Q?htoXwJ6NqMVx1XNCegzEnOesUA1UA1HZ6E0rouM7YJZTUjh7xnl6YAw5ZJ4X?= =?us-ascii?Q?R8+ETdGo7ku43g+u3uMgEqwIvVdi4HBqyDDuuvZRdclTUDDI78r1TqsdrNpF?= =?us-ascii?Q?S/z/+Lh8zfRDnI+QL9WM5zCS4olazlJAh8unvkFm3NRaz71CNAZ6CA3fMroQ?= =?us-ascii?Q?7gNMgggKbInbrFpnAbv9LyRUiyDv0C5ECOMPd5XAeiEY3lMZo9V+HAVV17Gx?= =?us-ascii?Q?alibE8GSyizUb/lWImHlbEwlYIBuSENq5FsZ8LBgJEhBVtqsN5ox8AkIzYP0?= =?us-ascii?Q?8JvQbzNRpLt8Vnzbo5MNr18CJrT2bMjIos8wae5dExv/6/xPsIT67kaFPkuM?= =?us-ascii?Q?s4rw+31fA06a38s765+yF7IzI9PCOT+D8PuNgyGhC2oo63r/085APNar8qb8?= =?us-ascii?Q?X0KucSOQTJByYgREaPTJEAGFCJ3VTwo84w5NFEKmsMQTsCASvjdjNNThIOUB?= =?us-ascii?Q?2hvWtJH+UMC8FL893sllLHXPt+FzWVm6362M0lZMsWVAxFUVMOAYD5j3i2Pz?= =?us-ascii?Q?VHLlgp3LPEqiFW5rL1jLWqcfHFtQhFpCEDTVj1uCKRo2BSvx3lhQu/mkttW2?= =?us-ascii?Q?vE1e6hPAa5slYvZCblvjhZg1i+K98Bv4Pi3go0Cij8pUf9LRfE+XQYlgcUVR?= =?us-ascii?Q?HLLclj/n/QBr0/OQzg+9ek3YurgacH4rKOtMPdztzDhv8vvtHw0nt9kQiRqn?= =?us-ascii?Q?0GO9EQqkWkRSMI7pY8Z9p/gjt+2Q0J2mTgHO3qI2CM9Qrb0gqkSFLEI0Soag?= =?us-ascii?Q?6lOMatMaAabbfkyWq0GFAuAiVqGR+XONbQjIbyDAd23Q7aLF6xudWDwpIS44?= =?us-ascii?Q?u3jHnqTWti68IkN3FtHYDM0QzTPFEysf3w7EyX40aMQ6WDDZJ2lZFO+us2WY?= =?us-ascii?Q?ssf6jVQ3QM+NRq/8cVpAjHoqPgqi/WsNgzUB27b7pTXVlMFmRQtqneBwFeRb?= =?us-ascii?Q?f5H5v5wZqnc0Aw7Q9A34htndFm3rHakdPKCMc+IsK3aC/sk77ORmQ20pT1qg?= =?us-ascii?Q?OlRW0qluiN0MYlMMCMA9AZ0rVU1Hy55BnMFip16b+B0SUu1GUc3E9rQtZbJH?= =?us-ascii?Q?5gu1bGUOWOYzDOajO+WrP9rHjulOpds1Xt3g29M+f3CiklHn6wmhkAa+jvXg?= =?us-ascii?Q?bxbf5ftA99t9x8dRvKA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfa61f92-7a72-4a56-5adc-08db5d2f496c X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2023 14:49:47.9556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Awi4w7dW5+56Jg0N3TsE6JO3EQltig8Z9M9M+Kkuo9mOcXPSgQ7p/oas3DIpavitTAnoHL9FgBOnI22AE81BsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5578 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed, thanks Richard. Pan -----Original Message----- From: Gcc-patches On = Behalf Of Richard Biener via Gcc-patches Sent: Thursday, May 25, 2023 9:06 PM To: Richard Sandiford Cc: juzhe.zhong@rivai.ai; gcc-patches@gcc.gnu.org Subject: Re: [PATCH V16] VECT: Add decrement IV iteration loop control by v= ariable amount support On Thu, 25 May 2023, Richard Sandiford wrote: > This looks good to me. Just a couple of very minor cosmetic things: >=20 > juzhe.zhong@rivai.ai writes: > > @@ -753,17 +846,35 @@ vect_set_loop_condition_partial_vectors (class lo= op *loop, > > continue; > > } > > =20 > > - /* See whether zero-based IV would ever generate all-false masks > > - or zero length before wrapping around. */ > > - bool might_wrap_p =3D vect_rgroup_iv_might_wrap_p (loop_vinfo, rgc); > > - > > - /* Set up all controls for this group. */ > > - test_ctrl =3D vect_set_loop_controls_directly (loop, loop_vinfo, > > - &preheader_seq, > > - &header_seq, > > - loop_cond_gsi, rgc, > > - niters, niters_skip, > > - might_wrap_p); > > + if (!LOOP_VINFO_USING_DECREMENTING_IV_P (loop_vinfo) || !iv_rgc > > + || (iv_rgc->max_nscalars_per_iter * iv_rgc->factor > > + !=3D rgc->max_nscalars_per_iter * rgc->factor)) >=20 > Coding style is to put each subcondition on a separate line when the=20 > whole condition doesn't fit on a single line. So: >=20 > if (!LOOP_VINFO_USING_DECREMENTING_IV_P (loop_vinfo) > || !iv_rgc > || (iv_rgc->max_nscalars_per_iter * iv_rgc->factor > !=3D rgc->max_nscalars_per_iter * rgc->factor)) >=20 > > @@ -2725,6 +2726,17 @@ start_over: > > && !vect_verify_loop_lens (loop_vinfo)) > > LOOP_VINFO_CAN_USE_PARTIAL_VECTORS_P (loop_vinfo) =3D false; > > =20 > > + /* If we're vectorizing an loop that uses length "controls" and >=20 > s/an loop/a loop/ (Sorry for not noticing earlier.) >=20 > OK for trunk from my POV with those changes; no need to repost unless=20 > your policies require it. Please give Richi a chance to comment too=20 > though. LGTM as well. Thanks, Richard.