public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH v1] RISC-V: Update comments for FP rounding related autovec
@ 2023-10-06  2:38 pan2.li
  2023-10-06  3:09 ` Kito Cheng
  0 siblings, 1 reply; 3+ messages in thread
From: pan2.li @ 2023-10-06  2:38 UTC (permalink / raw)
  To: gcc-patches; +Cc: juzhe.zhong, pan2.li, yanzhang.wang, kito.cheng

From: Pan Li <pan2.li@intel.com>

Some comment is out of date, this patch would like to fix it.

gcc/ChangeLog:

	* config/riscv/autovec.md: Update comments.

Signed-off-by: Pan Li <pan2.li@intel.com>
---
 gcc/config/riscv/autovec.md | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index 056f2c352f6..53e9d34eea1 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -2229,12 +2229,16 @@ (define_expand "<u>avg<v_double_trunc>3_ceil"
 })
 
 ;; -------------------------------------------------------------------------
-;; ---- [FP] Math.h.
+;; ---- [FP] Rounding.
 ;; -------------------------------------------------------------------------
 ;; Includes:
 ;; - ceil/ceilf
 ;; - floor/floorf
 ;; - nearbyint/nearbyintf
+;; - rint/rintf
+;; - round/roundf
+;; - trunc/truncf
+;; - roundeven/roundevenf
 ;; -------------------------------------------------------------------------
 (define_expand "ceil<mode>2"
   [(match_operand:V_VLSF 0 "register_operand")
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] RISC-V: Update comments for FP rounding related autovec
  2023-10-06  2:38 [PATCH v1] RISC-V: Update comments for FP rounding related autovec pan2.li
@ 2023-10-06  3:09 ` Kito Cheng
  2023-10-06  3:13   ` Li, Pan2
  0 siblings, 1 reply; 3+ messages in thread
From: Kito Cheng @ 2023-10-06  3:09 UTC (permalink / raw)
  To: Li, Pan2; +Cc: GCC Patches, 钟居哲, yanzhang.wang

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

LGTM

<pan2.li@intel.com> 於 2023年10月6日 週五 10:39 寫道:

> From: Pan Li <pan2.li@intel.com>
>
> Some comment is out of date, this patch would like to fix it.
>
> gcc/ChangeLog:
>
>         * config/riscv/autovec.md: Update comments.
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
> ---
>  gcc/config/riscv/autovec.md | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
> index 056f2c352f6..53e9d34eea1 100644
> --- a/gcc/config/riscv/autovec.md
> +++ b/gcc/config/riscv/autovec.md
> @@ -2229,12 +2229,16 @@ (define_expand "<u>avg<v_double_trunc>3_ceil"
>  })
>
>  ;;
> -------------------------------------------------------------------------
> -;; ---- [FP] Math.h.
> +;; ---- [FP] Rounding.
>  ;;
> -------------------------------------------------------------------------
>  ;; Includes:
>  ;; - ceil/ceilf
>  ;; - floor/floorf
>  ;; - nearbyint/nearbyintf
> +;; - rint/rintf
> +;; - round/roundf
> +;; - trunc/truncf
> +;; - roundeven/roundevenf
>  ;;
> -------------------------------------------------------------------------
>  (define_expand "ceil<mode>2"
>    [(match_operand:V_VLSF 0 "register_operand")
> --
> 2.34.1
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH v1] RISC-V: Update comments for FP rounding related autovec
  2023-10-06  3:09 ` Kito Cheng
@ 2023-10-06  3:13   ` Li, Pan2
  0 siblings, 0 replies; 3+ messages in thread
From: Li, Pan2 @ 2023-10-06  3:13 UTC (permalink / raw)
  To: Kito Cheng; +Cc: GCC Patches, 钟居哲, Wang, Yanzhang

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

Committed, thanks Kito.

Pan

From: Kito Cheng <kito.cheng@gmail.com>
Sent: Friday, October 6, 2023 11:09 AM
To: Li, Pan2 <pan2.li@intel.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>; 钟居哲 <juzhe.zhong@rivai.ai>; Wang, Yanzhang <yanzhang.wang@intel.com>
Subject: Re: [PATCH v1] RISC-V: Update comments for FP rounding related autovec

LGTM

<pan2.li@intel.com<mailto:pan2.li@intel.com>> 於 2023年10月6日 週五 10:39 寫道:
From: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>

Some comment is out of date, this patch would like to fix it.

gcc/ChangeLog:

        * config/riscv/autovec.md: Update comments.

Signed-off-by: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>
---
 gcc/config/riscv/autovec.md | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index 056f2c352f6..53e9d34eea1 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -2229,12 +2229,16 @@ (define_expand "<u>avg<v_double_trunc>3_ceil"
 })

 ;; -------------------------------------------------------------------------
-;; ---- [FP] Math.h.
+;; ---- [FP] Rounding.
 ;; -------------------------------------------------------------------------
 ;; Includes:
 ;; - ceil/ceilf
 ;; - floor/floorf
 ;; - nearbyint/nearbyintf
+;; - rint/rintf
+;; - round/roundf
+;; - trunc/truncf
+;; - roundeven/roundevenf
 ;; -------------------------------------------------------------------------
 (define_expand "ceil<mode>2"
   [(match_operand:V_VLSF 0 "register_operand")
--
2.34.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-06  3:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-06  2:38 [PATCH v1] RISC-V: Update comments for FP rounding related autovec pan2.li
2023-10-06  3:09 ` Kito Cheng
2023-10-06  3:13   ` Li, Pan2

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).