* [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment
@ 2023-08-24 7:37 pan2.li
2023-08-24 7:43 ` Kito Cheng
2023-08-24 8:14 ` [PATCH v2] " pan2.li
0 siblings, 2 replies; 6+ messages in thread
From: pan2.li @ 2023-08-24 7:37 UTC (permalink / raw)
To: gcc-patches; +Cc: juzhe.zhong, pan2.li, yanzhang.wang, kito.cheng
From: Pan Li <pan2.li@intel.com>
Fix below typo for the pattern comment.
vfmsac => vfnmsac
vfmsub => vfnmsub
Signed-off-by: Pan Li <pan2.li@intel.com>
gcc/ChangeLog:
* config/riscv/autovec.md: Fix typo.
---
gcc/config/riscv/autovec.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index d9f1a10eb66..18950ac7c4f 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -1258,11 +1258,11 @@ (define_insn_and_split "*fms<VF:mode><P:mode>"
(set (attr "frm_mode") (symbol_ref "riscv_vector::FRM_DYN"))])
;; -------------------------------------------------------------------------
-;; ---- [FP] VFMSAC and VFMSUB
+;; ---- [FP] VFNMSAC and VFNMSUB
;; -------------------------------------------------------------------------
;; Includes:
-;; - vfmsac
-;; - vfmsub
+;; - vfnmsac
+;; - vfnmsub
;; -------------------------------------------------------------------------
(define_expand "fnms<mode>4"
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment
2023-08-24 7:37 [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment pan2.li
@ 2023-08-24 7:43 ` Kito Cheng
2023-08-24 7:53 ` Li, Pan2
2023-08-24 8:14 ` [PATCH v2] " pan2.li
1 sibling, 1 reply; 6+ messages in thread
From: Kito Cheng @ 2023-08-24 7:43 UTC (permalink / raw)
To: Li, Pan2; +Cc: GCC Patches, 钟居哲, yanzhang.wang
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
LGTM
Pan Li via Gcc-patches <gcc-patches@gcc.gnu.org> 於 2023年8月24日 週四 15:41 寫道：
> From: Pan Li <pan2.li@intel.com>
>
> Fix below typo for the pattern comment.
>
> vfmsac => vfnmsac
> vfmsub => vfnmsub
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
> * config/riscv/autovec.md: Fix typo.
> ---
> gcc/config/riscv/autovec.md | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
> index d9f1a10eb66..18950ac7c4f 100644
> --- a/gcc/config/riscv/autovec.md
> +++ b/gcc/config/riscv/autovec.md
> @@ -1258,11 +1258,11 @@ (define_insn_and_split "*fms<VF:mode><P:mode>"
> (set (attr "frm_mode") (symbol_ref "riscv_vector::FRM_DYN"))])
>
> ;;
> -------------------------------------------------------------------------
> -;; ---- [FP] VFMSAC and VFMSUB
> +;; ---- [FP] VFNMSAC and VFNMSUB
> ;;
> -------------------------------------------------------------------------
> ;; Includes:
> -;; - vfmsac
> -;; - vfmsub
> +;; - vfnmsac
> +;; - vfnmsub
> ;;
> -------------------------------------------------------------------------
>
> (define_expand "fnms<mode>4"
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment
2023-08-24 7:43 ` Kito Cheng
@ 2023-08-24 7:53 ` Li, Pan2
0 siblings, 0 replies; 6+ messages in thread
From: Li, Pan2 @ 2023-08-24 7:53 UTC (permalink / raw)
To: Kito Cheng; +Cc: GCC Patches, 钟居哲, Wang, Yanzhang
[-- Attachment #1: Type: text/plain, Size: 1659 bytes --]
Thanks Kito. Looks need some additional change and will send the V2 for this.
Pan
From: Kito Cheng <kito.cheng@gmail.com>
Sent: Thursday, August 24, 2023 3:44 PM
To: Li, Pan2 <pan2.li@intel.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>; 钟居哲 <juzhe.zhong@rivai.ai>; Wang, Yanzhang <yanzhang.wang@intel.com>
Subject: Re: [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment
LGTM
Pan Li via Gcc-patches <gcc-patches@gcc.gnu.org<mailto:gcc-patches@gcc.gnu.org>> 於 2023年8月24日 週四 15:41 寫道：
From: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>
Fix below typo for the pattern comment.
vfmsac => vfnmsac
vfmsub => vfnmsub
Signed-off-by: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>
gcc/ChangeLog:
* config/riscv/autovec.md: Fix typo.
---
gcc/config/riscv/autovec.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index d9f1a10eb66..18950ac7c4f 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -1258,11 +1258,11 @@ (define_insn_and_split "*fms<VF:mode><P:mode>"
(set (attr "frm_mode") (symbol_ref "riscv_vector::FRM_DYN"))])
;; -------------------------------------------------------------------------
-;; ---- [FP] VFMSAC and VFMSUB
+;; ---- [FP] VFNMSAC and VFNMSUB
;; -------------------------------------------------------------------------
;; Includes:
-;; - vfmsac
-;; - vfmsub
+;; - vfnmsac
+;; - vfnmsub
;; -------------------------------------------------------------------------
(define_expand "fnms<mode>4"
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] RISC-V: Fix one typo in autovec.md pattern comment
2023-08-24 7:37 [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment pan2.li
2023-08-24 7:43 ` Kito Cheng
@ 2023-08-24 8:14 ` pan2.li
2023-08-24 8:37 ` 钟居哲
1 sibling, 1 reply; 6+ messages in thread
From: pan2.li @ 2023-08-24 8:14 UTC (permalink / raw)
To: gcc-patches; +Cc: juzhe.zhong, pan2.li, yanzhang.wang, kito.cheng
From: Pan Li <pan2.li@intel.com>
vfmsac => vfnmacc
vfmsub => vfnmadd
Signed-off-by: Pan Li <pan2.li@intel.com>
gcc/ChangeLog:
* config/riscv/autovec.md: Fix typo.
---
gcc/config/riscv/autovec.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index e1addc07036..e9659b2b157 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -1253,11 +1253,11 @@ (define_insn_and_split "*fms<VF:mode><P:mode>"
(set_attr "mode" "<VF:MODE>")])
;; -------------------------------------------------------------------------
-;; ---- [FP] VFMSAC and VFMSUB
+;; ---- [FP] VFNMACC and VFNMADD
;; -------------------------------------------------------------------------
;; Includes:
-;; - vfmsac
-;; - vfmsub
+;; - vfnmacc
+;; - vfnmadd
;; -------------------------------------------------------------------------
(define_expand "fnms<mode>4"
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] RISC-V: Fix one typo in autovec.md pattern comment
2023-08-24 8:14 ` [PATCH v2] " pan2.li
@ 2023-08-24 8:37 ` 钟居哲
2023-08-24 8:40 ` Li, Pan2
0 siblings, 1 reply; 6+ messages in thread
From: 钟居哲 @ 2023-08-24 8:37 UTC (permalink / raw)
To: pan2.li, gcc-patches; +Cc: pan2.li, yanzhang.wang, kito.cheng
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
LGTM
juzhe.zhong@rivai.ai
From: pan2.li
Date: 2023-08-24 16:14
To: gcc-patches
CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng
Subject: [PATCH v2] RISC-V: Fix one typo in autovec.md pattern comment
From: Pan Li <pan2.li@intel.com>
vfmsac => vfnmacc
vfmsub => vfnmadd
Signed-off-by: Pan Li <pan2.li@intel.com>
gcc/ChangeLog:
* config/riscv/autovec.md: Fix typo.
---
gcc/config/riscv/autovec.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index e1addc07036..e9659b2b157 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -1253,11 +1253,11 @@ (define_insn_and_split "*fms<VF:mode><P:mode>"
(set_attr "mode" "<VF:MODE>")])
;; -------------------------------------------------------------------------
-;; ---- [FP] VFMSAC and VFMSUB
+;; ---- [FP] VFNMACC and VFNMADD
;; -------------------------------------------------------------------------
;; Includes:
-;; - vfmsac
-;; - vfmsub
+;; - vfnmacc
+;; - vfnmadd
;; -------------------------------------------------------------------------
(define_expand "fnms<mode>4"
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] RISC-V: Fix one typo in autovec.md pattern comment
2023-08-24 8:37 ` 钟居哲
@ 2023-08-24 8:40 ` Li, Pan2
0 siblings, 0 replies; 6+ messages in thread
From: Li, Pan2 @ 2023-08-24 8:40 UTC (permalink / raw)
To: 钟居哲, gcc-patches; +Cc: Wang, Yanzhang, kito.cheng
[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]
Committed, thanks Juzhe.
Pan
From: 钟居哲 <juzhe.zhong@rivai.ai>
Sent: Thursday, August 24, 2023 4:37 PM
To: Li, Pan2 <pan2.li@intel.com>; gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Li, Pan2 <pan2.li@intel.com>; Wang, Yanzhang <yanzhang.wang@intel.com>; kito.cheng <kito.cheng@gmail.com>
Subject: Re: [PATCH v2] RISC-V: Fix one typo in autovec.md pattern comment
LGTM
________________________________
juzhe.zhong@rivai.ai<mailto:juzhe.zhong@rivai.ai>
From: pan2.li<mailto:pan2.li@intel.com>
Date: 2023-08-24 16:14
To: gcc-patches<mailto:gcc-patches@gcc.gnu.org>
CC: juzhe.zhong<mailto:juzhe.zhong@rivai.ai>; pan2.li<mailto:pan2.li@intel.com>; yanzhang.wang<mailto:yanzhang.wang@intel.com>; kito.cheng<mailto:kito.cheng@gmail.com>
Subject: [PATCH v2] RISC-V: Fix one typo in autovec.md pattern comment
From: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>
vfmsac => vfnmacc
vfmsub => vfnmadd
Signed-off-by: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>
gcc/ChangeLog:
* config/riscv/autovec.md: Fix typo.
---
gcc/config/riscv/autovec.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/config/riscv/autovec.md b/gcc/config/riscv/autovec.md
index e1addc07036..e9659b2b157 100644
--- a/gcc/config/riscv/autovec.md
+++ b/gcc/config/riscv/autovec.md
@@ -1253,11 +1253,11 @@ (define_insn_and_split "*fms<VF:mode><P:mode>"
(set_attr "mode" "<VF:MODE>")])
;; -------------------------------------------------------------------------
-;; ---- [FP] VFMSAC and VFMSUB
+;; ---- [FP] VFNMACC and VFNMADD
;; -------------------------------------------------------------------------
;; Includes:
-;; - vfmsac
-;; - vfmsub
+;; - vfnmacc
+;; - vfnmadd
;; -------------------------------------------------------------------------
(define_expand "fnms<mode>4"
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-24 8:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-24 7:37 [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment pan2.li
2023-08-24 7:43 ` Kito Cheng
2023-08-24 7:53 ` Li, Pan2
2023-08-24 8:14 ` [PATCH v2] " pan2.li
2023-08-24 8:37 ` 钟居哲
2023-08-24 8:40 ` Li, Pan2
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).