From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id A3E5D3857012 for ; Tue, 16 May 2023 12:17:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3E5D3857012 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684239438; x=1715775438; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=b2Nt2z3Bjv1r2Kh+4v82k+wc+uQQmFG9sjWtscra/vc=; b=WauPGDrM1C2diDc4T2P90y/UopJy+rUtGti6o3ZzerBhng+6iaBd9kV4 tZZyw2txyxOjNkye3HrBphiayTEMp3ehE56Ti+hp87R2BH7T/6KVK/IMT cVizxhKMOWeFYpywsP5SX4Zxj7XDXCKTRE1hNMeRZZtd4733uSRx+/cmr YwR8MuUj3S14fbf5iB/Rltale+bXanV42rL8brZTLMeOEX7myHeu+SqZU Ra7x65Dh9qzbsdgAHVzytU08YcoHOEfYZ8qkvIGHHat8EsVp/ekZhvXoN Xb2NcPzF19XxJ6eiHdqoHQaNJiwAM+ZIElKkyYm/riAbZ2ft6smUgA5BI g==; X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="417119113" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="417119113" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 05:17:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="701328785" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="701328785" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 16 May 2023 05:17:17 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 05:17:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 05:17:17 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 05:17:17 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 05:17:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXEbmNAc0cJ0Z9hz/K/qO7zJj/SrQmeDkbi8nod05N/gvAV8YnmQWL9+SHDCrA2ClMfMXVdztcvffFx7NDd8TgrF06fnMISJqJAX6ybFU+5iLC66I/Qzv0TMtGNkvzsWk7mlfPLwkk+As3/wP7lVQUqDL6RR6aC8wt5wUpBN/7+T71G2TobHokrot7L/m8oYeNR+eNhZ3MNqpiJRIW+dBYKmzW1k/bq07kwIdXyhMXSGN/fX2yKGExXBhVDYvxjfGQL+ssqftBjJA3Yi2Y3DiRZbcZhHhvEty5wWsB9rAriTSrXE10WIDFBpUvaFoHu5DPzhvS6Y1JohVfjd5o68Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OGySlA/o8ruVttSo3NhsyyAA+nuhsbpbCPTV2nqwiuE=; b=B/nnp7OFpqJ3o1UDyGBFDaHin6cANVwdL5m3671UkUne1Olx4UlsotVsDc13RDN6sugtpk2ElksxyEsYaOpzDAoOssw1jbKjKJq7aIA873VbW1DB3kjoxcWRUcF4i6gogc224UKok5F0tDuIcmsQnMTHpIrsQUNdSOmLRG8dqCq9J4doyRIYJCuD6pxla0hfEPN/1GN8tPyOnqKvVAREHUp0yj5DX7b8Dac046OkdO46EH+ShzyGEcvjX0p6SzY3B0WUwFg5By62EePk9QF3ynA5OrOoiour+BbIBGAS43RPJB53qAykpJc+sYGnLZyAKIO3j3p8zOKlHHBUtvqnWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by DM4PR11MB8227.namprd11.prod.outlook.com (2603:10b6:8:184::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Tue, 16 May 2023 12:17:15 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9%3]) with mapi id 15.20.6387.030; Tue, 16 May 2023 12:17:15 +0000 From: "Li, Pan2" To: Richard Sandiford CC: "gcc-patches@gcc.gnu.org" , "juzhe.zhong@rivai.ai" , "kito.cheng@sifive.com" , "Wang, Yanzhang" , "jeffreyalaw@gmail.com" , "rguenther@suse.de" Subject: RE: [PATCH v3] Machine_Mode: Extend machine_mode from 8 to 16 bits Thread-Topic: [PATCH v3] Machine_Mode: Extend machine_mode from 8 to 16 bits Thread-Index: AQHZhZy5KDlJLdzko0m9KcEdCFzeZq9coQbGgAAyutA= Date: Tue, 16 May 2023 12:17:15 +0000 Message-ID: References: <20230512050016.476110-1-pan2.li@intel.com> <20230513131325.1667305-1-pan2.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|DM4PR11MB8227:EE_ x-ms-office365-filtering-correlation-id: 300656a7-c4f4-4f29-7778-08db56077c43 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eW+fPNohvff7XxhRPbBO/cQmryvkZkl+trP8bXBQWH11Bq4Itw/lkCDnPHrbihQ9eaXWwJhZYkBM7ZO/0Rg87SDNCaDyYJNiJcTURG/eISRh6qsSbjxFXo1sQMdWbJdDz08FPkOoKCGrOj9b+Cw1Z2yLTyUpIZQD+PoDiZP3b77vJe7OCK+K6SDT0gU3L1tlqNKQ2Mtw0Zv+zBp40oCm6oBz2DYCq+huKz0uoPztTFn+TO+Or9Iua5zoLbXgWJgYiPZQKFJd3vwYwWBeLkTYLtTG/WbBThWxp0idT35wd6pFMBdrzLKpRD1LEfE1msqaVvFsqfhqBe41VvGmWlNtAC2j5CZmhVISIgyVikJeHuB1KTRfhy9AnR0/E/N9I57t3wLxMP8apLXSlaqcoMXtXJEcY/cM3VFVtzrsBsArar780015JUirHfnyCC72fv9oOItd6UALCVYBNjJvi9lC/naPWW8Ka/UyQi/GRlJFRDRKKbX+iXgCSaZ3JvENIyDoR5puNFebf6af6B3vQt5Zj96saaduloVF7ZH8L+STt/zk60h5xKjb+gczQNO7nrdEM9KtPcCeQpNgNXzkxDC8Y9+aGFEMsD+9T8KsNXtNYom9aHH/XooJ4ApU+gQqtblL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(396003)(39860400002)(366004)(346002)(451199021)(66556008)(66446008)(64756008)(6916009)(66476007)(4326008)(76116006)(66946007)(478600001)(316002)(54906003)(86362001)(33656002)(38070700005)(7696005)(83380400001)(6506007)(53546011)(26005)(9686003)(186003)(41300700001)(52536014)(5660300002)(8676002)(2906002)(71200400001)(8936002)(55016003)(122000001)(82960400001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RVhcZ3eQ2vfh+m8hGRGpqQygPXRel9a7B33rIsZMBXIet9y7FYxQ/Jh64eQd?= =?us-ascii?Q?abTMEt2I/qxQD2xvQ8fSu875XLfFSXKq0gzNPjB9fxEKtNmxRHbWPpldOZjB?= =?us-ascii?Q?esAtE2lxQf4aMn3lKyvUhSo2N4OF4kvlM+IngBsf76CEOXuzuBbW+I/oaHCX?= =?us-ascii?Q?a0O2kb9myMHvraPqtt0c1/QVw4Riur3raYSA624+gseHFqg4QCMx7GKVKU02?= =?us-ascii?Q?T9vwHUcN46AlH3miAGP4Egc99hx5OO2r98wt70eaGfDTGWjS11Zyh8KNEGox?= =?us-ascii?Q?JaKsdYeHBF90z2X7DES3Zbs6ud0tkv0V2U0DhKWICxvUIgWWYP+l7If8HSse?= =?us-ascii?Q?Ch6xOYUfNQEQEkyEarMSgEKkkGXrjOrEEI9fWevtE0PHqgYlU7t1jDu6LXqO?= =?us-ascii?Q?lvzN9PY1YUkZY4zoh49ERqBM2W3zKsiNv3vtKaN4TqMLsSxTjw/YmZU4hkUy?= =?us-ascii?Q?3VGQyPY6+rCuobqTkvMKLhWT0ffcC/GPQtOlB2dvrRg21HHq/Ao1nLCLv+2l?= =?us-ascii?Q?+acndGhJ3D6y3EUSE503EA1RLLIwsoKBAbvUbKg+w5KN6fPNTAGMlrnyK/jf?= =?us-ascii?Q?nHju+HM6K1aJ5pIDIHscg7AZbboDHGQZ9+Tm5bZKwTXCvjs9h0w6QYUnVMSa?= =?us-ascii?Q?XSJISYnoGTE+nX4nV5EHueGT9duP/3P7LhTeBERHworhZCl1uAoymPVy5izz?= =?us-ascii?Q?G0NVBCuqKthmoSv+z73+Zxuq7CdTNkoa+Wk+nzvb5uvr3FF/Q/k5hRHVPH4w?= =?us-ascii?Q?+mN9BVObCU1ffYcf/16GC+9ApMdKdrSP/idgihY5EauvDuUN5EKV4RGMp5Rm?= =?us-ascii?Q?k2ZTEcQ0nEWO/BB/eurB/kf/VvTnvTQZNfCVTOpmjELnxfSyRg6pbWhwwYlM?= =?us-ascii?Q?imUzhF7Eeu83Ms8NYHPPTDlZradFh6hTfFPZ/aJiEKWG2sBkGsAW2QxEy4Qs?= =?us-ascii?Q?tJdgeiyP7E8Gxmb0SsaOVQ9OpyjThJukJysuYajmYLUbPsjn+AMzWk5OSt/n?= =?us-ascii?Q?JeL4CbQc9AXWZ9YrXq9b8azulYzXU3vyqTzCPltcNbTE1sAPV8sasd0qQFAu?= =?us-ascii?Q?wtUiDNKGJWHiFNQfjGtqNkhRdRDXxUoC+GRqjBNYaJ4+ZDlA8sN9XEsJP4qf?= =?us-ascii?Q?kMkzhd/PjMko5wLsmqIThaWMZs61K4TwFFYNXI0fWjWyg9TBBUmJMvVKu+nQ?= =?us-ascii?Q?B3mxHn05HDihauJ447wQmF7XiTpIARIFGj1T/SqVOHRtuEFIyYxFXyVuvTrg?= =?us-ascii?Q?ATf404GO10/LtgYs3EQOPIeKfE68kGpl6ZyySSS3dqJpzfqFLTlDaEKG7Rx7?= =?us-ascii?Q?2MAl8PH3MDazzpjbJemyUXMIPo8O+C7UgaRup96OJKPsSLOqqzNawCo/yYFU?= =?us-ascii?Q?KySFXSf/iBMe17gVJ7lysMQw/J/MIPswhUnKO2bOSLab/7wg5iqzGBiY5/rZ?= =?us-ascii?Q?xFb+vcc9ux2HJjYOkKWDshqchi7MWIABoZoE+9LDEEvs8MXyOy2H38OKYGnY?= =?us-ascii?Q?bfl7vKaCQtbYaV+VR3JpvLLJ0a5hyalgyO6dGLbTmBEm7OwIrpUOr4c80YkW?= =?us-ascii?Q?SoeU0U32m08iqQwpuGM3D+yFSMOGoUusJ8PMWJEG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 300656a7-c4f4-4f29-7778-08db56077c43 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 12:17:15.2495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j9qIT5leEpbIZteQwxlhZBGSe32D/oUBS2lql1597Bnaww8AbMbAgN6gajlELGLl0DazjNvRKJesDKoYV7JWQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8227 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks Richard Sandiford for review. Yes, currently the class access_info will be extended from 8 bytes to 12 by= tes, which is missed in the table. With the adjustment as you suggested it = will be 8 bytes but unfortunately the change of m_kind may trigger some ICE= in some test case(s). I will take a look into it and keep you posted. Pan -----Original Message----- From: Richard Sandiford =20 Sent: Tuesday, May 16, 2023 5:09 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; kito.cheng@sifive.com; W= ang, Yanzhang ; jeffreyalaw@gmail.com; rguenther@s= use.de Subject: Re: [PATCH v3] Machine_Mode: Extend machine_mode from 8 to 16 bits pan2.li@intel.com writes: > diff --git a/gcc/rtl-ssa/accesses.h b/gcc/rtl-ssa/accesses.h index=20 > c5180b9308a..38b4d6160c2 100644 > --- a/gcc/rtl-ssa/accesses.h > +++ b/gcc/rtl-ssa/accesses.h > @@ -254,7 +254,7 @@ private: > unsigned int m_spare : 2; > =20 > // The value returned by the accessor above. > - machine_mode m_mode : 8; > + machine_mode m_mode : MACHINE_MODE_BITSIZE; > }; > =20 > // A contiguous array of access_info pointers. Used to represent a This structure (access_info) isn't mentioned in the table in the patch desc= ription. The structure is currently 1 LP64 word and is very size-sensitive= . I think we should: - Put the mode after m_regno - Reduce m_kind to 2 bits - Remove m_spare I *think* that will keep the current size, but please check. LGTM otherwise. Thanks, Richard