From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 773C03858D20 for ; Mon, 26 Jun 2023 14:09:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 773C03858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687788547; x=1719324547; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fX5Emmw08fcGYAcsh6qQG2ZK1YhNdvD4axR8Rluhz5Y=; b=UGxWLxbDapVioNZNYOCOW1J2oYxPvi7938xjiSU3dXB9kCq2OXx/a5ns 3gaoKMruNd+rrzei+1UvsgZ/dViLDZxev9WU+hpJqXKfLBpakVuvDxSYx 0qWcKX3SAxsKZdFTjBieUhaHZxZCY4QbuPQRB1J0MGCFgxE/ENBtJx9km lTHlTZIzsY1NidjzQEQjVm/ylP8mACHgqfwI4pqPKrYWosmHb3N+RZKLm Qp0zw9kqOEgzIISJdnHHDF8G9R8dDbr8a2VykR+ibYMV7TKDEacig54ku n3ddSdDJU5yjWvlvqt7jkSDRo1MQk3NjRMRjj46wouVInQQcbD8hAUHpv Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="427273848" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="427273848" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 07:08:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="962764465" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="962764465" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 26 Jun 2023 07:08:39 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 07:08:39 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 26 Jun 2023 07:08:39 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 26 Jun 2023 07:08:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=asQe5kFmQCjuc9c6e9IdiCwsm8ZdRB9gsDpqu6ejABG626iQ39BaVT3QPq4W5GlPr51k5chbyhdijQpjjNiNKlaTLDW3znu5j/OWkyThZGBAjZS7k4XL2KcOki7RMaHbyfXpKV0hJbRV3e7TqNi6F1uxIfTvehgDOBqgZoFZOviB1AKR5ecWfA0RgJ4jlilrq3LVjLCGEGuTYIVZFCBM6faLmAcqRu6A+4oyvg26HLXT0Ekahq7tbbRyV2A1wWs1dn1D9ugenwh40SEH4Y+v03NrhJm/PLg7ue8dWIDrUYCbbmXKfHxtUSCtI+zGthCbuH116+NsSoFQMnB1tbR+hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LQiaseZ7jAXOx8qNB4YKVp+wpETN7LB7YLyUoD5o8Rc=; b=Mj1oy7/4qInzOROEE02QeSf3VR4H2KVLhC97FT+Hba7XjSUpNvJ+p9WfdGhY4SUOb9L1rdxKYRsCkNlkuVMMVgUHEMSvwPzZP30Cs9mb5RNK1rl2jlBSRggU/i7EfjjB1gLVYgNEGolTbzD3J7XKwHr+NVVYVkcmhE9QnJ4k67Ry2knungCCi4w4u9yFrRkqW67dt+KNyrf1Yr5WuNJ9YhTXEb6jiGskILwL0PqyKdP8yffEUvnPCEUqH3m5Kyhxqj1aieAtDjC1Ot9WbTNQnGP1kysO7Zwhv6YicbPRKsb9WbzQDfIpPsB1jO7dsNh6LmOZkpLYZW1dcMZ6YmN9KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by DM4PR11MB5552.namprd11.prod.outlook.com (2603:10b6:5:399::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Mon, 26 Jun 2023 14:08:36 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::127c:f4cc:e699:8f73]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::127c:f4cc:e699:8f73%6]) with mapi id 15.20.6521.023; Mon, 26 Jun 2023 14:08:36 +0000 From: "Li, Pan2" To: Richard Biener , Ju-Zhe Zhong CC: "gcc-patches@gcc.gnu.org" , "richard.sandiford@arm.com" Subject: RE: [PATCH V3] DSE: Add LEN_MASK_STORE analysis into DSE and fix LEN_STORE Thread-Topic: [PATCH V3] DSE: Add LEN_MASK_STORE analysis into DSE and fix LEN_STORE Thread-Index: AQHZqAICAGpRElXMaUGcGSc+K4CcJK+cvIwAgABir8A= Date: Mon, 26 Jun 2023 14:08:35 +0000 Message-ID: References: <20230626074342.2629716-1-juzhe.zhong@rivai.ai> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|DM4PR11MB5552:EE_ x-ms-office365-filtering-correlation-id: 1d849f82-0325-42de-4e06-08db764ed534 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: At+pgnY87Q0ceg3dkDQRNBE8Gq/hRrbYsg824dulLbDmq+PSCraWjaYwEcoco/3IGbrfICh9FVUyaJeZzU54HQ3NL+TMG6oyRb7qr/OeoWaa9VcLDbnam6WdBLf8M9KcYOq6dbpc7cBIvyNw4MuwOAi2evtRtQzQSQ8EdFrDb4LEWk6smqjsc7/i8mVbujHPHuNj/Q9Bhw/zsztofSTdskX3ebKCvKZBokuAyGgytqQ4Xp9LrALq6NYIGozazNdYu+BUPgkweTEnXgcYhbTRaNbvxzDlVl+NwRZtgzQao8PW+ficiSx8M8qcuUCslSH8W3rtI0jj0aryfRxlkNqITc1Hkjq8dMLeeUrGyYLwhl294XoY7qQTEXWrM+kZJZLmujRi4kJdEtQZwTCgLpsrhbvyl5ThrE4nMML1iKs/mdfFQkclV859cDScZv4hzKDHlvLLvVC8A/hnkKOlOoLTk6kODmcJqn+NBRu5bzCGdvWUW8ghJZ0n/mNhZxD48aaYhnOatd3CqvlCmfl/xUQZE1z1XIr3gaa04NZ4/EPU5xiqZQz6qVlRps0Q9hp205lrBFXCxWgvV3/hBueU9XkgoQrs5GusPHZxO8p1yMz8NK1ehvhPjjIzAvsYDmeo71om x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(346002)(366004)(136003)(376002)(451199021)(6506007)(33656002)(52536014)(5660300002)(316002)(86362001)(66476007)(8936002)(8676002)(55016003)(4326008)(41300700001)(66446008)(38070700005)(64756008)(66556008)(38100700002)(122000001)(76116006)(82960400001)(66946007)(26005)(53546011)(2906002)(9686003)(186003)(71200400001)(478600001)(7696005)(83380400001)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qpXF4/hiMwKRTw1mkUY1khbHw2N42YiYi2ueogGS9NYRjQZixaW/EHG5UbRX?= =?us-ascii?Q?+b7Xw0qpofwe+LtmKvq5UrGpbCZ7L1pnSLJKVIrfE/Gun+pItN/bFN9j07pp?= =?us-ascii?Q?Ks/YZqngXmA0KEcE5hdTT2n3tNJo+cVWcTJTVIKiTRcdlWAfBEMy49QoE9qS?= =?us-ascii?Q?gC5m7DnHnay8dbd9j65BhuTkb8iL/a52h3fcetzmnXHeQ2YYzuIp2CGbxne9?= =?us-ascii?Q?zq04p3GTCahn8tgfRnisQDiEcXQQNiOe1bEL/MGM0euQzLo+qeD4c2CEcsOi?= =?us-ascii?Q?F/yMk6IuhrvJ3BNEjD4tt7GlkORntLOhGtME9Q76Rme/q88U6hTAKLdVjaHN?= =?us-ascii?Q?V7XxuZX2NqPU9gm0PNxq/p/RvcGkiFfPBcr2pjTXbfjxVRLmy3XsPPZr1N4K?= =?us-ascii?Q?iP/9JLkeCdGpGoWkAxVJ4G2arwiphiG3t1y2GoY37O0W5bbvZBvlNxf+Dynp?= =?us-ascii?Q?sHDNFSqvEhaQs1+oboZIQ90dnnbIluSpITXcPe/p9vvo+XulOIqJBbpzoYom?= =?us-ascii?Q?0gYeYvEji85NvcUiHhCS/CoSmr2etx/7qF7/BEpOrtEq4Q4dPlabdhMPbEnr?= =?us-ascii?Q?c78QFq8wd3aEog+OVjh+8EQ8YGNScM+u69q00aqfX3EAsrC/XlFPoAv0kav7?= =?us-ascii?Q?c41CqWz/Fj8qtrDBpkHoOdMZiUxMnxIsbUZmApGHuPXsiizr8aWv6uq28xOm?= =?us-ascii?Q?ea7LIrA/0V2onkT5mi88kmBvvKrYQ7JQWtaYqOnO9qJGXlGr5OR9UMNB24qD?= =?us-ascii?Q?cfWKlCTtOHPiRp4JgRGKB8iW5/HZWBlurQwTj0w1hsAnvlRXA2coONF4IqNp?= =?us-ascii?Q?qr2AuHqCn7v7bCB66qmUZv9k4rlR/6y0gReeLdpUyGdzt++UdRD/bSb/kkwB?= =?us-ascii?Q?LlPqBDN9FS8GJUHzRbBldMwFOQtXBwVZjmA2xyXT11C8lmn5y1kVazsQTu8o?= =?us-ascii?Q?+86A94OyVR8iEwj+dviTd2pvnecl3xaxCZg3+/A4IBJhp0Sp9IKINsjc4RFb?= =?us-ascii?Q?vdHjlbkZRortu2mpgGvjG6mdjylq2dCF7g59ysmWgOC20uxLWHC+oTYRNlTW?= =?us-ascii?Q?VN0d2ho8u49VFs0ZS1FEp7LxU2azv3UDq7oONbQqNcz+hgSb2oELYb+5yHxm?= =?us-ascii?Q?IEYJQXF83uU55sG5dP1xknGFY/bNDgRRJIGoYClS/FHPnaf3PBk0MGm4VbBq?= =?us-ascii?Q?bO9kt01LuZl1gk4Ukg65Pzw38UC/mSBsTvdUimXC/UOY9sN3fVNqkVB7RMGS?= =?us-ascii?Q?l9JLJBlPPvMrcRZ4laX7LbiM6f9myAi4u2oUs99/Be7HNJ20IJUQc5FLOoOt?= =?us-ascii?Q?ipvg1bv5fY0OtVOJ7UNqwLBUyBUNcGo8x2hhQ7SJDYr7hcwJJ++ONNeF5c/S?= =?us-ascii?Q?fhvXlz6qtL6BBNnax/dC3EJzY3HXyKJrDX9VmpCEwvrBq65nk6tpZWnKDTc3?= =?us-ascii?Q?xcePwUyXBhyytJvfnyuz8I0jG9C1B9IA3/yxMntZ1T/v0xX799wJfZ0Onct5?= =?us-ascii?Q?8OI4hFPw1+ECdH83BY1tAqvID6541+080a7gbGjy8nxbFVZvz08A4hcIcKgr?= =?us-ascii?Q?9X/9RA7Q4CqHpuxHdW0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d849f82-0325-42de-4e06-08db764ed534 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2023 14:08:35.9203 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yvTMkaO/GQt3gYu4BvpwccLDPa00XajSLiuIRYfwTJXELXg0kZ9ifz7KA6pdaavHbKgCToCQSQNQ/ekZhXlgQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5552 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed as passed both the bootstrap and regression test, thanks Richard. Pan -----Original Message----- From: Gcc-patches On = Behalf Of Richard Biener via Gcc-patches Sent: Monday, June 26, 2023 4:15 PM To: Ju-Zhe Zhong Cc: gcc-patches@gcc.gnu.org; richard.sandiford@arm.com Subject: Re: [PATCH V3] DSE: Add LEN_MASK_STORE analysis into DSE and fix L= EN_STORE On Mon, 26 Jun 2023, juzhe.zhong@rivai.ai wrote: > From: Ju-Zhe Zhong >=20 > Hi, Richi. >=20 > This patch is adding LEN_MASK_STORE into DSE. >=20 > My understanding is LEN_MASK_STORE is predicated by mask and len. > No matter len is constant or not, the ao_ref should be the same as MASK_S= TORE. >=20 > Wheras for LEN_STORE, when len is constant, we use (len - bias), otherwis= e, it's > the same as MASK_STORE/LEN_MASK_STORE. >=20 > Not sure whether I am on the same page with you, feel free to correct me. OK if it passes bootstrap/regtest. Thanks, Richard. > Thanks. >=20 > gcc/ChangeLog: >=20 > * tree-ssa-dse.cc (initialize_ao_ref_for_dse): Add LEN_MASK_STORE= and fix LEN_STORE. > (dse_optimize_stmt): Add LEN_MASK_STORE. >=20 > --- > gcc/tree-ssa-dse.cc | 47 ++++++++++++++++++++++++++++++--------------- > 1 file changed, 31 insertions(+), 16 deletions(-) >=20 > diff --git a/gcc/tree-ssa-dse.cc b/gcc/tree-ssa-dse.cc > index 3c7a2e9992d..f8338037a61 100644 > --- a/gcc/tree-ssa-dse.cc > +++ b/gcc/tree-ssa-dse.cc > @@ -48,6 +48,7 @@ along with GCC; see the file COPYING3. If not see > #include "tree-ssa-loop-niter.h" > #include "cfgloop.h" > #include "tree-data-ref.h" > +#include "internal-fn.h" > =20 > /* This file implements dead store elimination. > =20 > @@ -157,23 +158,36 @@ initialize_ao_ref_for_dse (gimple *stmt, ao_ref *wr= ite, bool may_def_ok =3D false) > switch (gimple_call_internal_fn (stmt)) > { > case IFN_LEN_STORE: > - ao_ref_init_from_ptr_and_size > - (write, gimple_call_arg (stmt, 0), > - int_const_binop (MINUS_EXPR, > - gimple_call_arg (stmt, 2), > - gimple_call_arg (stmt, 4))); > - return true; > case IFN_MASK_STORE: > - /* We cannot initialize a must-def ao_ref (in all cases) but we > - can provide a may-def variant. */ > - if (may_def_ok) > - { > - ao_ref_init_from_ptr_and_size > - (write, gimple_call_arg (stmt, 0), > - TYPE_SIZE_UNIT (TREE_TYPE (gimple_call_arg (stmt, 3)))); > - return true; > - } > - break; > + case IFN_LEN_MASK_STORE: > + { > + int stored_value_index > + =3D internal_fn_stored_value_index (gimple_call_internal_fn (stmt= )); > + if (gimple_call_internal_fn (stmt) =3D=3D IFN_LEN_STORE) > + { > + tree len =3D gimple_call_arg (stmt, 2); > + tree bias =3D gimple_call_arg (stmt, 4); > + if (tree_fits_uhwi_p (len)) > + { > + ao_ref_init_from_ptr_and_size (write, > + gimple_call_arg (stmt, 0), > + int_const_binop (MINUS_EXPR, > + len, bias)); > + return true; > + } > + } > + /* We cannot initialize a must-def ao_ref (in all cases) but we > + can provide a may-def variant. */ > + if (may_def_ok) > + { > + ao_ref_init_from_ptr_and_size ( > + write, gimple_call_arg (stmt, 0), > + TYPE_SIZE_UNIT ( > + TREE_TYPE (gimple_call_arg (stmt, stored_value_index)))); > + return true; > + } > + break; > + } > default:; > } > } > @@ -1502,6 +1516,7 @@ dse_optimize_stmt (function *fun, gimple_stmt_itera= tor *gsi, sbitmap live_bytes) > { > case IFN_LEN_STORE: > case IFN_MASK_STORE: > + case IFN_LEN_MASK_STORE: > { > enum dse_store_status store_status; > store_status =3D dse_classify_store (&ref, stmt, false, live_bytes)= ; >=20 --=20 Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)