From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 90CF13858D1E for ; Wed, 21 Jun 2023 07:23:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90CF13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687332193; x=1718868193; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5Vkz+Bg2F+4M7WQu5ImTsBSfcZLy5fXws6pA/vx22uw=; b=EHnFrXWon4INW7v8YOjPjyooqw3pUatMxrpF+rtnQjRXkCFzmH7564OZ vMfWje3jQB24wFD/SQ9gjCXRad37xPVcGvWt6P3REyX0oTM+RipI3fFUT czc9gc1wQcSo6X+vgl0/b763/tXashtzV51xJMfvyyE2qn3xFJVAPbIYH wvJCY4+Hf9N8FC0l1zErMwP1fHQfmhlLXH86FdR1IYwEZuy+5Yk12yDKI IBdjpP8oo8ki4GUxG+juLYlhY2uODCyUXUWNHbFS0psGTUPwIrZQM8TKu /j/SPCUo1ihrrkOvKZgJADaLAOqZs6UMuK2qbbVHG9IU4ppUNYrnh+8iQ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="426047322" X-IronPort-AV: E=Sophos;i="6.00,259,1681196400"; d="scan'208";a="426047322" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 00:23:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="827325082" X-IronPort-AV: E=Sophos;i="6.00,259,1681196400"; d="scan'208";a="827325082" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 21 Jun 2023 00:23:11 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 21 Jun 2023 00:23:11 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 21 Jun 2023 00:23:10 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 21 Jun 2023 00:23:10 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 21 Jun 2023 00:23:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mCsQlpyFXuLD81hAVExpACeQFkEyp4u/2bAacareTWf3JYUX4qaFnXyHhrWJ4djG203X4btsRKv43FKm8XGnTZv/umw14WJLkTBjSjViLuw/BL764dOx4DrlrWnsRCsn6Z5sgzdYdVlMrXp2obL5DPhd/YgAl9oOl51WTC/uUx0fw4CVoARig5/9ntcsbGaperiBFNiprtjTpwANlzp33jCBq+VOETqwsGSSfbsltFvdh+1elrQCmZFfKM9h8zT/kiFJIwCJuP81JOdE3TXvA0OU1uHo9ZLMhpafGQqapktYKkwRNEYKMk6rJACGne+txKgQwo6seJhof0WSzOM+jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9QGd3to4mxKVdZ+x6e6aDsepiAzzdo/oXqrfPfh2tK0=; b=gUTp4qwFUNKrBtyNM8ZcXue+fWdqAAmVCy/p6N7eF7ChzRhXM0x6F2Ni8EowSjatbX+EQw1h4A7lSxRpldyhbaGEUR88mgMCDS+EXxx9BEVf+vI6LeQVGzYjt44oqje7GHVm30r137wDyGdb1UPkBBEhYlEeqW+3l+LzkqtazoRl9O2AkB2Aq5LZ68wunsQb7P5IRiE7W7zWRUfRjEb+pVGeDOiM9UHx5g9R4+rEWz+d69Mwl0RdlPKnGGZeReq0HbvTBydoF6YTUHZCy5wwxObnBEhrznjbl6zOIc2D/RNGc2XuCbT6/AyUAHCGbpWDAStFSux0SS68Jzk26C/Ckw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SN7PR11MB7638.namprd11.prod.outlook.com (2603:10b6:806:34b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Wed, 21 Jun 2023 07:23:07 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::127c:f4cc:e699:8f73]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::127c:f4cc:e699:8f73%6]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 07:23:07 +0000 From: "Li, Pan2" To: Jakub Jelinek CC: "gcc-patches@gcc.gnu.org" , "juzhe.zhong@rivai.ai" , "rdapp.gcc@gmail.com" , "jeffreyalaw@gmail.com" , "Wang, Yanzhang" , "kito.cheng@gmail.com" , "rguenther@suse.de" Subject: RE: [PATCH] RISC-V: Fix out of range memory access of machine mode table Thread-Topic: [PATCH] RISC-V: Fix out of range memory access of machine mode table Thread-Index: AQHZoo1G5H0Lv2r9XkuUWLbdvLdQGK+R2HQAgABIDhCAARQ0EIAAIaEAgABlIPCAABZlgIABA1ZwgAAGNICAAAF5IA== Date: Wed, 21 Jun 2023 07:23:07 +0000 Message-ID: References: <20230619080710.1536456-1-pan2.li@intel.com> <20230619090548.1574008-1-pan2.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SN7PR11MB7638:EE_ x-ms-office365-filtering-correlation-id: b9b8a877-9434-4037-5412-08db72285c3c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 48eXGCt40iO+QoBox4LZB3FM6YO3eNK2yn2UTZrr/r6OtGFufm6Ot5QZI1g1gqTw87veA8RYKtXg/DhbL9AdG63JpeT/leal7Xf1zgmA5LEGhNoF/WjICOOMU845spAv0YeNg2hEAsj1fg7sXEMWwofpSrIPq6FletDWAsq0z399w83j3pj7kynvIzde5AJ2iLLRCkEtWO4qR7QCdjV0UUdPAfNZZ+Mu9MgP1M0wF9mn1qtbQLoLe10O6k8nUYS3wqugELRx8XpZ/iopwAywWXmpBSE0GhYEA/ab0bViHrshCREHjXYXDusvNUun+Z9rCwnDSYYZtTGGP4DgiwPzrw2WIM4aCgq2b2qGa6kwmPpStFYt4F9M3zvc2ZJpkto+eMk1hALzyGkwuZ+d+0ACjev7+GsVpuu27mDFQAYTt4pPatVHGgPuPCvpMXAhFzaU1NSOAAQMit/Yx93yfbxx2ylS6F0Dvs43tIHoa0tX7Px+WSZ6970+M57QczexLpuG/UrU4US8idG/d+q9vhgbxoc1gKCgsjMmtdaKQl3seoNJk1T1AeQ6fYerfOo/MFcEXRewb+vWGz4VFa6F7pZxFSiyEgcwgbNgfkh4rrC8+8k= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199021)(5660300002)(52536014)(8936002)(8676002)(6916009)(4326008)(66476007)(66946007)(64756008)(66556008)(66446008)(76116006)(316002)(2906002)(54906003)(41300700001)(7696005)(966005)(71200400001)(478600001)(55016003)(26005)(186003)(9686003)(53546011)(83380400001)(33656002)(38100700002)(82960400001)(122000001)(6506007)(38070700005)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dgGVvhRlp/tzYkcmT9rZu4FeyWar1tkFYOLk3/wM9Pk0d17DMIbegWDjb6Sw?= =?us-ascii?Q?o+zh3tdQwUS4f8fkoRBpY2dMmpYVfqC0SOJXD9tB9SCwk2nSozJxnKiP6Ilt?= =?us-ascii?Q?TCfIODLV/w1Bgzpe9PZ+dvb/kwscvTbl/tE5Jn9e64CTtnmo7ltq2YmqCh1k?= =?us-ascii?Q?DXoWV7n3VrGxlfHdI7fe+v8PcyD2DQavNmxU0Xzi++D1K163lgXlMP4U48LZ?= =?us-ascii?Q?F8KwIvWJu7cy5U/bKVkxDPAS1cfISUVqrLX2bnujXtRIIvLvtnagZIlT1TIh?= =?us-ascii?Q?4j49Yz+80xyf+I7qp50G3ChKG6M0rtovaXWs0JWjxfSpiC7bC3Fr4zq80hov?= =?us-ascii?Q?Z00qDZSvjBEYjk5mfhpw7URY+sAEcmcHIbMTkSmRfuUaPfydbjsZlCWg5UD2?= =?us-ascii?Q?o9DgOHx1J/pY13a7ektabtMe+XXoa6SIHByg8aI6bJ8ls+wss7Ov43FJQfLG?= =?us-ascii?Q?GocCxNwcH5Ynub8EMRqAhoHjnaxx/Ahonm5s9ZdeEtKP6fpnN7WTAamYe0t5?= =?us-ascii?Q?v5t3YuaX8XM7ek61kGTLQm9fAqNJnB/CmpIiOPZZTuidu18G4qcovcUfUBJ5?= =?us-ascii?Q?/dGBeiUFGbNx5o09zeLYoSqJlz1KaVc3wa7IGZXvB+RcG6VHkO/aT0wb1rhd?= =?us-ascii?Q?6vtcZu6LQDWrTV62vsr6ohVmpzsh7ZOJhPLP/bC1xDucJFPca6ZXb1r8VLFa?= =?us-ascii?Q?Ahn9pg23B+jrxulydsEuDVdVLI3bBravShbW+k4LGOOmdDhlKIdjT2ouz6pw?= =?us-ascii?Q?5pvyvQv8om+ebz7p2aFvMrnI4GzxMLWi3PbrMMfT79hl2tpdre7Wr+WIhmVw?= =?us-ascii?Q?kCWPTD5sW5ARAKXV56PfQaFC5r91OdvxmQWR+sT5GNI3gL0FPOiYptDD+ojP?= =?us-ascii?Q?ErTUjwgB06nscOxrVVGmqF4mqo4YiywZBh85PJr33wIWS8XKE1ZtVKcUJG+m?= =?us-ascii?Q?gIBOcLwvu7n6wOsTy7GyS6GdBFVCYTmbJoRWAQmlaqKwa9E8SXiamxe6vngP?= =?us-ascii?Q?K8QhNDNhkOpcQaXBiR9Oqoy7hOOP5qiMeWRnaPjXwjKoQtyUWzEPHmb8bpyi?= =?us-ascii?Q?pjA6nJtV3F+B9L/c2fL6csIJZ36s4/rIT2LUy0oNg/FLJpPnbd1706rQ7/OH?= =?us-ascii?Q?lvdcQEvSdZ40jKC+NYBm4501EGJJOCh51YZQlc38b7OV59ClB0brTdj+Rjt2?= =?us-ascii?Q?/7lknk9zo2acZhBguP5oPs5YHct3twNv/gd/fBT3LFF9qWLL4xuIMSZk6ryZ?= =?us-ascii?Q?B6prVzQncpNtZIvBbE0PZvbqFJ2owgVqqC4ufcRcc5AIcqSu3wqRWPTvh3cL?= =?us-ascii?Q?/TQQhnTTqUSTh+MZwMLIw6MXWjLb2+3GqQWFoZmLIj0C0ciYu5M0fmvyWW8E?= =?us-ascii?Q?DxvoJi6j2qzHN3v5VzE2YdO0a74k+XfefppBE/OZBTlI+owMdrY8RZ4hp1lk?= =?us-ascii?Q?/hgvMvZ7zRfBNVWPDfFfwXD8sK+IgqWMyQ3oQ2dxvb46/dFL1MsKSG4EC7RF?= =?us-ascii?Q?Ae7g8LyVnOmiEBJwQnW4+3C25UGUBzENfc73R/59lnIfx/JKGuQn6+NGOfOf?= =?us-ascii?Q?iqd9ZRAcHjHnDOG9t0s=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9b8a877-9434-4037-5412-08db72285c3c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2023 07:23:07.4764 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PzrnM2LSOb7kjkq+m9rB8Eq0/tKe1J7brSzSV911wzMZTLsSYMcJDCqEF1+fiwxfZwLs+8PCr4luSHieKZER+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7638 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks Jakub, will fix the format issue and send the V3 patch, as well as t= ry to validate it for offloading. Pan -----Original Message----- From: Jakub Jelinek =20 Sent: Wednesday, June 21, 2023 3:16 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; rdapp.gcc@gmail.com; jef= freyalaw@gmail.com; Wang, Yanzhang ; kito.cheng@gm= ail.com; rguenther@suse.de Subject: Re: [PATCH] RISC-V: Fix out of range memory access of machine mode= table On Wed, Jun 21, 2023 at 06:59:08AM +0000, Li, Pan2 wrote: > inline machine_mode > bp_unpack_machine_mode (struct bitpack_d *bp) > { > - return (machine_mode) > - ((class lto_input_block *) > - bp->stream)->mode_table[bp_unpack_enum (bp, machine_mode, 1 << 8)]; > + int last =3D 1 << ceil_log2 (MAX_MACHINE_MODE); > + lto_input_block *input_block =3D (class lto_input_block *) bp->stream= ; Still 2 spaces instead of 1 here, otherwise it LGTM, but the important question is if you have actually tested it with offloading, because only that will verify it works correctly. See https://gcc.gnu.org/wiki/Offloading for details. Jakub