From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id CC0343858D32 for ; Mon, 8 May 2023 07:00:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC0343858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683529201; x=1715065201; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=M3LT4+DXgTGWH2mU+5zBZk93/VDAp+ph879TgDCK+WQ=; b=AP7RoPoXeddxIQe6KN8KRF++m0bglG1U3addjE3Is1NWrOZjbThWLa84 SrcnPyLyTtMaSN15JfqrQ+z8EKjopP/zbyYzxAkWU+TlaBhfSqRyEj96C lK5QXvHqT8EjSIz0P1SMlF91IYkOB0+HhJX0laavUWh30qYheQ9EQIhax 0DwbGsBO3YMcYglOenuICi3tqQnYIY4eSIOdtlNhnLzOe+wnnEn5mVZAC evNtJ4FVwmoTbzQi99jvYMOO1MvCI4HSRSmUW6GcOU5KKtPQqbxsGtr3L 5ceRZFT8KNTMIpHXH2vAlANuRrBgqoJgg5uICTP8xmSmj2cB5SoYOMifU Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10703"; a="348400362" X-IronPort-AV: E=Sophos;i="5.99,258,1677571200"; d="scan'208";a="348400362" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2023 23:59:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10703"; a="842590255" X-IronPort-AV: E=Sophos;i="5.99,258,1677571200"; d="scan'208";a="842590255" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 07 May 2023 23:59:58 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 7 May 2023 23:59:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 7 May 2023 23:59:58 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 7 May 2023 23:59:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EHA8CL3rnms5pHburwzmllEumxb5GE39ZOJ296pymoqOgWmy96497T9uYDrq6/ji5p46PuGg2TW0UXyKpY7tlcQuWzMrTOKZhynMUTANFcY8f1NIOJ7T/2XNp2a4LjKmVVqF9RVfWLbtC8Hn1eRiq1aOoErLzf6edJnIM1LVRdpVuSz+kk1O/+U3zXCX/jD6vlbTiR28qY7X+2EVDn5HzzL6HoGR4qcrtcPiZojsMH2Z2dnwjsnslbD+clMld+sCXIDlFypLYL0ci+8UgjEZrm0AiuuVtaoqjtiQAn9Z0w+X6YMztXHNBIX8l4gCw1cMjO2fSehlAXVC39xtKak70g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R6Dx6KDNl5nmyxi+OiW396ULL0oT8dr88Itq48QUDyc=; b=LF0ihp+ExqzIwVOWayt3dpc2ywVCnAu8gPtwqaBoM4TMddzbNjb9+im9MRx5Bpe0QlK0si6qEublAH34ImvjFbvNT9LYe4KrUITqwfZgpXC0dr0zgTYWSWdyYlCaLIeYgEl1ycTgOGdKE/JJ5Fs0wC+GqGdZac3Bb1eSGKJzqieeNMaXs2N9uNlp2quad7/3WALo6cH00C6gKpSPAoV07rQ3dZ3MLSXmvt4Hlpo+w1Gae9oOmnJIh2TjI/I4HSWZWwnlR9rzKDaK03J5kq2/t4ZXYIIDEhMxiNfk4YVG6G8Bezd4o8OFJmPXS9zrUeV/hQ5I+c2z7qYz5bI5MVm5TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SA2PR11MB4987.namprd11.prod.outlook.com (2603:10b6:806:113::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 06:59:56 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9%3]) with mapi id 15.20.6363.032; Mon, 8 May 2023 06:59:56 +0000 From: "Li, Pan2" To: Richard Biener , Jeff Law CC: Kito Cheng , "juzhe.zhong@rivai.ai" , richard.sandiford , gcc-patches , palmer , jakub Subject: RE: [PATCH] machine_mode type size: Extend enum size from 8-bit to 16-bit Thread-Topic: [PATCH] machine_mode type size: Extend enum size from 8-bit to 16-bit Thread-Index: AQHZgPgLEItqgvjuhkOVhtsYc5zgaq9P6wCAgAABRvCAAATiIA== Date: Mon, 8 May 2023 06:59:56 +0000 Message-ID: References: <20230410144808.324346-1-juzhe.zhong@rivai.ai> <2978624D57874251+2023041307225185723242@rivai.ai> <436847c8-0c15-24de-5925-f56d78caf540@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SA2PR11MB4987:EE_ x-ms-office365-filtering-correlation-id: 156c1d46-c89a-44ae-7bf1-08db4f91d4cd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r2m3bdW00wZE7iOfj2reo6RT+GuhU1TEReGaV7jWlgOwHuHCnRqai07G8fflc3Y/PkEYwLlEFy4v8VMP33bMXl14WkeJbjM5K7h5RLIVcnMmF04uRs2d8fQFZLwhttvLJ4ukITFdrsKkoe9AMPTu8qaIH3zkt7x9jKyGCP7TydUaAxjTyl3f17sNhmOCrqDwQiww0QlCLkb8Bk6EsCwpAilQgXk7DdiekbGGuAknmEuVqTbkzttRYCnd9wY/g137MwvgJYIvsErTadVdghIH4VOIsKLs9C89mROn7snEof6Kshmm0ERarRbr1oemzpbQBcQulxBbHFWmtDCRTVjy2FUmTPJ64/sNYcuHqUNUG3R4SCXGrMl4/sPAbglLHsadsFB0b4211WTrnJxKxYRrFrq6eM2nVXxc2L3QHxVT/FYYvw3gsb7/iH1OR/1YD8uu96lB+Vk8/RiMjczVJeEClrUHM6G5NrYxvamyTdJ5KHpbDWpCt0LbczW5sePuK46u9VGYjFu//pfh0WIZoALuNZXY+Tpdj2AiRduKVl/1YiW9UWlj/PI3S8lyK6N9HX3qs2RDcZ9UA8HEqsb/AI95LwVmZq7L7Q3n/AFqXcPRE0LzBBE47vdXZ9/g3MsWL6bf x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(376002)(39860400002)(396003)(136003)(451199021)(110136005)(76116006)(66476007)(64756008)(5660300002)(2940100002)(4326008)(478600001)(8676002)(8936002)(66446008)(66556008)(66946007)(54906003)(2906002)(316002)(52536014)(41300700001)(71200400001)(7696005)(53546011)(9686003)(6506007)(26005)(186003)(82960400001)(55016003)(83380400001)(38070700005)(33656002)(38100700002)(86362001)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BKeE++AkKyS2nWBuajilajsoXgRgCav7GMbnEliYHQhn4DVKCcHCp/ySPU5Q?= =?us-ascii?Q?+77jwfTbavja0aEbTwDEsFwaKSTo5MB/aItKN6bSdPXkLPqOgLdpt42b3a9+?= =?us-ascii?Q?b/U7Ak0aoGNK4tW02YG70JKsP3zQI4f+seazYZjd30imkk41fzeoWAdinvMV?= =?us-ascii?Q?iQ0FF9C+bEPN7cHsO9HfizQHh/KHuARXD3TgMqU89YQ3v/rmwwQuevm1DVz7?= =?us-ascii?Q?B+U4KNB3XtyEF5cAs0OTtuPQSh3em+G6/+qKIzj74oj3Sj+i20DLKaoTKOtB?= =?us-ascii?Q?PYKqLfuVBsdX6IMkeWmztwrB9r+EBHLVbsbtEIQPxf2ovGp8KyQHQ+OBh0kv?= =?us-ascii?Q?WAYFBbgOS5ijicQwZ4iRtj+sZxSEzXIDl/9ESNgknUjj0pYUiyGKaMeX3q6O?= =?us-ascii?Q?Si36BUTR0UmUS7H5MF7pw55yHcqS0QWqIL2FVNgD7UGnSVVOfTNa2BLUag5p?= =?us-ascii?Q?gzecOCnsaF+ybn6j5hNSHrrSJCfqQ5i0kmXweJNqOxVUSiP1RZwFOzekplfU?= =?us-ascii?Q?CgueWd1/KImLYa84T7o2iWTBMMl1fsiO+kEByBJGN3uV0tlr0q0CkaGuwYo4?= =?us-ascii?Q?d5mlUTgVl2CGLDLcARr7kmJtJ5LadpS3eHxxgzU3pCJ172ArI4FGdlSUPVZa?= =?us-ascii?Q?5wJG/4DaGpT53mPQLxHTns/x6akK3jRWyc/hFUuPvuav335kawAGGuCJiRAo?= =?us-ascii?Q?XxZ5w5bKuZE/u+l03pHd5lWSEBFXhKOOSHMKIzIFNhZqMNktTUUJWlwi26hi?= =?us-ascii?Q?pW+lpQpPnnCg3JYAhsltGOEt5MAmAnODcILcQ4qAQla1/pruL4sMvpRG5O7F?= =?us-ascii?Q?xbqTumHGyn6jV8gVbhQOayvYlotM8vcI402NHaWp8v7u7aqqxTJfyFPKZaI9?= =?us-ascii?Q?eNZlgOF+g2v07jYnJD9qtDVfC6WTZ5eTQPbFw9YmbddV4sd/eTYxRNic5N5z?= =?us-ascii?Q?hQ43jl9V/nKCi/p1GpCR8kiBWowZ+5cgrQzK6kGrVeFWjLZWjyO1vbrTo7g0?= =?us-ascii?Q?nj2JlEkqSMV3Ka4/5Yu3X8VJpExqCxA8JiHB8E2JnF6UZYrZklRjE1n9Jb1M?= =?us-ascii?Q?SXjlOabMirmMpPyhC8rAPPrPO1CA0su37/Ob4qbZimmaJf0cYRtSk6BWIUay?= =?us-ascii?Q?vQJoPjkkkzEyfl2xK6V89kZ9C6pLZDhl/RjTH5y2yjjFbudaF2qeyC1sdESG?= =?us-ascii?Q?vifxpNNp9k08Gs+qkGy9HTsk/EWblAQCPrenHj/XQbMa762/MrOxMoydFW2u?= =?us-ascii?Q?lSpxvi5OOgfmR4zgtZHzM2vJuTrM/EvpnAZtWq/62sT63Nt+V8ZxrHcQ5vL6?= =?us-ascii?Q?H76qNiVdcMmpk5XDxEp7k5AwWvZiG3YIik6ar60YWagEQ0Q0pIl0UXKNfDiD?= =?us-ascii?Q?avJzqqwfW20SScVUOBbI/9vq9TeZZxnQ31/9BIqGRdoiyHSsCQGAZ9hhMMzi?= =?us-ascii?Q?p5Sn2fr8TMTPcBWy1cn1Y86pGdNaQQ2u6bnQDp5I9qRri0s9Jv5OSmF+GElJ?= =?us-ascii?Q?6+8UF36OWNyfE0G+8WL9kSs2YnUbEUubIP5yU/LxYkDFGGhLyTD9ZPMtfFkZ?= =?us-ascii?Q?6z1WBdF3P3EDxhZknXU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 156c1d46-c89a-44ae-7bf1-08db4f91d4cd X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2023 06:59:56.1965 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mv3VI9uHlR7WlVSI6WRUG+AKEMkrUxnDGVYpXW1oRAWS3J3QEgz6H8uCPyoSydAzxn4EMWSFyKpn4PRoBwOG6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4987 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: return !dv || (int) GET_CODE ((rtx) dv) !=3D (int) VALUE; } is able to fix = this ICE after mode bits change. I will re-trigger the memory allocate byte= s test with below changes for X86. rtx_def code 16 =3D> 8 bits. rtx_def mode 8 =3D> 16 bits. tree_base code unchanged. Pan -----Original Message----- From: Li, Pan2=20 Sent: Monday, May 8, 2023 2:42 PM To: Richard Biener ; Jeff Law Cc: Kito Cheng ; juzhe.zhong@rivai.ai; richard.sandif= ord ; gcc-patches ; pal= mer ; jakub Subject: RE: [PATCH] machine_mode type size: Extend enum size from 8-bit to= 16-bit Oops. Actually I am patching a version as you mentioned like storage alloca= tion. Thank you Richard, will try your suggestion and keep you posted. Pan -----Original Message----- From: Richard Biener Sent: Monday, May 8, 2023 2:30 PM To: Jeff Law Cc: Li, Pan2 ; Kito Cheng ; juzhe.= zhong@rivai.ai; richard.sandiford ; gcc-patches = ; palmer ; jakub Subject: Re: [PATCH] machine_mode type size: Extend enum size from 8-bit to= 16-bit On Sun, 7 May 2023, Jeff Law wrote: >=20 >=20 > On 5/6/23 19:55, Li, Pan2 wrote: > > It looks like we cannot simply swap the code and mode in rtx_def,=20 > > the code may have to be the same bits as the tree_code in tree_base. > > Or we will meet ICE like below. > >=20 > > rtx_def code 16 =3D> 8 bits. > > rtx_def mode 8 =3D> 16 bits. > >=20 > > static inline decl_or_value > > dv_from_value (rtx value) > > { > > decl_or_value dv; > > dv =3D value; > > gcc_checking_assert (dv_is_value_p (dv)); <=3D ICE > > return dv; > Ugh. We really just need to fix this code. It assumes particular=20 > structure layouts and that's just wrong/dumb. Well, it's a neat trick ... we just need to adjust it to static inline bool dv_is_decl_p (decl_or_value dv) { return !dv || (int) GET_CODE ((rtx) dv) !=3D (int) VALUE; } =20 I think (and hope for the 'decl' case the bits inspected are never 'VALUE')= . Of course the above stinks from a TBAA perspective ... Any "real" fix would require allocating storage for a discriminator and thu= s hurt the resource constrained var-tracking a lot. Richard.