From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by sourceware.org (Postfix) with ESMTPS id AF7023858C5F for ; Tue, 5 Dec 2023 07:20:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF7023858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF7023858C5F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=198.175.65.10 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701760806; cv=pass; b=TOe/3zhfGqsCe1LHDiSIkfDgLdyXv39JD+lt5oX++NKiYIrWrRKcdZfJndg2t8WbjOnDcbKfjR5v+K8MgE3MPimgZx2qdi8ZrGV6YuaPTckCxgYPdhrvu66SroZvEgym+SiYynLIAgUzBAbghdxL4p70+PKen187v0PIfR+0rDE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701760806; c=relaxed/simple; bh=C8QqL10xiVoXUrd9uQmc3UVfXRNftc9PXuxf9zTnfV0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GA9+4znHYRYwsfaGbZN+l53M00uGTFQgXh1hMjG2fKpLV07GURLivTwngDoClYCfh+zV+nYu7eg20StXC3dzCYOuQNRf7Dn17YmrWt6wbZ2W5opYBdlEnR4aiXg3C1rufNZx/hT4+YQhdI/e8WvXSDjmLKojof4vsRYxaXS1r9Y= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701760803; x=1733296803; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=C8QqL10xiVoXUrd9uQmc3UVfXRNftc9PXuxf9zTnfV0=; b=DZN0XkgaB3TLZxlHklZw7D504y4LUlI3G1pS2svIlV6I5a4icmLqAiSA nX54Q74PuJ7nC6zP/1SmU9HJyR433fXWsCQyOUf35WBGad9UPwb97lAQR PJGHHakm2WusjL663IuNdi6dhbUP73+QK9jHXupQQjPQjQcIC4McDAvGL z4/DSNR1yCx1dj3xprULQBfCDDIpFfAXQMhg+dfymbTfshqJYfySyDrp6 LWuzlSRU0AEoKv5TAMy7f22akO3yVkB4yOHdWWBzSLw2LpTdHkEqNl8CT 2S7ojHWC/I9CDZUcz5Gcgi2M5h4Wx/ZhF6EpGe511y4/i6faNx+CiJecy w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="7195404" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="7195404" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 23:20:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="894278183" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="894278183" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Dec 2023 23:20:02 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Dec 2023 23:20:01 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 4 Dec 2023 23:20:01 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 4 Dec 2023 23:20:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oO86PZyOXhyfLMobVAlDEvuhmUFRQHH5DeLU++YmEKcLeGVNAUr94BbqzeDDFPcI5FmVE/mdnF3K44kDsTSYyhvVb4ShI36jYdboXoR91so3z5hDyu0TqiXnFYyMOFBF/u16xgySzBNQ71+7Ano3jbbZkb+f79v6OV7To/jzpPnrLzCnQ1b49ij0VXF6qpXXfKMpFJELdYcpF7eoC9+IJLQ0VxBGQHfGFICYD8GQ/wEp0xDcAs34mIMNc1DcDI5CZvIb7TXgnP/s5r9JJR+jKpfE/0Z0eGUso87I0pRcJglhBo980YfK3BGFEDMa0C6ZOah2NHsMquzCa4ZBFvE9OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a8TdJAOwdVRypgSe+HK9etCITyYJrwIwVbqEN2Kjj4c=; b=DUynkdb+QUSOuNjhK7NVOBUfD8kVlg3NtIj43GYgzxl2clEHJLohOWvZeczFB0rXT/rTQU3j48IrG9SWK28NM3a2qiJoSY7VjXppd9mlV/kjwhYGV2ztpbZVlnYMAbUr+WZeSVklhk1v3FPuLIQIjgo7jPUJox5IjhoqEDClP+ddM7i8jXjOp1b8rU1BbCS6XZ+6Mm2Dl58rX4CkLEEsK5IJJ0AOoSjqt4WSBOrJaNos+H2F6rYf11OeEDSOmvRfleciutxdsF8FAAXvzwjQnbeWr5vUpAKfbYKdIC7zNRNYk14Z1sDrPEA2bMCpFMVh20kencqFiNDE7AOX3Q7wQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by DS7PR11MB6014.namprd11.prod.outlook.com (2603:10b6:8:73::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33; Tue, 5 Dec 2023 07:19:54 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::4317:53a0:2638:358c]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::4317:53a0:2638:358c%5]) with mapi id 15.20.7046.034; Tue, 5 Dec 2023 07:19:54 +0000 From: "Li, Pan2" To: Richard Biener , "gcc-patches@gcc.gnu.org" CC: "juzhe.zhong@rivai.ai" Subject: RE: [PATCH] tree-optimization/112827 - corrupt SCEV cache during SCCP Thread-Topic: [PATCH] tree-optimization/112827 - corrupt SCEV cache during SCCP Thread-Index: AQHaJqiaC8Ooe7Hcd0qrRvY8bQqsRLCaRgcg Date: Tue, 5 Dec 2023 07:19:54 +0000 Message-ID: References: <20231204115340.CA9C813588@imap2.dmz-prg2.suse.org> In-Reply-To: <20231204115340.CA9C813588@imap2.dmz-prg2.suse.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|DS7PR11MB6014:EE_ x-ms-office365-filtering-correlation-id: aa4554de-438a-4a95-c44b-08dbf5629429 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FeX0YAyo+FAgItTNFU7VNmc8qQYTo/mn+8fd3jY0U6oQcKbioKHUV7QY17R/UaVXSYA1cb/0MqehCTKBh6ipicnRxcOOcYOhkLYvN83lwicxhI8TqiQ78pQkxCqqk0adNlkyzmSIYga9QcDDaDdymyKgYNWX/GmH67ijBlBJMVkaOLUa90VZEXDA4b3XXrjWiMw/L3/jb/bd2yUCQ5mlf91nI22lacwKdDwQ4g7prmc+dsXh9LyNjCi0wQB/1YOMpRdNTHvMBgY13rGsFEj24yEz7L19tmqKROTJrtra3xaR9oBrBsKUrVXUQl/jubqndmARi7aSNHdBmhGB74wNqYtg/qNWZKGak9MQ1Ce5BLbZQhRsmFJQaiZNgvxS7aX895I5v7wsioorK+25WZnPcMjcJdgDDW25B/sHZCixfvpvJ4w+bu3DrkSmlHZyEkVaMsjIJJlqi1NFV8nbPuoh405FiVo4TNHVOVCEI3X/MCOuqIIkNWub7giZPoE+POIQcP+iRwE7SX+K8I/0vVgU1VPIiJr6jpjqiiR/gId3+eZaGvhtzem16otuk49XoT7j7l6W93rZPfLaIgKKmwgdYf3rq0Ye9bKWi5vcJpBzruZJ9dHsD6yma2bShSYwbwL6W56ak76OQiLhYJ8xZVSyYw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(366004)(396003)(136003)(39860400002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(26005)(478600001)(83380400001)(7696005)(71200400001)(6506007)(9686003)(82960400001)(53546011)(84970400001)(316002)(66946007)(110136005)(66476007)(66446008)(64756008)(76116006)(66556008)(122000001)(38100700002)(55016003)(5660300002)(52536014)(86362001)(4326008)(8936002)(8676002)(2906002)(41300700001)(33656002)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b3+w6qqemhtZ3OqaCDaKSr4ZuLYpAGWrF6e6+H3hT/UQsFVW6fS/3EXysW0z?= =?us-ascii?Q?oRxlnCgLwDwcrcL4xrGRoBEjwxuaBDzjoM/xJa9MyuUqhJXna6qB/F8dTVEe?= =?us-ascii?Q?TXkKIM44SDJdOtkdIo+wbzCvt63AHhjNn8Q6IA0Etmt5gGNWxJS5Kt7m9JUD?= =?us-ascii?Q?vmg+Ty89P2DadJp3W3EluOwTtkiEAitTtphk+5ZBOTt5sEtZdLSheMNkGCGg?= =?us-ascii?Q?il5mQXo2qFUznQ/kvPYSAmNv/gGO/KuyAZODQMDNQHgoAZq9VAedrw/wdfNy?= =?us-ascii?Q?/1YFOtIEplvjUzPGNGRhzXzCIQpXgKTd01EKu+x+Tndgjzh3xbs8aWh29Hz6?= =?us-ascii?Q?grpR8edLTJMjrxOLPqWj8qCLKpflrjXCOfKjpz8gR1MU+PTgZrymk4Ksfwma?= =?us-ascii?Q?wU8vqMiONOM5mKDbmoJBZ651n+i5+F50vEn/d9SzwDRs+D/3GsYJBFPPqsQS?= =?us-ascii?Q?CvaShGYUxiKlOgu8/qvhnpl4tfrHOMo3C6jkqPVKcznW0ar/z7wxet96SmhK?= =?us-ascii?Q?UNjT3HbnwqBk4MrRrKyrUyO5qOovAvUaZ5X5b53t2O6R2/iHjBlOnYv2c/Ec?= =?us-ascii?Q?Lkbw/zBh9goiIl256ogw9e5u8CMo80rBAMyWBGsmrLEYcTQz/UQDaKdxcT9o?= =?us-ascii?Q?n22HDKmTe+na21l6dL7R1uzH/WUSTudrJude6GMCjRQhrsvv0FJK6oul9JNg?= =?us-ascii?Q?A+AsRZkDkES6ZT7HuziKwfA68+ZXxDv2JbWbtgPXd0esrAmgX0f8UH0MzKsY?= =?us-ascii?Q?YQlfaB2CP5WyNkn9P15NR+Wh4XXf/CmrUVhotPrATcs0jz/tWBHXq45rlsbT?= =?us-ascii?Q?YLq1TOA6/r7QLj2VDs05iSdjxxA3JlBm5jHIczUwVl8EsM/B/1nYDo0ioLrz?= =?us-ascii?Q?t3YRT6rGIIyuQnxosIyv+bGithmkbwrOgbciFqRXMmdhqJoJJDaKE7cVZgC8?= =?us-ascii?Q?5CnX++Yyp39H/d6xPjw1zUMrRyNt4uezq0pzYJaUPR8FKCJhGKfRKdxEnBb0?= =?us-ascii?Q?CbWeVTRJbSys4ZwDggiYCtM1eD4btghM75M9LQiHCSO7I1BWqIIu0/60AxGb?= =?us-ascii?Q?HWa4euPvuB7IAGy8eJhXgaGPecAX/2EqG5sLJpqnDMd2Bud/x/7ROKycFm4Z?= =?us-ascii?Q?seqLd/ODnwxCiSdHEaOAV08wwMv3SnmB3gakyx24PGjcdcZfdTV4J56A2w5U?= =?us-ascii?Q?DojTDEyeIeh0lwLu783uH3GP2CkEXnnrSrS7iIMuu15Hd6E7xGdkzH+CIIMU?= =?us-ascii?Q?Pi++37U6CsLKAi0OhLmbPju+EvluAU0+z2266mP73pbvpRJkFEtA+VUGznGQ?= =?us-ascii?Q?tCCnPBBgL6Gh0jvl/z0Ljhzg5Ro5yCPzVrdGrDK2tbd3ilzJCC+iV0tczi5s?= =?us-ascii?Q?uXEywta95AKqzglRkbpqFhGx0KwbCfxctEz+nbpnhAyuIHmEnqOeosS+7I9/?= =?us-ascii?Q?2ouiloNXrjz/cO0RIatpXHW7N8UUePSKHywEbtcyQUU71Ims7TIeW9TgPq2Y?= =?us-ascii?Q?4ua2Ti+WptQz1CMx/TArQnlQqO+CXG1ds+pV2IN4NIFn6uQlpx3NdSL/5ex+?= =?us-ascii?Q?TzvaYW4tSdfeUWBa5AI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa4554de-438a-4a95-c44b-08dbf5629429 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2023 07:19:54.4398 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ixM1XQYqI8sV8b+cFO6fdBH5NgqCe7S9bQHyLTTo2iVhpYxGn5IRiXtCr7gyxaik9+/gXosyR3OtSSRKY6U3Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6014 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, It looks like this patch result in one ICE for RISC-V backend for case tree= -ssa.exp=3Dssa-sink-16.c, could you please help to double check about it? Any more information required please feel free to let me know. Thanks. compiler error: Segmentation fault 0x1903067 crash_signal ../../../../gcc/gcc/toplev.cc:316 0x111a24e loop_outer(loop const*) ../../../../gcc/gcc/cfgloop.h:549 0x1ac2143 find_uses_to_rename_use ../../../../gcc/gcc/tree-ssa-loop-manip.cc:424 0x1ac2295 find_uses_to_rename_stmt ../../../../gcc/gcc/tree-ssa-loop-manip.cc:464 0x1ac2456 find_uses_to_rename_bb ../../../../gcc/gcc/tree-ssa-loop-manip.cc:495 0x1ac2585 find_uses_to_rename ../../../../gcc/gcc/tree-ssa-loop-manip.cc:521 0x1ac267c rewrite_into_loop_closed_ssa_1 ../../../../gcc/gcc/tree-ssa-loop-manip.cc:588 0x1ac2735 rewrite_into_loop_closed_ssa(bitmap_head*, unsigned int) ../../../../gcc/gcc/tree-ssa-loop-manip.cc:628 0x19682a3 repair_loop_structures ../../../../gcc/gcc/tree-cfgcleanup.cc:1190 0x196831d cleanup_tree_cfg(unsigned int) ../../../../gcc/gcc/tree-cfgcleanup.cc:1209 0x16e654b execute_function_todo ../../../../gcc/gcc/passes.cc:2057 0x16e534d do_per_function ../../../../gcc/gcc/passes.cc:1687 0x16e68b0 execute_todo ../../../../gcc/gcc/passes.cc:2142 Pan -----Original Message----- From: Richard Biener =20 Sent: Monday, December 4, 2023 7:54 PM To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/112827 - corrupt SCEV cache during SCCP The following avoids corrupting the SCEV cache by my last change to propagate constant final values immediately. The easiest fix is to keep a dead initialization around. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/112827 * tree-scalar-evolution.cc (final_value_replacement_loop): Do not release SSA name but keep a dead initialization around. * gcc.dg/torture/pr112827-1.c: New testcase. * gcc.dg/torture/pr112827-2.c: Likewise. --- gcc/testsuite/gcc.dg/torture/pr112827-1.c | 14 ++++++++++++++ gcc/testsuite/gcc.dg/torture/pr112827-2.c | 18 ++++++++++++++++++ gcc/tree-scalar-evolution.cc | 9 +++------ 3 files changed, 35 insertions(+), 6 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr112827-1.c create mode 100644 gcc/testsuite/gcc.dg/torture/pr112827-2.c diff --git a/gcc/testsuite/gcc.dg/torture/pr112827-1.c b/gcc/testsuite/gcc.= dg/torture/pr112827-1.c new file mode 100644 index 00000000000..6838cbbe62f --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr112827-1.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ + +int a, b, c, d, e; +int main() { + for (; c; c++) { + for (a =3D 0; a < 2; a++) + ; + for (; b; b++) { + e =3D d; + d =3D a; + } + } + return 0; +} diff --git a/gcc/testsuite/gcc.dg/torture/pr112827-2.c b/gcc/testsuite/gcc.= dg/torture/pr112827-2.c new file mode 100644 index 00000000000..a7a2a70211b --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr112827-2.c @@ -0,0 +1,18 @@ +/* { dg-do compile } */ + +short a, b[1], f; +char c, g; +int d, e; +int main() { + for (; f; f++) { + for (d =3D 0; d < 2; d++) + ; + if (a) + for (g =3D 0; g < 2; g++) + for (c =3D 0; c < 2; c +=3D b[d+g]) + ; + for (; e; e++) + ; + } + return 0; +} diff --git a/gcc/tree-scalar-evolution.cc b/gcc/tree-scalar-evolution.cc index 065bcd0743d..7556d89e9f8 100644 --- a/gcc/tree-scalar-evolution.cc +++ b/gcc/tree-scalar-evolution.cc @@ -3847,13 +3847,10 @@ final_value_replacement_loop (class loop *loop) def =3D unshare_expr (def); remove_phi_node (&psi, false); =20 - /* Propagate constants immediately. */ + /* Propagate constants immediately, but leave an unused initializati= on + around to avoid invalidating the SCEV cache. */ if (CONSTANT_CLASS_P (def)) - { - replace_uses_by (rslt, def); - release_ssa_name (rslt); - continue; - } + replace_uses_by (rslt, def); =20 /* Create the replacement statements. */ gimple_seq stmts; --=20 2.35.3