From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by sourceware.org (Postfix) with ESMTPS id 4FBB5385B501 for ; Tue, 16 May 2023 15:39:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FBB5385B501 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684251566; x=1715787566; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AJvSEnyukOxqi6EGEUwRhylKqU5x3HBevKLWiaE4nQQ=; b=F3WlNoGBc/Y9YuqRgzXCuGK3igdsa6gLR4CCCW5myFmNRG3AkDCs4C79 GRwn36JK3YzZG8fwSoWLXLvUgCjulxnwrSXWkgMOu/LE/xCAuAB6LDTkX dvLzjBljJ9eL9Q6w4MzMvEtlNLsAOg0iKkAWXLDSlULF6YBTGWplTtFQT fjtKQQPnxP3MGjTgLxM65Gv5IjFVUF+KEEaluNbT3S5CTF56fI6TOBA4E 135qvtpHFUDv6BTArtvlTKyzWaVV3cHJKRu/RviSrY9j6FkC4GAklFpVa q8q8GoXB/f56uhtHGTBRHaHLJU2b319vMr9vWgtLgpBzzRHIIXp3vFWks g==; X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="340881120" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="340881120" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 08:39:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="813479070" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="813479070" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 16 May 2023 08:39:24 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 08:39:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 08:39:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 08:39:24 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 08:39:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jmPTPtpjppkamX7LQfOBj7VR3Qwt7ASR2RDS5/PU119ZaU33jfUiioDxe4HtVBEibuenXGAwhLfH04PHRJXNKu7u5eGWMqCnC+i769QfJG6S9i5Eh0JbqS7lKJiEi2e3jNUPxnvgG10QQGQuRl1eNK1lRoezSe7vpaK3o2OEAOG+vxbJMm3f22QHjws1qQ/J98Q4Tvcp6Mfs+CrU9A/o6dfcB9TwV/g1JzYPsNtsZvDV5sPOcwJXmBJ/H1zfwUVxgCcoGUJZf2WLJ3csQjRaH053miCZwk8lzvO831eZNUSR8R5ejeP7UFz5h7QXwQFGsnc7ztz/Gx/pSMt+aUVyog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nos70auRnNS3jYXRhxhA6LahLLW0w7lGKafUjvCMFP4=; b=fAWtEOJASvosg1LleL2PoGDdr8A7yZIYjTDGc0FXA+DBVXRnbK6l3TGNhCmnBX5nXv+xs0p2WUo8YexUHE1wtYnom0sgohZM/2pVY6ZRcpHM3BPyLuKLEmNeqyOwv9Kz5zb/pWMQUNDTDep8VSB+iWqfJYn5yzkkH7R0AiX+jKArx4qsGB7b7dMRv1t4GzppHI9l5HDpWP0mrSbciP0DHZ8tV0pYGmguvCPFWcA29aYJuThJNJSxvnNuB/E1gB3o7pFVYsWwLHL6R0hQDcqvLWgmK2ai7qrXPZvaPbml5xEt4Ks2O4htI0ZFJ1L7fo05d07hi/gUY6HDHtG1g+XaHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SA1PR11MB8396.namprd11.prod.outlook.com (2603:10b6:806:38d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 15:39:20 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::bbc5:f013:1f53:10a9%3]) with mapi id 15.20.6387.030; Tue, 16 May 2023 15:39:20 +0000 From: "Li, Pan2" To: "Li, Pan2" , Richard Sandiford CC: "gcc-patches@gcc.gnu.org" , "juzhe.zhong@rivai.ai" , "kito.cheng@sifive.com" , "Wang, Yanzhang" , "jeffreyalaw@gmail.com" , "rguenther@suse.de" Subject: RE: [PATCH v3] Machine_Mode: Extend machine_mode from 8 to 16 bits Thread-Topic: [PATCH v3] Machine_Mode: Extend machine_mode from 8 to 16 bits Thread-Index: AQHZhZy5KDlJLdzko0m9KcEdCFzeZq9coQbGgAAyutCAADl1wA== Date: Tue, 16 May 2023 15:39:20 +0000 Message-ID: References: <20230512050016.476110-1-pan2.li@intel.com> <20230513131325.1667305-1-pan2.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SA1PR11MB8396:EE_ x-ms-office365-filtering-correlation-id: 9ab3755c-a687-4f71-37a8-08db5623b79e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VJx13SPJ9mRlkkruN4QbU0MkFSHoB6SbSeMDlDPNBYkFQPrQh0QQEFWWwm2iwvEXc9U0ux6u30Zn5Y4PSdXKDQbtCInD+nimw6RB1Hh/UxuaT7W4VnisP5eM8r0Ad/Fs8BdVzBWMeESCZdXW/ifimJDgvgew+jtJrUukyaxhFna56paHfGlADvgLOuthNTwWDeUGI1PFzzllEpgCRLRjxJp3MFjgjUbdq9f7BxSxmYp+rmCD0oBYGk1v/qziMR10xvvvTKzZFkunUFKRNEg21BFfK/EzsfGvyd4moyO/ij7ojC2qbFwyTXDOuGxLEKf3/Mmw74CaO2dM43e5ha2KkK4DWxn+mXbHUtpCfb2cppQr13VPiyWYU+vIrROV9Zc2w9fZTs6wxUACR7enw7JsIBJiGICb5dmZeB/3Aocfj3VylPTVGMOrpVexLJvefxZFMaX3wOvXWLGY5hk8O8EcZs1GP0/tUZsjzGhHqeESaiSiw0Gp1k8sMHQhN9Z7bC6rC3I3OF6/abu+hN3SlqUtSZzBTg01XUj4G5R8cV4wpjJv54RpZjdP6RMVdSMAtpnNRpeewBH1eeKZyug7dBa/4pIFFRRc7RdvQwdwXx7tDec= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199021)(7696005)(8676002)(71200400001)(8936002)(38100700002)(41300700001)(83380400001)(478600001)(82960400001)(54906003)(110136005)(186003)(76116006)(2906002)(26005)(38070700005)(66446008)(6506007)(66946007)(9686003)(53546011)(2940100002)(66556008)(66476007)(86362001)(122000001)(33656002)(55016003)(316002)(64756008)(966005)(4326008)(5660300002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nOrW1F48+HDV0ToX4G7T88cfeQZ16sPucVXMg7LsJNcZAIwcdTnY/1u/NYPQ?= =?us-ascii?Q?NrSzxGo9bsMDiplXqeyibEYZJVx3sjPQ7AV/3o0sIjDmv4TcfJsBZh8qvMDq?= =?us-ascii?Q?L96HDL9F76xD8apM2q81tLUfxZCoKSErNyceADLTJYgFUKkNdn8AwQxVbBrf?= =?us-ascii?Q?r9d0EyHS1vcGomHdw5e+wWwDPWlyBLgs2DPR3wweCXwE1JrBKdEft+1hC0Qw?= =?us-ascii?Q?pkmqGG1lhfWCWKvdFwGhBMSlQ06C8jPFjTWZUfzQlKCXac7CEK2xZfVu09/w?= =?us-ascii?Q?BO0pWfVm+HyWgRNGR+u4iZKMnl2d9kD+9gD/6cUMcGzpI2RICe5PnVLMfuHg?= =?us-ascii?Q?4uBAbmzx4ikCBopPwoyczYTRCUOooIDA/4KqzkisKNaQ8vcIHBCrC8mvMvjr?= =?us-ascii?Q?yuCxfjTLTca8U5r8eIt7VrYhZRrXElkewmSVCDE9vxqwY0zk1KMlb0tbJRfW?= =?us-ascii?Q?4uIqPeLQXY9r8j8Oj8hvBDZpZI/Hwszk9hb9Hmv5wvLhTbLHqgJvmdTlFAyU?= =?us-ascii?Q?AQxCHiVMLm/BH5uS1pkI0UJgq+zrq2L6p8ITsdjZ6JwBbZZamAddlTOfYTLT?= =?us-ascii?Q?1nGbvT4eOYn6GZOSPylTqKZKlb/XABllYLRkP1DoNQzZZRqlCUbT9rl149IL?= =?us-ascii?Q?EWpUi90VwKH+OOC4Q+OVg/oo6KD2NZdiiHV7bA+hryX0iLH8PXG4Nmr2LZSS?= =?us-ascii?Q?+YntRJ+eHz+okb/vQIREGHzYKea7qvyeYPAdEULyN3fGfY7UaaS+FV3cfORM?= =?us-ascii?Q?T5ssElYZLwJQ3jXpZD/gKws8M55/0lpsakKlPVr0ur6aCmZmSfPTbmoFgUqo?= =?us-ascii?Q?ZSzYmeL0V9fq8ALBmEgTH1vosUTAVTIYywOQHhR1/npJgqSRPg88EcObsA6p?= =?us-ascii?Q?ordxsbXxWF6E1KeN2kLInBu7I1kVq3qXvjfmiYEL7GuEMq/L4DviLBEbcGtd?= =?us-ascii?Q?YSMOIDms8lx6b/IiMgdLN7sHagSrfk2b6xM/DRfrolXub53I09gRUfvPfSwe?= =?us-ascii?Q?8dmbEELDyRktaBs8H37Ek75vOS3HhChed+FB4XHyoYnM8s9pn4Pu/1uEtEkq?= =?us-ascii?Q?hsnc5JVx1dM2DYgxMa3q35RKLon3DNV/90weaCl8wvKeQHFrx0CCXaevDSki?= =?us-ascii?Q?yiTeQ5s7qkp66wBzw6RLXRxmG6KEdR70yqiWxgbfucr5FjQEiPPO0CB6UJS/?= =?us-ascii?Q?eGq9TKrEAiDEg9x+1OsTWYDdmVUarvf4BIZdmPZBO1U1VE8Jd/XEQGty3BLb?= =?us-ascii?Q?kHNa3RgpMTP2AX3nHDiFg+pNCHPqY+9idfJVzmsKcLMZdAnEfaCIj0w7tf4/?= =?us-ascii?Q?Apm5XSEUnxy/U1vCFxIFfmPlTsmi2LFymeNw3u7T+Vj6z8xsvtJU0azgpl0n?= =?us-ascii?Q?OLR4cqhrPqE9ZckZ3Ih1WWO9ofXCMvZ5ip/ZFqDXcR9xndMLq2cpyyoW2Sh0?= =?us-ascii?Q?uHs6lQkeHsJ37JDoZ+3tlbK/G0di3bHu8WGgxpc+wRcO8r6iWDdl4/NpCqng?= =?us-ascii?Q?+rZ2AXI2B8nGTmn9jsQgBx/a8oXG9YuQkxnjMLnMeQgFwOCwvPcfupADPVnL?= =?us-ascii?Q?D3lkGTwz/t4LFh+kgslYWkbPhMVXAA8j8Jy8L2Gf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ab3755c-a687-4f71-37a8-08db5623b79e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 15:39:20.7164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /WA3+Q56vwLY+E07e0neHXTtbe2oCqVqJ6jbMgVk2koUuJNtY+FdZdqlR8wejy3P576cn1E9sd+X/1nAiRiZLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8396 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Update the PATCH v4 (I am sorry, missed the v4 in subject) as below with x8= 6 bootstrap test passed. https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618742.html Pan -----Original Message----- From: Gcc-patches On = Behalf Of Li, Pan2 via Gcc-patches Sent: Tuesday, May 16, 2023 8:17 PM To: Richard Sandiford Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; kito.cheng@sifive.com; W= ang, Yanzhang ; jeffreyalaw@gmail.com; rguenther@s= use.de Subject: RE: [PATCH v3] Machine_Mode: Extend machine_mode from 8 to 16 bits Thanks Richard Sandiford for review. Yes, currently the class access_info will be extended from 8 bytes to 12 by= tes, which is missed in the table. With the adjustment as you suggested it = will be 8 bytes but unfortunately the change of m_kind may trigger some ICE= in some test case(s). I will take a look into it and keep you posted. Pan -----Original Message----- From: Richard Sandiford =20 Sent: Tuesday, May 16, 2023 5:09 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; kito.cheng@sifive.com; W= ang, Yanzhang ; jeffreyalaw@gmail.com; rguenther@s= use.de Subject: Re: [PATCH v3] Machine_Mode: Extend machine_mode from 8 to 16 bits pan2.li@intel.com writes: > diff --git a/gcc/rtl-ssa/accesses.h b/gcc/rtl-ssa/accesses.h index=20 > c5180b9308a..38b4d6160c2 100644 > --- a/gcc/rtl-ssa/accesses.h > +++ b/gcc/rtl-ssa/accesses.h > @@ -254,7 +254,7 @@ private: > unsigned int m_spare : 2; > =20 > // The value returned by the accessor above. > - machine_mode m_mode : 8; > + machine_mode m_mode : MACHINE_MODE_BITSIZE; > }; > =20 > // A contiguous array of access_info pointers. Used to represent a This structure (access_info) isn't mentioned in the table in the patch desc= ription. The structure is currently 1 LP64 word and is very size-sensitive= . I think we should: - Put the mode after m_regno - Reduce m_kind to 2 bits - Remove m_spare I *think* that will keep the current size, but please check. LGTM otherwise. Thanks, Richard