From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id 4385D3858D28 for ; Thu, 22 Jun 2023 00:19:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4385D3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687393175; x=1718929175; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tFhRjTu+B1VKl9ooSIzzrJa32qLZtVJtzjPDZicqPLU=; b=I/N+nS45zz9h8OR9tkXfwa7/gcOI7CTcWnT2zGAKetcgIYtovjguoQuU 8xZErdem0xHusZx8hoVmPvnOk4hkNZ22ueQlAOc6sWv3jtlRkYSU1waae uerNfvHWa6NZr6QcNIbxPRwUXr9y7+sxWgDmzBvlwfr0vuTH8NfDrZ5Bn +WjsLfKDwaY38mTYt1FDLOtWcYBsfezPg/dqYl/idIe3CY5prjPka8YUW 5B5zVRa1aCVTluosNaeii+b1f/5ybXsv+88DyXwrUhMgoHfLtr2LzF7Mi nSUWP3Yk+QCYq+Nkxsg6CCp/j3Shg6bNbL6TFR2OjGheN1postC7N+349 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="424012175" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="424012175" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 17:19:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="780020407" X-IronPort-AV: E=Sophos;i="6.00,262,1681196400"; d="scan'208";a="780020407" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 21 Jun 2023 17:19:23 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 21 Jun 2023 17:19:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 21 Jun 2023 17:19:20 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 21 Jun 2023 17:19:20 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 21 Jun 2023 17:19:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0U/z+jd7toib02dTbxzVFqzJ3nQPzpA9YJk5YxdZZ52GqAKw6be7dAt+6bCZSywPrQ0BlQZhMffzYm7fd7zVuLJ/ztdF2qXN9NZTGmJshr4hsX2fzzO5MyN+YJb4HgFkv4VncOG/yS518e28mnq31NyfvdQb+31t17u/b6Ano82+CAySRQ+anxeVNet6wa4sQETFHUfNLuXXsRp+dcLBhdfiXmvyDPlONt84hOiXSVhQ/Fgp3urxxQ6XcDhBmNrebl7lBAtxVdYakTQ0myd/KMg8D8cqFFt/jy8HWNzMhD0jcgU2izxdLdKwWR2Cy4hGi/4Vv1/bnRevwffDb4uOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jRNo5s+B5EhjgQ68qASXy0BUYzVLZ1iDe9sSbguosqc=; b=hEmGGTgbOjm0htGDm6FUbn3/AbZOXCEjJgwzCFumsxrkw8XBtDtJs10PUsAi1jtaEUNHdWWli5wVx7jiBLRSdR0wLhr3XDSNb34gXI/HoAAP9aDcy0YM8sD3cRcviH5ePxcGB1oiTjdNeiOSw99MVLMaSgjiU1bho0+Kar4eMAKKH7ZmJclqFbGHyWJcn0nYCnnwf0FY+kDYulejui48YMo/kkw5fjiOq85q/uxkUR7Rq95mpmlrTMpnJhswmhlr/1foJVXaBocMX8FuBk+InZNUiByzHetitTemQQyQcHmPi7kP9JUGpdlZApGjaZnFaNsvRoqip9cpC6s02S4fyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by MN2PR11MB4727.namprd11.prod.outlook.com (2603:10b6:208:26f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Thu, 22 Jun 2023 00:19:17 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::127c:f4cc:e699:8f73]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::127c:f4cc:e699:8f73%6]) with mapi id 15.20.6521.023; Thu, 22 Jun 2023 00:19:17 +0000 From: "Li, Pan2" To: Jakub Jelinek CC: "gcc-patches@gcc.gnu.org" , "juzhe.zhong@rivai.ai" , "rdapp.gcc@gmail.com" , "jeffreyalaw@gmail.com" , "Wang, Yanzhang" , "kito.cheng@gmail.com" , "rguenther@suse.de" Subject: RE: [PATCH] RISC-V: Fix out of range memory access of machine mode table Thread-Topic: [PATCH] RISC-V: Fix out of range memory access of machine mode table Thread-Index: AQHZoo1G5H0Lv2r9XkuUWLbdvLdQGK+R2HQAgABIDhCAARQ0EIAAIaEAgABlIPCAABZlgIABA1ZwgAAGNICAAAF5IIAAYoxg Date: Thu, 22 Jun 2023 00:19:16 +0000 Message-ID: References: <20230619080710.1536456-1-pan2.li@intel.com> <20230619090548.1574008-1-pan2.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|MN2PR11MB4727:EE_ x-ms-office365-filtering-correlation-id: 2cf5d1f2-3a41-434f-6564-08db72b650f0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XJCz1GNI4Gc/ViKfZRfGhJuRSX2LK91YvDxQLnSvsS7bc+6LooN+Xc8Ff4d7kwZc77+BXft299iKk+QXKhgyp8Dp080e98W1b2pI0jhF2rRqQgd7OIi7BtffQy959r63oP9wynPeFHqEq92ne2M1Ju9qhEI02Krk0G3YLkooCEgtyVVT3d5SDLVs4FdWB2GIoMdgWacT61D9SdnA+fzY5aDV6LtZnLExiq256eyxvsBrWuEe5BBJjEP766HD7WIfifGtI0MATx4idbyq6bRfrLQmtnHqGF0rQI+m6m6JJ7rEBXP0I6pCwy9QzE3EJwKUuw3ZEG9Jns0ylhiCxJ5vh8VgyH+MDOAMWAT79s5sUZq0vsWpUNFuzkeG09KIjsmlFvucym/WucOXQrIAO0MtAtqfsHF8Z4ls0AC/hdPpCK+P7OTUZbmp96FK2cQC0ZopuPhtmqhc+sSmUZoDUekubOdYG3UcWLfO9F9Yf6zEr+zsTmrC72Q4v3qjWnd45jDhAm8dmxTcVUNdrN5qlMp9MM2iBnzsIGIiu/Jdm9+jKmSSjnvJJ57wLwvyRP8+C8VgZN1cKur1Q8RH5zwkdBV2Y68p1AZz/O3i2U6qv0GMzrEamHUx1OQtEgGLmqRCXO1pc2rYSZkGC9HnwDy0xW9aEvXV09MVLS1twCDF6/xh2Gk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(366004)(136003)(376002)(39860400002)(451199021)(82960400001)(38100700002)(122000001)(33656002)(38070700005)(86362001)(52536014)(41300700001)(8676002)(966005)(5660300002)(26005)(478600001)(53546011)(6506007)(8936002)(55016003)(186003)(83380400001)(2906002)(54906003)(4326008)(316002)(76116006)(7696005)(66946007)(66446008)(71200400001)(64756008)(6916009)(66556008)(66476007)(9686003)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MOj7k0coxq+hrlLg9jU8+TNUGNlDxzPjubijuYgAdG7N1GF8BeOHV3AZlxOm?= =?us-ascii?Q?5ffe8gxRWoXc6FEPtiYloS6LRlaZb+uTDiE/WidFvXZMLxefJe51AWI+/hK0?= =?us-ascii?Q?05Yak9Yzr5jQ7bj3tvLQmWRZkYhwiPfUC7T1IdesU8ZrIvS3p9BXg79kmN50?= =?us-ascii?Q?0lvN6/b+tJbKqZzfUuPz1FTBS7/uVSIYyRixMppQlmRVtLOM1TNdR1uHS345?= =?us-ascii?Q?NflLXrDKwU41/tIXD8Jgtx6aoxvMMr35hND47lkVnTjz9lIm/YrCSnNxRODA?= =?us-ascii?Q?+VnOEHJTQbme+aYvg5h256BiBiCB3qlrCFEyWnFytCzBmSr+8Ur5E+KDbyZ6?= =?us-ascii?Q?421zJpCVu5MrrU6ibSuiAOtMwGgZLYiZeBaquqhN2FbfilFjfLKh1Drh2lVD?= =?us-ascii?Q?qsDTuufryVklKMYtw3GcjhEpAPKyvrbLHLmYTEYe+XzBkrAfLOWyao+rq+uF?= =?us-ascii?Q?nujPPBVoqnn+sHbiLm+W9YLmzEUcd5JAHQ5ko5vqngzCsEwirRT/kxsUAQKP?= =?us-ascii?Q?0IGfxShCTspIRXJRCDuCFWrTKARUkv38puA8jroECnnn34/AWncz40xRXb9k?= =?us-ascii?Q?7DYgw3oSl/30IoRSw2ocoQwYvDScC598/8KO7qBBZOpmJ1AvAO6Cbr9yekXp?= =?us-ascii?Q?08KLstquLxz/K8c8YaBK/xmAQEqXF8bCwoSOLkQt/AyMpyrS0Z01X3QkF4Lr?= =?us-ascii?Q?9wf/j6MtmvReOPw9xh/WWZq/DC0wxZNikqeOb9SnJCqAQdW3x1YehZwoPkHz?= =?us-ascii?Q?ZHo+VXewJweXJKyahRpiJyKZe/XSBdt/vyD05eAlTuI/+50zCZ1PdhFN4Jip?= =?us-ascii?Q?4RwwzgCKJsoGvL3WJjf2RrFH3UxdHiUzKPPafgbxyNSYWGc4Jbr+GQJOZ8YC?= =?us-ascii?Q?mxuIJyKy6pk73OM6mJSOiBbokU5RWmmPGvzM990QfVWOSg6laH/0XdMpReiW?= =?us-ascii?Q?a5HzHfvs+iBXsY+rJt37F9xAKZNoRKx89E1pOqSEniwNICgpr9jQLLh2H5yj?= =?us-ascii?Q?XPj1+uprUm7qRIOpB1kTzkgjqPLXdY1KdAHHUsCiB4CviOzcJqMFjSfXxwF9?= =?us-ascii?Q?spRP8VTw7LdHf0TJJwcjK0pFogl+z4Rrc01s2D/j29XbC4VEA1PG8p7azCpN?= =?us-ascii?Q?gOpKtRhdGRmD02MP+aHAEOdINKtF9jiBHWMAi1Ewyae235HpglH5WvsK4Juh?= =?us-ascii?Q?5TkSNl+8eh2Khxe0++sd/5WzIHjNJnDvWSBxykuPoaiZvDFDBR98s58FMY+Z?= =?us-ascii?Q?HPyiseUcCEgE4CXSb9ehd+bIAxzF/9lHELXKjuysbTrTA4dBh872+7Al58yr?= =?us-ascii?Q?gPrWJgH4ngKewLlkQjwUdk89+W6YCJCUB9HpFHlAij6KR7SoB7HQ1TdPUvt9?= =?us-ascii?Q?pwoBpoldyAcXRTtBbwrmswI5UL3zlFV85fRKCaCcZ3eGgou/KWaNAgpT9oam?= =?us-ascii?Q?lnLpBhRQBTABhpO6pKITKmXCQCUrKTcyL+7F4c5BKPMy6lbZ42Ml9RUMvf/4?= =?us-ascii?Q?ShlfD+4UI1fiZzruJTJ2c/i0GBf3PBrJZ3AP3lERKjZP4nse0Rrk7W2AIBfV?= =?us-ascii?Q?1kcctvbMNpFuKUc6DiA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cf5d1f2-3a41-434f-6564-08db72b650f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2023 00:19:17.0358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ScIuO439iz9RPE+C5OMOl0ZZGzMb503Lzwuuo4FbMaGtTZtGl+7MQcLxioh5u1UkeeGqR/Svv6RWGeMcBBVKxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4727 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi there, I try to verify the offloading following below doc. https://gcc.gnu.org/wiki/Offloading#How_to_build_an_offloading-enabled_GCC with some steps: 1. Build nvptx-tools. 2. Symbol link nvptx-newlib to gcc source code. 3. Build the Nividia PTX accel compiler. 4. Build the host compiler with nvptx as offload target, but I don't have t= he GPU, then drop the --with-cuda-driver=3Dxxx option. 5. Run command for building, aka ./nvptx-tools/usr/local/bin/gcc -O0 -fopen= mp test.c -o test.elf. The building complete successfully, but looks I cannot run it without GPU, = and I am not very sure this is good enough for validation or not. Pan -----Original Message----- From: Li, Pan2=20 Sent: Wednesday, June 21, 2023 3:23 PM To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; rdapp.gcc@gmail.com; jef= freyalaw@gmail.com; Wang, Yanzhang ; kito.cheng@gm= ail.com; rguenther@suse.de Subject: RE: [PATCH] RISC-V: Fix out of range memory access of machine mode= table Thanks Jakub, will fix the format issue and send the V3 patch, as well as t= ry to validate it for offloading. Pan -----Original Message----- From: Jakub Jelinek =20 Sent: Wednesday, June 21, 2023 3:16 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; rdapp.gcc@gmail.com; jef= freyalaw@gmail.com; Wang, Yanzhang ; kito.cheng@gm= ail.com; rguenther@suse.de Subject: Re: [PATCH] RISC-V: Fix out of range memory access of machine mode= table On Wed, Jun 21, 2023 at 06:59:08AM +0000, Li, Pan2 wrote: > inline machine_mode > bp_unpack_machine_mode (struct bitpack_d *bp) > { > - return (machine_mode) > - ((class lto_input_block *) > - bp->stream)->mode_table[bp_unpack_enum (bp, machine_mode, 1 << 8)]; > + int last =3D 1 << ceil_log2 (MAX_MACHINE_MODE); > + lto_input_block *input_block =3D (class lto_input_block *) bp->stream= ; Still 2 spaces instead of 1 here, otherwise it LGTM, but the important question is if you have actually tested it with offloading, because only that will verify it works correctly. See https://gcc.gnu.org/wiki/Offloading for details. Jakub