From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2121.outbound.protection.outlook.com [40.107.101.121]) by sourceware.org (Postfix) with ESMTPS id 4F868398583F for ; Thu, 17 Jun 2021 16:21:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F868398583F ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qws8KSLvYxk9Dh+SjxGy1b40ra6OtvkKD+DYq4KQZeI55IUvyxKE9+SG9/+MhzqP7KGGPGrUnNQfUpxF3vBbQY/dHKjF1rGRTVod7BBtTDpPcy1C4H1nykNcugVKJpj2l5HI0A49cEf9hQdH7UTM6+edoX2fKJwAs+Pu50P833SMO05SODtlOT9H8ctrpL/lAlk0Oy4GfOICegJ+Y+hk6EHjIxJxAoFZSz4ybB8v9M6NlRi7JvyE2lLOX1ynSQpV5Zz5yLtr1J17mopfIsbV5C6cWBgT7l+Y3Q+d+SLz7Sj9qrASHyWTvwa3A5AvYqOw6JAOeJqZwNKs8+Bw+wx68A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RTa1xjl+e1j7vyoGYgQFE8nQYk+ULAh2swXTSHq2oI4=; b=WcQVVX2XDjd06VFq2664TT5PfawY2wiP9Xp89JU4hdliailDKb3ijtVjjaVYPGhJ5pP9Ebupoq7EB/+sm3PN9P+soP0wMohRpAtEZaY6HIRBdWAj3NBhEImMvBng0ZEhx5UNeEfYscGHqpJU9kLDfTBI5MQOCFDBJC6AYGInNiX7mFzZUFbGfFNCtyDLhmvatD9MXZhapQNJYx+P1Mank6UObxLRJY0IHlWLc2nu20pNmgNCd8acenrwhcuKgtmyWVxXnCtLVnqrd9L3N6+W47X6QpB1X+rX2/0zMgFlb5biYBq9tw4DiUMZ3h2/72mHu/oKIdrHBUw+WFHHPHermg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from MWHPR21MB0798.namprd21.prod.outlook.com (2603:10b6:300:128::18) by MWHPR2101MB0812.namprd21.prod.outlook.com (2603:10b6:301:7c::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.3; Thu, 17 Jun 2021 16:21:34 +0000 Received: from MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946]) by MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946%14]) with mapi id 15.20.4264.003; Thu, 17 Jun 2021 16:21:34 +0000 From: Eugene Rozenfeld To: =?iso-8859-2?Q?Martin_Li=B9ka?= , "gcc-patches@gcc.gnu.org" Subject: RE: [EXTERNAL] [PATCH] gcov: Use system IO buffering Thread-Topic: [EXTERNAL] [PATCH] gcov: Use system IO buffering Thread-Index: AQHXNoNFX4pDtFzbAkCvJKesOOcWkasXyj5AgACBn4CAAGn4UA== Date: Thu, 17 Jun 2021 16:21:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=b47c57ec-6b1c-40ab-9b70-1079c5589479; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-06-17T15:57:09Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb93fb84-dd42-4a5c-8952-08d931abf97b x-ms-traffictypediagnostic: MWHPR2101MB0812: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P7m9Jl06M6hFaP9OKxsiBtw3vgpT5tp/IF4PTwQIFSAUcHnUIkLvoDSa7os/XPmz71/DIbAbbkYz8fAFeJApAK71DvsXsCTmIZYw9yEwGGwR0tLyIDzRPEqcvmH5xxeVsIDx0qN7Yc0NQNeHuIPKLIEUM5k3VOsbusZolW/OxqqEKdrYC6gbSWC1AnyKMiZMUiqpn98kCgXC2tntCL0VtHImon+Cv/G0k9TAasgsQAK089A9vCsEvNzPlpqquSQtzX+AfQHybIB4Q1AF/E+OObeVQT22oKyAtYc7o7OuGlHaUJBXom2mIhB2sb7x1sWkvlyJnd9Fx7KwL9P8NfusL7c2lS0Ic4SRQkWDxaj7iABkvXVUIC3N2adAysIm3EXmPlAjCZBLjnbHlxbqBv1Y13EceuH1OsfHjezvAJSlW9qzM0bnIMwSb6v2GjR7OsRxoB6aUuHDvIVsserOYDS1fUUSyj7yvzSnsIGRZJ/gYF2l2noytU0yi6Xm1Vf/EnBLaBrQe5GtRMblWYPB8hx8lSr2PAFD3pr986z4mmkxZcV34ZdBBVhKmb2/tqioYRG1O+JMnYI9BdESBOugKtZM8eU7uNBvXvYiAJCNxq+bsiZoAHQrV0j9LLtvtTX5ljDR7LZn9PIhSMcIPyxQtK5h1BJGJHg7TE70YeJ2Ct40l6JSo0fBc50kSdZVXtWOmP+v5FBeXRXlXUchR41qsPplAbbWSvuC2r+R7A6vTIu+qP5uoa8RZzhRN0ovH24U2MNgLYdYCaMZ0itS260S84OQcQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR21MB0798.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(66574015)(66946007)(38100700002)(6506007)(53546011)(82950400001)(71200400001)(52536014)(122000001)(10290500003)(33656002)(9686003)(478600001)(86362001)(64756008)(2906002)(8936002)(66556008)(66476007)(66446008)(55016002)(82960400001)(76116006)(8990500004)(186003)(110136005)(5660300002)(316002)(8676002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?kuRq/f/6V6DcwAKnUvMvo2VZTbtq8/qwcyFNveJONxkpcujK733rgBb7hi?= =?iso-8859-2?Q?Hu5DHLylAn0dEUCBlRhye8A80o8SPnNyOWQY+teBo5EhY26D8hYorKP2Ms?= =?iso-8859-2?Q?iAi2LzK/KX6nYdCGlX403M7PVOL7u7Qr4J1uXzMtaINcg/Nx7SGo6cKvql?= =?iso-8859-2?Q?If0wEgt2/jBh8a4GZ8WYEZ8P866RaPpcJOELpwh18rn2+Z2n6jF0T1t6l3?= =?iso-8859-2?Q?fL7pQumRvWMTdrlcw8BegwUfZ0URMbc6QR/aEJzHVm/y1odniREs07ixe0?= =?iso-8859-2?Q?3xtoxXzujTFUeYf6AHwzki0/UwSa1QCqSOQcDQJU2kK6M2b4EZL8Yjr6uu?= =?iso-8859-2?Q?BfxIdSlzed45Ssk4jBz58vuxegJ6Ykx1HScglJAombShJOTOw+SivcOPQh?= =?iso-8859-2?Q?1mrL0nkSLrBmXDq8mNY6//oXRVeOPVT2JW8SLqFdPPq0VOvg+w5xTtN0Ol?= =?iso-8859-2?Q?E05YuyI1PEKKI5iddfrU9mAeRLAGOWgC/g291VWScFCBa3N8ZYEb+cssiw?= =?iso-8859-2?Q?LUlkfcORK3s0fJ7nM1tZ1LJ5UCR3rH7PQ4rYvzQpmiUUKNFlU3jATdxOcn?= =?iso-8859-2?Q?h48AUnDIuY1zOgZaaYmN+QDkNuixSEep6rzoMg9G34QsfVYLiTIFKZlJSA?= =?iso-8859-2?Q?jPOG7ZmbZXnCEbBjRWDvBIduxpsdSOm+loy2Z6nhcF8ayScJdkikC6hcT5?= =?iso-8859-2?Q?19vdrkjBD1Lmvm7F8jyrXO724E7TOd33Z1Y76Hn0VE4uvXdFHlNXmPEij9?= =?iso-8859-2?Q?VwSbGTiWoAbuysoy9/NxM401IVp3TxJYT5aZ2+IxZ4dk+8nwDERyt/HZEH?= =?iso-8859-2?Q?MNVApTsBgLRp7+/EAn/2EN7Tq0xyIo1n20T1/JFNm0s1m0YPImNMX4y9SW?= =?iso-8859-2?Q?q3o+Bhu1oVKaot3DLRU7jKwOadTLJTr4H+8D7pmcex/VmZvS4Y7sOwbizm?= =?iso-8859-2?Q?sD0P9BLWLayiIP+ROrZ2Z6EmPe2wWEbLi4kQp0Z0FipFO1/RuOLip3r+J8?= =?iso-8859-2?Q?pq1b9JHt2pgf4yPGMm1LgY/xcUB05vgnrXOcB3Ty6hK7WCYLt74SYCdWxZ?= =?iso-8859-2?Q?2Gls58HXkbVgmetvFWUGwbu53dCRhFAcEKQz5pbxZaFfk+cKhIG+Z4I5ps?= =?iso-8859-2?Q?x1rjRKmK9iXuN09ym9eWBpsHPwpc9sfmvDPBtdwFN9ZxFml/VAqj4ShA9X?= =?iso-8859-2?Q?NRLXB5EJVVTJZYBWWcP5rduOoSC50yYQ5k/Lo56RbrLqOTh6p+n+LT4Q6a?= =?iso-8859-2?Q?m4LEYa7orTkLCinHfw4iUburjDhgTWrd0X4vfNlc4oTgFEYlc7UYyra3jt?= =?iso-8859-2?Q?KYPxG+gnYYqgBsI+aRCzHI5wHAVS7kRMEQW/alSl6DLX5ah3YEyGTz3PD4?= =?iso-8859-2?Q?imd0AjWbYadEaiqSKVZi2QSUyRLOm9EAS/k40cYv81qjio8ER9Mmg=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB0798.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb93fb84-dd42-4a5c-8952-08d931abf97b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2021 16:21:34.3117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OstDOuQbg2jOBIbyEJ5ZbYXGeAYLFhFBaatzZkTLK4op81uuSWjpNv1XFWZtvaPEh52M/bhzH8rukhxZsZnEQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR2101MB0812 X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 16:21:39 -0000 Thank you for your reply Martin! AUTO_PROFILE_VERSION should also be changed. Then create_gcov can be update= d to support both the old format and the new format. Eugene -----Original Message----- From: Martin Li=B9ka =20 Sent: Thursday, June 17, 2021 2:38 AM To: Eugene Rozenfeld ; gcc-patches@gcc.gnu.= org Subject: Re: [EXTERNAL] [PATCH] gcov: Use system IO buffering On 6/17/21 3:59 AM, Eugene Rozenfeld wrote: > |The commit from this patch (https://nam06.safelinks.protection.outlook.c= om/?url=3Dhttps%3A%2F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh= %3D23eb66d1d46a34cb28c4acbdf8a1deb80a7c5a05&data=3D04%7C01%7CEugene.Roz= enfeld%40microsoft.com%7C508d63026ea84be211cc08d9317395bb%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637595194782996821%7CUnknown%7CTWFpbGZsb3d8eyJW= IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&s= data=3DUG%2B41tXMZ94%2Ff80qCnmq%2BtZsFkLXc9NrdWF8KXwPjnk%3D&reserved=3D= 0) changed the semantics of gcov_read_string and gcov_write_string. Before = this change the string storage was as described in gcov-io.h: "Strings are = padded with 1 to 4 NUL bytes, to bring the length up to a multiple of 4. Th= e number of 4 bytes is stored, followed by the padded string." After this c= hange the number before the string indicates the number of bytes (not words= ) and there is no padding. Was this file format change intentional? Hello. Thanks for heads up! Yes, the change was intentional and I'm going to update documentation entry= in gcov-io.h. > It breaks AutoFDO because create_gcov produces strings in the format spec= ified in gcov-io.h. Thanks, Eugene Sure, that needs to be adjusted. Martin