From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-211668-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 10036 invoked by alias); 8 Feb 2008 12:53:51 -0000
Received: (qmail 10027 invoked by uid 22791); 8 Feb 2008 12:53:50 -0000
X-Spam-Check-By: sourceware.org
Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Feb 2008 12:53:28 +0000
Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) 	by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m18CrPP7167760 	for <gcc-patches@gcc.gnu.org>; Fri, 8 Feb 2008 12:53:25 GMT
Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) 	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m18CrOhn2404354 	for <gcc-patches@gcc.gnu.org>; Fri, 8 Feb 2008 13:53:24 +0100
Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) 	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m18CrO00020309 	for <gcc-patches@gcc.gnu.org>; Fri, 8 Feb 2008 13:53:24 +0100
Received: from d12ml062.megacenter.de.ibm.com (d12ml062.megacenter.de.ibm.com [9.149.166.219]) 	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m18CrOf8020306; 	Fri, 8 Feb 2008 13:53:24 +0100
In-Reply-To: <de8d50360802071853u79a952e1p33e20bc0408a05c1@mail.gmail.com>
To: "Andrew Pinski" <pinskia@gmail.com>
Cc: gcc-patches@gcc.gnu.org
MIME-Version: 1.0
Subject: Re: [PATCH, spu] fix wrong parameter type in spu intrinsics
X-Mailer: Lotus Notes Release 7.0 HF277 June 21, 2006
Message-ID: <OF207CDC92.D3A0AB98-ONC12573E9.004699DF-C12573E9.0046FA12@de.ibm.com>
From: Sa Liu <SALIU@de.ibm.com>
Date: Fri, 08 Feb 2008 14:58:00 -0000
Content-Type: text/plain; charset="US-ASCII"
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2008-02/txt/msg00254.txt.bz2

"Andrew Pinski" <pinskia@gmail.com> wrote on 08.02.2008 03:53:18:

> This is ok with testcases and a changelog entry.

Ok, patch committed and added test case intrinsics-3.c to 
testsuite/gcc.target/spu/.

Index: gcc/gcc/testsuite/gcc.target/spu/intrinsics-3.c
===================================================================
--- /dev/null
+++ gcc/gcc/testsuite/gcc.target/spu/intrinsics-3.c
@@ -0,0 +1,21 @@
+/* { dg-do compile } */
+#include <spu_intrinsics.h>
+void f0 (vec_uint4 *in)
+{
+  vec_float4 out = spu_convtf (in[0], 128); /* { dg-error "expects an 
integer literal in the range" "0, 127"  }*/
+}
+
+void f1 (vec_int4 *in)
+{
+  vec_float4 out = spu_convtf (in[0], 128); /* { dg-error "expects an 
integer literal in the range" "0, 127"  }*/
+}
+
+void f2 (vec_float4 *in)
+{
+  vec_int4 out = spu_convts (in[0], 128); /* { dg-error "expects an 
integer literal in the range" "0, 127"  }*/
+}
+
+void f3 (vec_float4 *in)
+{
+  vec_uint4 out = spu_convtu (in[0], 128); /* { dg-error "expects an 
integer literal in the range" "0, 127"  }*/
+}


Thanks!
Sa