From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13890 invoked by alias); 15 Jun 2011 22:20:59 -0000 Received: (qmail 13879 invoked by uid 22791); 15 Jun 2011 22:20:57 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate6.uk.ibm.com (HELO mtagate6.uk.ibm.com) (194.196.100.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Jun 2011 22:20:41 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p5FMKdfY000993 for ; Wed, 15 Jun 2011 22:20:39 GMT Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5FMKbR91941734 for ; Wed, 15 Jun 2011 23:20:39 +0100 Received: from d06av08.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5FMKbZs001271 for ; Wed, 15 Jun 2011 23:20:37 +0100 Received: from d12mc102.megacenter.de.ibm.com (d12mc102.megacenter.de.ibm.com [9.149.167.114]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p5FMKbHf001268; Wed, 15 Jun 2011 23:20:37 +0100 In-Reply-To: References: Subject: Re: [PATCH, SMS] Fix violation of memory dependence X-KeepSent: 38CC809C:88AFA71A-C22578B0:007A5AC6; type=4; name=$KeepSent To: Revital Eres Cc: gcc-patches@gcc.gnu.org, Patch Tracking Message-ID: From: Ayal Zaks Date: Wed, 15 Jun 2011 23:07:00 -0000 MIME-Version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01185.txt.bz2 > OK for mainline once regtest on arm-linux-gnueabi completes? ok. + else + { + if (mem_read_insn_p (to->insn)) + return; + else better do else if (!mem_read_insn_p (to->insn)) + create_ddg_dep_no_link (g, from, to, ANTI_DEP, MEM_DEP, 0); + } Ayal. Revital Eres wrote on 15/06/2011 11:45:15 AM: > From: Revital Eres > To: Ayal Zaks/Haifa/IBM@IBMIL > Cc: gcc-patches@gcc.gnu.org, Patch Tracking > Date: 15/06/2011 11:45 AM > Subject: Re: [PATCH, SMS] Fix violation of memory dependence > > Hello, > > >>> =A0 =A0 =A0 =A0 * ddg.c (add_intra_loop_mem_dep): New function. > > > > You could check first thing if (from->cuid =3D=3D to->cuid), for code clarity. > > Attached is the new version of the patch which addresses this. > > The patch was re-tested as follows: > On ppc64-redhat-linux regtest as well as bootstrap with SMS flags > enabling SMS also on loops with stage count 1. Regtested on SPU. > On arm-linux-gnueabi bootstrap c language with SMS > flags enabling SMS also on loops with stage count 1 > and currently regression testing on c,c++. > > OK for mainline once regtest on arm-linux-gnueabi completes? > > Thanks, > Revital > > gcc/ > * ddg.c (add_intra_loop_mem_dep): New function. > (build_intra_loop_deps): Call it. > > testsuite/ > * gcc.dg/sms-9.c: New file. > [attachment "patch_sms_14_6.txt" deleted by Ayal Zaks/Haifa/IBM]