PING: PING: patch: ICE in legitimize_pic_address for x86_64 mingw target

[Kai Tietz <Kai.Tietz@onevision.com>]

[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]

Hi,

there is an ICE for __declspec(dllimport) imported variables. The checking 
of pic seems to be to early in legitimize_address. The check for 
TARGET_DLLIMPORT_DECL_ATTRIBUTES should be done infront AFAICS. I 
bootstraped it for x86_64-pc-mingw32 and i686-pc-mignew32 and it seems to 
work fine for me.
I tested this patch for i686-pc-cygwin and x86_64-pc-mingw32 and I saw no 
regressions.

ChangeLog:

2007-03-30  Kai Tietz  <kai.tietz@onevision.com>

        * i386.c: (legitimize_address): Move dllimported variable check
        infront of legitimizing pic address of CONST symbols.

Regards,
 i.A. Kai Tietz


|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-Straße 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  Komplementärin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-Straße 9 – 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - Geschäftsführer: 
Ulrike Döhler, Manuela Kluger

[-- Attachment #2: i386_got.txt --]
[-- Type: text/plain, Size: 812 bytes --]

Index: gcc/gcc/config/i386/i386.c
===================================================================
--- gcc.orig/gcc/config/i386/i386.c
+++ gcc/gcc/config/i386/i386.c
@@ -7673,9 +7673,6 @@ legitimize_address (rtx x, rtx oldx ATTR
       return gen_rtx_PLUS (Pmode, t, XEXP (XEXP (x, 0), 1));
     }
 
-  if (flag_pic && SYMBOLIC_CONST (x))
-    return legitimize_pic_address (x, 0);
-
   if (TARGET_DLLIMPORT_DECL_ATTRIBUTES)
     {
       if (GET_CODE (x) == SYMBOL_REF && SYMBOL_REF_DLLIMPORT_P (x))
@@ -7690,6 +7687,9 @@ legitimize_address (rtx x, rtx oldx ATTR
 	}
     }
 
+  if (flag_pic && SYMBOLIC_CONST (x))
+    return legitimize_pic_address (x, 0);
+
   /* Canonicalize shifts by 0, 1, 2, 3 into multiply */
   if (GET_CODE (x) == ASHIFT
       && CONST_INT_P (XEXP (x, 1))
=