public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew_Pinski@PlayStation.Sony.Com
To: Zdenek Dvorak <rakdver@kam.mff.cuni.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix IV-opts so it no longer produces MEM[index:]
Date: Wed, 01 Aug 2007 21:18:00 -0000	[thread overview]
Message-ID: <OF72556AE7.3C95EA07-ON8825732A.0074C33C-8825732A.00750104@playstation.sony.com> (raw)
In-Reply-To: <20070801095236.GA13479@kam.mff.cuni.cz>

Zdenek Dvorak <rakdver@kam.mff.cuni.cz> wrote on 08/01/2007 02:52:36 AM:

> Hello,
> > @@ -1934,7 +1939,7 @@ add_candidate_1 (struct ivopts_data *dat
> >      {
> >        orig_type = TREE_TYPE (base);
> >        type = generic_type_for (orig_type);
> > -      if (type != orig_type)
> > +      if (type != orig_type && !POINTER_TYPE_P (orig_type))
> >     {
> >       base = fold_convert (type, base);
> >       step = fold_convert (type, step);
> 
> You still need to convert base to type.

No, this is why we are getting MEM[index:] as generic_type_for for pointer 
types is unsigned_type_for and unsigned_type_for  returns the same size 
integer as the pointer which is not what we want here really.  Maybe we 
should return the pointer to void type instead?

Thanks,
Andrew Pinski

  reply	other threads:[~2007-08-01 21:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  2:36 Andrew_Pinski
2007-08-01  9:52 ` Zdenek Dvorak
2007-08-01 21:18   ` Andrew_Pinski [this message]
2007-08-07 12:26     ` Andrew Pinski
2007-08-08 10:18       ` Zdenek Dvorak
2007-08-10 21:21   ` Andrew Pinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF72556AE7.3C95EA07-ON8825732A.0074C33C-8825732A.00750104@playstation.sony.com \
    --to=andrew_pinski@playstation.sony.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rakdver@kam.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).