From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17411 invoked by alias); 21 Nov 2011 13:51:13 -0000 Received: (qmail 17039 invoked by uid 22791); 21 Nov 2011 13:51:05 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate1.uk.ibm.com (HELO mtagate1.uk.ibm.com) (194.196.100.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Nov 2011 13:50:19 +0000 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pALDoH9k015747 for ; Mon, 21 Nov 2011 13:50:17 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pALDoHtU2248784 for ; Mon, 21 Nov 2011 13:50:17 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pALDoGIj011861 for ; Mon, 21 Nov 2011 06:50:16 -0700 Received: from d06ml319.portsmouth.uk.ibm.com (d06ml319.portsmouth.uk.ibm.com [9.149.76.146]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pALDoGmg011858; Mon, 21 Nov 2011 06:50:16 -0700 In-Reply-To: <20111121125707.GG27242@tyan-ft48-01.lab.bos.redhat.com> References: <20111121125707.GG27242@tyan-ft48-01.lab.bos.redhat.com> To: Jakub Jelinek Cc: GCC Patches , Richard Guenther MIME-Version: 1.0 Subject: Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence X-KeepSent: 7EA72A95:B3E25FE6-C225794F:004B41E0; type=4; name=$KeepSent From: Razya Ladelsky Message-ID: Date: Mon, 21 Nov 2011 14:24:00 -0000 Content-Type: text/plain; charset="US-ASCII" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg02098.txt.bz2 gcc-patches-owner@gcc.gnu.org wrote on 21/11/2011 02:57:07 PM: > From: Jakub Jelinek > To: Razya Ladelsky/Haifa/IBM@IBMIL > Cc: Richard Guenther , GCC Patches patches@gcc.gnu.org> > Date: 21/11/2011 02:57 PM > Subject: Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix > self data dependence > Sent by: gcc-patches-owner@gcc.gnu.org > > On Tue, Nov 15, 2011 at 12:31:39PM +0200, Razya Ladelsky wrote: > > This patch fixes the failures described in > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49960 > > It also fixes bzips when run with autopar enabled. > > Sorry, I've been away and couldn't react to this earlier, but the patch > looks wrong to me. The reason why I've been calling compute_self_dependence > from the gather handling code is to do there what we did for normal data > references in compute_all_dependences, except for the affine stuff. Hi Jakub, what do you mean by 'except for the affine stuff'? Before having this patch, compute_self_depepndence just marked the distance zero and returned, while now it calls compute_affine_dependence. So I think you do get the right outcome now. > So, when compute_all_dependences no longer calls it, neither should > vect_analyze_data_refs. So do you want to replace it with the call to compute_affine_dependence? Thanks, Razya > > Jakub >