From: "Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>
To: Richard Henderson <rth@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: S/390: Fix minor missed optimization
Date: Mon, 04 Nov 2002 11:11:00 -0000 [thread overview]
Message-ID: <OF7F740876.EC7700E5-ONC1256C67.00687ABF@de.ibm.com> (raw)
Richard Henderson wrote:
>Better to compare against the arg_pointer_rtx directly.
Right. I've committed the following patch to fix this.
Thanks,
Ulrich
* config/s390/s390.c (s390_decompose_address): Use arg_pointer_rtx
for comparison.
Index: gcc/config/s390/s390.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/s390/s390.c,v
retrieving revision 1.66
diff -c -p -r1.66 s390.c
*** gcc/config/s390/s390.c 25 Oct 2002 12:26:40 -0000 1.66
--- gcc/config/s390/s390.c 4 Nov 2002 13:24:20 -0000
*************** s390_decompose_address (addr, out)
*** 1605,1616 ****
Thus we don't check the displacement for validity here. If after
elimination the displacement turns out to be invalid after all,
this is fixed up by reload in any case. */
! if ((base && REGNO (base) == ARG_POINTER_REGNUM)
! || (indx && REGNO (indx) == ARG_POINTER_REGNUM))
! ;
!
! else if (INTVAL (disp) < 0 || INTVAL (disp) >= 4096)
! return FALSE;
}
/* In the small-PIC case, the linker converts @GOT12
--- 1605,1615 ----
Thus we don't check the displacement for validity here. If after
elimination the displacement turns out to be invalid after all,
this is fixed up by reload in any case. */
! if (base != arg_pointer_rtx && indx != arg_pointer_rtx)
! {
! if (INTVAL (disp) < 0 || INTVAL (disp) >= 4096)
! return FALSE;
! }
}
/* In the small-PIC case, the linker converts @GOT12
next reply other threads:[~2002-11-04 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-04 11:11 Ulrich Weigand [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-10-25 5:32 Ulrich Weigand
2002-10-25 13:14 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF7F740876.EC7700E5-ONC1256C67.00687ABF@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).