New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

[Hans-Peter Nilsson]

Lots of the new tests introduced with 130892:130894 fail for
cris-elf:

Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/struct/struct-reorg.exp ...
FAIL: gcc.dg/struct/wo_prof_escape_str_init.c scan-ipa-dump ipa_struct_reorg "is initialized...Excluded"
FAIL: gcc.dg/struct/wo_prof_global_array.c scan-ipa-dump ipa_struct_reorg "Number of structures to transform is 1"
FAIL: gcc.dg/struct/wo_prof_global_var.c scan-ipa-dump ipa_struct_reorg "Number of structures to transform is 1"
FAIL: gcc.dg/struct/wo_prof_local_array.c scan-ipa-dump ipa_struct_reorg "Number of structures to transform is 1"
FAIL: gcc.dg/struct/wo_prof_local_var.c scan-ipa-dump ipa_struct_reorg "Number of structures to transform is 1"
FAIL: gcc.dg/struct/wo_prof_single_str_global.c scan-ipa-dump ipa_struct_reorg "Number of structures to transform is 1"
FAIL: gcc.dg/struct/wo_prof_two_strs.c (internal compiler error)
FAIL: gcc.dg/struct/wo_prof_two_strs.c (test for excess errors)
WARNING: gcc.dg/struct/wo_prof_two_strs.c compilation failed to produce executable
FAIL: gcc.dg/struct/wo_prof_two_strs.c scan-ipa-dump ipa_struct_reorg "Number of structures to transform is 2"

gcc.log doesn't have much more to say.  For the ICE:
x/gcc/testsuite/gcc.dg/struct/wo_prof_two_strs.c:56: internal compiler error: in find_new_var_of_type, at ipa-struct-reorg.c:605

Also, gcc.dg/weak/weak-5.c and gcc.dg/weak/weak-6.c has started
to fail in the mentioned revision range.  Looks like "-O3
-fipa-struct-reorg -fdump-ipa-all -fwhole-program -combine
-fipa-type-escape" have been added to the default compiler
options.  Perhaps you need to save and restore DEFAULT_CFLAGS or
similar in gcc/testsuite/gcc.dg/struct/struct-reorg.exp?

brgds, H-P

Re: New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

[Olga Golovanevsky]

Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote on 13/12/2007
18:42:36:

> Lots of the new tests introduced with 130892:130894 fail for
> cris-elf:
>
> Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/struct/struct-
> reorg.exp ...
> FAIL: gcc.dg/struct/wo_prof_escape_str_init.c scan-ipa-dump
> ipa_struct_reorg "is initialized...Excluded"
> FAIL: gcc.dg/struct/wo_prof_global_array.c scan-ipa-dump
> ipa_struct_reorg "Number of structures to transform is 1"
> FAIL: gcc.dg/struct/wo_prof_global_var.c scan-ipa-dump
> ipa_struct_reorg "Number of structures to transform is 1"
> FAIL: gcc.dg/struct/wo_prof_local_array.c scan-ipa-dump
> ipa_struct_reorg "Number of structures to transform is 1"
> FAIL: gcc.dg/struct/wo_prof_local_var.c scan-ipa-dump
> ipa_struct_reorg "Number of structures to transform is 1"
> FAIL: gcc.dg/struct/wo_prof_single_str_global.c scan-ipa-dump
> ipa_struct_reorg "Number of structures to transform is 1"
> FAIL: gcc.dg/struct/wo_prof_two_strs.c (internal compiler error)
> FAIL: gcc.dg/struct/wo_prof_two_strs.c (test for excess errors)
> WARNING: gcc.dg/struct/wo_prof_two_strs.c compilation failed to
> produce executable
> FAIL: gcc.dg/struct/wo_prof_two_strs.c scan-ipa-dump
> ipa_struct_reorg "Number of structures to transform is 2"
>
> gcc.log doesn't have much more to say.  For the ICE:
> x/gcc/testsuite/gcc.dg/struct/wo_prof_two_strs.c:56: internal
> compiler error: in find_new_var_of_type, at ipa-struct-reorg.c:605

I forgot to commit ipa-struct-reorg.c, committed.

Would you please try now?

>
> Also, gcc.dg/weak/weak-5.c and gcc.dg/weak/weak-6.c has started
> to fail in the mentioned revision range.  Looks like "-O3
> -fipa-struct-reorg -fdump-ipa-all -fwhole-program -combine
> -fipa-type-escape" have been added to the default compiler
> options.  Perhaps you need to save and restore DEFAULT_CFLAGS or
> similar in gcc/testsuite/gcc.dg/struct/struct-reorg.exp?

true. fixing it.

Olga

>
> brgds, H-P

Re: New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

[Olga Golovanevsky]

Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote on 13/12/2007
18:42:36:


>
> Also, gcc.dg/weak/weak-5.c and gcc.dg/weak/weak-6.c has started
> to fail in the mentioned revision range.  Looks like "-O3
> -fipa-struct-reorg -fdump-ipa-all -fwhole-program -combine
> -fipa-type-escape" have been added to the default compiler
> options.  Perhaps you need to save and restore DEFAULT_CFLAGS or
> similar in gcc/testsuite/gcc.dg/struct/struct-reorg.exp?

Fixed with the patch below.

Please let me know if it still fails on scis-elf.

Olga

Index: gcc.dg/struct/struct-reorg.exp
===================================================================
--- gcc.dg/struct/struct-reorg.exp  (revision 130914)
+++ gcc.dg/struct/struct-reorg.exp  (working copy)
@@ -20,12 +20,12 @@
 load_lib gcc-dg.exp
 load_lib target-supports.exp

-set DEFAULT_CFLAGS "-O3 -fipa-struct-reorg -fdump-ipa-all -fwhole-program
-combine -fipa-type-escape"
+set STRUCT_REORG_CFLAGS "-O3 -fipa-struct-reorg -fdump-ipa-all
-fwhole-program -combine -fipa-type-escape"

 # Initialize `dg'.
 dg-init

-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/wo_prof_*.c]] ""
$DEFAULT_CFLAGS
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/wo_prof_*.c]] ""
$STRUCT_REORG_CFLAGS

 dg-final

Index: ChangeLog
===================================================================
--- ChangeLog     (revision 130914)
+++ ChangeLog     (working copy)
@@ -1,3 +1,8 @@
+2007-12-13  Olga Golovanevsky  <olga@il.ibm.com>
+
+     * gcc.dg/struct/struct-reorg.exp: Replace
+      DEFAULT_CFLAGS by STRUCT_REORG_CFLAFS.
+
 2007-12-13  Thomas Koenig  <tkoenig@gcc.gnu.org>

      PR libfortran/34370

>
> brgds, H-P

Re: New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

[Hans-Peter Nilsson]

> From: Olga Golovanevsky <OLGA@il.ibm.com>
> Date: Thu, 13 Dec 2007 21:05:48 +0200
> Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote on 13/12/2007
> 18:42:36:
> > gcc.log doesn't have much more to say.  For the ICE:
> > x/gcc/testsuite/gcc.dg/struct/wo_prof_two_strs.c:56: internal
> > compiler error: in find_new_var_of_type, at ipa-struct-reorg.c:605
> 
> I forgot to commit ipa-struct-reorg.c, committed.
> 
> Would you please try now?

That fixed some, but with 130917, there's still the ICE for
cris-elf:

Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/struct/struct-reorg.exp ...
FAIL: gcc.dg/struct/wo_prof_two_strs.c (internal compiler error)
FAIL: gcc.dg/struct/wo_prof_two_strs.c (test for excess errors)
WARNING: gcc.dg/struct/wo_prof_two_strs.c compilation failed to produce executable
FAIL: gcc.dg/struct/wo_prof_two_strs.c scan-ipa-dump ipa_struct_reorg "Number of structures to transform is 2"

The ICE message is the same.

> > Also, gcc.dg/weak/weak-5.c and gcc.dg/weak/weak-6.c has started
> > to fail in the mentioned revision range.  Looks like "-O3
> > -fipa-struct-reorg -fdump-ipa-all -fwhole-program -combine
> > -fipa-type-escape" have been added to the default compiler
> > options.  Perhaps you need to save and restore DEFAULT_CFLAGS or
> > similar in gcc/testsuite/gcc.dg/struct/struct-reorg.exp?
> 
> true. fixing it.

This part is fixed, thanks!

brgds, H-P

Re: New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

[Olga Golovanevsky]

Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote on 14/12/2007
02:01:15:

>
> That fixed some, but with 130917, there's still the ICE for
> cris-elf:
>
> Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/struct/struct-
> reorg.exp ...
> FAIL: gcc.dg/struct/wo_prof_two_strs.c (internal compiler error)
> FAIL: gcc.dg/struct/wo_prof_two_strs.c (test for excess errors)
> WARNING: gcc.dg/struct/wo_prof_two_strs.c compilation failed to
> produce executable
> FAIL: gcc.dg/struct/wo_prof_two_strs.c scan-ipa-dump
> ipa_struct_reorg "Number of structures to transform is 2"
>
> The ICE message is the same.
>

I am trying to build a cross-compiler for cris-elf on powerpc-suse-linux
to reproduce the ICE.

Olga

Re: New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

[Hans-Peter Nilsson]

> From: Olga Golovanevsky <OLGA@il.ibm.com>
> Date: Fri, 14 Dec 2007 14:43:03 +0200

> Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote on 14/12/2007
> 02:01:15:
> > That fixed some, but with 130917, there's still the ICE for
> > cris-elf:
> >
> > Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/struct/struct-
> > reorg.exp ...
> > FAIL: gcc.dg/struct/wo_prof_two_strs.c (internal compiler error)
> > FAIL: gcc.dg/struct/wo_prof_two_strs.c (test for excess errors)
> > WARNING: gcc.dg/struct/wo_prof_two_strs.c compilation failed to
> > produce executable
> > FAIL: gcc.dg/struct/wo_prof_two_strs.c scan-ipa-dump
> > ipa_struct_reorg "Number of structures to transform is 2"
> >
> > The ICE message is the same.
> >
> 
> I am trying to build a cross-compiler for cris-elf on powerpc-suse-linux
> to reproduce the ICE.

What's the status of this?  It still fails for me at r131650,
cross from x86_64-unknown-linux-gnu (Fedora 8 and Debian etch).

brgds, H-P

Re: New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

[Olga Golovanevsky]

Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote on 19/01/2008
14:58:56:

> > From: Olga Golovanevsky <OLGA@il.ibm.com>
> > Date: Fri, 14 Dec 2007 14:43:03 +0200
>
> > Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote on 14/12/2007
> > 02:01:15:
> > > That fixed some, but with 130917, there's still the ICE for
> > > cris-elf:
> > >
> > > Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/struct/struct-
> > > reorg.exp ...
> > > FAIL: gcc.dg/struct/wo_prof_two_strs.c (internal compiler error)
> > > FAIL: gcc.dg/struct/wo_prof_two_strs.c (test for excess errors)
> > > WARNING: gcc.dg/struct/wo_prof_two_strs.c compilation failed to
> > > produce executable
> > > FAIL: gcc.dg/struct/wo_prof_two_strs.c scan-ipa-dump
> > > ipa_struct_reorg "Number of structures to transform is 2"
> > >
> > > The ICE message is the same.
> > >
> >
> > I am trying to build a cross-compiler for cris-elf on
powerpc-suse-linux
> > to reproduce the ICE.
>
> What's the status of this?  It still fails for me at r131650,
> cross from x86_64-unknown-linux-gnu (Fedora 8 and Debian etch).

Please try the following two patches together: one from comment #11 of PR
34483,>
and the other from comment #31 of the same PR. They should solve the ICE,
but there are systems where they generate execution failures.
Please let me know what happens on cris-elf.

Thank you,
Olga

>
> brgds, H-P

Re: New IPA tests and gcc.dg/weak/weak-5.c and 6 fail, cris-elf

[Hans-Peter Nilsson]

> From: Olga Golovanevsky <OLGA@il.ibm.com>
> Date: Sat, 19 Jan 2008 19:48:44 +0200
> Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote on 19/01/2008
> 14:58:56:
> > What's the status of this?  It still fails for me at r131650,
> > cross from x86_64-unknown-linux-gnu (Fedora 8 and Debian etch).
> 
> Please try the following two patches together: one from comment #11 of PR
> 34483,>
> and the other from comment #31 of the same PR. They should solve the ICE,
> but there are systems where they generate execution failures.
> Please let me know what happens on cris-elf.

I had to apply hunk #2 of the patch in comment #31 manually (for
no apparent reason than spaces, which are usually considered
"fuzz") but with #11 and #31 applied, the ICE was gone;
gcc.dg/struct/wo_prof_two_strs.c passed.  No regressions.

brgds, H-P