From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5135 invoked by alias); 24 Oct 2008 06:09:43 -0000 Received: (qmail 5118 invoked by uid 22791); 24 Oct 2008 06:09:41 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.17.161) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Oct 2008 06:08:57 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.1/8.13.1) with ESMTP id m9O68ok3018187 for ; Fri, 24 Oct 2008 06:08:50 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9O68o8g2851056 for ; Fri, 24 Oct 2008 08:08:50 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9O68omV028723 for ; Fri, 24 Oct 2008 08:08:50 +0200 Received: from d12ml069.megacenter.de.ibm.com (d12ml069.megacenter.de.ibm.com [9.149.167.186]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m9O68oAr028720; Fri, 24 Oct 2008 08:08:50 +0200 Subject: Re: [PATCH] SPU: Use FRAME_GROWS_DOWNWARD X-KeepSent: A761BA28:035964C9-C12574EC:00218C7D; type=4; name=$KeepSent To: trevor_smigiel@playstation.sony.com Cc: andrew_pinski@playstation.sony.com, gcc-patches@gcc.gnu.org X-Mailer: Lotus Notes Release 8.0.1 February 07, 2008 Message-ID: From: Stefan Schulze Frielinghaus Date: Fri, 24 Oct 2008 08:30:00 -0000 MIME-Version: 1.0 Content-type: multipart/mixed; Boundary="0__=4EBBFE7FDFB20AED8f9e8a93df938690918c4EBBFE7FDFB20AED" Content-Disposition: inline X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-10/txt/msg01017.txt.bz2 --0__=4EBBFE7FDFB20AED8f9e8a93df938690918c4EBBFE7FDFB20AED Content-type: text/plain; charset=US-ASCII Content-length: 2003 gcc-patches-owner@gcc.gnu.org wrote on 10/21/2008 09:42:56 PM: > > Sent by: gcc-patches-owner@gcc.gnu.org [...] > In the "stack_protect_set" and "stack_protect_test_si" patterns, the > type attribute should be multi1. This indicates that the first > instruction is in the odd pipeline, which allows slightly better > scheduling of these patterns. Sure, load/store always computes in pipe 1. Changed > > In "stack_protect_test_si", shouldn't the "+r" of the first operand be > "=&r"? Also, please change "register_operand" to "spu_reg_operand". > Based on the code, it is not necessary now, but it protects us from > possible issues in the future. Changed. > > I'm a little suspicious of the memory predicates, constraints, and the > hard coded load/store instructions. How do we know that the memory rtl > will always match the hard coded instructions? Right. Changed to %p and spu_mem_operand. > > How did you compare the test suite results? Did you use > contrib/compare_tests? Or just compare the numbers/statistics printed > at the end? (Use compare_tests.) compare_tests result: New tests that PASS:: gcc.dg/pr34225.c (test for excess errors) This test passes because it needs -fstack-protector. New patch tested with same results as previous patch. (See attached file: spu.patch) Mit freundlichen Gruessen / Kind regards Stefan Schulze Frielinghaus IBM Systems & Technology Group, Systems Software Development SW Linux on Cell BE Development & Evaluation ------------------------------------------------------------------------------- IBM Deutschland Schoenaicher Str. 220 71032 Boeblingen Phone: ++49-(0)7031-16-2173 E-Mail: xxschulz@de.ibm.com ------------------------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschaeftsfuehrung: Herbert Kircher Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 --0__=4EBBFE7FDFB20AED8f9e8a93df938690918c4EBBFE7FDFB20AED Content-type: application/octet-stream; name="spu.patch" Content-Disposition: attachment; filename="spu.patch" Content-transfer-encoding: base64 Content-length: 8061 MjAwOC0xMC0yMyAgU3RlZmFuIFNjaHVsemUgRnJpZWxpbmdoYXVzICA8eHhz Y2h1bHpAZGUuaWJtLmNvbT4KCgkqIGNvbmZpZ3VyZS5hYzogUmVtb3ZlIHNr aXAgZGlyIGxpYnNzcCBvZiBTUFUgYXJjaC4KCSogY29uZmlndXJlOiBSZS1n ZW5lcmF0ZS4KCgkqIGdjYy9jb25maWcvc3B1L3NwdS5oIChGUkFNRV9HUk9X U19ET1dOV0FSRCkKCShJTklUSUFMX0ZSQU1FX1BPSU5URVJfT0ZGU0VUKTog RGVmaW5lCglGUkFNRV9HUk9XU19ET1dOV0FSRCB0byAxIGFuZCByZW1vdmUg dW51c2VkCglJTklUSUFMX0ZSQU1FX1BPSU5URVJfT0ZGU0VULgoJKiBnY2Mv Y29uZmlnL3NwdS9zcHUuYyAoc3B1X2luaXRpYWxfZWxpbWluYXRpb25fb2Zm c2V0KTogQ2FsY3VsYXRlIG5ldwoJb2Zmc2V0IGlmIGVsaW1pbmF0aW5nIHNv ZnQgZnJhbWUgcG9pbnRlci4KCSogZ2NjL2NvbmZpZy9zcHUvc3B1Lm1kIChz dGFja19wcm90ZWN0X3NldCwgc3RhY2tfcHJvdGVjdF90ZXN0KQoJKHN0YWNr X3Byb3RlY3RfdGVzdF9zaSk6IEFkZCBpbml0aWFsIG1hY2hpbmUgZGVzY3Jp cHRpb24KCWZvciBTdGFjayBTbWFzaGluZyBQcm90ZWN0b3IKCkluZGV4OiBj b25maWd1cmUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY29uZmlndXJl CShyZXZpc2lvbiAxNDEyODkpCisrKyBjb25maWd1cmUJKHdvcmtpbmcgY29w eSkKQEAgLTI2NTYsNyArMjY1Niw2IEBACiAgIHNwYXJjLSotc29sYXJpcyog fCBzcGFyYzY0LSotc29sYXJpcyogfCBzcGFyY3Y5LSotc29sYXJpcyopCiAg ICAgOzsKICAgc3B1LSotKikKLSAgICBza2lwZGlycz0idGFyZ2V0LWxpYnNz cCIKICAgICA7OwogICB2ODEwLSotKikKICAgICBub2NvbmZpZ2RpcnM9IiRu b2NvbmZpZ2RpcnMgYmZkIGJpbnV0aWxzIGdhcyBnY2MgZ2RiIGxkIHRhcmdl dC1saWJzdGRjKystdjMgb3Bjb2RlcyB0YXJnZXQtbGliZ2xvc3MgJHtsaWJn Y2p9IgpJbmRleDogZ2NjL2NvbmZpZy9zcHUvc3B1LmMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gZ2NjL2NvbmZpZy9zcHUvc3B1LmMJKHJldmlzaW9u IDE0MTI4OSkKKysrIGdjYy9jb25maWcvc3B1L3NwdS5jCSh3b3JraW5nIGNv cHkpCkBAIC0xNzU5LDggKzE3NTksOCBAQAogICAgVGhlIHN0YWNrIGZyYW1l IGxvb2tzIGxpa2UgdGhpczoKICAgICAgICAgICstLS0tLS0tLS0tLS0tKwog ICAgICAgICAgfCAgaW5jb21pbmcgICB8IAotICAgICAgQVAgfCAgICBhcmdz ICAgICB8IAotICAgICAgICAgKy0tLS0tLS0tLS0tLS0rCisgICAgICAgICB8 ICAgIGFyZ3MgICAgIHwgCisgICBBUCAtPiArLS0tLS0tLS0tLS0tLSsKICAg ICAgICAgIHwgJGxyIHNhdmUgICAgfAogICAgICAgICAgKy0tLS0tLS0tLS0t LS0rCiAgcHJldiBTUCB8IGJhY2sgY2hhaW4gIHwgCkBAIC0xNzcwLDEwICsx NzcwLDEwIEBACiAgICAgICAgICArLS0tLS0tLS0tLS0tLSsKICAgICAgICAg IHwgICAgLi4uICAgICAgfCAKICAgICAgICAgIHwgc2F2ZWQgcmVncyAgfCBz cHVfc2F2ZWRfcmVnc19zaXplKCkgYnl0ZXMKLSAgICAgICAgICstLS0tLS0t LS0tLS0tKworICAgRlAgLT4gKy0tLS0tLS0tLS0tLS0rCiAgICAgICAgICB8 ICAgIC4uLiAgICAgIHwgCi0gICAgICBGUCB8ICAgdmFycyAgICAgIHwgZ2V0 X2ZyYW1lX3NpemUoKSAgYnl0ZXMKLSAgICAgICAgICstLS0tLS0tLS0tLS0t KworICAgICAgICAgfCAgIHZhcnMgICAgICB8IGdldF9mcmFtZV9zaXplKCkg IGJ5dGVzCisgIEhGUCAtPiArLS0tLS0tLS0tLS0tLSsKICAgICAgICAgIHwg ICAgLi4uICAgICAgfCAKICAgICAgICAgIHwgIG91dGdvaW5nICAgfCAKICAg ICAgICAgIHwgICAgYXJncyAgICAgfCBjcnRsLT5vdXRnb2luZ19hcmdzX3Np emUgYnl0ZXMKQEAgLTE3ODEsOCArMTc4MSw4IEBACiAgICAgICAgICB8ICRs ciBvZiBuZXh0IHwKICAgICAgICAgIHwgICBmcmFtZSAgICAgfCAKICAgICAg ICAgICstLS0tLS0tLS0tLS0tKwotICAgICAgU1AgfCBiYWNrIGNoYWluICB8 IAotICAgICAgICAgKy0tLS0tLS0tLS0tLS0rCisgICAgICAgICB8IGJhY2sg Y2hhaW4gIHwgCisgICBTUCAtPiArLS0tLS0tLS0tLS0tLSsKIAogKi8KIHZv aWQKQEAgLTM2NzEsMTUgKzM2NzEsMTYgQEAKICAgICAgIHx8IGdldF9mcmFt ZV9zaXplICgpIHx8IHNhdmVkX3JlZ3Nfc2l6ZSkKICAgICBzcF9vZmZzZXQg PSBTVEFDS19QT0lOVEVSX09GRlNFVDsKICAgaWYgKGZyb20gPT0gRlJBTUVf UE9JTlRFUl9SRUdOVU0gJiYgdG8gPT0gU1RBQ0tfUE9JTlRFUl9SRUdOVU0p Ci0gICAgcmV0dXJuIChzcF9vZmZzZXQgKyBjcnRsLT5vdXRnb2luZ19hcmdz X3NpemUpOworICAgIHJldHVybiBnZXRfZnJhbWVfc2l6ZSAoKSArIGNydGwt Pm91dGdvaW5nX2FyZ3Nfc2l6ZSArIHNwX29mZnNldDsKICAgZWxzZSBpZiAo ZnJvbSA9PSBGUkFNRV9QT0lOVEVSX1JFR05VTSAmJiB0byA9PSBIQVJEX0ZS QU1FX1BPSU5URVJfUkVHTlVNKQotICAgIHJldHVybiAwOworICAgIHJldHVy biBnZXRfZnJhbWVfc2l6ZSAoKTsKICAgZWxzZSBpZiAoZnJvbSA9PSBBUkdf UE9JTlRFUl9SRUdOVU0gJiYgdG8gPT0gU1RBQ0tfUE9JTlRFUl9SRUdOVU0p CiAgICAgcmV0dXJuIHNwX29mZnNldCArIGNydGwtPm91dGdvaW5nX2FyZ3Nf c2l6ZQogICAgICAgKyBnZXRfZnJhbWVfc2l6ZSAoKSArIHNhdmVkX3JlZ3Nf c2l6ZSArIFNUQUNLX1BPSU5URVJfT0ZGU0VUOwogICBlbHNlIGlmIChmcm9t ID09IEFSR19QT0lOVEVSX1JFR05VTSAmJiB0byA9PSBIQVJEX0ZSQU1FX1BP SU5URVJfUkVHTlVNKQogICAgIHJldHVybiBnZXRfZnJhbWVfc2l6ZSAoKSAr IHNhdmVkX3JlZ3Nfc2l6ZSArIHNwX29mZnNldDsKLSAgcmV0dXJuIDA7Cisg IGVsc2UKKyAgICBnY2NfdW5yZWFjaGFibGUgKCk7CiB9CiAKIHJ0eApJbmRl eDogZ2NjL2NvbmZpZy9zcHUvc3B1LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gZ2NjL2NvbmZpZy9zcHUvc3B1LmgJKHJldmlzaW9uIDE0MTI4OSkK KysrIGdjYy9jb25maWcvc3B1L3NwdS5oCSh3b3JraW5nIGNvcHkpCkBAIC0y NTEsNiArMjUxLDggQEAKIAogI2RlZmluZSBTVEFDS19HUk9XU19ET1dOV0FS RAogCisjZGVmaW5lIEZSQU1FX0dST1dTX0RPV05XQVJEIDEKKwogI2RlZmlu ZSBTVEFSVElOR19GUkFNRV9PRkZTRVQgKDApCiAKICNkZWZpbmUgU1RBQ0tf UE9JTlRFUl9PRkZTRVQgMzIKQEAgLTMxMiw4ICszMTQsNiBAQAogCiAjZGVm aW5lIEZSQU1FX1BPSU5URVJfUkVRVUlSRUQgMAogCi0jZGVmaW5lIElOSVRJ QUxfRlJBTUVfUE9JTlRFUl9PRkZTRVQoREVQVEgpICgoREVQVEgpID0gMCkK LQogI2RlZmluZSBFTElNSU5BQkxFX1JFR1MgIFwKICAge3tBUkdfUE9JTlRF Ul9SRUdOVU0sCSBTVEFDS19QT0lOVEVSX1JFR05VTX0sCQkJCVwKICAge0FS R19QT0lOVEVSX1JFR05VTSwJIEhBUkRfRlJBTUVfUE9JTlRFUl9SRUdOVU19 LAkJCVwKSW5kZXg6IGdjYy9jb25maWcvc3B1L3NwdS5tZAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBnY2MvY29uZmlnL3NwdS9zcHUubWQJKHJldmlz aW9uIDE0MTI4OSkKKysrIGdjYy9jb25maWcvc3B1L3NwdS5tZAkod29ya2lu ZyBjb3B5KQpAQCAtMTU1LDYgKzE1NSw4IEBACiAgKFVOU1BFQ19ERlRTVgkJ IDUxKQogIChVTlNQRUNfRkxPQVRfRVhURU5ECSA1MikKICAoVU5TUEVDX0ZM T0FUX1RSVU5DQVRFCSA1MykKKyAoVU5TUEVDX1NQX1NFVCAgICAgICAgIDU0 KQorIChVTlNQRUNfU1BfVEVTVCAgICAgICAgNTUpIAogXSkKIAogKGluY2x1 ZGUgInByZWRpY2F0ZXMubWQiKQpAQCAtNTE4OCw0ICs1MTkwLDUxIEBACiAg IERPTkU7CiB9IikKIAorKGRlZmluZV9pbnNuICJzdGFja19wcm90ZWN0X3Nl dCIKKyAgWyhzZXQgKG1hdGNoX29wZXJhbmQ6U0kgMCAic3B1X21lbV9vcGVy YW5kIiAiPW0iKQorICAgICAgICAodW5zcGVjOlNJIFsobWF0Y2hfb3BlcmFu ZDpTSSAxICJzcHVfbWVtX29wZXJhbmQiICJtIildIFVOU1BFQ19TUF9TRVQp KQorICAgKHNldCAobWF0Y2hfc2NyYXRjaDpTSSAyICI9JnIiKSAoY29uc3Rf aW50IDApKV0KKyAgIiIKKyAgImxxJXAxXHQlMiwlMVw7c3RxJXAwXHQlMiwl MFw7eG9yXHQlMiwlMiwlMiIKKyAgWyhzZXRfYXR0ciAibGVuZ3RoIiAiMTIi KQorICAgKHNldF9hdHRyICJ0eXBlIiAibXVsdGkxIildCispCiAKKyhkZWZp bmVfZXhwYW5kICJzdGFja19wcm90ZWN0X3Rlc3QiCisgIFsobWF0Y2hfb3Bl cmFuZCAwICJzcHVfbWVtX29wZXJhbmQiICIiKQorICAgKG1hdGNoX29wZXJh bmQgMSAic3B1X21lbV9vcGVyYW5kIiAiIikKKyAgIChtYXRjaF9vcGVyYW5k IDIgIiIgIiIpXQorICAiIgoreworICBydHggY29tcGFyZV9yZXN1bHQ7Cisg IHJ0eCBiY29tcCwgbG9jX3JlZjsKKworICBjb21wYXJlX3Jlc3VsdCA9IGdl bl9yZWdfcnR4IChTSW1vZGUpOworCisgIGVtaXRfaW5zbiAoZ2VuX3N0YWNr X3Byb3RlY3RfdGVzdF9zaSAoY29tcGFyZV9yZXN1bHQsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3BlcmFuZHNbMF0sCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3BlcmFu ZHNbMV0pKTsKKworICBiY29tcCA9IGdlbl9ydHhfTkUgKFNJbW9kZSwgY29t cGFyZV9yZXN1bHQsIGNvbnN0MF9ydHgpOworCisgIGxvY19yZWYgPSBnZW5f cnR4X0xBQkVMX1JFRiAoVk9JRG1vZGUsIG9wZXJhbmRzWzJdKTsKKworICBl bWl0X2p1bXBfaW5zbiAoZ2VuX3J0eF9TRVQgKFZPSURtb2RlLCBwY19ydHgs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdlbl9ydHhf SUZfVEhFTl9FTFNFIChWT0lEbW9kZSwgYmNvbXAsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs b2NfcmVmLCBwY19ydHgpKSk7CisKKyAgRE9ORTsKK30pCisKKyhkZWZpbmVf aW5zbiAic3RhY2tfcHJvdGVjdF90ZXN0X3NpIgorICBbKHNldCAobWF0Y2hf b3BlcmFuZDpTSSAwICJzcHVfcmVnX29wZXJhbmQiICI9JnIiKQorICAgICAg ICAodW5zcGVjOlNJIFsobWF0Y2hfb3BlcmFuZDpTSSAxICJzcHVfbWVtX29w ZXJhbmQiICJtIikKKyAgICAgICAgICAgICAgICAgICAgKG1hdGNoX29wZXJh bmQ6U0kgMiAic3B1X21lbV9vcGVyYW5kIiAibSIpXQorICAgICAgICAgICAg ICAgICAgIFVOU1BFQ19TUF9URVNUKSkKKyAgIChzZXQgKG1hdGNoX3NjcmF0 Y2g6U0kgMyAiPSZyIikgKGNvbnN0X2ludCAwKSldCisgICIiCisgICJscSVw MVx0JTAsJTFcO2xxJXAyXHQlMywlMlw7Y2VxXHQlMCwlMCwlM1w7eG9yXHQl MywlMywlMyIKKyAgWyhzZXRfYXR0ciAibGVuZ3RoIiAiMTYiKQorICAgKHNl dF9hdHRyICJ0eXBlIiAibXVsdGkxIildCispCisKSW5kZXg6IGNvbmZpZ3Vy ZS5hYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjb25maWd1cmUuYWMJ KHJldmlzaW9uIDE0MTI4OSkKKysrIGNvbmZpZ3VyZS5hYwkod29ya2luZyBj b3B5KQpAQCAtODkyLDcgKzg5Miw2IEBACiAgIHNwYXJjLSotc29sYXJpcyog fCBzcGFyYzY0LSotc29sYXJpcyogfCBzcGFyY3Y5LSotc29sYXJpcyopCiAg ICAgOzsKICAgc3B1LSotKikKLSAgICBza2lwZGlycz0idGFyZ2V0LWxpYnNz cCIKICAgICA7OwogICB2ODEwLSotKikKICAgICBub2NvbmZpZ2RpcnM9IiRu b2NvbmZpZ2RpcnMgYmZkIGJpbnV0aWxzIGdhcyBnY2MgZ2RiIGxkIHRhcmdl dC1saWJzdGRjKystdjMgb3Bjb2RlcyB0YXJnZXQtbGliZ2xvc3MgJHtsaWJn Y2p9Igo= --0__=4EBBFE7FDFB20AED8f9e8a93df938690918c4EBBFE7FDFB20AED--