public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kai Tietz <Kai.Tietz@onevision.com>
To: "GCC Patches" <gcc-patches@gcc.gnu.org>
Cc: NightStrike <nightstrike@gmail.com>
Subject: Re: [patch]: pr33617 vector modes have to be passed via memory for x86_64-pc-mingw32
Date: Tue, 18 Mar 2008 09:54:00 -0000	[thread overview]
Message-ID: <OFBA888436.61E91B86-ONC1257410.00324716-C1257410.00328C21@onevision.de> (raw)
In-Reply-To: <OF0CD46A34.BEA0BAA0-ONC1257410.00312764-C1257410.0031E760@onevision.de>

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

Hello,

I had a typo in changelog, so I resent. This bug was found via testsuite 
as regression bug for x86_64 mingw. By 
ABI structures and vector types have to be passed via memory.

ChangeLog entries for gcc

2008-03-18  Kai Tietz  <kai.tietz@onevision.com>

        * gcc/config/i386/i386.c (return_in_memory_ms_64): Vector and 
block
          types are passed via memory. (testsuite 
gcc.c-torture/compile/pr33617.c).

Tested for x86_64-pc-mingw32 target. Other targets are not affected.

Cheers,
  Kai



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
 

[-- Attachment #2: mingw64_pr33617.txt --]
[-- Type: text/plain, Size: 765 bytes --]

Index: gcc/gcc/config/i386/i386.c
===================================================================
--- gcc.orig/gcc/config/i386/i386.c
+++ gcc/gcc/config/i386/i386.c
@@ -4827,9 +4827,14 @@ return_in_memory_ms_64 (const_tree type,
   if (!COMPLEX_MODE_P (mode) && size == 16 && VECTOR_MODE_P (mode))
     return 0;
 
-  /* Otherwise, the size must be exactly in [1248]. But not for complex. */
+  /* Structures pass always via memory.  */
+  if (mode == BLKmode)
+    return 1;
+
+  /* Otherwise, the size must be exactly in [1248]. But not for complex
+     and vector. */
   return (size != 1 && size != 2 && size != 4 && size != 8)
-         || COMPLEX_MODE_P (mode);
+         || COMPLEX_MODE_P (mode) || VECTOR_MODE_P (mode);
 }
 
 int
=

  reply	other threads:[~2008-03-18  9:12 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.0801312346090.5937@digraph.polyomino.org.uk>
2008-02-01 11:04 ` Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c Kai Tietz
2008-02-01 15:52   ` Joseph S. Myers
2008-02-04 14:23     ` Kai Tietz
2008-02-13 18:32       ` Joseph S. Myers
2008-02-19  9:22         ` Kai Tietz
2008-02-19 12:38           ` Joseph S. Myers
2008-02-19 13:30             ` Kai Tietz
2008-02-19 14:10               ` Joseph S. Myers
2008-02-19 15:16                 ` Kai Tietz
2008-02-25 16:46                   ` NightStrike
2008-02-25 16:58                     ` Joseph S. Myers
2008-02-25 17:42                       ` NightStrike
2008-02-25 18:53                   ` Joseph S. Myers
2008-03-04 19:25                     ` Joseph S. Myers
2008-03-10 11:06                     ` Kai Tietz
2008-03-10 22:29                       ` Joseph S. Myers
2008-03-13  0:03                         ` Danny Smith
2008-03-13  8:43                           ` Kai Tietz
2008-03-13  9:29                           ` Kai Tietz
2008-03-13 19:24                             ` Ralf Wildenhues
2008-03-14  9:32                               ` Kai Tietz
2008-03-13 20:52                             ` Danny Smith
2008-03-14 11:00                               ` Kai Tietz
2008-03-16  5:54                                 ` Danny Smith
2008-03-16 12:16                                   ` Kai Tietz
2008-03-18  9:12                                     ` [patch]: pr33617 vector modes have to be passed via memory for x86_64-pc-mingw32 Kai Tietz
2008-03-18  9:54                                       ` Kai Tietz [this message]
2008-03-18 13:20                                   ` Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c Kai Tietz
2008-03-18 13:44                                     ` NightStrike
2008-03-18 13:51                                       ` Kai Tietz
2008-03-18 15:07                                       ` Kai Tietz
2008-03-19  5:01                                         ` NightStrike
2008-03-19  6:22                                         ` Danny Smith
2008-03-19  9:42                                           ` Kai Tietz
2008-03-19 13:43                                             ` NightStrike
2008-03-19 13:51                                             ` NightStrike
2008-03-20  1:18                                             ` Danny Smith
2008-03-20  1:18                                               ` NightStrike
2008-03-20  9:54                                               ` Kai Tietz
2008-02-13 21:27       ` Danny Smith
2008-02-19  9:17         ` Kai Tietz
2008-03-19 15:44 [patch]: pr33617 vector modes have to be passed via memory for x86_64-pc-mingw32 Kai Tietz
2008-03-26 17:11 ` NightStrike
2008-03-26 17:22   ` Kai Tietz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OFBA888436.61E91B86-ONC1257410.00324716-C1257410.00328C21@onevision.de \
    --to=kai.tietz@onevision.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nightstrike@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).