From: Ayal Zaks <ZAKS@il.ibm.com>
To: Revital1 Eres <ERES@il.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PING][patch][modulo-sched] Fix order params calculation
Date: Thu, 21 Feb 2008 23:43:00 -0000 [thread overview]
Message-ID: <OFE32B512D.5B630A0B-ONC22573F6.007B91D8-C22573F6.007CD0BB@il.ibm.com> (raw)
In-Reply-To: <OF22352064.A49A7E99-ONC22573F4.002AA3BA-C22573F4.002AFC51@LocalDomain>
Revital1 Eres/Haifa/IBM wrote on 19/02/2008 09:49:31:
> Hello,
>
> http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01065.html
>
> Thanks,
> Revital
> Hello,
>
> The following patch contains a fix to the calculation of the order params
> in case of latency zero.
>
> It is currently bootstrapped and tested on ppc and SPU.
>
> OK for mainline once testing completes?
>
OK.
Please add the explanation/testcase why this fix is needed -- we want the
ASAP/ALAP/HEIGHT parameters to maintain the direction of dependencies,
including those having zero latency.
Ayal.
> :ADDPATCH modulo-sched:
>
> Thanks,
> Revital
>
> 2008-01-23 Ayal Zaks <zaks@il.ibm.com>
>
> * modulo-sched.c (calculate_order_params): Fix calculate of
> order params.
>
>
> Index: modulo-sched.c
> ===================================================================
> --- modulo-sched.c (revision 131717)
> +++ modulo-sched.c (working copy)
> @@ -2174,7 +2174,7 @@
> for (e = u_node->in; e; e = e->next_in)
> if (e->distance == 0);
> ASAP (u_node) = MAX (ASAP (u_node),)
> - ASAP (e->src) + e->latency);
> + ASAP (e->src) + e->latency + 1);
> max_asap = MAX (max_asap, ASAP (u_node));
> }
>
> @@ -2188,9 +2188,9 @@
> if (e->distance == 0)
> {
> ALAP (u_node) = MIN (ALAP (u_node),;
> - ALAP (e->dest) - e->latency);;
> + ALAP (e->dest) - e->latency - 1);
> HEIGHT (u_node) = MAX (HEIGHT (u_node),
> - HEIGHT (e->dest) + e->latency);
> + HEIGHT (e->dest) + e->latency + 1);
> }
> }
> if (dump_file)
>
>
> Thanks,
> Revital
next parent reply other threads:[~2008-02-21 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF22352064.A49A7E99-ONC22573F4.002AA3BA-C22573F4.002AFC51@LocalDomain>
2008-02-21 23:43 ` Ayal Zaks [this message]
2008-02-19 9:01 Revital1 Eres
2008-02-19 9:12 ` Revital1 Eres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFE32B512D.5B630A0B-ONC22573F6.007B91D8-C22573F6.007CD0BB@il.ibm.com \
--to=zaks@il.ibm.com \
--cc=ERES@il.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).