* Re: [PING][patch][modulo-sched] Fix order params calculation
[not found] <OF22352064.A49A7E99-ONC22573F4.002AA3BA-C22573F4.002AFC51@LocalDomain>
@ 2008-02-21 23:43 ` Ayal Zaks
0 siblings, 0 replies; 3+ messages in thread
From: Ayal Zaks @ 2008-02-21 23:43 UTC (permalink / raw)
To: Revital1 Eres; +Cc: gcc-patches
Revital1 Eres/Haifa/IBM wrote on 19/02/2008 09:49:31:
> Hello,
>
> http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01065.html
>
> Thanks,
> Revital
> Hello,
>
> The following patch contains a fix to the calculation of the order params
> in case of latency zero.
>
> It is currently bootstrapped and tested on ppc and SPU.
>
> OK for mainline once testing completes?
>
OK.
Please add the explanation/testcase why this fix is needed -- we want the
ASAP/ALAP/HEIGHT parameters to maintain the direction of dependencies,
including those having zero latency.
Ayal.
> :ADDPATCH modulo-sched:
>
> Thanks,
> Revital
>
> 2008-01-23 Ayal Zaks <zaks@il.ibm.com>
>
> * modulo-sched.c (calculate_order_params): Fix calculate of
> order params.
>
>
> Index: modulo-sched.c
> ===================================================================
> --- modulo-sched.c (revision 131717)
> +++ modulo-sched.c (working copy)
> @@ -2174,7 +2174,7 @@
> for (e = u_node->in; e; e = e->next_in)
> if (e->distance == 0);
> ASAP (u_node) = MAX (ASAP (u_node),)
> - ASAP (e->src) + e->latency);
> + ASAP (e->src) + e->latency + 1);
> max_asap = MAX (max_asap, ASAP (u_node));
> }
>
> @@ -2188,9 +2188,9 @@
> if (e->distance == 0)
> {
> ALAP (u_node) = MIN (ALAP (u_node),;
> - ALAP (e->dest) - e->latency);;
> + ALAP (e->dest) - e->latency - 1);
> HEIGHT (u_node) = MAX (HEIGHT (u_node),
> - HEIGHT (e->dest) + e->latency);
> + HEIGHT (e->dest) + e->latency + 1);
> }
> }
> if (dump_file)
>
>
> Thanks,
> Revital
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PING][patch][modulo-sched] Fix order params calculation
2008-02-19 9:01 Revital1 Eres
@ 2008-02-19 9:12 ` Revital1 Eres
0 siblings, 0 replies; 3+ messages in thread
From: Revital1 Eres @ 2008-02-19 9:12 UTC (permalink / raw)
To: Ayal Zaks; +Cc: gcc-patches
Hello,
http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01065.html
Thanks,
Revital
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PING][patch][modulo-sched] Fix order params calculation
@ 2008-02-19 9:01 Revital1 Eres
2008-02-19 9:12 ` Revital1 Eres
0 siblings, 1 reply; 3+ messages in thread
From: Revital1 Eres @ 2008-02-19 9:01 UTC (permalink / raw)
To: Ayal Zaks; +Cc: gcc-patches
Hello,
http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01065.html
Thanks,
Revital
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-21 22:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <OF22352064.A49A7E99-ONC22573F4.002AA3BA-C22573F4.002AFC51@LocalDomain>
2008-02-21 23:43 ` [PING][patch][modulo-sched] Fix order params calculation Ayal Zaks
2008-02-19 9:01 Revital1 Eres
2008-02-19 9:12 ` Revital1 Eres
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).