From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32146 invoked by alias); 1 Mar 2010 10:26:38 -0000 Received: (qmail 32130 invoked by uid 22791); 1 Mar 2010 10:26:37 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.17.165) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Mar 2010 10:26:33 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.1/8.13.1) with ESMTP id o21AQUMT022269 for ; Mon, 1 Mar 2010 10:26:30 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o21AQUxc1536128 for ; Mon, 1 Mar 2010 11:26:30 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o21AQTcP014561 for ; Mon, 1 Mar 2010 11:26:30 +0100 Received: from d12ml102.megacenter.de.ibm.com (d12ml102.megacenter.de.ibm.com [9.149.170.85]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id o21AQT1V014546; Mon, 1 Mar 2010 11:26:29 +0100 In-Reply-To: References: Subject: Re: [PATCH][RFC] Clean up STMT_VINFO_VECTYPE X-KeepSent: E8E05CAD:F2095049-C22576D9:0037D0AC; type=4; name=$KeepSent To: Richard Guenther Cc: gcc-patches@gcc.gnu.org Message-ID: From: Ira Rosen Date: Mon, 01 Mar 2010 10:26:00 -0000 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-03/txt/msg00013.txt.bz2 Richard Guenther wrote on 25/02/2010 07:05:10 PM: > This cleans up the semantic of STMT_VINFO_VECTYPE to be always the > vector type of the LHS of the statement. This allows to get rid > of a lot of vector type constructions in the various vectorization > routines. Which makes it way easier for me to add support for > multiple vector sizes to the vectorizer as I can restrict setting > vector types to a central analysis place. > > The biggest part of the patch is re-ordering of tests in the > analysis/transform functions where we have to call > vect_is_simple_use_1 to get the input vector type(s). This new > function can now simply look up the definition statement and > return its STMT_VINFO_VECTYPE, something previously not possible > (For non-loop related definitions the analysis/transform function > is still responsible for choosing a proper vector type - but > that's something most already do or should be easy to add. In > the patch I simply fall back to the old method for now) > > Thus, this is part 1 of a series to teach the vectorizer about > AVX 16/32 byte mixed vector sizes. It's a cleanup that looked > obvious anyway, too. > > Bootstrap and regtest running on x86_64-unknown-linux-gnu. > > Does this look reasonable for 4.6? I'd appreciate testing > on powerpc in case I missed some paths not excercised by x86_64/i?86. Looks good to me. I tested with vectorization testsuite on powerpc. I am now running the whole testsuite, will let you know if anything goes wrong. Thanks, Ira