From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23176 invoked by alias); 28 Nov 2007 08:54:17 -0000 Received: (qmail 23161 invoked by uid 22791); 28 Nov 2007 08:54:15 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Nov 2007 08:54:08 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id lAS8s3nC474512 for ; Wed, 28 Nov 2007 08:54:03 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lAS8s2p12506870 for ; Wed, 28 Nov 2007 09:54:03 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lAS8s2xw017458 for ; Wed, 28 Nov 2007 09:54:02 +0100 Received: from d12mc102.megacenter.de.ibm.com (d12mc102.megacenter.de.ibm.com [9.149.167.114]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lAS8s2Hf017451; Wed, 28 Nov 2007 09:54:02 +0100 In-Reply-To: Subject: Re: [PATCH 1/2][Modulo-sched] Fix the direction of the scheduling window To: Ayal Zaks Cc: Andrey Belevantsev , "Alexander Monakov" , gcc-patches@gcc.gnu.org X-Mailer: Lotus Notes Release 7.0 HF277 June 21, 2006 Message-ID: From: Revital1 Eres Date: Wed, 28 Nov 2007 14:17:00 -0000 MIME-Version: 1.0 Content-type: multipart/mixed; Boundary="0__=4DBBF908DFA23C608f9e8a93df938690918c4DBBF908DFA23C60" Content-Disposition: inline X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-11/txt/msg01551.txt.bz2 --0__=4DBBF908DFA23C608f9e8a93df938690918c4DBBF908DFA23C60 Content-type: text/plain; charset=US-ASCII Content-length: 1062 Hello, Thanks for the comments. Attached is the fixed version. > attachment "sms-3.c.txt": > > > /* { dg-do compile } */ > > /* { dg-options "-O2 -fmodulo-sched -funroll-loops -dm" } */ > > > > int X[100]; > > int Y[100]; > > > > int > > foo (int len, long *result) > > { > > int i; > > > > len = 1000; > > long res = *result; > > for (i = 0; i < len; i++) > > res += X[i] * Y[i]; > > > > *result = res; > > } > > > > /* { dg-final { cleanup-rtl-dump "sms" } } */ > > Better check that result is correct on some data, in addition to the fact that > the loop is sms'ed. Done. Re-tested on powerpc64-linux and SPU together with patch 2/2. OK for mainline? Revital 2007-11-28 Ayal Zaks Revital Eres * modulo-sched.c (get_sched_window): Fix the direction of the scheduling window and add dump info. testsuite: 2007-11-27 Vladimir Yanovsky * gcc.dg/sms-3.c: New testcase. (See attached file: sms-3.c.txt)(See attached file: patch_1_2_28.txt) --0__=4DBBF908DFA23C608f9e8a93df938690918c4DBBF908DFA23C60 Content-type: text/plain; name="sms-3.c.txt" Content-Disposition: attachment; filename="sms-3.c.txt" Content-transfer-encoding: base64 Content-length: 712 LyogeyBkZy1kbyBydW4gfSAqLw0KLyogeyBkZy1vcHRpb25zICItTzIgLWZt b2R1bG8tc2NoZWQgLWZ1bnJvbGwtbG9vcHMiIH0gKi8NCg0KZXh0ZXJuIHZv aWQgYWJvcnQgKHZvaWQpOw0KDQppbnQgWFsxMDAwXT17MH07DQppbnQgWVsx MDAwXT17MH07DQoNCmV4dGVybiB2b2lkIGFib3J0ICh2b2lkKTsNCg0KaW50 DQpmb28gKGludCBsZW4sIGxvbmcgYSkNCnsNCiAgaW50IGk7DQogIGxvbmcg cmVzID0gYTsNCg0KICBsZW4gPSAxMDAwOw0KICBmb3IgKGkgPSAwOyBpIDwg bGVuOyBpKyspDQogICAgcmVzICs9IFhbaV0qIFlbaV07DQoNCiAgaWYgKHJl cyAhPSA2MDEpDQogICAgYWJvcnQgKCk7DQoNCn0NCg0KaW50DQptYWluICgp DQp7DQogIFhbMF0gPSBZWzFdID0gMjsNCiAgWVswXSA9IFhbMV0gPSAyMTsN CiAgWFsyXSA9IFlbM10gPSAzOw0KICBZWzJdID0gWFszXSA9IDMxOw0KICBY WzRdID0gWVs1XSA9IDQ7DQogIFlbNF0gPSBYWzVdID0gNDE7DQoNCiAgZm9v ICg1LCAzKTsNCiAgcmV0dXJuIDA7DQp9DQoNCg0K --0__=4DBBF908DFA23C608f9e8a93df938690918c4DBBF908DFA23C60 Content-type: text/plain; name="patch_1_2_28.txt" Content-Disposition: attachment; filename="patch_1_2_28.txt" Content-transfer-encoding: base64 Content-length: 4828 SW5kZXg6IG1vZHVsby1zY2hlZC5jDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQotLS0gbW9kdWxvLXNjaGVkLmMJKHJldmlzaW9uIDEzMDI2OSkNCisrKyBt b2R1bG8tc2NoZWQuYwkod29ya2luZyBjb3B5KQ0KQEAgLTEzNDMsOCArMTM0 Myw5IEBADQogICAgICAgICAgICAgICAgIE1BWCAoZWFybHlfc3RhcnQsIHBf c3QgKyBlLT5sYXRlbmN5IC0gKGUtPmRpc3RhbmNlICogaWkpKTsNCiANCiAg ICAgICAgICAgICAgIGlmIChkdW1wX2ZpbGUpDQotICAgICAgICAgICAgICAg IGZwcmludGYgKGR1bXBfZmlsZSwgInByZWQgc3QgPSAlZDsgZWFybHlfc3Rh cnQgPSAlZDsgIiwgcF9zdCwNCi0gICAgICAgICAgICAgICAgICAgICAgICAg ZWFybHlfc3RhcnQpOw0KKyAgICAgICAgICAgICAgICBmcHJpbnRmIChkdW1w X2ZpbGUsIA0KKyAgICAgICAgICAgICAgICAgICAgICAgICAicHJlZCBzdCA9 ICVkOyBlYXJseV9zdGFydCA9ICVkOyBsYXRlbmN5OiAlZCIsDQorICAgICAg ICAgICAgICAgICAgICAgICAgIHBfc3QsIGVhcmx5X3N0YXJ0LCBlLT5sYXRl bmN5KTsNCiANCiAJICAgICAgaWYgKGUtPmRhdGFfdHlwZSA9PSBNRU1fREVQ KQ0KIAkJZW5kID0gTUlOIChlbmQsIFNDSEVEX1RJTUUgKHZfbm9kZSkgKyBp aSAtIDEpOw0KQEAgLTEzNTQsNiArMTM1NSw3IEBADQogCX0NCiAgICAgICBz dGFydCA9IGVhcmx5X3N0YXJ0Ow0KICAgICAgIGVuZCA9IE1JTiAoZW5kLCBl YXJseV9zdGFydCArIGlpKTsNCisgICAgICAvKiBTY2hlZHVsZSB0aGUgbm9k ZSBjbG9zZSB0byBpdCdzIHByZWRlY2Vzc29ycy4gICovDQogICAgICAgc3Rl cCA9IDE7DQogDQogICAgICAgaWYgKGR1bXBfZmlsZSkNCkBAIC0xMzkwLDgg KzEzOTIsOSBAQA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c19zdCAtIGUtPmxhdGVuY3kgKyAoZS0+ZGlzdGFuY2UgKiBpaSkpOw0KIA0K ICAgICAgICAgICAgICAgaWYgKGR1bXBfZmlsZSkNCi0gICAgICAgICAgICAg ICAgZnByaW50ZiAoZHVtcF9maWxlLCAic3VjYyBzdCA9ICVkOyBsYXRlX3N0 YXJ0ID0gJWQ7Iiwgc19zdCwNCi0gICAgICAgICAgICAgICAgICAgICAgICAg bGF0ZV9zdGFydCk7DQorICAgICAgICAgICAgICAgIGZwcmludGYgKGR1bXBf ZmlsZSwgDQorICAgICAgICAgICAgICAgICAgICAgICAgICJzdWNjIHN0ID0g JWQ7IGxhdGVfc3RhcnQgPSAlZDsgbGF0ZW5jeSA9ICVkIiwNCisgICAgICAg ICAgICAgICAgICAgICAgICAgc19zdCwgbGF0ZV9zdGFydCwgZS0+bGF0ZW5j eSk7DQogDQogCSAgICAgIGlmIChlLT5kYXRhX3R5cGUgPT0gTUVNX0RFUCkN CiAJCWVuZCA9IE1BWCAoZW5kLCBTQ0hFRF9USU1FICh2X25vZGUpIC0gaWkg KyAxKTsNCkBAIC0xNDA1LDYgKzE0MDgsNyBAQA0KIAl9DQogICAgICAgc3Rh cnQgPSBsYXRlX3N0YXJ0Ow0KICAgICAgIGVuZCA9IE1BWCAoZW5kLCBsYXRl X3N0YXJ0IC0gaWkpOw0KKyAgICAgIC8qIFNjaGVkdWxlIHRoZSBub2RlIGNs b3NlIHRvIGl0J3Mgc3VjY2Vzc29ycy4gICovDQogICAgICAgc3RlcCA9IC0x Ow0KIA0KICAgICAgIGlmIChkdW1wX2ZpbGUpDQpAQCAtMTQxOCw2ICsxNDIy LDggQEANCiAgICAgew0KICAgICAgIGludCBlYXJseV9zdGFydCA9IElOVF9N SU47DQogICAgICAgaW50IGxhdGVfc3RhcnQgPSBJTlRfTUFYOw0KKyAgICAg IGludCBjb3VudF9wcmVkcyA9IDA7DQorICAgICAgaW50IGNvdW50X3N1Y2Nz ID0gMDsNCiANCiAgICAgICBzdGFydCA9IElOVF9NSU47DQogICAgICAgZW5k ID0gSU5UX01BWDsNCkBAIC0xNDQ1LDkgKzE0NTEsMTMgQEANCiAJCQkJIC0g KGUtPmRpc3RhbmNlICogaWkpKTsNCiANCiAgICAgICAgICAgICAgIGlmIChk dW1wX2ZpbGUpDQotICAgICAgICAgICAgICAgIGZwcmludGYgKGR1bXBfZmls ZSwgInByZWQgc3QgPSAlZDsgZWFybHlfc3RhcnQgPSAlZDsiLCBwX3N0LA0K LSAgICAgICAgICAgICAgICAgICAgICAgICBlYXJseV9zdGFydCk7DQorICAg ICAgICAgICAgICAgIGZwcmludGYgKGR1bXBfZmlsZSwgDQorICAgICAgICAg ICAgICAgICAgICAgICAgICJwcmVkIHN0ID0gJWQ7IGVhcmx5X3N0YXJ0ID0g JWQ7IGxhdGVuY3kgPSAlZCIsDQorICAgICAgICAgICAgICAgICAgICAgICAg IHBfc3QsIGVhcmx5X3N0YXJ0LCBlLT5sYXRlbmN5KTsNCiANCisgICAgICAg ICAgICAgIGlmIChlLT50eXBlID09IFRSVUVfREVQICYmIGUtPmRhdGFfdHlw ZSA9PSBSRUdfREVQKQ0KKyAgICAgICAgICAgICAgICBjb3VudF9wcmVkcysr Ow0KKw0KIAkgICAgICBpZiAoZS0+ZGF0YV90eXBlID09IE1FTV9ERVApDQog CQllbmQgPSBNSU4gKGVuZCwgU0NIRURfVElNRSAodl9ub2RlKSArIGlpIC0g MSk7DQogCSAgICB9DQpAQCAtMTQ3OCwxMCArMTQ4OCwxNCBAQA0KIAkJCQlz X3N0IC0gZS0+bGF0ZW5jeQ0KIAkJCQkrIChlLT5kaXN0YW5jZSAqIGlpKSk7 DQogDQotICAgICAgICAgICAgICAgaWYgKGR1bXBfZmlsZSkNCi0gICAgICAg ICAgICAgICAgIGZwcmludGYgKGR1bXBfZmlsZSwgInN1Y2Mgc3QgPSAlZDsg bGF0ZV9zdGFydCA9ICVkOyIsIHNfc3QsDQotICAgICAgICAgICAgICAgICAg ICAgICAgICBsYXRlX3N0YXJ0KTsNCisgICAgICAgICAgICAgIGlmIChkdW1w X2ZpbGUpDQorICAgICAgICAgICAgICAgIGZwcmludGYgKGR1bXBfZmlsZSwg DQorICAgICAgICAgICAgICAgICAgICAgICAgICJzdWNjIHN0ID0gJWQ7IGxh dGVfc3RhcnQgPSAlZDsgbGF0ZW5jeSA9ICVkIiwNCisgICAgICAgICAgICAg ICAgICAgICAgICAgc19zdCwgbGF0ZV9zdGFydCwgZS0+bGF0ZW5jeSk7DQog DQorICAgICAgICAgICAgICAgaWYgKGUtPnR5cGUgPT0gVFJVRV9ERVAgJiYg ZS0+ZGF0YV90eXBlID09IFJFR19ERVApDQorICAgICAgICAgICAgICAgICBj b3VudF9zdWNjcysrOw0KKw0KIAkgICAgICBpZiAoZS0+ZGF0YV90eXBlID09 IE1FTV9ERVApDQogCQlzdGFydCA9IE1BWCAoc3RhcnQsIFNDSEVEX1RJTUUg KHZfbm9kZSkgLSBpaSArIDEpOw0KIAkgICAgfQ0KQEAgLTE0OTIsNiArMTUw NiwxNiBAQA0KICAgICAgIHN0YXJ0ID0gTUFYIChzdGFydCwgZWFybHlfc3Rh cnQpOw0KICAgICAgIGVuZCA9IE1JTiAoZW5kLCBNSU4gKGVhcmx5X3N0YXJ0 ICsgaWksIGxhdGVfc3RhcnQgKyAxKSk7DQogICAgICAgc3RlcCA9IDE7DQor ICAgICAgLyogSWYgdGhlcmUgYXJlIG1vcmUgc3VjY2Vzc29ycyB0aGFuIHBy ZWRlY2Vzc29ycyBzY2hlZHVsZSB0aGUNCisgICAgICAgICBub2RlIGNsb3Nl IHRvIGl0J3Mgc3VjY2Vzc29ycy4gICovDQorICAgICAgaWYgKGNvdW50X3N1 Y2NzID49IGNvdW50X3ByZWRzKQ0KKyAgICAgICAgew0KKyAgICAgICAgICBp bnQgb2xkX3N0YXJ0ID0gc3RhcnQ7DQorDQorICAgICAgICAgIHN0YXJ0ID0g ZW5kIC0gMTsNCisgICAgICAgICAgZW5kID0gb2xkX3N0YXJ0IC0gMTsNCisg ICAgICAgICAgc3RlcCA9IC0xOw0KKyAgICAgICAgfQ0KICAgICB9DQogICBl bHNlIC8qIHBzcCBpcyBlbXB0eSAmJiBwc3MgaXMgZW1wdHkuICAqLw0KICAg ICB7DQo= --0__=4DBBF908DFA23C608f9e8a93df938690918c4DBBF908DFA23C60--