"Danny Smith" wrote on 19.03.2008 07:01:25: > On Wed, Mar 19, 2008 at 3:34 AM, Kai Tietz wrote: > > NightStrike wrote on 18.03.2008 14:34:11: > > > > > > > Attached is the gcc test log for formatters for this latest patch > > > (recompiled and retested in like 10 minutes :) > > > > Sorry, this was a typo of mine. I removed the testcase ms_warnll-1.c > > completly. It makes not so much sense to check ISO C90 ll for mingw :) > > I attached the updated patch. > > Actually., I think it makes a lot of sense to test whether the > appropriate warning is reported. I agree, that some testcases have to be added to test all ms versus gnu feature set. When the initial patch is applied, we can add the additional necessary testcases. Eg. the test for 'll', additional tests for 'I64', 'I32', and 'I' in failure cases (ISO C, wrong type specifiers, etc). For this patch I wanted just to have an initial set of major tests, where others can continue on. > Also, if you look again at the msdn page you will note that the field > width flag (a glibc extensuion) is not documented. > Indeed if you test a format like "%5m", you will see that it produces > this as output: "m" The use of this flag should produce a warning. You are right, I removed the 'w' flag for ms_strftime. Cheers, Kai PS: NightStrike could you rerun the testsuite? Thanks in advance. | (\_/) This is Bunny. Copy and paste Bunny | (='.'=) into your signature to help him gain | (")_(") world domination.