From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2074.outbound.protection.outlook.com [40.107.7.74]) by sourceware.org (Postfix) with ESMTPS id 638453858281 for ; Tue, 30 Jan 2024 15:51:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 638453858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 638453858281 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.74 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1706629894; cv=pass; b=daVrwFYyywPIITI61KDzOpKwvxD0jz7KChX8fAarV+HLLJM7dHK/gS81yJptGgA8VSc1zbs33uGug+cifAGnUVXfvMNTPVe8lcz5rX52HP0X0kSSp9hyswoywcTR2mXhQsYT1YAfK2iFuznX7kvNQavpvgC/RRsHeYB6vIDKOUk= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1706629894; c=relaxed/simple; bh=/se5jfLkVMusK1VaLKfRHOOKerXtAUcV9UYRUsIKvk0=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=QdhLJm9HYLcZgxlaYdsxVO5zK3iAA8Nyezt4mqqHzKtjSUZ/9j2+Q9wwFHgI9jqDYPpTtb9XWssShsdEKPYBX4jsZzlto3zRBOG/NMoOd4ll0olifv/0PlMueKJZY1ECZRIVnjI7xQid/T5Xr72Dct0BjR0GRuufduC5Slmm4mE= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lcl41DunUlgaq2nSP37Xy7PtWl7WJ1UrECBWXHYSHKdvoICpUSqwZ3vAXhbq+n38mi/cfyLWrxvqSBCC+bdM6udVoXWeTWOy12rsr9qWqTsNDyMs06bZ2ccADgY/WuD/DyxrssvcTlQ2xscrkbmRRQTB6LfhRIb4kV4QBP7PcwPh4EjSDANkMhFLKAL6yXCFFbNsJHHrt13aX5w33Bh3dQ1gbTDAbtueOVpmm5lwpKiZg2ZY95VeXr/QAEzvmpo2cDk+Fy7L8WbNY7qxt5IYwGrYGv8prLqHl9rbDhnW2UZpkQ+wfWDXr71EqBlsBaFjjKtIGrdHg4ugmTqxOcl22A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/se5jfLkVMusK1VaLKfRHOOKerXtAUcV9UYRUsIKvk0=; b=XN+YWMSO2vXwrIir0Szl6NgKkFhRS2Q7TH2U1efJEnetSML09545uwEKS4ihiHEwVjhG+kdNjI75SekfYWS5Y4YEQQ6oYou+UVGGVJmirGmqHK38mMOZW4NjP5FdDlXFbCC3mRDJQqmJgBYGXiqyHegUJDpUQyPGeeksWXWPNQjBIlWDgrXXSVP3tj9AfNkSlvbooB3iD+PJjXtUjM0O5Pkz7v89TwMS7PdFVpGeRLkbSVarMBw/APohcaPQTABZLw6EUdtgFjckWWYPIMOBbdv7+Bstycb8abwwourNv4SugO78mLXJPksryDCaUd2i6UVzIs6GDQnE0nemANOVkg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/se5jfLkVMusK1VaLKfRHOOKerXtAUcV9UYRUsIKvk0=; b=duszAMHp/PiAJgJ8WOTtcle29BrcMP4GM86kpqPttDOKUonuTHcb3LO8CQHD12j1oEhDJ56ntJc4R7VPGcrAglAczH0NHBewh8E8EXD5p0iO0fxTW5C0yHSAObDbZWBk8fYBmRlddPDdQqzMOWxa5Qtbm1BWRW0/4yiPBfRG2HU= Received: from DB7PR03CA0089.eurprd03.prod.outlook.com (2603:10a6:10:72::30) by AS8PR08MB6358.eurprd08.prod.outlook.com (2603:10a6:20b:337::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Tue, 30 Jan 2024 15:51:29 +0000 Received: from DB1PEPF0003922D.eurprd03.prod.outlook.com (2603:10a6:10:72:cafe::5) by DB7PR03CA0089.outlook.office365.com (2603:10a6:10:72::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32 via Frontend Transport; Tue, 30 Jan 2024 15:51:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF0003922D.mail.protection.outlook.com (10.167.8.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.19 via Frontend Transport; Tue, 30 Jan 2024 15:51:29 +0000 Received: ("Tessian outbound a064b9944658:v228"); Tue, 30 Jan 2024 15:51:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 46820acc4171a2ae X-CR-MTA-TID: 64aa7808 Received: from f6db2884d7b5.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 11DB95CC-5352-4360-9F8C-1CCA8A866D04.1; Tue, 30 Jan 2024 15:51:22 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f6db2884d7b5.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 30 Jan 2024 15:51:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7N6TrxJNR61T2auZl9Hl5uUb3+vIQmwus+z88ra3/Pqiux44bLs1EDAkgHJpm08XGlsWxUSPkMvx0b11onZ9TPdyUSugFtxyWWr2I+UOC2yOTTpSnJ/PxFeirw68BUcxTKUrQltJ12SHDlSE83Y/uWNqWtl67n6kieYAbPu0D4u8anR9bPWBT2Afk9mHLaIpLWoMpj8y7Rmn6wuqVcNjoj4tWZcXtsUAJ95FYUQKY0O9kjI7J5IsgpIMLlO/7xZpgLVWKmd9vzpGQwQnGp9d5wTfg/xNLvzEGXm/er8IvJ9TkFAJ2oyzeeJxmHlXZF1eFFWFEBjnnMAUUWDuWjp2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/se5jfLkVMusK1VaLKfRHOOKerXtAUcV9UYRUsIKvk0=; b=hMY+ixXwqs2angWpn+vuQK/L8zXJlliV0XQyX5qg3aPnLs5zTsPcVsJo9RWNP2N4uEmCQKQrlHU7DENO0YnqCsTH7F90cPE8XF+kTCATA8QCL+K0VuukiVrrUfib7EEoLUIC9RLsIQ96Nn7GfjycGYY2iMv+vOhZ0vNSLUO2fPGu8Qbs3Q+FQEC4VgO56KCVksJ861ji7IRy/AaTrrqrPj540t4fhPwFfh52ZYppXUH1GZqavF89aciO4JGuXG9Ecg9ahEFX7xXNFasFpW9eW0RnEEDps4WMt0UgmQJY/3v+1vkQF3UlDrufdAHV00bcaB1d/AhxjcKHTZivdPnT6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/se5jfLkVMusK1VaLKfRHOOKerXtAUcV9UYRUsIKvk0=; b=duszAMHp/PiAJgJ8WOTtcle29BrcMP4GM86kpqPttDOKUonuTHcb3LO8CQHD12j1oEhDJ56ntJc4R7VPGcrAglAczH0NHBewh8E8EXD5p0iO0fxTW5C0yHSAObDbZWBk8fYBmRlddPDdQqzMOWxa5Qtbm1BWRW0/4yiPBfRG2HU= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by VI0PR08MB10582.eurprd08.prod.outlook.com (2603:10a6:800:20f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Tue, 30 Jan 2024 15:51:18 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::381e:a45c:29f8:65c]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::381e:a45c:29f8:65c%7]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 15:51:18 +0000 From: Wilco Dijkstra To: Richard Sandiford CC: Richard Earnshaw , Kyrylo Tkachov , GCC Patches , Richard Earnshaw Subject: Re: [PATCH v4] AArch64: Cleanup memset expansion Thread-Topic: [PATCH v4] AArch64: Cleanup memset expansion Thread-Index: AQHaQz2R+nbcCZyNOEiO763kMev3rrDTWwp1gB9DXKw= Date: Tue, 30 Jan 2024 15:51:18 +0000 Message-ID: References: <372b9689-24b5-41f4-a990-5aee0226e15f@foss.arm.com> <61c6e268-188c-4b35-956d-bd8927d705f2@foss.arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|VI0PR08MB10582:EE_|DB1PEPF0003922D:EE_|AS8PR08MB6358:EE_ X-MS-Office365-Filtering-Correlation-Id: 0fa48685-3592-4f0e-bdd1-08dc21ab52fb x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TBW77OxwwxWNY++NmTtUGe6CedTT2ay62tXBKT6RZoz+DQwQfidSpLF6RcFgJrIe47Fr5RfoN2xnyVcw09zUGw/KFa2RtaWkVZY/pSWxudXlCpIIDXaFAkbqauIXSiYqS7A+D7qeyPfrI9HnPObfuUpzX8/GakfFEMKiVIWywZmVYXvX+3tR/jRgQDHT02ZpXcWt1NkK48ZojJNuKppzzk+dHw4HBqSaHgr1LH4VlqsyeXKTiTXpW88sObc6QVJW4VIZw9d5owYeUIfIau33AS31IcCpI6C1Qg6MIK46S2QQpMUKed/Pr7f3I/6adIzC2LVKr57XSofog7neEK1dv3+oLrrmunQQOFVwHUnJzyXkFX9D3m6I6j3Q0Cob1mcn08D59ZMtY+r2ZYIhCOxIMoDFt/UNKAP/qQcIpIBv1OljBy4yXYe5V8deJjodradgZcUrOeo+5enbaaqy5IyjGUHwKRRrFFRKYO35GYXEauM0buawi0ww7Th+e2+ELALZZGMbqI8veaiOYveiRHlGw0b6/TDvvORrNBk2QxlxuJpFZs8QKfldL/Lt9VTA3Q3W08glWTk2+hF21AUQxxDULvnZtnfjL893uj+3tD97tBylQfMUXvBK9UA/t4DzvPIC1ULxqv/clvE7XWgAXQ5KhQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(346002)(39860400002)(376002)(136003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(26005)(55016003)(7696005)(6506007)(83380400001)(86362001)(33656002)(38070700009)(41300700001)(52536014)(6862004)(5660300002)(4326008)(38100700002)(9686003)(66946007)(122000001)(478600001)(71200400001)(316002)(8936002)(91956017)(54906003)(76116006)(64756008)(66556008)(66446008)(66476007)(2906002)(966005)(6636002)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10582 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF0003922D.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9c89428e-b8f1-420a-0027-08dc21ab4c8e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0D/YZeJF4WVKn5zRgmVAzEbal6h8jlwaaMfiRxEderJIXl7wDz7x31qFR5ZNSU3pJFA/N1+XcbdyXAaak82Uimm5P0lHJLtQ7vDLd1krMgCPRYgSXocsADNb3W9sJb17ZNj1TiUF0Ga0mm7TiEXYcl2VJ361lhKRfl63QQlAuBDQ8j1twlNiDFZ+RWnHLDxFjLTrtN1vEDyWz2OJZcdr04VyEQEg1Rkw9mHSmyML7RskHEb4xwyx8LmSU98OWTJ6YhDLR8f9GU7tA47bnvVhGYEnojdRSIIA0hhqI0PkAqQ24DVhti3+3139EPeR1/lTf2WVAp6BUFtQ0lnFnUNCxlVNn03AJVMx0+xiIGpgB9hnxHX+hfupXjQ+O/Goy00+CfIqXRgetsN64xD/jfZ/bh0nTDyr8qmZ2td9R5qFWD6SxzXygMR41Spl40fQfEvsX9v3SzfrWRmWC2HFOOPjsZYg0vVtZ/+n8fRvuLPzaQGByBhCLiWR5Rezz8Id/IvCk3rwqfm30565RLOa7VTUPJKoEQGS5TLogB6gO3IMP7OFXGArntC/8K8oE36qp3PlGDi/tI7ddOsdQFog8VKhUDnn9ec4yJg2Il8ZvhS1vtEjdE8+QI2G12QfVTgduFaybco1PdroVSkk2iW3un8x/ozNKsWonoEt4+1aLAS+tKCufHstw2IQxrpR+SU1p3Fj93hEoeaR+bPrqf9CAiqI3/UqaH9sMmH0tGqfGELLVwBYecVNAdMEtGzZvUVWy227ayt7URj4UWNZWUcimk+ffg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(136003)(39860400002)(346002)(376002)(230922051799003)(64100799003)(1800799012)(451199024)(82310400011)(186009)(40470700004)(46966006)(36840700001)(86362001)(36860700001)(47076005)(41300700001)(83380400001)(33656002)(356005)(82740400003)(81166007)(52536014)(8676002)(6862004)(336012)(478600001)(70206006)(70586007)(316002)(54906003)(26005)(2906002)(7696005)(9686003)(5660300002)(6506007)(8936002)(4326008)(966005)(6636002)(40460700003)(40480700001)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 15:51:29.5121 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0fa48685-3592-4f0e-bdd1-08dc21ab52fb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF0003922D.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6358 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard,=0A= =0A= >> That tune is only used by an obsolete core. I ran the memcpy and memset= =0A= >> benchmarks from Optimized Routines on xgene-1 with and without LDP/STP.= =0A= >> There is no measurable penalty for using LDP/STP. I'm not sure why it wa= s=0A= >> ever added given it does not do anything useful. I'll post a separate pa= tch=0A= >> to remove it to reduce the maintenance overhead.=0A= =0A= Patch: https://gcc.gnu.org/pipermail/gcc-patches/2024-January/644442.html= =0A= =0A= > Is that enough to justify removing it though?=A0 It sounds from:=0A= >=0A= >=A0 https://gcc.gnu.org/pipermail/gcc-patches/2018-June/500017.html=0A= >=0A= > like the problem was in more balanced code, rather than memory-limited=0A= > things like memset/memcpy.=0A= >=0A= > But yeah, I'm not sure if the intuition was supported by numbers=0A= > in the end.=A0 If SPEC also shows no change then we can probably drop it= =0A= > (unless someone objects).=0A= =0A= SPECINT didn't show any difference either, so LDP doesn't have a measurable= =0A= penalty. It doesn't look like the original commit was ever backed up by ben= chmarks...=0A= =0A= > Let's leave this patch until that's resolved though, since I think as it= =0A= > stands the patch does leave -Os -mtune=3Dxgene1 worse off (bigger code).= =0A= > Handling the tune in the meantime would also be OK.=0A= =0A= Note it was incorrectly handling -Os, it should still form LDP in that case= =0A= and take advantage of longer and faster inlined memcpy/memset instead of=0A= calling a library function.=0A= =0A= >=A0=A0=A0 /* Default the maximum to 256-bytes when considering only libcal= l vs=0A= >=A0=A0=A0=A0=A0=A0 SIMD broadcast sequence.=A0 */=0A= =0A= > ...this comment should be deleted along with the code it's describing.=0A= > Don't respin just for that though :)=0A= =0A= I've fixed that locally.=0A= =0A= Cheers,=0A= Wilco=