From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Richard Earnshaw <Richard.Earnshaw@arm.com>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] ARM: Fix conditional execution [PR113915]
Date: Mon, 26 Feb 2024 16:05:52 +0000 [thread overview]
Message-ID: <PAWPR08MB89825DE72CC8B2BF3C73D73C835A2@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <a5e74777-79cd-4025-ade1-fa119d680172@arm.com>
Hi Richard,
> Did you test this on a thumb1 target? It seems to me that the target parts that you've
> removed were likely related to that. In fact, I don't see why this test would need to be changed at all.
The testcase explicitly forces a Thumb-2 target (arm_arch_v6t2). The patterns
were wrong for Thumb-2 indeed, and the testcase was explicitly testing for this.
There is a separate builtin-bswap-2.c for Thumb-1 target (arm_arch_v6m).
Cheers,
Wilco
next prev parent reply other threads:[~2024-02-26 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 14:34 Wilco Dijkstra
2024-02-21 15:58 ` Richard Earnshaw (lists)
2024-02-23 15:46 ` Wilco Dijkstra
2024-02-26 15:58 ` Richard Earnshaw (lists)
2024-02-26 16:05 ` Wilco Dijkstra [this message]
2024-02-26 16:13 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR08MB89825DE72CC8B2BF3C73D73C835A2@PAWPR08MB8982.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).