public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729]
@ 2021-12-16 10:36 Przemyslaw Wirkus
  2021-12-16 10:45 ` Richard Sandiford
  0 siblings, 1 reply; 3+ messages in thread
From: Przemyslaw Wirkus @ 2021-12-16 10:36 UTC (permalink / raw)
  To: gcc-patches
  Cc: christophe.lyon, Richard Earnshaw, Richard Sandiford,
	Kyrylo Tkachov, Marcus Shawcroft

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Hi,

This patch is sorting issue with LS64 intrinsics tests failing with
AArch64_be targets.

Regtested on aarch64_be_elf and aarch64_elf, no issues.

OK to install?

gcc/ChangeLog:

	PR target/PR103729
	* config/aarch64/aarch64-simd.md (aarch64_movv8di): Allow big endian
	targets to move V8DI.

[-- Attachment #2: rb15153.patch --]
[-- Type: application/octet-stream, Size: 786 bytes --]

diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md
index 9ebf795a624f0183e0333349d0db7a71ba2d17dd..f95a7e1d91c97c9e981d75e71f0b49c02ef748ba 100644
--- a/gcc/config/aarch64/aarch64-simd.md
+++ b/gcc/config/aarch64/aarch64-simd.md
@@ -7265,9 +7265,8 @@ (define_insn "*aarch64_mov<mode>"
 (define_insn "*aarch64_movv8di"
   [(set (match_operand:V8DI 0 "nonimmediate_operand" "=r,m,r")
 	(match_operand:V8DI 1 "general_operand" " r,r,m"))]
-  "!BYTES_BIG_ENDIAN
-   && (register_operand (operands[0], V8DImode)
-       || register_operand (operands[1], V8DImode))"
+  "(register_operand (operands[0], V8DImode)
+    || register_operand (operands[1], V8DImode))"
   "#"
   [(set_attr "type" "multiple,multiple,multiple")
    (set_attr "length" "32,16,16")]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729]
  2021-12-16 10:36 [PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729] Przemyslaw Wirkus
@ 2021-12-16 10:45 ` Richard Sandiford
  2021-12-16 10:52   ` Przemyslaw Wirkus
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2021-12-16 10:45 UTC (permalink / raw)
  To: Przemyslaw Wirkus
  Cc: gcc-patches, christophe.lyon, Richard Earnshaw, Kyrylo Tkachov,
	Marcus Shawcroft

Przemyslaw Wirkus <Przemyslaw.Wirkus@arm.com> writes:
> Hi,
>
> This patch is sorting issue with LS64 intrinsics tests failing with
> AArch64_be targets.
>
> Regtested on aarch64_be_elf and aarch64_elf, no issues.
>
> OK to install?
>
> gcc/ChangeLog:
>
> 	PR target/PR103729
> 	* config/aarch64/aarch64-simd.md (aarch64_movv8di): Allow big endian
> 	targets to move V8DI.

OK, thanks.

Richard

> diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md
> index 9ebf795a624f0183e0333349d0db7a71ba2d17dd..f95a7e1d91c97c9e981d75e71f0b49c02ef748ba 100644
> --- a/gcc/config/aarch64/aarch64-simd.md
> +++ b/gcc/config/aarch64/aarch64-simd.md
> @@ -7265,9 +7265,8 @@ (define_insn "*aarch64_mov<mode>"
>  (define_insn "*aarch64_movv8di"
>    [(set (match_operand:V8DI 0 "nonimmediate_operand" "=r,m,r")
>  	(match_operand:V8DI 1 "general_operand" " r,r,m"))]
> -  "!BYTES_BIG_ENDIAN
> -   && (register_operand (operands[0], V8DImode)
> -       || register_operand (operands[1], V8DImode))"
> +  "(register_operand (operands[0], V8DImode)
> +    || register_operand (operands[1], V8DImode))"
>    "#"
>    [(set_attr "type" "multiple,multiple,multiple")
>     (set_attr "length" "32,16,16")]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729]
  2021-12-16 10:45 ` Richard Sandiford
@ 2021-12-16 10:52   ` Przemyslaw Wirkus
  0 siblings, 0 replies; 3+ messages in thread
From: Przemyslaw Wirkus @ 2021-12-16 10:52 UTC (permalink / raw)
  To: Richard Sandiford
  Cc: gcc-patches, christophe.lyon, Richard Earnshaw, Kyrylo Tkachov,
	Marcus Shawcroft



> -----Original Message-----
> From: Richard Sandiford <richard.sandiford@arm.com>
> Sent: 16 December 2021 10:46
> To: Przemyslaw Wirkus <Przemyslaw.Wirkus@arm.com>
> Cc: gcc-patches@gcc.gnu.org; christophe.lyon@linaro.org; Richard Earnshaw
> <Richard.Earnshaw@arm.com>; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>;
> Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> Subject: Re: [PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729]
> 
> Przemyslaw Wirkus <Przemyslaw.Wirkus@arm.com> writes:
> > Hi,
> >
> > This patch is sorting issue with LS64 intrinsics tests failing with
> > AArch64_be targets.
> >
> > Regtested on aarch64_be_elf and aarch64_elf, no issues.
> >
> > OK to install?
> >
> > gcc/ChangeLog:
> >
> > 	PR target/PR103729
> > 	* config/aarch64/aarch64-simd.md (aarch64_movv8di): Allow big
> endian
> > 	targets to move V8DI.
> 
> OK, thanks.

Thank you.

commit 0a68862e782847752be0ea2b2a987278cdbefc9e

Przemek

> Richard
> 
> > diff --git a/gcc/config/aarch64/aarch64-simd.md
> > b/gcc/config/aarch64/aarch64-simd.md
> > index
> >
> 9ebf795a624f0183e0333349d0db7a71ba2d17dd..f95a7e1d91c97c9e981d75e71
> f0b
> > 49c02ef748ba 100644
> > --- a/gcc/config/aarch64/aarch64-simd.md
> > +++ b/gcc/config/aarch64/aarch64-simd.md
> > @@ -7265,9 +7265,8 @@ (define_insn "*aarch64_mov<mode>"
> >  (define_insn "*aarch64_movv8di"
> >    [(set (match_operand:V8DI 0 "nonimmediate_operand" "=r,m,r")
> >  	(match_operand:V8DI 1 "general_operand" " r,r,m"))]
> > -  "!BYTES_BIG_ENDIAN
> > -   && (register_operand (operands[0], V8DImode)
> > -       || register_operand (operands[1], V8DImode))"
> > +  "(register_operand (operands[0], V8DImode)
> > +    || register_operand (operands[1], V8DImode))"
> >    "#"
> >    [(set_attr "type" "multiple,multiple,multiple")
> >     (set_attr "length" "32,16,16")]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-16 10:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 10:36 [PATCH][GCC] aarch64: fix: ls64 tests fail on aarch64_be [PR103729] Przemyslaw Wirkus
2021-12-16 10:45 ` Richard Sandiford
2021-12-16 10:52   ` Przemyslaw Wirkus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).