public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: Chung-Ju Wu <jasonwucj@gmail.com>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Cc: "Jason.Wu@anshingtek.com.tw" <Jason.Wu@anshingtek.com.tw>
Subject: RE: [PATCH 2/3][ARM] STAR-MC1 CPU Support - arm: Add individual star-mc1 cost tables and cost functions
Date: Mon, 6 Jun 2022 14:18:33 +0000	[thread overview]
Message-ID: <PAXPR08MB69260D05058B5CA38FD7B46F93A29@PAXPR08MB6926.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <b751121d-cdf2-e18d-328c-d73f0db0fbfb@gmail.com>

Hi jasonwucj,

> -----Original Message-----
> From: Gcc-patches <gcc-patches-
> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Chung-Ju Wu
> via Gcc-patches
> Sent: Thursday, May 26, 2022 8:18 AM
> To: Richard Earnshaw <Richard.Earnshaw@arm.com>; gcc-patches <gcc-
> patches@gcc.gnu.org>
> Cc: Jason.Wu@anshingtek.com.tw
> Subject: [PATCH 2/3][ARM] STAR-MC1 CPU Support - arm: Add individual
> star-mc1 cost tables and cost functions
> 
> Hi,
> 
> Attached is the patch to provide star-mc1 specific cost functions and tables.
> Given these individual implementation, developers are able to make
> their own adjustment to fine-tune star-mc1 performance without affecting
> other cpu configurations.
> 
> Bootstrapped and tested on arm-none-eabi.
> 
> Is it OK for trunk?

It looks like arm_star_mc1_tune, star_mc1_extra_costs and arm_star_mc1_branch_cost are identical to arm_v7m_tune, v7m_extra_costs and arm_cortex_m_branch_cost.
I'd rather not duplicate those structures and functions in the master branch, as they provide a maintenance burden to the community.
If some tuning parameters need to be modified in the future for better performance we can create star-mc1-specific structures on demand then.
Thus, I think we don't want this patch.
Thanks,
Kyrill

  reply	other threads:[~2022-06-06 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  7:18 Chung-Ju Wu
2022-06-06 14:18 ` Kyrylo Tkachov [this message]
2022-06-08  8:32   ` Chung-Ju Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAXPR08MB69260D05058B5CA38FD7B46F93A29@PAXPR08MB6926.eurprd08.prod.outlook.com \
    --to=kyrylo.tkachov@arm.com \
    --cc=Jason.Wu@anshingtek.com.tw \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jasonwucj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).