From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2086.outbound.protection.outlook.com [40.107.6.86]) by sourceware.org (Postfix) with ESMTPS id D7E8B3858D20 for ; Fri, 5 May 2023 10:55:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D7E8B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=immExDrsznYNygTPBwjQj962gtbWKka5XcoDYpEON5Q=; b=HHCaZB+STSG6NWLvsomUmaSgtcTaZDSoSnWW09J0ZgTbGCgnMP2Xqwv5jEjSEZOUomV4Z1VLQo0Y+o4TjLQVQjOs6db5XY+Mf8CMgVD9aEPhR6KK51tmHJiqQAvrOzssKaoUWhlFwVZ/N4BPpk4F+AnruSu2s1ImXSKwxmraDJ4= Received: from DU2P251CA0007.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::9) by AM0PR08MB5332.eurprd08.prod.outlook.com (2603:10a6:208:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 10:55:45 +0000 Received: from DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::d7) by DU2P251CA0007.outlook.office365.com (2603:10a6:10:230::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 10:55:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT009.mail.protection.outlook.com (100.127.143.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 10:55:45 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Fri, 05 May 2023 10:55:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3c22b48e12b77030 X-CR-MTA-TID: 64aa7808 Received: from ca5b7ea4c496.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 26659B57-1852-45B0-934D-B4BA9D71D15E.1; Fri, 05 May 2023 10:55:39 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca5b7ea4c496.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 May 2023 10:55:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0dyJHD9gNJbpKsZ8TOnPdEMWLPqTkBy/ukB7bOIfzIugpeuGxLxi/lQtyPOgjfqAPkjtAl5VlUtJQKcPRefyuU5eiRRQasi3gN8ORt3ZtRgO5+3x9r69snoB5voLBqNsKLv3lk+g3Dm/vMKzj7l0h6sIByz1DxXVkXoH3cJ9E8D9SC0iGMverQmZaUVAYRB7hRsYzPT2tBu+4vjqteEmbXhv+SrisSMjLm5tsNt5DIrkpGrHXFQag7gKES0aq+ywMepzz39pZq+c+emiY09aVairBxafHKLasGZpqz5FOmV/7epJgo98MsaE9u67U+XaJ1hCGM8USrjvVMi0eoVpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=immExDrsznYNygTPBwjQj962gtbWKka5XcoDYpEON5Q=; b=VB3ng70PtOFDxiBz1BmnTuRffG4u/XR+SWwR58XQ+gW2z7K1TZqUIYbHmP6kGWxqvG7sAui920507LjMYVaj3EDKNpZ3Eb1RaP0H794NN7HPVVlLPgPYX3QEVIQlaqzYs694N9MRVpZvrI5Up1KSlL2NXa1Op4VchCFpDq3c/9E4kz9g7gkYKegGNaX/XjbINlNUpWFbO88VvrxCJxZzXPfLKg1g3yxlBgbvltTxsBOUjGgsUUWRLKDyTZxWh2F9tgUBX4AQ/Iy2ES7/L6LBVNtc1OqPlTLEpYrBqg6VU7JfJBP3+JPl8dDVXhHRO5u5zE6vQjRe1MtTP21K674Uig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=immExDrsznYNygTPBwjQj962gtbWKka5XcoDYpEON5Q=; b=HHCaZB+STSG6NWLvsomUmaSgtcTaZDSoSnWW09J0ZgTbGCgnMP2Xqwv5jEjSEZOUomV4Z1VLQo0Y+o4TjLQVQjOs6db5XY+Mf8CMgVD9aEPhR6KK51tmHJiqQAvrOzssKaoUWhlFwVZ/N4BPpk4F+AnruSu2s1ImXSKwxmraDJ4= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by AS2PR08MB10154.eurprd08.prod.outlook.com (2603:10a6:20b:62e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 10:55:36 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1%3]) with mapi id 15.20.6363.027; Fri, 5 May 2023 10:55:36 +0000 From: Kyrylo Tkachov To: Christophe Lyon , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Richard Sandiford CC: Christophe Lyon Subject: RE: [PATCH 09/23] arm: [MVE intrinsics] add support for MODE_r Thread-Topic: [PATCH 09/23] arm: [MVE intrinsics] add support for MODE_r Thread-Index: AQHZfy0uIV1vaRQRgkqzMEkdsQK23K9LgSVw Date: Fri, 5 May 2023 10:55:36 +0000 Message-ID: References: <20230505083930.101210-1-christophe.lyon@arm.com> <20230505083930.101210-9-christophe.lyon@arm.com> In-Reply-To: <20230505083930.101210-9-christophe.lyon@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|AS2PR08MB10154:EE_|DBAEUR03FT009:EE_|AM0PR08MB5332:EE_ X-MS-Office365-Filtering-Correlation-Id: 09a8d75f-7549-4af0-b565-08db4d57475e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 94jCmCMqVlysm0UUofLi1qQ8GfE1hsPt8O8oxfCVkQ0tps3S/Hp11tTTNUIVxL8Sw6dGl1hJF8LLYT05XM0K6ZitVoGoIe1hvuJayBN+D8WuCZ9U9/zcKDcyHT5ECUABj7eEIHlz0pFoNZPC4hy1pgINjdX/qHdDSfYsqeJpKdXlCf/Cd+QCk8jOvR4PwMaEhcY/c29izRWoki6okkXbyASmwkJ99l5WKFXQhsrLtAH/5dz6/67C4cJYynZkrdriYDYiaq7ip/MqkJdEEgN/mzkUoaG05g2MqJ6pbwXpnZfuayamje3bAG4l8gXBV4WGqvHj8BVJBFN50ZRNykaOoVKIly4B5oJJHu+LGuyfAn9wbsV5DyUdZ9NXaeddIJ8zWcSLMbB3eqbvXGz21rIkuYXHrb/NRDkvWKnOv/KIso2qEXOKpEDMoOEn40sIYT0NEUfmHYhkPqVlYsG+fjuaIyvx7KRnRK6W/DQJRTh8HpEnc4Ez3tJTJv+DTsKLYHQv+gzej/NrRcJa8fJDVxAVRZvbdP+zBDcxSrBwNiuTO9X/8KKuIv4zZyUopTFeP9CLA8342njnS9UtWD8sqWp82yFO+8vRpUcvH+lDSLsC6zqNvctLrPF6NVt4e5Wxi9RH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(136003)(39860400002)(396003)(376002)(451199021)(83380400001)(186003)(55016003)(86362001)(38070700005)(38100700002)(33656002)(122000001)(5660300002)(52536014)(8676002)(8936002)(66476007)(66556008)(64756008)(6636002)(4326008)(478600001)(66946007)(76116006)(66446008)(71200400001)(7696005)(316002)(41300700001)(26005)(6506007)(9686003)(2906002)(53546011)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10154 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b98e407b-6368-4d97-136b-08db4d5741d0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ivpla+xWxXsLkQPVrLHAtdPvM71+Y3TmS/YKkoq+J6hIu7+1n7X2KLeKfo0MIzbxYlaBEfhYe2DP4GCyi+wvFLssIfwkldCa48rlbtDh0k3O2oztlpCKY8hP4IR1nm9pEYmONmtfPLozBFmkoRTDbwFtDpxIH44gIDpHKjbMnGWiclasozFvtVRF3M6p+DVP+5JQqlLUgX4vi9C5efeOMqFWgoaVAlAdJF5P6Wiq4CdlzLbJJ3pM+/tt3RGklI+g4mzMzMxGiQO7FdO5mkBPjCkn1Euysk/bAeI65Qo1pxOy4Ez2iCyDmzoaT58jHkzm1jZa5WhLSTuf9DQAFWjz5n80YFPZfz8OpM86WmyOHe8E5ihqJ7U/UHBdhjn+uyENQ+R7g0Gt3KjILe5o7pF5hNL3FM9n3tNVqpUub2haa5fsUEBKhUC0EFraKbMmJiiiQUtGbr/6501tp24Pm4pjYn+dosPzLWKrQ+jf7BiolAyQ0t076RsaeDA6UmVs4PvLnp8idwsWhPfUn2JXtODmi5mxq5rU/t0jyXfqzN3mbtzbhWAR3i7+4cAnuOSQ2nZhevYpF1AANZnhLvxsrJU1C3cRRNm/kGOTK1J+w4LxKoG8XTdd+68XdYuNU+MzuOJiSw58GfmBVm6O5duNxXs1eRBZw7l4cI9qCb001g5tusHUJP8JTuPeG6GoobXch0TQRJzNE+IOSIe66j1xKQh4az+6CSKjqseTBg+1G9pwPFw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199021)(40470700004)(46966006)(36840700001)(33656002)(6506007)(8936002)(8676002)(9686003)(26005)(47076005)(53546011)(478600001)(40480700001)(7696005)(40460700003)(82310400005)(55016003)(52536014)(41300700001)(2906002)(5660300002)(110136005)(86362001)(70586007)(186003)(34020700004)(4326008)(70206006)(6636002)(336012)(83380400001)(36860700001)(356005)(81166007)(82740400003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 10:55:45.7939 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09a8d75f-7549-4af0-b565-08db4d57475e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5332 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Christophe Lyon > Sent: Friday, May 5, 2023 9:39 AM > To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov ; > Richard Earnshaw ; Richard Sandiford > > Cc: Christophe Lyon > Subject: [PATCH 09/23] arm: [MVE intrinsics] add support for MODE_r >=20 This is missing a description of what MODE_r is. I've deduced what it is from looking at the next 3 patches in the series, b= ut I think this patch should have at least a one-sentence summary. Therefore ok with a cover letter. Thanks, Kyrill > 2022-09-08 Christophe Lyon >=20 > gcc/ > * config/arm/arm-mve-builtins.cc (has_inactive_argument) > (finish_opt_n_resolution): Handle MODE_r. > * config/arm/arm-mve-builtins.def (r): New mode. > --- > gcc/config/arm/arm-mve-builtins.cc | 8 ++++++-- > gcc/config/arm/arm-mve-builtins.def | 1 + > 2 files changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/gcc/config/arm/arm-mve-builtins.cc b/gcc/config/arm/arm-mve- > builtins.cc > index 91b3ae71f94..c25b1be9903 100644 > --- a/gcc/config/arm/arm-mve-builtins.cc > +++ b/gcc/config/arm/arm-mve-builtins.cc > @@ -669,7 +669,8 @@ function_instance::has_inactive_argument () const > if (pred !=3D PRED_m) > return false; >=20 > - if ((base =3D=3D functions::vorrq && mode_suffix_id =3D=3D MODE_n) > + if (mode_suffix_id =3D=3D MODE_r > + || (base =3D=3D functions::vorrq && mode_suffix_id =3D=3D MODE_n) > || (base =3D=3D functions::vqrshlq && mode_suffix_id =3D=3D MODE_n= ) > || (base =3D=3D functions::vrshlq && mode_suffix_id =3D=3D MODE_n)= ) > return false; > @@ -1522,7 +1523,10 @@ finish_opt_n_resolution (unsigned int argno, > unsigned int first_argno, > { > if (inferred_type =3D=3D NUM_TYPE_SUFFIXES) > inferred_type =3D first_type; > - tree scalar_form =3D lookup_form (MODE_n, inferred_type); > + mode_suffix_index scalar_mode =3D MODE_n; > + if (mode_suffix_id =3D=3D MODE_r) > + scalar_mode =3D MODE_r; > + tree scalar_form =3D lookup_form (scalar_mode, inferred_type); >=20 > /* Allow the final argument to be scalar, if an _n form exists. */ > if (scalar_argument_p (argno)) > diff --git a/gcc/config/arm/arm-mve-builtins.def b/gcc/config/arm/arm-mve= - > builtins.def > index 49d07364fa2..e3f37876210 100644 > --- a/gcc/config/arm/arm-mve-builtins.def > +++ b/gcc/config/arm/arm-mve-builtins.def > @@ -35,6 +35,7 @@ >=20 > DEF_MVE_MODE (n, none, none, none) > DEF_MVE_MODE (offset, none, none, bytes) > +DEF_MVE_MODE (r, none, none, none) >=20 > #define REQUIRES_FLOAT false > DEF_MVE_TYPE (mve_pred16_t, boolean_type_node) > -- > 2.34.1