From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2086.outbound.protection.outlook.com [40.107.22.86]) by sourceware.org (Postfix) with ESMTPS id F2F083858D3C for ; Fri, 10 Nov 2023 12:36:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2F083858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F2F083858D3C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.86 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1699619810; cv=pass; b=tmFVLRFY5UAwcdYI0UYadQiori5UPJXPfroylvreoIN/xst2aTAfUzGytpakqv1egPYWtlZ+6Q6gVh/dbBKUKyXvKATrCMeZ3qfDpfKk0H3rgn8kT/L4hM9u9vw2DOQjDRN/RA7lG6cbOBGfW6rXrpQGATA8T3CscxJGWlELd+M= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1699619810; c=relaxed/simple; bh=grdIoQpJDH2q8TYd7PKdcuh1GFrD7seGdXUjbhlS2qU=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=BaU8jMkKzq/4b4ipIJRok7Nb7QKR+YR+hrBCnD0i1v52DajcuwEN3B+6XYeDVYrMDm9RZmG5la6LVa6YBAaYnBbs3iUu8vO3bC/LC26aTb2FgpcdxkymJQZVkjxr2HP7pwaSnR3TgiNzCSldpH3GdBP3puH4ySq16aC8b+0kggc= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HKika1GaUD0dTZT4f0Ka7DBAkWgDwTI0eYptCykFuw3TKjkDr+ScX5b3ri/vuaKb7YavHsJtL2VHDjmVcwlj4qqNfYSwfCksDXmueL2mM0SRNSNgipg5ufiJ0poRd0GYyox77s6WnlEpxwhCwwQMn19zI4Qw4UF3selH8jjWf5PXkWPTem1Huhly7/6PgdqavRTYDvl6IwQHWpJYNSQLzCuPomqVjXC94cjAtBp2gPYvSD+8a5uXl9PnJDQnlHGDhbE4ihjgLNddgFykIf7oFDLHro1wTQYG25Xtn5DjZW9jvKeMuL/5BQIxunEq+k5khLRyckdaTvyexRhefpFnfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CEqHdovXChvE3lKnDMlnJ+moJ32Z8mxZaMH2T3Uusbk=; b=RN7F/jN4zgorG9HZtFmVY8fSYNqTAnqHuJOq31Y1KH0PSLU+raXohtoIg5904RvbcbDPpUnzpYPZHtaFns0/Y0A4hIvVPuWbZBXbU9FMmlRddwDfPROhXI9/oiKpmNFnQkC0AoXp09J0tOZtV0Qo/S35eGV7whQTflghoumccWMOe4JumERoBuAk5bGh8xqpXfNTATaqvumsNZX0olE5AVAkkSciPkKf3iGTT9YpRguoKGVdv3HBG6TzixNfd55+ud/zL1Zk5yDoFHXeVGHx94ztVgBO3l3jlwK8RhOxCaKiULcyxV0aqCJQsegYciu0hWzP5wSK9HBoaT+IQebTxQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CEqHdovXChvE3lKnDMlnJ+moJ32Z8mxZaMH2T3Uusbk=; b=6nideeBa5pdZHEONd7HseM5nkBvDqtnofmKAyWwqgAYxCvSbgcYScuWI5PWV18NAKR6Ramn0dKm+NHLcWa0VbkwcSvWE4wWCJbVnFt4hL4Zm4iFGIC+v3IUFCVUYKwKxQSv2MADWuMC3T03iTYoEy8Y2K4mjVKX6MuyaLoH4QIU= Received: from DU6P191CA0070.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53e::18) by PAVPR08MB9305.eurprd08.prod.outlook.com (2603:10a6:102:306::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Fri, 10 Nov 2023 12:36:45 +0000 Received: from DU2PEPF0001E9C5.eurprd03.prod.outlook.com (2603:10a6:10:53e:cafe::e2) by DU6P191CA0070.outlook.office365.com (2603:10a6:10:53e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19 via Frontend Transport; Fri, 10 Nov 2023 12:36:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF0001E9C5.mail.protection.outlook.com (10.167.8.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18 via Frontend Transport; Fri, 10 Nov 2023 12:36:45 +0000 Received: ("Tessian outbound 7c4ecdadb9e7:v228"); Fri, 10 Nov 2023 12:36:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: bdc787efd3101e8b X-CR-MTA-TID: 64aa7808 Received: from 2283e0eab0a6.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4E95F2F3-C27D-4D3B-9D59-78E91156AFFA.1; Fri, 10 Nov 2023 12:36:33 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2283e0eab0a6.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 10 Nov 2023 12:36:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEgAthmPXAUQY6NzCjPxV1S4crvrZkVEJSSC5t76oxrJpKy7fRUbzmuKl+Tw+JxBLp++xNId+gGvfDoRqNDjrnkhLn52ia2Beo3Oh/Gz9OzJ0VeqROkiUD4oDY01tpFcE/xRPQ+4zj43PRHr0xnwmj0nWmFLir9oiNb4Z5KP77PJinpdkdI5hoPiwpFUw9weD/Gfya1wOCVrIcVcgwI5extUSGwOpts9azGIwFpx/P1AHeZFr3Fw7y/vhqLIlhFH1Ja2Lt1a/MRTxNzg/k6WihAp9ll4mQ+/9Soc8anCZQgBtq9uA90mquecwKeJ/Gyv93DbccRVcd+Dnku4ZGKMLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CEqHdovXChvE3lKnDMlnJ+moJ32Z8mxZaMH2T3Uusbk=; b=VtpZ/6mdu3SRjM1lmF7kbGeaCkV/BEU+pc1QjiBOjqDloLRw3PvOfwm7sNNMyb/7zqMy73KIxexcipZScg8Hs/5gUQ5hFNh9XJ2OY3MtmZ9Xv7SHPnmJnEmbm/KLU2fGM48sjJxTL3JUKVxuUi2vCjcjA/UIdHQcY9pHzFP0M2LhA+umLutnTLqPiC9/vzO4Kr+h8gsnJQNk6+6Lh+xcS5nY0q55WwMs/zZ8pGsAaPUfIokaOXQteQlTWLzTSgmaJiKwTqLEFW9LYDYMIqzTGkGvuodTR6JJrssPLqMuJCKVtGro451zn76bodmH3tbJDq4PTcA5/1K724fqmJCYKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CEqHdovXChvE3lKnDMlnJ+moJ32Z8mxZaMH2T3Uusbk=; b=6nideeBa5pdZHEONd7HseM5nkBvDqtnofmKAyWwqgAYxCvSbgcYScuWI5PWV18NAKR6Ramn0dKm+NHLcWa0VbkwcSvWE4wWCJbVnFt4hL4Zm4iFGIC+v3IUFCVUYKwKxQSv2MADWuMC3T03iTYoEy8Y2K4mjVKX6MuyaLoH4QIU= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by AS8PR08MB10223.eurprd08.prod.outlook.com (2603:10a6:20b:629::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Fri, 10 Nov 2023 12:36:29 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::afc8:6fef:2f82:559]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::afc8:6fef:2f82:559%4]) with mapi id 15.20.6977.019; Fri, 10 Nov 2023 12:36:29 +0000 From: Kyrylo Tkachov To: Wilco Dijkstra , GCC Patches , Richard Sandiford Subject: RE: [PATCH] libatomic: Improve ifunc selection on AArch64 Thread-Topic: [PATCH] libatomic: Improve ifunc selection on AArch64 Thread-Index: AQHZxuSuUjG3Jeserki4jO+PA+zoTbAZFyVogDO52lKAIPZN9IAGI6NwgAAF0zCAACZHgA== Date: Fri, 10 Nov 2023 12:36:29 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|AS8PR08MB10223:EE_|DU2PEPF0001E9C5:EE_|PAVPR08MB9305:EE_ X-MS-Office365-Filtering-Correlation-Id: 42345b0e-743f-4047-2560-08dbe1e9b312 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6MJzzCjm8ipjVR5G82/APmPO55xGwaEEBndyOHL5uqHc2JGqlv+mnIPdYdYZN+x+JLORy4riFJsW2NiBW28Z2hVLVoopzaamJCw5uOyjDBp2mN+mnD0JwT4Yj5basZMD5T0ycc7slOBhfGFhSYAUq/wB8lpX9tWONurfakzDL2IbpEKODemcRb0dGYzAtz9YYEtmhisgCXM0jdzOqAyUIj3Q1BLGALXeNXj79t3GxCtAFWPOv+j5oHPYIYHd5yLMjD83Udug6reCSOXUmofiWOC13Y0/5q0PmPn7Jv4aNHjFZdgI97K2a3ApPDlWAYrAN3Zlo/3HHvCatF+Z0Gqy+YQ+WFB3XJ2TyDgWzZA6A05TeucJcFu1zwqR1vcOZChE6LCyThMXO8RhGAQHJPTSkYYItKckc23xxVyrblJP+JPdkCZuc760RcT54O/lSd5E3t/vSODDx39GGsz/VAefXDwB0jEXzLMEjeh70U8pAjRRsXMOWMde/2go4HscsrNFfCBfv9efkLNBA6tJRyu7QRIuK9/96UuvRD540+1TtRnF1Suda2kr6M6LFgoaJuf2XegqhBdjJLxVycWVGsCPoOSmpRd3psJDdbWgCT0Fg1w= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(396003)(346002)(366004)(376002)(136003)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(38070700009)(122000001)(76116006)(83380400001)(66946007)(26005)(71200400001)(6506007)(7696005)(478600001)(110136005)(38100700002)(66556008)(53546011)(9686003)(966005)(52536014)(5660300002)(4744005)(2906002)(86362001)(41300700001)(33656002)(66476007)(66446008)(6636002)(64756008)(8676002)(316002)(8936002)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10223 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF0001E9C5.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ab5dbf9c-0eb6-4d5b-ba44-08dbe1e9a9ab X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MLlvQfbLEEtDrSOx4nEaJWp9vNLLEsuvVdOeW4Rv/YyL1dZQdHNIAeDCR4n8ljwupB4/I7byEMsuN+xujJZV+hposO+T4eMDFZ660AV49XQvQtSKtJD5uGZHYSgRrxOOaWbo0oyQnQJTZSCysu2QcuCewB+RS2ikMFzJgozX3Hks8YVZ6+NP20cCHWBFegd3STxNYILeFEl74UvlteLvBeBBAz3R3SIbv5TDLnoP0ehhadi9L1v+7fmYwRI7b9ExmUuV1JLKCugYZKTe+vbEud9JmwfCbYMyRvM3VpWfGvUF+1T3QaMLb2L7ycs/IhlZf0JBIyyx1JpH7Mx/3hGqOAxUynAQwN4qnyMLgl96fYLIAPiUsDD0FHusDbN3gkW4wZ0UjEMxyGx8FdLf2FBjFgnGhEZi9KuZu99z8bUbBIXfJL07YQGTGk9oH6fSDKIAEuqaosBO+mI9TfnDcnhI2u9/bi5JboFrY9X0xnCd0seDOha6ZkewMHHCJQO4aMnqdidBcmVwaRZpksZhO3tmpwxF8GJjw4nekN+CmOYQofnmUYNK+gBAWJqxHwIUuAjq7HDMjV2Cs4I1cIyHmAYK0k5EY7mMIqCSHr41/AbXMXRQFbe75iSDEuva/V6K6IPBrKuwGgbTGwuYpQChfQI6Otwku5kAXGE+MLUC5xs+VpxrwE0V76HHPcKrXWbe+DduMsmvXog+LkAIme5LDQhm5miygpWV9fPJFU7xV35iX/0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(136003)(39860400002)(376002)(346002)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(82310400011)(36840700001)(40470700004)(46966006)(356005)(55016003)(36860700001)(7696005)(6506007)(53546011)(83380400001)(81166007)(47076005)(40480700001)(9686003)(336012)(33656002)(41300700001)(40460700003)(8936002)(8676002)(86362001)(5660300002)(6636002)(316002)(70586007)(110136005)(70206006)(52536014)(82740400003)(2906002)(26005)(478600001)(966005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2023 12:36:45.0997 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42345b0e-743f-4047-2560-08dbe1e9b312 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF0001E9C5.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9305 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Wilco Dijkstra > Sent: Friday, November 10, 2023 10:23 AM > To: Kyrylo Tkachov ; GCC Patches patches@gcc.gnu.org>; Richard Sandiford > Subject: Re: [PATCH] libatomic: Improve ifunc selection on AArch64 >=20 > Hi Kyrill, >=20 > > + if (!(hwcap & HWCAP_CPUID)) > > + return false; > > + > > + unsigned long midr; > > + asm volatile ("mrs %0, midr_el1" : "=3Dr" (midr)); >=20 > > From what I recall that midr_el1 register is emulated by the kernel and= so > userspace software > > has to check that the kernel supports that emulation through hwcaps bef= ore > reading it. > > According to https://www.kernel.org/doc/html/v5.8/arm64/cpu-feature- > registers.html you > > need to check getauxval(AT_HWCAP) & HWCAP_CPUID) before doing that > read. >=20 > That's why I do that immediately before reading midr_el1 - see above. Errr, yes. Obviously I wasn't fully awake when I looked at it! Sorry for the noise. Ok for trunk then. Kyrill >=20 > Cheers, > Wilco