From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: Christophe Lyon <christophe.lyon@foss.st.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: [PATCH 05/13] arm: Add support for VPR_REG in arm_class_likely_spilled_p
Date: Tue, 28 Sep 2021 11:23:07 +0000 [thread overview]
Message-ID: <PAXPR08MB692615FE96B15ACA597ECF9093A89@PAXPR08MB6926.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210907091704.1034380-6-christophe.lyon@foss.st.com>
> -----Original Message-----
> From: Gcc-patches <gcc-patches-
> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Christophe
> Lyon via Gcc-patches
> Sent: 07 September 2021 10:17
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH 05/13] arm: Add support for VPR_REG in
> arm_class_likely_spilled_p
>
> VPR_REG is the only register in its class, so it should be handled by
> TARGET_CLASS_LIKELY_SPILLED_P. No test fails without this patch, but
> it seems it should be implemented.
The documentation for the hook does recommend returning true when there is only one register in the class.
So this seems sensible to me. It's supposed to affect optimisation rather than correctness so I'm in favour of it.
Ok.
Thanks,
Kyrill
>
> 2021-09-01 Christophe Lyon <christophe.lyon@foss.st.com>
>
> gcc/
> * config/arm/arm.c (arm_class_likely_spilled_p): Handle VPR_REG.
>
> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
> index 11dafc70067..1222cb0d0fe 100644
> --- a/gcc/config/arm/arm.c
> +++ b/gcc/config/arm/arm.c
> @@ -29307,6 +29307,9 @@ arm_class_likely_spilled_p (reg_class_t rclass)
> || rclass == CC_REG)
> return true;
>
> + if (TARGET_HAVE_MVE && (rclass == VPR_REG))
> + return true;
> +
> return false;
> }
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-09-28 11:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 9:16 Christophe Lyon
2021-09-07 9:16 ` [PATCH 06/13] arm: Fix mve_vmvnq_n_<supf><mode> argument mode Christophe Lyon
2021-09-28 11:24 ` Kyrylo Tkachov
2021-10-11 13:42 ` Richard Sandiford
2021-10-13 10:19 ` Christophe Lyon
2021-09-07 9:16 ` [PATCH 07/13] arm: Implement MVE predicates as vectors of booleans Christophe Lyon
2021-10-11 13:50 ` Richard Sandiford
2021-09-07 9:16 ` [PATCH 08/13] arm: Implement auto-vectorized MVE comparisons with vectors of boolean predicates Christophe Lyon
2021-10-11 13:59 ` Richard Sandiford
2021-09-07 9:17 ` [PATCH 09/13] arm: Fix vcond_mask expander for MVE (PR target/100757) Christophe Lyon
2021-10-11 14:06 ` Richard Sandiford
2021-09-28 11:23 ` Kyrylo Tkachov [this message]
2021-10-11 13:11 ` [PATCH 05/13] arm: Add support for VPR_REG in arm_class_likely_spilled_p Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR08MB692615FE96B15ACA597ECF9093A89@PAXPR08MB6926.eurprd08.prod.outlook.com \
--to=kyrylo.tkachov@arm.com \
--cc=christophe.lyon@foss.st.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).