From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2046.outbound.protection.outlook.com [40.107.20.46]) by sourceware.org (Postfix) with ESMTPS id 5AA8F385841C for ; Fri, 18 Nov 2022 16:33:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5AA8F385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jfTzSD1Bobv2vJUJtivhZV0tLttmGs4hnSc0FUOlJmA=; b=DqjigdPtIwwW4w3iMx8bbT/Acv7Qn+TdWjhOu2xwx81UojL81k0fWqqFLPLN4rX2oWrC2S+z4w8DDsjoh1iab37WDRFoj0E0F80xgJAx3k9JzwZmWQZz7imzVGe8uflDmeMFZyktSZw8rSyi7rR9krZuUSU+PcCXKk9eMpdWXXs= Received: from DU2PR04CA0082.eurprd04.prod.outlook.com (2603:10a6:10:232::27) by AS8PR08MB8945.eurprd08.prod.outlook.com (2603:10a6:20b:5b5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Fri, 18 Nov 2022 16:33:41 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::1d) by DU2PR04CA0082.outlook.office365.com (2603:10a6:10:232::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 18 Nov 2022 16:33:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 16:33:41 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 18 Nov 2022 16:33:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4095f6ec24588ba3 X-CR-MTA-TID: 64aa7808 Received: from 3bf1847de59b.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E7DD2E6A-C2CA-4CFC-8327-81A80748A7A2.1; Fri, 18 Nov 2022 16:33:35 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3bf1847de59b.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 16:33:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9RCLsoOcaV1lXTdaHkj3fBDhEEbnBwwk8RkhYPyXEWOmeFs6nAPqk/CvrBBbM9Ia7cRfH46P4V8A7TwoAxHhx3jE1RuFM6MREqlbgpodra1NvoUonOMWG568JpHCYXcxJCTS0FqbBpz9/VzM2uyLrmsCa4+XYoYUG0Ac4TJuvmmbHhAlZIGgyYvJodJHcM2Lugxd9ffktzZxzqwlQ2o3NXxMq3ViHs7f08P4A/2jeTAAkDQMVHqaXGw2v2ieFoDXrHcz17CLatmPoAPz9PIvB5bE0AFYCJaKE6f+6uDBp3FpHg7gvVpN2ozQZMeact/NtMBghEPhYczPVyxHios6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jfTzSD1Bobv2vJUJtivhZV0tLttmGs4hnSc0FUOlJmA=; b=SnOWSKLgAcjNUg1j2FlhLJsDZlZGo4mE8x7RadjihpfLbRfmA8jkbnXTLO0qHlcQkSVDtiuZDNmRxDihyPm8zASUbWkt5r3tHdqdf7x1CMWl5ZsWbI4dhj01sr/ijRxegazSTGapBHe9q/mwBNqaQtXM06a9EZWIcWcPWdDWbak8cPFGUrggY0/U7EeUXSSu0simfug8H8KGIjFfr7kpweYSXX9+OSpYMLuZpnBypzHRYbibCgRCcIoeJ5A9Bv7WreCIeAs80lyKvhnLIqPOpQK9IERwZ8fxyFtncyURxtEzQVp1KednyTHPLvjjO78KXKJXq5KsDfH7/St+px6wYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jfTzSD1Bobv2vJUJtivhZV0tLttmGs4hnSc0FUOlJmA=; b=DqjigdPtIwwW4w3iMx8bbT/Acv7Qn+TdWjhOu2xwx81UojL81k0fWqqFLPLN4rX2oWrC2S+z4w8DDsjoh1iab37WDRFoj0E0F80xgJAx3k9JzwZmWQZz7imzVGe8uflDmeMFZyktSZw8rSyi7rR9krZuUSU+PcCXKk9eMpdWXXs= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by AM8PR08MB5732.eurprd08.prod.outlook.com (2603:10a6:20b:1d4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Fri, 18 Nov 2022 16:33:33 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::8668:3414:edde:d292]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::8668:3414:edde:d292%7]) with mapi id 15.20.5857.008; Fri, 18 Nov 2022 16:33:33 +0000 From: Kyrylo Tkachov To: Andrea Corallo , "gcc-patches@gcc.gnu.org" CC: Richard Earnshaw , Andrea Corallo Subject: RE: [PATCH 02/35] arm: fix 'vmsr' spacing and register capitalization Thread-Topic: [PATCH 02/35] arm: fix 'vmsr' spacing and register capitalization Thread-Index: AQHY+qMG0RSzcpfAkUuivhAMh5zKh65E4a8A Date: Fri, 18 Nov 2022 16:33:33 +0000 Message-ID: References: <20221117163809.1009526-1-andrea.corallo@arm.com> <20221117163809.1009526-3-andrea.corallo@arm.com> In-Reply-To: <20221117163809.1009526-3-andrea.corallo@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|AM8PR08MB5732:EE_|DBAEUR03FT033:EE_|AS8PR08MB8945:EE_ X-MS-Office365-Filtering-Correlation-Id: a55d6e14-4ca9-4fa9-ce5a-08dac982a72f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +QATDD3JpBysG8yzgeglkzgRNnCZf5iTtdFBVGCPAfkcTCQQVG8gygIFi/NKT0UuMWd4CBAf4cQcZR5O9qQ5ErS0hYQwpJrrjMJc2hFKpbHP7+iWU4t+v9sz5s6TaYOGGMj9fgpZSMiNf76UHZidGl3MWbDtJaM50MK8nyufr1UgqNGlS6rzwiRAbTlYjfsf7Tn4Dri2IORHp72N+AMkSINOVvBuHwwMFRmQjm3UVAr3xWn+iICg1g2ZkKI2CVgwGbaErAyBBfqrTCi4p9NQ2Z1c/amLWdiFH8rqgnQzxQrFOEHv/YfQgLfud2WqEDbXjEaGXdj3d/4bOs2cFVWfZrN7RnSkOHr7gWR19cPU7K23Hhagn1f6NSIuBDrJDGlxtDlB0QiJxX0xWaCy6CHSpNfDIqc4xJG15q+l/hsNQTCs3RjXNcpMbX07iLnCetBwYYME8YLU/DkpvYe9NGr2LWYstH8UXej7i5SEj0rjRDCeuRLZbR9oAHT/SYksLvTtMezYnhskz1lCmcataLKj5ruyPui+Idny988hCgXn3GplkvmjUknWtQzbOhsHRB9EI4zXDLDB4V3d9OCqdH71I9U6z7hxczl4vk1+n9K8qRrcBoIf4L9bJcbYstL5ISjbeFsPjITKye4UZ5dgtjpqt1hr3j3RSLASWbcCbfvYVrxTgdB85ZWy1pkOsGIi5mLypXY35GKYEsbJlRF/ADsMF4wxNCptj4VXKaiG43s9M9zax/QGnSRyhoox4BTe1rx+k8GWReNiLnwbCDXZkxlZXA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(366004)(376002)(39860400002)(451199015)(316002)(54906003)(84970400001)(2906002)(71200400001)(33656002)(26005)(38070700005)(6506007)(110136005)(55016003)(8936002)(7696005)(9686003)(53546011)(186003)(4326008)(66946007)(66556008)(66446008)(66476007)(64756008)(8676002)(76116006)(52536014)(478600001)(86362001)(83380400001)(5660300002)(122000001)(41300700001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5732 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fba73418-7b51-4bac-d69c-08dac982a23c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A2I0NFBBdvu7DsZGuGa4+BU0Wzjgwdt5D3EtD6XGe8Uml14ZcY/wiOP4uO5KS/wAtK37N+9kkTTZqzGGVwvLpxPg77l9SBRoRB3agUSuw1Qz9fcKkwJsgL4VssoHLBNmtqYkYaHYYaKT2w8RFDSHuav63hDYBggEa7kznjYbLwYHAQYIrobB+uj7EQX+KDhjvcfhftNQ43gCY3aul5t0D1QVVz/qjon0FxPSu8JswuAzI8hbAQwOLCfPfVFMgbwEoiWtvNvC0ojHuD1vI8vFaIKB2fsTuBbWaq1wLjqz3oNCrfAR8lJIramGDu3A0lJIOKkVSYu7hBtKduTXS9Iriy8QAysiD4Z0aw1YgM8QkPbj6mHfZoXHaOQDGc1XlUL1K0Ircn+eeDKwRUDtshL6VVOOjtKp2BJz3Hecbz1vZNy+VuVJAMee1S8EIFwDd6Zxc4z6xa2/tXZsnTMFaBJftoO0gu6NlFhtsrv4w3uvZ2R14BDToOewyTS0GMb1H99nVJjLIm641tQmNAVwmXuMx3CMrPJlWg4vHcIEeGln8xYmRpxo6+1xmXS0d5X4cbDvSaPubdpVGOVozOjFj3YIkE82AfsF4HvHN68VigoAJHogOwsSoGd1GhRIBDJhjaVnwWEwsnNDhKocJtn3aEr1p3nUb6XfUeAAClEgD2CGakOGt8gpu6ARTXREbNBkmZ7PNiAv1PSE9e8H1JDH7yexceM70/YeUxVzwR1GG1aJ6j1TVRniiIBXpVY47zZ0494Kt7423DLh+tfu2SlYaHJp0A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(41300700001)(40460700003)(84970400001)(33656002)(86362001)(36860700001)(81166007)(70206006)(356005)(82740400003)(53546011)(40480700001)(47076005)(26005)(6506007)(83380400001)(9686003)(7696005)(4326008)(186003)(55016003)(336012)(70586007)(316002)(8676002)(52536014)(54906003)(110136005)(478600001)(82310400005)(5660300002)(2906002)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 16:33:41.4049 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a55d6e14-4ca9-4fa9-ce5a-08dac982a72f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8945 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 02/35] arm: fix 'vmsr' spacing and register capitalizatio= n >=20 > gcc/ChangeLog: >=20 > * config/arm/vfp.md (*thumb2_movhi_vfp, *thumb2_movhi_fp16): > Fix > 'vmsr' spacing and reg capitalization. >=20 > gcc/testsuite/ChangeLog: >=20 > * gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_f32.c: > Update test. > * gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_s32.c: > Likewise. > * gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_u32.c: > Likewise. Ok. Thanks, Kyrill > --- > gcc/config/arm/vfp.md | 8 ++++---- > .../arm/mve/intrinsics/vldrwq_gather_base_wb_z_f32.c | 2 +- > .../arm/mve/intrinsics/vldrwq_gather_base_wb_z_s32.c | 2 +- > .../arm/mve/intrinsics/vldrwq_gather_base_wb_z_u32.c | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/gcc/config/arm/vfp.md b/gcc/config/arm/vfp.md > index d0f423cc3c5..932e4b7447e 100644 > --- a/gcc/config/arm/vfp.md > +++ b/gcc/config/arm/vfp.md > @@ -105,9 +105,9 @@ (define_insn "*thumb2_movhi_vfp" > case 8: > return "vmov%?.f32\t%0, %1\t%@ int"; > case 9: > - return "vmsr%?\t P0, %1\t@ movhi"; > + return "vmsr%?\tp0, %1\t@ movhi"; > case 10: > - return "vmrs%?\t %0, P0\t@ movhi"; > + return "vmrs%?\t%0, p0\t@ movhi"; > default: > gcc_unreachable (); > } > @@ -209,9 +209,9 @@ (define_insn "*thumb2_movhi_fp16" > case 8: > return "vmov%?.f32\t%0, %1\t%@ int"; > case 9: > - return "vmsr%?\t P0, %1\t%@ movhi"; > + return "vmsr%?\tp0, %1\t%@ movhi"; > case 10: > - return "vmrs%?\t%0, P0\t%@ movhi"; > + return "vmrs%?\t%0, p0\t%@ movhi"; > default: > gcc_unreachable (); > } > diff --git > a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_f3 > 2.c > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_f3 > 2.c > index f3219e2e825..1e57ca40739 100644 > --- > a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_f3 > 2.c > +++ > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_f3 > 2.c > @@ -11,7 +11,7 @@ foo (uint32x4_t * addr, mve_pred16_t p) > } >=20 > /* { dg-final { scan-assembler "vldrw.32\tq\[0-9\]+, \\\[r\[0-9\]+\\\]" = } } */ > -/* { dg-final { scan-assembler "vmsr\t P0, r\[0-9\]+.*" } } */ > +/* { dg-final { scan-assembler "vmsr\tp0, r\[0-9\]+.*" } } */ > /* { dg-final { scan-assembler "vpst" } } */ > /* { dg-final { scan-assembler "vldrwt.u32\tq\[0-9\]+, \\\[q\[0-9\]+, #\= [0- > 9\]+\\\]!" } } */ > /* { dg-final { scan-assembler "vstrw.32\tq\[0-9\]+, \\\[r\[0-9\]+\\\]" = } } */ > diff --git > a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_s3 > 2.c > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_s3 > 2.c > index 4d093d243fe..f8d77fdfd5b 100644 > --- > a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_s3 > 2.c > +++ > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_s3 > 2.c > @@ -11,7 +11,7 @@ foo (uint32x4_t * addr, mve_pred16_t p) > } >=20 > /* { dg-final { scan-assembler "vldrw.32\tq\[0-9\]+, \\\[r\[0-9\]+\\\]" = } } */ > -/* { dg-final { scan-assembler "vmsr\t P0, r\[0-9\]+.*" } } */ > +/* { dg-final { scan-assembler "vmsr\tp0, r\[0-9\]+.*" } } */ > /* { dg-final { scan-assembler "vpst" } } */ > /* { dg-final { scan-assembler "vldrwt.u32\tq\[0-9\]+, \\\[q\[0-9\]+, #\= [0- > 9\]+\\\]!" } } */ > /* { dg-final { scan-assembler "vstrw.32\tq\[0-9\]+, \\\[r\[0-9\]+\\\]" = } } */ > diff --git > a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_u3 > 2.c > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_u > 32.c > index e796522a49c..8a0e109c70c 100644 > --- > a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_u3 > 2.c > +++ > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_u > 32.c > @@ -11,7 +11,7 @@ foo (uint32x4_t * addr, mve_pred16_t p) > } >=20 > /* { dg-final { scan-assembler "vldrw.32\tq\[0-9\]+, \\\[r\[0-9\]+\\\]" = } } */ > -/* { dg-final { scan-assembler "vmsr\t P0, r\[0-9\]+.*" } } */ > +/* { dg-final { scan-assembler "vmsr\tp0, r\[0-9\]+.*" } } */ > /* { dg-final { scan-assembler "vpst" } } */ > /* { dg-final { scan-assembler "vldrwt.u32\tq\[0-9\]+, \\\[q\[0-9\]+, #\= [0- > 9\]+\\\]!" } } */ > /* { dg-final { scan-assembler "vstrw.32\tq\[0-9\]+, \\\[r\[0-9\]+\\\]" = } } */ > -- > 2.25.1