From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) by sourceware.org (Postfix) with ESMTPS id 7E4A8384F6D6 for ; Tue, 22 Nov 2022 17:04:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E4A8384F6D6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ebTzN7Je8WHiLtCrViDiNkKnRMjFSFJR+A6IWTOk8EU=; b=ZImcy+itIebJgh2cQ3u6sTqOE89GiIB8K5ZukqPwrXiM17Ro7+e9xZQNObOoMDrN9IIvCX13vMAP2H0fM/R8AHZI8KUijVGecSCVRvaeSzAEXVSzcTE3lkvPpbvSzrBLRd+DWiIvo0wP8whQu/VpBgPPwTyMYAwgKZQoKyRZB8k= Received: from DB6PR07CA0019.eurprd07.prod.outlook.com (2603:10a6:6:2d::29) by DU2PR08MB10132.eurprd08.prod.outlook.com (2603:10a6:10:49a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 17:03:57 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::72) by DB6PR07CA0019.outlook.office365.com (2603:10a6:6:2d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Tue, 22 Nov 2022 17:03:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 17:03:56 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Tue, 22 Nov 2022 17:03:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: eeb81d46421ee024 X-CR-MTA-TID: 64aa7808 Received: from b5e4bb188ab2.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 205D09D7-D4C6-418C-9514-C03A53A3E9CB.1; Tue, 22 Nov 2022 17:03:45 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b5e4bb188ab2.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Nov 2022 17:03:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cv6Np4AGzCet4m5zBxAcRocIXj5bh5czq6EPAy7sxujfbRCmEqjydiSouqIoeqq6LQne3JLvW/dPsjaV6MU+qd84CvRyHOlXsZnp4gKYfhkWLtuBBPZuOWdLRpqsmKsV1su7w8v/PoAg3G9q1XQkpky/hPktwHZ3Bp0bwpfbwGrNeDDb3ykWVYBHlHjTgJ3IZfPJ5MCczxubGvQe07pKJsjdUCUPHS5N/7L0RYgtemEOTBsY/Ivxvy74Dv5ostBG4rivxzvEXjCLjh/qhPkWXjJlWqgm2MEv6oOIywn5xmTjuVFvorjnhAvt9eLwOANPBnpuOCVj0+SS6WczBxARwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ebTzN7Je8WHiLtCrViDiNkKnRMjFSFJR+A6IWTOk8EU=; b=AP5niwB3PC8twgA7i8XX6FfqOA1g/XE0NgFRIUs4kz2JzTGZhn4K3uHkMFaFNgjBK4r4mWjFi2x11oSJ52jWl+JUNDs4mV2CvrWRFFNljpPGrOHw/HvTCbbAw1moResab5FSTFlHkBH3Q7cyEFdpnuSw0xPF+h9HUPMd2pfPMquCoS7C2Rfm98zU7L2w6G3YNUBbwggZnF2W+m1M/WHBMOFYij0NW5fO82897rBdxyM1J3OezDAK5k5yaHddDxHd5NX4TYsBJM0oaHL8F3yQM8zTmYIVbKH2CmHgtgndfez9Qi7OKhPX28R05el/eBxW4xqfVnjQYbqErD+PrHxxyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ebTzN7Je8WHiLtCrViDiNkKnRMjFSFJR+A6IWTOk8EU=; b=ZImcy+itIebJgh2cQ3u6sTqOE89GiIB8K5ZukqPwrXiM17Ro7+e9xZQNObOoMDrN9IIvCX13vMAP2H0fM/R8AHZI8KUijVGecSCVRvaeSzAEXVSzcTE3lkvPpbvSzrBLRd+DWiIvo0wP8whQu/VpBgPPwTyMYAwgKZQoKyRZB8k= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by DB9PR08MB8314.eurprd08.prod.outlook.com (2603:10a6:10:3de::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 17:03:42 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::8668:3414:edde:d292]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::8668:3414:edde:d292%9]) with mapi id 15.20.5857.017; Tue, 22 Nov 2022 17:03:42 +0000 From: Kyrylo Tkachov To: Andrea Corallo , "gcc-patches@gcc.gnu.org" CC: Richard Earnshaw , Andrea Corallo Subject: RE: [PATCH 33/35] arm: improve tests and fix vrmlaldavhaq* Thread-Topic: [PATCH 33/35] arm: improve tests and fix vrmlaldavhaq* Thread-Index: AQHY+qMPWcEOFqDl8U+Pm8szHvkaY65LM3DQ Date: Tue, 22 Nov 2022 17:03:42 +0000 Message-ID: References: <20221117163809.1009526-1-andrea.corallo@arm.com> <20221117163809.1009526-34-andrea.corallo@arm.com> In-Reply-To: <20221117163809.1009526-34-andrea.corallo@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|DB9PR08MB8314:EE_|DBAEUR03FT057:EE_|DU2PR08MB10132:EE_ X-MS-Office365-Filtering-Correlation-Id: 863263fa-e54f-42bb-2dab-08daccab8afe x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lSDlWEODIWAfvrdDZUSXdJEN9Y/99qzmXLTUycjp8udBTDoarR3R+MULl24HuqK5nZ7gD7rL18vbsUIB91Jx7NKLs/EVtoE1RoaQ6UNrtfQcoSHkfnDTyflM4SKeyE+OVonNIVqlrT4VzN6ts4TGt+iqg3Fp3VvcfQegJunDME+VWuUh+gL7MjuYGvOilqMkXazpgA6vFDPS6P2dCG458imWcJ4oGBjt+PeOnBOjq9ku5bfd4ErUIW9CFg9lr2XHbunGj4pnmPHe1RuOmY2y71FfnZtOJMj+q+8A7QhmGPg05rNqOh3RRVib3GiuCCAFDYVzAPgb1rm9LguwBlXxELGIlwDdtPfTZrB1m1SB7KkR7ahUQiNbOiS+o90PraHbVEX5KZIio1aajUDzdY07yU0WxE7bsZiOxZYOE1tpZs65Nykh6FcvpXw/vgdGJWOrvPYRr5HYeXdTY95VcUzgqzDCNkbHAm4m9xbpgHXAqXP1/O7N4HDLr6cvRFwpS12joBBaQR1i9zJB/Hk6FjDzcd98acJqlFYFurK4s2VaEl5kO7NPZfHQ9/5on9YX6UTCuMbwskAKJu9xy6xGMvA1v4AhggOY8wkdkiqp3rPgCxsoXObMPDoHKVvkAaBXXB/xTCWgDAZ6f1dAm2HsY+FA7FRsbh6Y7SbrbWLAR6IAF/wIsDRCgGqfOeN55U+2qldgnb2ZU66uSNDezQW12YZ8SqIMxOK82hw9Bt1rdSq3eOPJUPUGHBMOBl51phUtY3cw7VgrylwiTbnl0qvxQ1OhPA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(366004)(136003)(396003)(451199015)(83380400001)(84970400001)(55016003)(478600001)(33656002)(8936002)(5660300002)(41300700001)(86362001)(38100700002)(38070700005)(26005)(9686003)(122000001)(71200400001)(52536014)(66946007)(2906002)(54906003)(186003)(8676002)(66446008)(6506007)(7696005)(53546011)(66556008)(4326008)(64756008)(66476007)(76116006)(316002)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8314 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 41e48fc0-ac07-4962-409e-08daccab8274 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MUnqWMPB+UwlqLqHa/rXIE6lQ3M9q9uiD89wcK56Ah8HIbGW3MCxooXtbcgpI7iAqOzZn1w3KJY5zF/WIZorbTX3LSrT/ie+ctdpC31G9cEtssl7/uomagh+tZMRyE5p+DULQQvokefnCQsC2Nru4GvnIYooV9ZTvc2QPNDPLGfHmbLphzBQnQVDpF3+QURYXNe2s4uj95cfOMHC3Nrrttar3FoXN/P9qc17iZoBOMajibhG4f+A719eWcmxShpBsV3KB3gtap/Wrt716Ewkxwwb+76SHJpL6Yo6hPj3voguBj077Zrf6erwjuPTi3I0/vuwd3zh+idLhNgbZS0+KCx8IVIgchRls0ugqfk0efKN9zcG2v0xo0leeTey4bXUw+OEiJDT7+7q0L8MnRm0/XzLDJXNq1ANt8OttyxCaqSSM+6TwutT3maEapPqCVavNVElBqKn8FkA3yU2E1OYHa0oDhY5Z0amFN4UH1iyv9BSNbWxsgiF+p6lWg8ym4E12ARHiOauUvbBSfDNAp/IDgaF5iCZvhjWTexOoHRkW2mOVKVpMxS1ALDRmGqAB2PCmjiFYaejEY6B+NZk4T3bxepBQI/pN4ck5oIn/YvN1Rz2TSttqExZ9lWxVNBqz35PIORCYOdLaXv6DSMcF3sdQii5eQFOEfXlDN7SakFClA9P3nZrj2odbxgI8ucMNTm2sQ2yurqSYElkaNJdr2Vvm3uUBuBKgH/qO2d0X3ftWW5rAiTECHRXEKalZdLmgXLEZPHaDRKNZHhS8X+3OzRdhQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(40470700004)(36840700001)(46966006)(36860700001)(478600001)(8936002)(2906002)(8676002)(86362001)(82740400003)(83380400001)(4326008)(356005)(52536014)(40460700003)(70206006)(6506007)(40480700001)(54906003)(41300700001)(7696005)(26005)(53546011)(55016003)(9686003)(47076005)(82310400005)(336012)(186003)(316002)(70586007)(5660300002)(81166007)(110136005)(84970400001)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 17:03:56.9734 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 863263fa-e54f-42bb-2dab-08daccab8afe X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10132 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 33/35] arm: improve tests and fix vrmlaldavhaq* >=20 > gcc/ChangeLog: >=20 > * config/arm/mve.md (mve_vrmlaldavhq_v4si, > mve_vrmlaldavhaq_v4si): Fix spacing vs tabs. >=20 > gcc/testsuite/ChangeLog: >=20 > * gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_s32.c: Improve > test. > * gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_u32.c: Likewise. Ok. Thanks, Kyrill > --- > gcc/config/arm/mve.md | 4 +- > .../arm/mve/intrinsics/vrmlaldavhaq_p_s32.c | 24 ++++++++++- > .../arm/mve/intrinsics/vrmlaldavhaq_p_u32.c | 40 ++++++++++++++++++- > 3 files changed, 62 insertions(+), 6 deletions(-) >=20 > diff --git a/gcc/config/arm/mve.md b/gcc/config/arm/mve.md > index d2ffae6a425..b5e6da4b133 100644 > --- a/gcc/config/arm/mve.md > +++ b/gcc/config/arm/mve.md > @@ -2543,7 +2543,7 @@ (define_insn "mve_vrmlaldavhq_v4si" > VRMLALDAVHQ)) > ] > "TARGET_HAVE_MVE" > - "vrmlaldavh.32 %Q0, %R0, %q1, %q2" > + "vrmlaldavh.32\t%Q0, %R0, %q1, %q2" > [(set_attr "type" "mve_move") > ]) >=20 > @@ -2649,7 +2649,7 @@ (define_insn "mve_vrmlaldavhaq_v4si" > VRMLALDAVHAQ)) > ] > "TARGET_HAVE_MVE" > - "vrmlaldavha.32 %Q0, %R0, %q2, %q3" > + "vrmlaldavha.32\t%Q0, %R0, %q2, %q3" > [(set_attr "type" "mve_move") > ]) >=20 > diff --git > a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_s32.c > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_s32.c > index 263d3509771..dec4a969dfe 100644 > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_s32.c > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_s32.c > @@ -1,21 +1,41 @@ > /* { dg-require-effective-target arm_v8_1m_mve_ok } */ > /* { dg-add-options arm_v8_1m_mve } */ > /* { dg-additional-options "-O2" } */ > +/* { dg-final { check-function-bodies "**" "" } } */ >=20 > #include "arm_mve.h" >=20 > +/* > +**foo: > +** ... > +** vmsr p0, (?:ip|fp|r[0-9]+)(?: @.*|) > +** ... > +** vpst(?: @.*|) > +** ... > +** vrmlaldavhat.s32 (?:ip|fp|r[0-9]+), (?:ip|fp|r[0-9]+), q[0-9]+, > q[0-9]+(?: @.*|) > +** ... > +*/ > int64_t > foo (int64_t a, int32x4_t b, int32x4_t c, mve_pred16_t p) > { > return vrmlaldavhaq_p_s32 (a, b, c, p); > } >=20 > -/* { dg-final { scan-assembler "vrmlaldavhat.s32" } } */ >=20 > +/* > +**foo1: > +** ... > +** vmsr p0, (?:ip|fp|r[0-9]+)(?: @.*|) > +** ... > +** vpst(?: @.*|) > +** ... > +** vrmlaldavhat.s32 (?:ip|fp|r[0-9]+), (?:ip|fp|r[0-9]+), q[0-9]+, > q[0-9]+(?: @.*|) > +** ... > +*/ > int64_t > foo1 (int64_t a, int32x4_t b, int32x4_t c, mve_pred16_t p) > { > return vrmlaldavhaq_p (a, b, c, p); > } >=20 > -/* { dg-final { scan-assembler "vrmlaldavhat.s32" } } */ > +/* { dg-final { scan-assembler-not "__ARM_undef" } } */ > \ No newline at end of file > diff --git > a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_u32.c > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_u32.c > index 83ab68c001b..f3c8bfd121c 100644 > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_u32.c > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vrmlaldavhaq_p_u32.c > @@ -1,21 +1,57 @@ > /* { dg-require-effective-target arm_v8_1m_mve_ok } */ > /* { dg-add-options arm_v8_1m_mve } */ > /* { dg-additional-options "-O2" } */ > +/* { dg-final { check-function-bodies "**" "" } } */ >=20 > #include "arm_mve.h" >=20 > +/* > +**foo: > +** ... > +** vmsr p0, (?:ip|fp|r[0-9]+)(?: @.*|) > +** ... > +** vpst(?: @.*|) > +** ... > +** vrmlaldavhat.u32 (?:ip|fp|r[0-9]+), (?:ip|fp|r[0-9]+), q[0-9]+, > q[0-9]+(?: @.*|) > +** ... > +*/ > uint64_t > foo (uint64_t a, uint32x4_t b, uint32x4_t c, mve_pred16_t p) > { > return vrmlaldavhaq_p_u32 (a, b, c, p); > } >=20 > -/* { dg-final { scan-assembler "vrmlaldavhat.u32" } } */ >=20 > +/* > +**foo1: > +** ... > +** vmsr p0, (?:ip|fp|r[0-9]+)(?: @.*|) > +** ... > +** vpst(?: @.*|) > +** ... > +** vrmlaldavhat.u32 (?:ip|fp|r[0-9]+), (?:ip|fp|r[0-9]+), q[0-9]+, > q[0-9]+(?: @.*|) > +** ... > +*/ > uint64_t > foo1 (uint64_t a, uint32x4_t b, uint32x4_t c, mve_pred16_t p) > { > return vrmlaldavhaq_p (a, b, c, p); > } >=20 > -/* { dg-final { scan-assembler "vrmlaldavhat.u32" } } */ > +/* > +**foo2: > +** ... > +** vmsr p0, (?:ip|fp|r[0-9]+)(?: @.*|) > +** ... > +** vpst(?: @.*|) > +** ... > +** vrmlaldavhat.u32 (?:ip|fp|r[0-9]+), (?:ip|fp|r[0-9]+), q[0-9]+, > q[0-9]+(?: @.*|) > +** ... > +*/ > +uint64_t > +foo2 (uint32x4_t b, uint32x4_t c, mve_pred16_t p) > +{ > + return vrmlaldavhaq_p (1, b, c, p); > +} > + > +/* { dg-final { scan-assembler-not "__ARM_undef" } } */ > \ No newline at end of file > -- > 2.25.1