From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) by sourceware.org (Postfix) with ESMTPS id AE17D385084F for ; Thu, 20 Oct 2022 14:53:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE17D385084F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mQBj8F3fwOEK5FfUbSIP+GG1lpvhcv3MS3boYk3bqu2pu/QAPSD4I88lw+r12JsOFMqFQNjI+F2x3ZMhroZ+dd+L1HS0Q8+js05ruFXa0T2fLJaTGrMEKKKSe0zehWPcO9Y+3cDpusxPmJ2CMni9No+7obAWFPJbvaTTMoBwiYyo2eN6CtTqprshi8Le0qvcp2x/nKxeHRoW9LiHy6kdFo46jhS7g/MK/V6w0MrpkqqgKYYIygpDGqFFsYkuDg1YNTXa/7Bbs98SiQSVIqD7fkIixD/ld4Jl9foUZETZorZ6oq5vVTclQ1qjYWHtkijMpfADEHi0awPtcSBAW7DV8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6rxYHtJ18GTEnxTEE3549N660MEJvdYJehL9UIvaPkQ=; b=Bs7ZDW7QhiVET8h/4phGrp8DDvm8JH40Y5X0LE2VPammuQES2LH0yanOzmwGZB30x/AVZUo7qf6/2DWtEz6P0J8Yr0TKW7ePCroyvtZ2Zt3mZLaCynf6bSMaKclP5+WB0VKZhWtdGuBo84WTmq+0rFS409DxLauIg2IuUH/kNMVIyzSbymCWsifWBo6O3draFSLujD1hBTWZhNp5NxNCrG8lVLuZTciX3gpIWw/Aq6EVA65ztz0b2a7elEuhKCF8ekAAVIlNZ1J7aCKLPe3ra/vmtZrYOs857FrGhIYjMPl/rYrrZgbwE0mL7vx8LdWb6NFUHXSAq8qYxmrlzbBbBQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6rxYHtJ18GTEnxTEE3549N660MEJvdYJehL9UIvaPkQ=; b=yW4NsNONHnWQvNZ3d3hdEM5QJJFwPN1OL5DxSw7KznxAjqMUQScTZYFu61vOEHYrDmXT3aDO2/VWWQGeKB1LUN0hubHnJorMZHr1eplhVaLVgICGmZbzEXHxgZbqWf514igf5Tde/CDUWbKJ7afU8J4ytI8Uo6La/Fqcf4suK1A= Received: from AM6PR0202CA0047.eurprd02.prod.outlook.com (2603:10a6:20b:3a::24) by DB9PR08MB9849.eurprd08.prod.outlook.com (2603:10a6:10:462::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct 2022 14:53:53 +0000 Received: from AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::f6) by AM6PR0202CA0047.outlook.office365.com (2603:10a6:20b:3a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend Transport; Thu, 20 Oct 2022 14:53:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT058.mail.protection.outlook.com (100.127.140.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend Transport; Thu, 20 Oct 2022 14:53:52 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Thu, 20 Oct 2022 14:53:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c81588e831f4ff72 X-CR-MTA-TID: 64aa7808 Received: from be9ab49a14ff.4 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BA8C645E-CDE1-488E-B107-5D94BE2353A4.1; Thu, 20 Oct 2022 14:53:46 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id be9ab49a14ff.4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 20 Oct 2022 14:53:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j05wydY6Nrw23Ftq7PjhbxsikUp4QWkzJ/EYkFUq6qlkel1RnTS7dajzRhOI7MkpvvuEhNGWyZdmIKKen53cBdufmF3JeDMhLVFPBjVk463YaOFlc1Oy5MJM9yHBt0jnBlYl2Bg1Co9sVdKz8lae10FJk9zlrvvmnvBKM7SSAx2x7euSxU2XTwyv6MVjitrErbexp5916cm5NlWfYNZLwVWayud3kcrisvkKzaesxMnKzz0AVC8CKYFL4oAy2XZY7dS98obT2/V0PiOZ8nv9SovUfcLuvj9wC2Uar4iKQKcFPX4rn7uFiN6vq3vRmAb1llECd2p2WKcuiG966aLQyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6rxYHtJ18GTEnxTEE3549N660MEJvdYJehL9UIvaPkQ=; b=YKEcYvTZs15dvBGCzGi2L+zei9HVphIRZF0gu8a9HBhJ/9SePMIJ7LVFjaL0NPF0QVP7vaMtt6UHP6j9NuyDM1rqARh/Hp/cHB+Y8l4uh455BrfbxTmxhLGTjcg8vx9SeRzksx7ifh/gIfUcjcNPss8g+hGq5KMFYnNVIumHrJBjZbrT7jUzZjReieebNf7z13Io552/YAimwflsc17Zp45hPSm5GJxXOUNNW6tNPJ+aA98JU01mhhqevs29Tt0wIUYqF4LWZPY3Z7hIEv+01E8n0eWzrp7O8R7BHuUYEvyH4OE1L6zjEEdpb0NS0z9EFASm0wj5ghVd2nYFyK5zQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6rxYHtJ18GTEnxTEE3549N660MEJvdYJehL9UIvaPkQ=; b=yW4NsNONHnWQvNZ3d3hdEM5QJJFwPN1OL5DxSw7KznxAjqMUQScTZYFu61vOEHYrDmXT3aDO2/VWWQGeKB1LUN0hubHnJorMZHr1eplhVaLVgICGmZbzEXHxgZbqWf514igf5Tde/CDUWbKJ7afU8J4ytI8Uo6La/Fqcf4suK1A= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by DB3PR08MB8820.eurprd08.prod.outlook.com (2603:10a6:10:438::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct 2022 14:53:44 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::c5b2:df77:49dc:608c]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::c5b2:df77:49dc:608c%7]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022 14:53:44 +0000 From: Kyrylo Tkachov To: Andrea Corallo , Richard Earnshaw CC: Richard Earnshaw , nd , Andrea Corallo via Gcc-patches Subject: RE: [PATCH 10/12 V2] arm: Implement cortex-M return signing address codegen Thread-Topic: [PATCH 10/12 V2] arm: Implement cortex-M return signing address codegen Thread-Index: AQHYitB7tuEZlLZZw0uQuoGq+mLUGq1prROAgDtRp5qAcxKC8A== Date: Thu, 20 Oct 2022 14:53:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|DB3PR08MB8820:EE_|AM7EUR03FT058:EE_|DB9PR08MB9849:EE_ X-MS-Office365-Filtering-Correlation-Id: 9882c732-39b1-4518-74b0-08dab2aae7d0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WuQWoh7FTaE6buoO5kdiP6nZ7AulDqpadmnxMvOGtzBiqUAqLAu6bYjQkpP5/rv+3Yqr0LimoxzV+o2n/fQtA7cZhkA2Fcg8+ocUZRt+XxoXmOjj7gShFX71l7X/+LTXgqYlkNqfdJNhyZDGYhtUoqp50hjjfHrkCccqpvwJsorhK/+Q9LLdf4onpGNmeJ0k/N6TIlDel1aAExGztffmYEbpz2XU3E0p4DCpKeoj1SqXI6+WvEmreisljr1UISfa/7XRpoZZlnXbALFXfXxibjSP41IU4qz/WFm8y5Esxm531rdCJs5/UrmwuQ8WXV/MUqtcOS9n4fgC9DQoFa3VemdhKyRXWaCSg3KW3E1tZvVpqKRduaPXYOCHThwHi3txsogNwCK7VTiX/I6UY2oyP+JpnFDslGRjUYAlC2zaLfooq64xpNLQTSBE8Cu6QhYjNf3z/JUCbpXP4hdxXGP3zUkEZl0yC0Fm1FsXi++HFK5oAl1Ru7j7dmdIc6giNguBe9XJUuw8HRqVYWJwFjrmFblWi/EraVl0QM8KpoQHMiucHMqjFC4QwwowWDnRQUGe9+kUEnzkNfwsG01iuBkNUrLd8tYqqHwVgPBI7BokxiM3vfFDl8FY774qtvwnRHTxcNYgS5USf1GRftwh37DNfFP3Aa9ZCI+Xjpr2FvaqOfSch+alxJHrAHBeVuhkrt7vHAC/kSBfGTy1x/R33tStQ5p8f0Lipby4nm+ygpYliyMQI0nYTApEgw4RzojC+Oxlbqrdakp/wWggPb5BDQXnXg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(366004)(396003)(451199015)(186003)(9686003)(7696005)(6506007)(83380400001)(26005)(2906002)(53546011)(8936002)(5660300002)(55016003)(110136005)(478600001)(66946007)(41300700001)(52536014)(4326008)(64756008)(71200400001)(76116006)(8676002)(66446008)(66476007)(66556008)(54906003)(316002)(86362001)(33656002)(38100700002)(122000001)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8820 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 698a6664-3598-4291-3347-08dab2aae282 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ODauoqw1hs9xKoAZSAlM3NgdpZIhyUec6wdIqkjGf2QwRSYrlxCFdgDpeKsW6nRSBygtXGfb+9P1y5G1RxjqaT7eWxJl8ekOeKkZmjcVEC0uQ0t2ALDVsmD6oumq3+emdjjMxi0md3iq3ZHdkZGd5p16roDbaSk1yjq1R0EGm0W4lbCxnJ6m5ydG9/kEllqpxJVi62WP7cZU2ZWh+0UIEshCOZ0mWd2aRpUn142duom0RYW9wnJj8TFxDtfE5uap4bnXc7FyYf8yjziCU5VlBFn/2nSRVM5HHfFPaTtCa7/sOk2tRMjKwg+iImC4ffFkGK7cTRJegGjDzUNLEhAHrHHfi9a9a2Z8R017D+QKrF8DMFB4mJTNUK+altOD09YKJDNUggK1LRu5pJ4SvsWm0miA2MESn8ghMydwQyU6ZaAN1F3i7AtFZlXCBAh/tZYAvfi9D1sCZqnj5FKeODwl0xwKlVCiFH39/yBsaOrdsD32si3LSJyA9BSuwh3vFyGfAJjrYkQg9KmkrbE/XbIrBE0tqK+JUSC5hQyDp8Bz/CV/LMgZTJ/o51VByleR2SZpPUbZJgHHDE3ZKubXt7Ni15brqwlP2tB5fv6oqtJsR+OstJDB4/bhRfNWKvCgqcUvxE/WYM7sWZUbRRqwMqImRHmt6dLDw2B7uqwZAzszuD8TiH1nfKB16I6ugA4ArlPYhCNiLapDK4dIccSHai6NGxyQXv66Gzgj8QrIIP4PS47+/hn0WJ7DLu2s8HWFF3kF0f1RI7V4/npVVQP94xqCpA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(82310400005)(82740400003)(8676002)(6506007)(7696005)(52536014)(8936002)(55016003)(54906003)(110136005)(40480700001)(70586007)(70206006)(5660300002)(2906002)(4326008)(316002)(33656002)(86362001)(336012)(478600001)(83380400001)(356005)(41300700001)(26005)(9686003)(186003)(53546011)(40460700003)(36860700001)(81166007)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 14:53:52.9104 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9882c732-39b1-4518-74b0-08dab2aae7d0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9849 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: (Sorry, this is a very late reply) > -----Original Message----- > From: Gcc-patches bounces+kyrylo.tkachov=3Darm.com@gcc.gnu.org> On Behalf Of Andrea > Corallo via Gcc-patches > Sent: Monday, August 8, 2022 10:34 AM > To: Richard Earnshaw > Cc: Richard Earnshaw ; nd ; > Andrea Corallo via Gcc-patches > Subject: Re: [PATCH 10/12 V2] arm: Implement cortex-M return signing > address codegen >=20 > Richard Earnshaw writes: >=20 > [...] >=20 > > +(define_insn "pac_nop" > > + [(set (reg:SI IP_REGNUM) > > + (unspec:SI [(reg:SI SP_REGNUM) (reg:SI LR_REGNUM)] > > + UNSPEC_PAC_NOP))] > > + "TARGET_THUMB2" > > + "pac\t%|ip, %|lr, %|sp" > > + [(set_attr "length" "2")]) > > > > This pattern is missing a type. >=20 > Which type do you think is missing? >=20 > > The length is also incorrect as the > > instruction is 32-bits (4 bytes). >=20 > Ack. >=20 > > Similarly for the other > > instructions below. Also, you need to mark them as incompatible with > > conditional execution (they're constrained-unpredictable in IT > > blocks). >=20 > I guess this would translate in setting it with '(set_attr "predicable" "= no")' >=20 > But isn't this already the default? I think Richard means the "conds" attribute. It's something I'd like to see= cleaned from the arm backend eventually, but for now there's a (very) late= condexec pass that can generate conditional instructions based on that att= ribute. Basically, it needs to be set to "undconditional" for these instructions. Thanks, Kyrill >=20 > Thanks >=20 > Andrea