From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60057.outbound.protection.outlook.com [40.107.6.57]) by sourceware.org (Postfix) with ESMTPS id E32DB3858C83 for ; Wed, 28 Sep 2022 12:23:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E32DB3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AIE/7hHzO4XAddh284zvA7iGP0WLhQ1gQ5HcS16WpDHqJ6BWkN7vZFniFnJdIiunApSVxDUdGFPXAMIgmCNg41ojeS7UpEkEvtBYp+3d3mnVxMlP7gkzN3qhXfdHEhOuiJvF/0XbUAmOHp+gzcMCTArkuKAwo8I9HbbI4S+18EnCrsfULaNV9BCaO1i6gpkChT3yO64eWXqA0Hv9KYAwehP3QntYUNBGu8SdsyjG+BcwiD663z0zp1vWj/FZ+xjHkDCdXio5Nv2n9lKG9XKWQbEuROamUfjmVZwPneTpZqqgv5kqzh4SQOLLMhyUvIu6OhyJITHHmq62AbFyVIAYfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NQbuwMm+7/V8bLla2RkvpdlG6VIGRLXVqTXyyWXAVKY=; b=PSNwTnBqV9TlXBY4PhSwW5Ml3RV2hbZUsl+D+44Gv2xdnI0O43P8HtDKTjtkPYtt2lAST1bF+uOnnbmU34KP3VswH3c5E/QpVPNOFdBpZ2V8gGN+9qQrOzf1u/yuDu/CNRcZD5D5AA6KxHVF3leJUuePFXnR+LAEa7A8CnQJgj32kLP4QlXORwNZ4mOczOe4ssHQkrgY7GPZ33scc237fL201bap2qawX4HXsezSjKwnOoSdwU3YsAyyR9G46FK0Ag4dLNZiSt8tR091aPJivqS/85fJVW9UID8a+VLIXNMXJ256d6GBxZAvSRd4IIS/iCGYlLZlYvFwtjmI+FrRgA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQbuwMm+7/V8bLla2RkvpdlG6VIGRLXVqTXyyWXAVKY=; b=bs8K4/qFdhJxV44EV2okdKvaZgOeSJN7be20KztNUOlXwhOTeYhGYTpzAe+oRLzKhujFSBS46wmkQh/CVxE25k2+HIF8jpIwuhMWtMur1rkRy11x51kXoSrAQbP2znFD6olMX5zSAq1WpR0Xo650oBu8pvXiYrCplOXMde6+2QA= Received: from AM5PR0202CA0015.eurprd02.prod.outlook.com (2603:10a6:203:69::25) by DB8PR08MB5356.eurprd08.prod.outlook.com (2603:10a6:10:f9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 12:23:16 +0000 Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:69:cafe::1d) by AM5PR0202CA0015.outlook.office365.com (2603:10a6:203:69::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend Transport; Wed, 28 Sep 2022 12:23:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Wed, 28 Sep 2022 12:23:16 +0000 Received: ("Tessian outbound c2c2da38ad67:v128"); Wed, 28 Sep 2022 12:23:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: df4a4b95fdc4bd4a X-CR-MTA-TID: 64aa7808 Received: from 213eaca59080.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 317968B5-626E-49AB-B2EB-A378E099EB10.1; Wed, 28 Sep 2022 12:23:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 213eaca59080.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 28 Sep 2022 12:23:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XXKmTTuDvW9P6CWSk16KYDnY/DMcjAlkK3c/AEv8sMkXsjDGJU3a6h9oBWt1oL1hegZNI3jctXxrOW6ruw3fHNihViu/0tbU9FUkWeL2qS514W+ndoRBAeQBNCPPMCSn4fS5psVxehsEAKhGS0UW2T7PWzJVU6ILbW/c/BFjUxrH2MjCb+phT34DH8Mb1dd2OEZiOMd4YjeVe0gmgkFkA1+HMOQGEWajwVW29JTGxCv+BVdbrCyCLVWc8d1bzAtrrEEOHcHXsDMv0y/zGhrS5dE2RB2ALXfreP7pdJ0GIGDxS3diSq3oVbH5thgVIPacnyO1X/hlUaiNsave9nLscg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NQbuwMm+7/V8bLla2RkvpdlG6VIGRLXVqTXyyWXAVKY=; b=afieqTSwyeTwClPQPe3gCCm2sYPNLg32ezfGsWIPc5mfpCZ6ukEdRaZ/TlWE+qVjbc5p4x4FOaBSWVXlbNwpTxhIsZrvTrQSid8aDP0h3hWIhC7E93Odq3JhlffO21JPgzO75xxrtXycxD0lbsvyY0bvWA0AX7YKe+S6a5ZVIOr59bqRmLklcfqGnfpZ/2AlGHJAPEwjyAiVtA0yuXx5E/S2lJeEJ0Hi4tQy3mXc+/Y12yTfULHR5hLUQHtC5jLcVS5LO9sTotgKocENEXlrNUSDUEw1NJsstrDYdRq5osZh92sjt0+XB2xHPmJfsAgJkAZflLh1xIx3AXmH8e90Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQbuwMm+7/V8bLla2RkvpdlG6VIGRLXVqTXyyWXAVKY=; b=bs8K4/qFdhJxV44EV2okdKvaZgOeSJN7be20KztNUOlXwhOTeYhGYTpzAe+oRLzKhujFSBS46wmkQh/CVxE25k2+HIF8jpIwuhMWtMur1rkRy11x51kXoSrAQbP2znFD6olMX5zSAq1WpR0Xo650oBu8pvXiYrCplOXMde6+2QA= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by DB8PR08MB5465.eurprd08.prod.outlook.com (2603:10a6:10:118::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Wed, 28 Sep 2022 12:23:05 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::f0a0:ab7d:81bb:aff8]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::f0a0:ab7d:81bb:aff8%9]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 12:23:05 +0000 From: Kyrylo Tkachov To: Andrea Corallo , "gcc-patches@gcc.gnu.org" CC: Richard Earnshaw , Andrea Corallo Subject: RE: [PATCH] arm: Define __ARM_FEATURE_AES and __ARM_FEATURE_SHA2 when march +crypto is selected Thread-Topic: [PATCH] arm: Define __ARM_FEATURE_AES and __ARM_FEATURE_SHA2 when march +crypto is selected Thread-Index: AQHY0zSav2BTz3v2ak2mHFfP7mC0gq30w5XQ Date: Wed, 28 Sep 2022 12:23:05 +0000 Message-ID: References: <20220928121926.13280-1-andrea.corallo@arm.com> In-Reply-To: <20220928121926.13280-1-andrea.corallo@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|DB8PR08MB5465:EE_|VE1EUR03FT004:EE_|DB8PR08MB5356:EE_ X-MS-Office365-Filtering-Correlation-Id: ecc91a89-838c-4d8b-cb75-08daa14c387a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SiOwzFzPf+S7gtNFYd/VNiwJB6LLphQsIMVFoo2gAZHgYQ28qJ/QeduLfLe4yTnBqPFfYtuW+XFABm/C+56wgzgaB244ZwxJWIGjQNVJl7STqQj7TsM1/XJWIdrvMVN4E1sCNqcF0T76m+hGWlvdYDxcUlWDnLfldpD7bzL/orvEtPNOKxRMSxTnY6dtkoFcmGjpCT9hM4wDIIObkQt38b1Q5owjNKlF5Y67WWiCSiu5I2QvokrsxHbp1ESOSWewmkEusF+tZwvlTB+vtRegctMXSRb+UrG9x2IidzMiGzG/j2nzZjeI8lc3ux6b+8yWIg3w9NbTlC7jmpGHAmLtK10253iZWERGLm5IcsCmCphnFUG59Xo0sIlPZMlm2kUFO42zAWAV3UtIfXUwDDySooO/V9l2Idyymb6SUCJBw6jCX/sGbTC6flHz/K4itrOuN/1iHD4+1E/lMYmfUJN0ptJ4CxpzYsi7P1n0YuSp3vf439xaJJFvr4g2y7m+nt0EYFFwT0R6O8TBDDv++5Mo3snC1hDx8sMsPDJyvwGrVR4LZbmr0jUCUo8sqbLU+TIxwuQoV+nREsbkeVWEOyfePutNt27ovMRQMYbwaSRz02e1yhHVpj7XBjYqlrf9EMFvKyGbC2KbaG/EXlsFLgDBNZNxdKNJgmAM453B+3oLh2nJSoXFlmQY9Sfi8zGWF80/lt6QqtFQB+JO4zK7qlOm/15eQ4l0ytoujtcRThy8Pkuww+xC/uzi2aLK1hWqp9xAMvHDXS1GFhAsPFQ5xjMoWP6kEWlyu9q51KN1V06n/Hw/L2R/cEXFMv4joKZgE2EqPtR3bjMFwWEjkmYvcpi1qA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(366004)(346002)(451199015)(122000001)(55016003)(7696005)(38100700002)(86362001)(54906003)(110136005)(84970400001)(26005)(2906002)(316002)(33656002)(38070700005)(9686003)(53546011)(6506007)(52536014)(8936002)(64756008)(71200400001)(478600001)(41300700001)(8676002)(76116006)(4326008)(66556008)(66446008)(66946007)(66476007)(5660300002)(186003)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5465 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1437e006-87fb-42b5-8e50-08daa14c31d8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FoCLIbFVpzoynIeCSVxTXPDGgFsDIK5rsL8Om57Sn1BNnITAC4pnI3rBbWmWvjuwMcqoNdcWZTATgaaGRngj2MU5asVbDOmpttDxKDl1/CCo/hAGlnzGuFYMilLvL7ajaJjBX7j9D/bL2xSYA4n7hvEam117xNP/gXlOzW+Q9/X67WHLbVg+NKOEp8IWINRaF6RG4kM0B8mmoj2ULYv8CvGCPBcokztQLUa7PkeeaxODLfThZP/3Bz7fwHIIzM+kJXcnZT1MEeihB68F2IB8BhjfcOH8U87kUNife79VqsHobnWWyeqxCr+5T5A/BFFXnfGQWf2utt7ZK310QQJYxW7kx0nDHat83R7ldNdDq3BSThPodALfnIB2kh4+qRQnpQJ1T4uSs4GtVpjgJ2Atnq9dltpU1f9nwzrdFdT0PdgnlI3FcI58TZw2hOIpzS4yS/XcKRAJzIS+xzAMLPf8ixO/xW+rR+M8yTe8ebXYCC7QnINkh+SNrhjgvhxDnoNbjBLsm4v1ueteqy2rHgoovna8ik1pg32wfgBFPQnohUAdJ53056IT9/B+6bEflAjC+3Lv8JZVu5hdUucooMTfGR9udhcimYGA4NKY9rw/odlVG1jDBY6769anrTE7fnLE/VvI9rWGv4iL4o0409wUMq1E9N8s3NZVTPnQApLhKjxOYmHkDByGKsv6fZJS4ahDdHSYZdPV/mrvE0VlvmiNNAxyhueRTzXLFoatgCfI2PlfFe65xzy+qVpH7WFKFRrdL6Fk6g/nRJmyjbrL4Ha2hXNTaznVC7TK+0yk7EkSi+E5CWf/59b+5yrMK59BhCT+ly59srvvMUTZSsegnghrNg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(4326008)(8676002)(70586007)(83380400001)(54906003)(40460700003)(86362001)(316002)(478600001)(110136005)(55016003)(40480700001)(33656002)(6506007)(47076005)(7696005)(5660300002)(9686003)(52536014)(2906002)(8936002)(336012)(186003)(26005)(82740400003)(82310400005)(41300700001)(53546011)(81166007)(356005)(36860700001)(70206006)(84970400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 12:23:16.2410 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecc91a89-838c-4d8b-cb75-08daa14c387a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5356 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Andrea, > -----Original Message----- > From: Andrea Corallo > Sent: Wednesday, September 28, 2022 1:19 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH] arm: Define __ARM_FEATURE_AES and > __ARM_FEATURE_SHA2 when march +crypto is selected >=20 > Hi all, >=20 > this patch fixes the missing definition of __ARM_FEATURE_AES and > __ARM_FEATURE_SHA2 when AES SHA1 & SHA2 crypto instructions are > available [1] (read when march +crypto is selected). >=20 > Okay for master? Ok. Thanks, Kyrill >=20 > Thanks >=20 > Andrea >=20 > [1] software/acle/main/main/acle.md> >=20 > /gcc/ChangeLog >=20 > 2022-09-14 Andrea Corallo >=20 > * config/arm/arm-c.cc (arm_cpu_builtins): Define > __ARM_FEATURE_AES and __ARM_FEATURE_SHA2. >=20 > gcc/testsuite/ChangeLog >=20 > 2022-09-14 Andrea Corallo >=20 > * gcc.target/arm/attr-crypto.c: Update test. > --- > gcc/config/arm/arm-c.cc | 2 ++ > gcc/testsuite/gcc.target/arm/attr-crypto.c | 8 ++++++++ > 2 files changed, 10 insertions(+) >=20 > diff --git a/gcc/config/arm/arm-c.cc b/gcc/config/arm/arm-c.cc > index a8697b8c62f..86c56bf2680 100644 > --- a/gcc/config/arm/arm-c.cc > +++ b/gcc/config/arm/arm-c.cc > @@ -202,6 +202,8 @@ arm_cpu_builtins (struct cpp_reader* pfile) > def_or_undef_macro (pfile, "__ARM_FEATURE_QBIT", > TARGET_ARM_QBIT); > def_or_undef_macro (pfile, "__ARM_FEATURE_SAT", TARGET_ARM_SAT); > def_or_undef_macro (pfile, "__ARM_FEATURE_CRYPTO", > TARGET_CRYPTO); > + def_or_undef_macro (pfile, "__ARM_FEATURE_AES", TARGET_CRYPTO); > + def_or_undef_macro (pfile, "__ARM_FEATURE_SHA2", TARGET_CRYPTO); >=20 > def_or_undef_macro (pfile, "__ARM_FEATURE_UNALIGNED", > unaligned_access); >=20 > diff --git a/gcc/testsuite/gcc.target/arm/attr-crypto.c > b/gcc/testsuite/gcc.target/arm/attr-crypto.c > index cbd13a757d8..05e458f36b6 100644 > --- a/gcc/testsuite/gcc.target/arm/attr-crypto.c > +++ b/gcc/testsuite/gcc.target/arm/attr-crypto.c > @@ -16,6 +16,14 @@ > #error __ARM_FEATURE_CRYPTO not defined. > #endif >=20 > +#ifndef __ARM_FEATURE_AES > +#error __ARM_FEATURE_AES not defined. > +#endif > + > +#ifndef __ARM_FEATURE_SHA2 > +#error __ARM_FEATURE_SHA2 not defined. > +#endif > + > #ifndef __ARM_NEON > #error __ARM_NEON not defined. > #endif > -- > 2.25.1