From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: Tamar Christina <Tamar.Christina@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
"nickc@redhat.com" <nickc@redhat.com>
Subject: RE: [3/3 PATCH][AArch32] use canonical ordering for complex mul, fma and fms
Date: Tue, 1 Feb 2022 09:56:40 +0000 [thread overview]
Message-ID: <PAXPR08MB692644A113E0FDAF1D4DEF6093269@PAXPR08MB6926.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <VI1PR08MB53252DB98884F698F9B86360FF7B9@VI1PR08MB5325.eurprd08.prod.outlook.com>
> -----Original Message-----
> From: Tamar Christina <Tamar.Christina@arm.com>
> Sent: Monday, December 20, 2021 4:22 PM
> To: gcc-patches@gcc.gnu.org
> Cc: nd <nd@arm.com>; Ramana Radhakrishnan
> <Ramana.Radhakrishnan@arm.com>; Richard Earnshaw
> <Richard.Earnshaw@arm.com>; nickc@redhat.com; Kyrylo Tkachov
> <Kyrylo.Tkachov@arm.com>
> Subject: RE: [3/3 PATCH][AArch32] use canonical ordering for complex mul,
> fma and fms
>
> Updated version of patch following AArch64 review.
>
> Bootstrapped Regtested on arm-none-linux-gnueabihf and no issues.
>
> Ok for master? and backport along with the first patch?
Ok, sorry I missed it.
Thanks,
Kyrill
>
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> PR tree-optimization/102819
> PR tree-optimization/103169
> * config/arm/vec-common.md (cml<fcmac1><conj_op><mode>4):
> Use
> canonical order.
>
> --- inline copy of patch ---
>
> diff --git a/gcc/config/arm/vec-common.md b/gcc/config/arm/vec-
> common.md
> index
> e71d9b3811fde62159f5c21944fef9fe3f97b4bd..eab77ac8decce76d70f5b2594
> f4439e6ed363e6e 100644
> --- a/gcc/config/arm/vec-common.md
> +++ b/gcc/config/arm/vec-common.md
> @@ -265,18 +265,18 @@ (define_expand "arm_vcmla<rot><mode>"
> ;; remainder. Because of this, expand early.
> (define_expand "cml<fcmac1><conj_op><mode>4"
> [(set (match_operand:VF 0 "register_operand")
> - (plus:VF (match_operand:VF 1 "register_operand")
> - (unspec:VF [(match_operand:VF 2 "register_operand")
> - (match_operand:VF 3 "register_operand")]
> - VCMLA_OP)))]
> + (plus:VF (unspec:VF [(match_operand:VF 1 "register_operand")
> + (match_operand:VF 2 "register_operand")]
> + VCMLA_OP)
> + (match_operand:VF 3 "register_operand")))]
> "(TARGET_COMPLEX || (TARGET_HAVE_MVE &&
> TARGET_HAVE_MVE_FLOAT
> && ARM_HAVE_<MODE>_ARITH)) &&
> !BYTES_BIG_ENDIAN"
> {
> rtx tmp = gen_reg_rtx (<MODE>mode);
> - emit_insn (gen_arm_vcmla<rotsplit1><mode> (tmp, operands[1],
> - operands[3], operands[2]));
> + emit_insn (gen_arm_vcmla<rotsplit1><mode> (tmp, operands[3],
> + operands[2], operands[1]));
> emit_insn (gen_arm_vcmla<rotsplit2><mode> (operands[0], tmp,
> - operands[3], operands[2]));
> + operands[2], operands[1]));
> DONE;
> })
>
next prev parent reply other threads:[~2022-02-01 9:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:42 [1/3 PATCH]middle-end vect: Simplify and extend the complex numbers validation routines Tamar Christina
2021-12-17 15:42 ` [2/3 PATCH]AArch64 use canonical ordering for complex mul, fma and fms Tamar Christina
2021-12-17 16:24 ` Richard Sandiford
2021-12-17 16:48 ` Richard Sandiford
2021-12-20 16:20 ` Tamar Christina
2022-01-11 7:10 ` Tamar Christina
2022-02-01 9:55 ` Tamar Christina
2022-02-01 11:04 ` Richard Sandiford
2021-12-17 15:43 ` [3/3 PATCH][AArch32] " Tamar Christina
2021-12-20 16:22 ` Tamar Christina
2022-01-11 7:10 ` Tamar Christina
2022-02-01 9:54 ` Tamar Christina
2022-02-01 9:56 ` Kyrylo Tkachov [this message]
2021-12-17 16:18 ` [1/3 PATCH]middle-end vect: Simplify and extend the complex numbers validation routines Richard Sandiford
2021-12-20 16:18 ` Tamar Christina
2022-01-10 10:16 ` Tamar Christina
2022-01-10 13:00 ` Richard Biener
2022-01-11 7:31 ` Tamar Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR08MB692644A113E0FDAF1D4DEF6093269@PAXPR08MB6926.eurprd08.prod.outlook.com \
--to=kyrylo.tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).