From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2041.outbound.protection.outlook.com [40.107.103.41]) by sourceware.org (Postfix) with ESMTPS id 877FC38DFB63 for ; Tue, 6 Dec 2022 10:26:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 877FC38DFB63 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z26/hRebkDnI4z2hEoeC0yfqNYEWU4pgKAcLSWm2slc=; b=OFv4etDyRYEtLua398+vsNid2uV4bzK7i4lHpA4Y9I6deJVFsB2UF+QUP+L4YpDNNx2TVdlPd591G73fmaJZY8OiUvgZzt5CSN1YtJvfdW6UrFv7oPhWq7CGwByU+3Tp4Vr3WYlUaVYbPPvWktV2FBUXtEnLxQMmjTBGAiJP1KQ= Received: from AS9PR0301CA0057.eurprd03.prod.outlook.com (2603:10a6:20b:469::11) by PAWPR08MB9968.eurprd08.prod.outlook.com (2603:10a6:102:35b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11; Tue, 6 Dec 2022 10:26:34 +0000 Received: from VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::e9) by AS9PR0301CA0057.outlook.office365.com (2603:10a6:20b:469::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8 via Frontend Transport; Tue, 6 Dec 2022 10:26:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT043.mail.protection.outlook.com (100.127.145.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14 via Frontend Transport; Tue, 6 Dec 2022 10:26:34 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Tue, 06 Dec 2022 10:26:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 672303424ee94b9b X-CR-MTA-TID: 64aa7808 Received: from d1ac0f2526f6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BED2D713-3A4E-47C4-BA27-CA971803E77F.1; Tue, 06 Dec 2022 10:26:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d1ac0f2526f6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Dec 2022 10:26:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jknXUJRSm4A7Z8azyp1p3KXfYPGTOMUUujbcs1AUNETnky3MaaRTxDfehl0GSiVyHRb/oRfpgf/q3AWx+nART68ex4mug5p+SCRmiqVvBJO7uCGo6qgHAs+un/5tu642Zb7leF2BgJsVaFBrVilcb0QVjYdnlnIFlkI5bTPuIF1S1pIXH8LaK1DuZz1bXby9lw1fC4bo34uXf0Mt9Cy4Pibh/0nSNFtlHquH7hs+z7PrdR4BDkj+M84QpkS4aApjf6h+MQCitI3CpgpIS+P4SaNXbl8P9ixfhihtqf7Al8WVwOT7tEX19Xh37pWfxxce/Ci1jH6IuoXB5DUc9IL7+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z26/hRebkDnI4z2hEoeC0yfqNYEWU4pgKAcLSWm2slc=; b=guU8lu+LNe4NZLyTELSiM+vNhfn7a7cAXiUEmtZ1+kXqSscEORAAi8WVi+4R/dg+xfLsqzhDZcUSLaPRZ/EwaCcKC0xyOSP2bLQExbK9uTJY5DHb5rN+XtxeLqa7FXTW3vINL34c3wCsuTPlGcpdqJtr20NgFoUlecQZilTdgxP8HMkjDTQ4rhY1MOaEQgskuYqh/+UPYCoPvk2f2kDACWYm0KXM4Txz7p/GhhRrrPfwspG4aPNNHr3zZcg8DVF78j8kWksBTwmwZoEZpHrzCRRE2MWz3wsj2OmY+edLaZS31qqHTRdzxmBq5FPN8DyQqkDZiInGEeGygHOyYcXEgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z26/hRebkDnI4z2hEoeC0yfqNYEWU4pgKAcLSWm2slc=; b=OFv4etDyRYEtLua398+vsNid2uV4bzK7i4lHpA4Y9I6deJVFsB2UF+QUP+L4YpDNNx2TVdlPd591G73fmaJZY8OiUvgZzt5CSN1YtJvfdW6UrFv7oPhWq7CGwByU+3Tp4Vr3WYlUaVYbPPvWktV2FBUXtEnLxQMmjTBGAiJP1KQ= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by AS8PR08MB7887.eurprd08.prod.outlook.com (2603:10a6:20b:52b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 6 Dec 2022 10:26:24 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::a7d2:445d:606d:7046]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::a7d2:445d:606d:7046%9]) with mapi id 15.20.5880.014; Tue, 6 Dec 2022 10:26:24 +0000 From: Kyrylo Tkachov To: "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH] aarch64: Specify that FEAT_MOPS sequences clobber CC Thread-Topic: [PATCH] aarch64: Specify that FEAT_MOPS sequences clobber CC Thread-Index: AdkE4rg2RUxEEVeoSE+1WMyMV8x7awEenEwA Date: Tue, 6 Dec 2022 10:26:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|AS8PR08MB7887:EE_|VI1EUR03FT043:EE_|PAWPR08MB9968:EE_ X-MS-Office365-Filtering-Correlation-Id: 35b97f64-1b6a-47af-ea82-08dad7745956 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: G8pAjlpBpoK2cMr59gzI55IRPMySSAwCdPw94iv4ue8F10RmfwNtSdaK0lttExtvk8dI+2dX9TeqlZncTQMot0hDR7TLoASiGjzi6lannC/4NA7XPiUYR2RkBvl+9ojfYXhaAwtsptwUgnfP3tsobf54VazNCcKZs/d6K3hwyWdITKEcDGmQXP1buySOTkvMGCyNYlQSKVGwBuW7Gg+ni1xmnZm5ZuEvo8KRGgUp59mYd642UzfpfhaEKIMbGJwBJx0Ja0CnSjz4DTquWQm24sQ1070m9HpcXgczQVi92edTcSugaWqvGZzZOouhMtBpch6OiI5AGBWsFxNg3WrHZkb+pQmsoPr8C/VyhZNnF/DoKL2+47VHS0Vr1rWkFM8JD7n1TC8MZnPtz7FyG5rEdtFhcLAdiqKS8KvYoVYPNMyocN6opR3TSH6qcKjFEETNexQKR3v5nKwEF2qJWtp4Shmta2rt6wYCcN6ptmZn8DwPIrMEfwVOZBWA3j5YDZ17+86Jd2DfZWmAJHnpgEQwBd11CTWB4p+bfMc9gjtmntOe73Hxo/Z4WBkCzt5dUOmX2QLVEnB/TB3sqGB9SJ8KfWJdnI6RjNydUdd6Ha2w2YAeQSfDO1lJWCopbPcvw7wUqnsTt8RWNpQ7wRDClKcmoVZlkfmw0r34RMaJlGajxf+FF2qKaaRLHPob02RmGtoLktLPAxbHv0bFhWndE2V3yatHTi9sVl6DPW8aPP1JOIdA8DorcxaC6dh39CuO+sDBzBvRxgOHZ1GjMdxfXxPhLg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(136003)(376002)(396003)(451199015)(84970400001)(6506007)(86362001)(478600001)(7696005)(53546011)(71200400001)(55016003)(38070700005)(26005)(9686003)(33656002)(38100700002)(83380400001)(122000001)(186003)(52536014)(5660300002)(41300700001)(8676002)(8936002)(66446008)(66946007)(66476007)(66556008)(76116006)(316002)(2906002)(64756008)(6916009);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7887 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e606139a-021f-4585-a868-08dad7745359 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lUdps6JUNGxqYCqQ/iV3Aqq/HI7T0eRm10Kcn2G6Xg0biEsMfojtx10nBemFdWOEevtTBYDgqwHmFkHeL8QwRlBNroe7DouhtpdSE2F9B8XsI7CPGYjZu3GwaBezaNrlBKR9qau0p101Cw7NtDmynSzsH2Rcnu4ropfAy2y+7eszsThfWHChi+Xtq00tYSTSDM6Ihw3JxTPCFaMY83p/oQ5nHNDX9aEnSaY/kpiJrd71DkF72n62rR4pxg0CYwasVsNSHkNyGywkA+z9t3K+apamgAzMwb+Afoco2eqBDivoojKCYW4Ai+U3GsXrW/Sr7I0+W6TbLUNahOd6aOtBebA0K7fpgPTVZVV31lHYbPnqGSIeavbA1ll7Y9qOT8EHrLqyIg6bwDOrPWIVSvfOf01QDgZnVY/kPjrg80g1FV0HDPVfmXHrtoGjM1gVyPo7j+eWmLxxGKPwbz/I1uCA8eLFx0YGDqdUKk9egzUeItgi8tzVRnyO+F82q2t+bpqZ1PhaAVxm8GfO00kopZbUOauyPWwHyqUBQpuOL5gnfsKtfoCLYshfdiAT5Clj4GbnDT7ZBqU5okka1kIRnlXpLUEhCXUm3QksfsrfYRjQQ+uzn9mc9KAE7a1EBRt3HtxAmniPEkSOhjiBzoVPab4f1WY6+mDsZ3/EBzpg/w4rQClegxltixjivrA4wKqipftM2zrv/ZjxZfVl2bOb9GqfiJ+e/hy7xfhACfZuSgVPWmPS/InJsOwQ9fzPZS8auKtE5fyTHg/S6vw5UbNIcuGIww== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(26005)(7696005)(6506007)(9686003)(40480700001)(53546011)(86362001)(84970400001)(478600001)(8676002)(70586007)(47076005)(336012)(186003)(52536014)(81166007)(70206006)(33656002)(356005)(41300700001)(55016003)(83380400001)(82740400003)(2906002)(5660300002)(82310400005)(36860700001)(8936002)(40460700003)(6916009)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 10:26:34.0299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35b97f64-1b6a-47af-ea82-08dad7745956 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9968 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Kyrylo Tkachov > Sent: Wednesday, November 30, 2022 5:40 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH] aarch64: Specify that FEAT_MOPS sequences clobber CC >=20 > Hi all, >=20 > According to the architecture pseudocode the FEAT_MOPS sequences > overwrite the NZCV flags > as part of their operation, so GCC needs to model that in the relevant RT= L > patterns. > For the testcase: > void g(); > void foo (int a, size_t N, char *__restrict__ in, > char *__restrict__ out) > { > if (a !=3D 3) > __builtin_memcpy (out, in, N); > if (a > 3) > g (); > } >=20 > we will currently generate: > foo: > cmp w0, 3 > bne .L6 > .L1: > ret > .L6: > cpyfp [x3]!, [x2]!, x1! > cpyfm [x3]!, [x2]!, x1! > cpyfe [x3]!, [x2]!, x1! > ble .L1 // Flags reused after CPYF* sequence > b g >=20 > This is wrong as the result of cmp needs to be recalculated after the MOP= S > sequence. > With this patch we'll insert a "cmp w0, 3" before the ble, like what clan= g > does. >=20 > Bootstrapped and tested on aarch64-none-linux-gnu. > Pushing to trunk and to the GCC 12 branch after some baking time. Pushed to releases/gcc-12 now. Thanks, Kyrill >=20 > Thanks, > Kyrill >=20 > gcc/ChangeLog: >=20 > * config/aarch64/aarch64.md (aarch64_cpymemdi): Specify clobber > of CC reg. > (*aarch64_cpymemdi): Likewise. > (aarch64_movmemdi): Likewise. > (aarch64_setmemdi): Likewise. > (*aarch64_setmemdi): Likewise. >=20 > gcc/testsuite/ChangeLog: >=20 > * gcc.target/aarch64/mops_5.c: New test. > * gcc.target/aarch64/mops_6.c: Likewise. > * gcc.target/aarch64/mops_7.c: Likewise.