From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2089.outbound.protection.outlook.com [40.107.8.89]) by sourceware.org (Postfix) with ESMTPS id 81AA73858410 for ; Wed, 17 Jan 2024 10:18:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81AA73858410 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81AA73858410 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.8.89 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1705486744; cv=pass; b=wvaOwiyZtcvDJC6s+m3sPrRGg5kdJMyoUTtDJyLMxdEpDqnFO4Sa2/dsXtZQKND/b9opgJiMUYpgjFEYjvw9M5wQiEQ9xTlV5qCBa36zrWukRGK3uVDAiZ3bfklOOrXfM2E+xK6lcFzUGy6KU8qKOJUQHUN04oRB20z+sRku7DY= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1705486744; c=relaxed/simple; bh=wiezCDAJhTrrAGAnqtelEplfFLlibdf0VlcN7G1dGUs=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=Z+0UN3EWykyGlksLYU72KPbNMmMsVW1QLrmpTTQTYHGnSyWhqWaAHhA0KIGrrr09LMJYk3DYuhmcV9CsfuSUYNW/3cQMzLWBwNgPONSrg5eA7FPgUZwmh5C/UWsSDl7FIUwEAQmwfbo8/Y3Wx5d3lxdit+3xYp97DiSh7rj760M= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=H1DtqkrVEJylBalbhUIgtfEsRQmkzmbScq8EOFoI2Yj8wAudSbx+nmYH0XwYRI2ivzjrG5s7SpuzMarVQnyNdJdu1pNioLhzjC7u0s4A61u0bAt40TaXsVm2u3+Ps8VFD0BCVjqsSHJfw6zJPYOXeD1EueAve9z3UOudpyuk1s1uZbabLrW1DLnwyGGMYssU7q3OcVYBsxQ8WOZ6b7739O5AriTh05TzqBNdxnwY1idlPViHrL6Gv+rL2T3j4WRQ3NFBxJne49e3UDbpnB/0s6cuJl9sXSNBceB2UAJIwhQosZbwIGu11tWYuoD/vwiWJ76zUyDnwdLsz5ffbj3Hyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pqg1DYmZF1bu9nSalzHPLenYy33fbXSfOS4hdq03HHA=; b=aaYvUYHiGmtuIckE9cqRSZDJDhS3faoRr2L8Im8fx6ZzOiU8i7vG2VvWio64bmoI68p9xpDX6IOxwR2yg/rDuYlTv6Bl5LvIAzBDQ0BSUk4qyVaBmhwRpNHaYYKbzJ+Fw4pHJKdUhyOfZ6g25prp36T9rBnYVnKtZ0BbMJ7AdZzV0YT2bhyxVNmMMlmojWhkx5hG27ce1ItL/YyU5hoLHY8qcgl/swyvnOozT9Iarbc006+2mmS/t6IDriNGj52/Z/MZL4zkPVFdoSl4SkQnEN8Jv1OmQPksclOGiqzb4DMnXTgOOw1hif2+3iZtoFWlLdEkM+4tMbxJgbZ9w9KhFw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pqg1DYmZF1bu9nSalzHPLenYy33fbXSfOS4hdq03HHA=; b=NocHg6M/lH0w3I21oKJWLMntzJsaboATPrjwn5JxxDLUD/U8voHXu2KucaC97STs0yGqb8doQTeAogQ5U7lfWPd0CEanIGHFBQIB7lCKbUnwWL+OUNN0BQYXXzvxJ5Xj2aj9Ke3v6UhNMj0YhGiYk7U5e6j8EUX5OnR2VekOQs4= Received: from AM4PR07CA0013.eurprd07.prod.outlook.com (2603:10a6:205:1::26) by DU5PR08MB10702.eurprd08.prod.outlook.com (2603:10a6:10:524::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.23; Wed, 17 Jan 2024 10:18:50 +0000 Received: from AM1PEPF000252E0.eurprd07.prod.outlook.com (2603:10a6:205:1:cafe::64) by AM4PR07CA0013.outlook.office365.com (2603:10a6:205:1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.22 via Frontend Transport; Wed, 17 Jan 2024 10:18:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM1PEPF000252E0.mail.protection.outlook.com (10.167.16.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.16 via Frontend Transport; Wed, 17 Jan 2024 10:18:50 +0000 Received: ("Tessian outbound 94d82ba85b1d:v228"); Wed, 17 Jan 2024 10:18:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f86761c30250fde5 X-CR-MTA-TID: 64aa7808 Received: from 3947319f7290.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9D3E0A6B-7374-4658-90C6-E3FFF904D6EB.1; Wed, 17 Jan 2024 10:18:39 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3947319f7290.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Jan 2024 10:18:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=liDPuSFzITwMOu0xpDkFc1BSajHHrq4PmlDDCxz6H8N40HuaZxFQcMIyhJbEWGeZ/wDQ7oUrPacDYRAo4ikiC7OCybwsTmCX2YO7NN881uqnxPAhlOMJj/0OEpH8D+tEWrM1Z7v3mPCgVZjGYQYg9cd8x9R7br5B5JVVsWWHGttCo3OWpraq+z2f/37XXT0PxeFRKY/IZmo6kXG+i++gcahYc3QfxcMqKd+7He/L1iM9BjV1lrHfxzu69AcPOkF5p9Y72Z4G0pABzTDM8BkHUZ9B5+IJxQKQjw9j3JPJzHXMulUmU97baWvN+mAabbVReetjuMf2Ih4D+NdZHraryw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pqg1DYmZF1bu9nSalzHPLenYy33fbXSfOS4hdq03HHA=; b=FOsXUfsr09lv4usCwrBJYmaONWdF4MAPRZYJjpdavwPEy9OVHstCs4CwhX2QtSsWU5i1kfLLrowaSI9AxlGY1us1K1tZmhvCphjYKO0q6gI8GEioIbQK3uYxDUEPIbwhY55S6bRdv34j710WowWPQ7ascvzd7ALLqGu6tT0djQADepklJvFEmtbzxOZkCtqCmZ2LIwuwXDvucFd4/U1PRM+Z6hr4iefYR1FboGHkluI94/iKkzsX8rg+G6J2B7LH0qvvGj9PwDTE56Csugur76gfYas60JoKE6GuNilTNUflrgFIn9ROAK5Os8azIMVfSydXQG/I6//FveqsAsQqBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pqg1DYmZF1bu9nSalzHPLenYy33fbXSfOS4hdq03HHA=; b=NocHg6M/lH0w3I21oKJWLMntzJsaboATPrjwn5JxxDLUD/U8voHXu2KucaC97STs0yGqb8doQTeAogQ5U7lfWPd0CEanIGHFBQIB7lCKbUnwWL+OUNN0BQYXXzvxJ5Xj2aj9Ke3v6UhNMj0YhGiYk7U5e6j8EUX5OnR2VekOQs4= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by GV2PR08MB8752.eurprd08.prod.outlook.com (2603:10a6:150:b6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.23; Wed, 17 Jan 2024 10:18:36 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::1846:322b:f2e1:35a8]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::1846:322b:f2e1:35a8%4]) with mapi id 15.20.7202.020; Wed, 17 Jan 2024 10:18:36 +0000 From: Kyrylo Tkachov To: Andrew Pinski , "gcc-patches@gcc.gnu.org" CC: Alex Coplan Subject: RE: [PATCH] aarch64: Fix aarch64_ldp_reg_operand predicate not to allow all subreg [PR113221] Thread-Topic: [PATCH] aarch64: Fix aarch64_ldp_reg_operand predicate not to allow all subreg [PR113221] Thread-Index: AQHaSPWJ/m5o1CmTGkumLlFR9uMuarDdyxUQ Date: Wed, 17 Jan 2024 10:18:36 +0000 Message-ID: References: <20240117032904.80831-1-quic_apinski@quicinc.com> In-Reply-To: <20240117032904.80831-1-quic_apinski@quicinc.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|GV2PR08MB8752:EE_|AM1PEPF000252E0:EE_|DU5PR08MB10702:EE_ X-MS-Office365-Filtering-Correlation-Id: 69532506-375b-465e-4cc2-08dc1745b325 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: U4+Bcxd69RXNC7xK3GtFB/khPUU3wYb6AVMX1gAb2hznBg7nCXqnaSsMOqyovgXQ3L6uwBX8tIQ9FyEUbZtPsajsG3ir3V7xtlM5705AdGlrZwlei8lMwIRluQl1Yt/DR04XbA+HiGBIRiVkh76MJKxYxpjBz4ODkxYhOYoEqu1aWJkHca9HQbUnrwrt/uqMkzNJ/udiEeuc8EcP32r4ebP0IRtHw0E9wDIDpL/qgf4vhdfeZuBZXMbd8Xvq9F/Raeo4mmABqRhjzMUr60DWxzJP+a4DNWGZodb+oJd7Cb0y9wXqxItKgRWfVU7lrL3i+xETQdELaRIXomMLzDUKBd2Ceio4WQgcFUerXL26Ni8VVHSYdyrefRY0E5nt+1QfSUqorj/EtZG1D9KLOUZfW5QGnPrHhEyUlUgn9RwCp5rD6LlAp1QuMquSd87E7qy+wFHD6ahNAzfH4t5h/hio6nuAqPPTWjFE7M4CPBSBmR81rZqOyOikQZB8hkycWV2RXbSjkuzTGqKC9dzouLoErhzuDRJelH9CNH8PRT4srTlFLyvsbIbit3GajYiu7sCkQFgPhoQfBDuzJJ5OZ0BAzyY075u9jC0CmpUpQtoLgrVLe3aX2k1aS6InvJeOyLgA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(376002)(396003)(366004)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(55016003)(71200400001)(9686003)(6506007)(26005)(53546011)(7696005)(55236004)(38100700002)(33656002)(86362001)(38070700009)(8936002)(2906002)(41300700001)(52536014)(4326008)(122000001)(5660300002)(83380400001)(478600001)(66556008)(316002)(8676002)(66446008)(66476007)(110136005)(66946007)(76116006)(64756008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8752 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252E0.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9241ae52-f122-4543-4df4-08dc1745aa91 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eBUu4FuJT592wf1ZvsJl01ZbwZpJJ1QFB4KN1tIgEZLtqCYChsP70AhHE3W6ek/+wZqmT+jSTDJHSWpSSYX0xbzDjW7CJhTe0dPjkrHPhtWueQC5Uig6anlGH5e21X9Yu8jDKz4NTvD/zr0hBgEdHPYC5nmG7h+tcZtIt+nBHuxMGZfz/CE8b065oDRj+5KcG6qpVWsK1iGQVfzu88Q11r88OQv2aUVgMBsOAhAV64njGW7TbsDwDx4XPEJ+gnw8eCAUSuMBUNHNYYsQyuU0zMU+Kk2cNWhKqKOvXpcvOdkfPf68rnCzvm4wq5FLgzgeCFwhsuoyhDp5VlIZaMBjCaILJseAIIqQk7o+uIdQtoEtUsa2v7drWchQ316cxA+J7IB8o1+AoNr3Ciz/4BE/Ed3qLmDkrHE3i0AMBKXCjtPQJytzz/h7zkVBU6PkBdd0w/NzRkKA8s795HNNyaGdmuEsv+/XwHCnB0yR5bB1hW4TlPrXif4TJEmCGS7Qz+ASWMZIzFY3L8quYt2fx4MSjKbcCjPRZuP2ynItAmwqXs0+f9Y2k60plRaE2AoNxfDGi6c/qctxXzYIjzonpiiM4Odk5wWiWJutmeHPP1XopAF2v1OP+2ON1wPXNPpVxfZli3jQ6SGy1orOuTw7V0ZSAt7X7LbFNcRI1JMXOAPsBLTeuKgdiWgCCtCrbNznAzH5w7mGsmsUcJfHc+95edKFMUc3mVGNiAER28jRFJ3Ljo/BQvxeGu92+GKA2I6W1jhq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(396003)(39860400002)(136003)(376002)(230922051799003)(186009)(82310400011)(64100799003)(451199024)(1800799012)(40470700004)(46966006)(36840700001)(40460700003)(55016003)(40480700001)(6506007)(7696005)(9686003)(336012)(26005)(36860700001)(53546011)(86362001)(82740400003)(81166007)(356005)(33656002)(2906002)(8936002)(41300700001)(8676002)(52536014)(4326008)(47076005)(83380400001)(5660300002)(316002)(478600001)(110136005)(70586007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 10:18:50.5047 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69532506-375b-465e-4cc2-08dc1745b325 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252E0.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR08MB10702 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Andrew Pinski > Sent: Wednesday, January 17, 2024 3:29 AM > To: gcc-patches@gcc.gnu.org > Cc: Alex Coplan ; Andrew Pinski > > Subject: [PATCH] aarch64: Fix aarch64_ldp_reg_operand predicate not to al= low > all subreg [PR113221] >=20 > So the problem here is that aarch64_ldp_reg_operand will all subreg even = subreg > of lo_sum. > When LRA tries to fix that up, all things break. So the fix is to change = the check to > only > allow reg and subreg of regs. >=20 > Note the tendancy here is to use register_operand but that checks the mod= e of > the register > but we need to allow a mismatch modes for this predicate for now. >=20 > Built and tested for aarch64-linux-gnu with no regressions > (Also tested with the LD/ST pair pass back on). Ok with the comments from Alex addressed. Thanks, Kyrill >=20 > PR target/113221 >=20 > gcc/ChangeLog: >=20 > * config/aarch64/predicates.md (aarch64_ldp_reg_operand): For subreg, > only allow REG operands isntead of allowing all. >=20 > gcc/testsuite/ChangeLog: >=20 > * gcc.c-torture/compile/pr113221-1.c: New test. >=20 > Signed-off-by: Andrew Pinski > --- > gcc/config/aarch64/predicates.md | 8 +++++++- > gcc/testsuite/gcc.c-torture/compile/pr113221-1.c | 12 ++++++++++++ > 2 files changed, 19 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr113221-1.c >=20 > diff --git a/gcc/config/aarch64/predicates.md > b/gcc/config/aarch64/predicates.md > index 8a204e48bb5..256268517d8 100644 > --- a/gcc/config/aarch64/predicates.md > +++ b/gcc/config/aarch64/predicates.md > @@ -313,7 +313,13 @@ (define_predicate "pmode_plus_operator" >=20 > (define_special_predicate "aarch64_ldp_reg_operand" > (and > - (match_code "reg,subreg") > + (ior > + (match_code "reg") > + (and > + (match_code "subreg") > + (match_test "GET_CODE (SUBREG_REG (op)) =3D=3D REG") > + ) > + ) > (match_test "aarch64_ldpstp_operand_mode_p (GET_MODE (op))") > (ior > (match_test "mode =3D=3D VOIDmode") > diff --git a/gcc/testsuite/gcc.c-torture/compile/pr113221-1.c > b/gcc/testsuite/gcc.c-torture/compile/pr113221-1.c > new file mode 100644 > index 00000000000..152a510786e > --- /dev/null > +++ b/gcc/testsuite/gcc.c-torture/compile/pr113221-1.c > @@ -0,0 +1,12 @@ > +/* { dg-options "-fno-move-loop-invariants -funroll-all-loops" } */ > +/* PR target/113221 */ > +/* This used to ICE after the `load/store pair fusion pass` was added > + due to the predicate aarch64_ldp_reg_operand allowing too much. */ > + > + > +void bar(); > +void foo(int* b) { > + for (;;) > + *b++ =3D (long)bar; > +} > + > -- > 2.39.3