[PATCH] testsuite: Add arm_arch_v7a_ok effective-target to pr57351.c

[PATCH] testsuite: Add arm_arch_v7a_ok effective-target to pr57351.c

[Christophe LYON]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

I've noticed that overriding cpu/arch flags when running the testsuite
can cause this test to fail rather than being skipped because of
incompatible flags combination.

Since the test forces -march=armv7-a, make sure it is accepted in
combination with the current runtestflags.

2021-06-30  Christophe Lyon  <christophe.lyon@foss.st.om>

         gcc/testsuite/
         * gcc.dg/debug/pr57351.c: Require arm_arch_v7a_ok
         effective-target.




[-- Attachment #2: 0001-testsuite-Add-arm_arch_v7a_ok-effective-target-to-pr.patch --]
[-- Type: text/plain, Size: 1208 bytes --]

From f49096dc6925a0b28785debdee8fdc323e4f6e82 Mon Sep 17 00:00:00 2001
From: Christophe Lyon <christophe.lyon@foss.st.com>
Date: Wed, 30 Jun 2021 13:47:07 +0000
Subject: [PATCH] testsuite: Add arm_arch_v7a_ok effective-target to pr57351.c

I've noticed that overriding cpu/arch flags when running the testsuite
can cause this test to fail rather than being skipped because of
incompatible flags combination.

Since the test forces -march=armv7-a, make sure it is accepted in
combination with the current runtestflags.

2021-06-30  Christophe Lyon  <christophe.lyon@foss.st.om>

	gcc/testsuite/
	* gcc.dg/debug/pr57351.c: Require arm_arch_v7a_ok
	effective-target.
---
 gcc/testsuite/gcc.dg/debug/pr57351.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gcc.dg/debug/pr57351.c b/gcc/testsuite/gcc.dg/debug/pr57351.c
index 972f3e9ebec..236d74ddedb 100644
--- a/gcc/testsuite/gcc.dg/debug/pr57351.c
+++ b/gcc/testsuite/gcc.dg/debug/pr57351.c
@@ -1,5 +1,6 @@
 /* { dg-do compile } */
 /* { dg-require-effective-target arm_neon }  */
+/* { dg-require-effective-target arm_arch_v7a_ok }  */
 /* { dg-options "-std=c99 -Os -g -march=armv7-a" } */
 /* { dg-add-options arm_neon } */
 
-- 
2.25.1

Re: [PATCH] testsuite: Add arm_arch_v7a_ok effective-target to pr57351.c

[Christophe Lyon]

ping?

On Wed, Jun 30, 2021 at 3:58 PM Christophe LYON via Gcc-patches <
gcc-patches@gcc.gnu.org> wrote:

> I've noticed that overriding cpu/arch flags when running the testsuite
> can cause this test to fail rather than being skipped because of
> incompatible flags combination.
>
> Since the test forces -march=armv7-a, make sure it is accepted in
> combination with the current runtestflags.
>
> 2021-06-30  Christophe Lyon  <christophe.lyon@foss.st.om>
>
>          gcc/testsuite/
>          * gcc.dg/debug/pr57351.c: Require arm_arch_v7a_ok
>          effective-target.
>
>
>
>

RE: [PATCH] testsuite: Add arm_arch_v7a_ok effective-target to pr57351.c

[Kyrylo Tkachov]

> -----Original Message-----
> From: Gcc-patches <gcc-patches-
> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Christophe
> Lyon via Gcc-patches
> Sent: 07 July 2021 13:24
> To: Christophe LYON <christophe.lyon@foss.st.com>
> Cc: gcc Patches <gcc-patches@gcc.gnu.org>
> Subject: Re: [PATCH] testsuite: Add arm_arch_v7a_ok effective-target to
> pr57351.c
> 
> ping?
> 
> On Wed, Jun 30, 2021 at 3:58 PM Christophe LYON via Gcc-patches <
> gcc-patches@gcc.gnu.org> wrote:
> 
> > I've noticed that overriding cpu/arch flags when running the testsuite
> > can cause this test to fail rather than being skipped because of
> > incompatible flags combination.
> >
> > Since the test forces -march=armv7-a, make sure it is accepted in
> > combination with the current runtestflags.

Ok, I would have counted it as obvious I suppose.
Thanks,
Kyrill

> >
> > 2021-06-30  Christophe Lyon  <christophe.lyon@foss.st.om>
> >
> >          gcc/testsuite/
> >          * gcc.dg/debug/pr57351.c: Require arm_arch_v7a_ok
> >          effective-target.
> >
> >
> >
> >